From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8479C33CB1 for ; Wed, 15 Jan 2020 14:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EEC9214AF for ; Wed, 15 Jan 2020 14:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728993AbgAOOWM (ORCPT ); Wed, 15 Jan 2020 09:22:12 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:59397 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgAOOWL (ORCPT ); Wed, 15 Jan 2020 09:22:11 -0500 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MGQzj-1isYVr058v-00Gsh0; Wed, 15 Jan 2020 15:22:10 +0100 Received: by mail-qk1-f174.google.com with SMTP id w127so15722566qkb.11; Wed, 15 Jan 2020 06:22:09 -0800 (PST) X-Gm-Message-State: APjAAAXR0i/nw4VXfnZSlejgh4fZ2a2KfRmGN3E0gfmq0ia8/P+hmmF9 nUgpg7FpHYLLd9n7RfJ6jP2V9rSvBIfoZNJXwig= X-Google-Smtp-Source: APXvYqxx2a39ERgImZn16gvReU3L59K4NPZ7rVI6r40qbh59bC6C4RPdM9GIKIPaH4dZYMYOAUlFtEAF/+VlIcIk3y8= X-Received: by 2002:a37:84a:: with SMTP id 71mr26665185qki.138.1579098128765; Wed, 15 Jan 2020 06:22:08 -0800 (PST) MIME-Version: 1.0 References: <20200114200846.29434-1-vgupta@synopsys.com> <20200114200846.29434-2-vgupta@synopsys.com> <20200115141224.GH8904@ZenIV.linux.org.uk> In-Reply-To: <20200115141224.GH8904@ZenIV.linux.org.uk> From: Arnd Bergmann Date: Wed, 15 Jan 2020 15:21:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use To: Al Viro Cc: Linus Torvalds , Vineet Gupta , Khalid Aziz , Andrey Konovalov , Andrew Morton , Peter Zijlstra , Christian Brauner , Kees Cook , Ingo Molnar , Aleksa Sarai , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux Kernel Mailing List , linux-arch Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:lOdPcxVLcqBDEULU954wg+G6L5Re6fTjFN9BhJpfuxlRd4a6lR4 hSIHFUtdbK3ItxmH/gNZwHTsPniOPTxj8q4g7Sg0TRgVIJ6HXkYStxhPEdlWHRWJx0NTd6E OxbYloa5u0vc2cQ6fMPG/0QbTP86Gp5Uos7Lg0pAXCuXVJiKHIMZ3Qg6vGklUWDrQWN2vns sBNaMcqUkwpiZFr+TVQyA== X-UI-Out-Filterresults: notjunk:1;V03:K0:CF8ls0Li9nE=:0MP2x6I/juuYaHyvrvutA8 koVW/HnYbXl2tpLoFALXNeZfBM5113zZ8Ayl/3ikXDiU/QHlN9J5C5SCxopTPPo6rCXtjZuca x8T4cGpQcfaMZZZzCC69/9QnAge+YPkrV+/W6VV9Aw1eReYevymbqxiex9ZpYS4NCB+2Erwed f6jpOZ871xncuQ/P8En2WW0rmfMPF5DGO36DlhrCTnnFPm9j6s1E6I7A1Lbv5guEKzT1tHFTJ WQksl+GzfN1mJm1pnoYTAFLL986qEAazRPgiNbBnC5vrPxXq3qFpT04ZLHYIkSiixBpjs4e5B mv4RwRnFDsS5ttwrri1+T86vzIPkPpD6hgrR/Q4lzJNJ08FR1ATxCmP9qPC2Z2m7RYjUe/MhV 7/s0ZU7urU6DhTCW+K4nZ3m/y2rWn5cRxFvxiap+gSy2s+Ebo3kkp5h/8ch+q5Tx+oseHxPjZ eB1BYo8ZiWiXpRIFQy4dLV1VM5Mzg+6p+XD3qP57OfBPfGu7Qs7Fzi1MWUgqYsw4cCK4Gpdxn Kw3jNjW5bUpRqUo/VaoybI+scr5qkj4yWd9KVIPhH7AEfuazB3UjcjlZkjSPCSjvjxcyhK333 Wa2qeI6A4Q1yUWyTKTk0AeJ81EWpW974NPQ/GvlPcAc9ngeSVqOirIf0b/wT+So7drFt8p5GA bxn8mgQoYkMujjGtxtd3+jF+7sai+OMd7U25qSbYiZacNTkjL/yWtz4AOWjD3NmGhve83yENZ zOR2K1+0vcO0OodorvBFWrn1RK4aWHHoutumI9F6WcCTxibQBCsxVF9z7RVGs4R7WxRYUsZ9H ZsHLQQtCPfUiE/Eth87r5mQBFylEmP78wQ/G1XbvTBnwMpBz6N236SWxlg3NIDdQqyZqzywa3 ODWOzLDMV5qW2FYUVIqw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 3:12 PM Al Viro wrote: > > On Wed, Jan 15, 2020 at 10:08:31AM +0100, Arnd Bergmann wrote: > > > > I would suggest that anybody who uses asm-generic/uaccess.h needs to > > > simply use the generic library version. > > > > Or possibly just everybody altogether: the remaining architectures that > > have a custom implementation don't seem to be doing any better either. > > No go for s390. There you really want to access userland memory in > larger chunks - it's oriented for block transfers. IIRC, the insn > they are using has a costly setup phase, independent of the amount > to copy, followed by reasonably fast transfer more or less linear > by the size. Right, I missed that one while looking through the remaining implementations. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use Date: Wed, 15 Jan 2020 15:21:52 +0100 Message-ID: References: <20200114200846.29434-1-vgupta@synopsys.com> <20200114200846.29434-2-vgupta@synopsys.com> <20200115141224.GH8904@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mout.kundenserver.de ([217.72.192.74]:59397 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgAOOWL (ORCPT ); Wed, 15 Jan 2020 09:22:11 -0500 In-Reply-To: <20200115141224.GH8904@ZenIV.linux.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Al Viro Cc: Linus Torvalds , Vineet Gupta , Khalid Aziz , Andrey Konovalov , Andrew Morton , Peter Zijlstra , Christian Brauner , Kees Cook , Ingo Molnar , Aleksa Sarai , "open list:SYNOPSYS ARC ARCHITECTURE" , Linux Kernel Mailing List , linux-arch On Wed, Jan 15, 2020 at 3:12 PM Al Viro wrote: > > On Wed, Jan 15, 2020 at 10:08:31AM +0100, Arnd Bergmann wrote: > > > > I would suggest that anybody who uses asm-generic/uaccess.h needs to > > > simply use the generic library version. > > > > Or possibly just everybody altogether: the remaining architectures that > > have a custom implementation don't seem to be doing any better either. > > No go for s390. There you really want to access userland memory in > larger chunks - it's oriented for block transfers. IIRC, the insn > they are using has a costly setup phase, independent of the amount > to copy, followed by reasonably fast transfer more or less linear > by the size. Right, I missed that one while looking through the remaining implementations. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC66C33CB1 for ; Wed, 15 Jan 2020 14:22:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B19BA214AF for ; Wed, 15 Jan 2020 14:22:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fgNyJYyU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B19BA214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7LDITjd0AU14iFCT0CD9PWAmjq9TNztDfPvKSm4HarM=; b=fgNyJYyUOK9ZGv 5gnyoijJ0VnFkKRDVU6qemmoVt9NoldEU40cE4lfOojneOu7hhYVX5gTQXy7QqdLcD7nh26QDkzmW /NGVNrrz8N11SGrm7EsbqEr7PYzTLe4r7stcRPx0Fp+k3VAEl/VMs2plApX655ozIJg7mF31So0SG vcm2oHdiVR7aR4cFNZyBbm/yAEEIyVwou5Lc9FjtqfAXHOqx4N2RMC1pzcQTvC2pcDbKcg7x1eMSz pWH4YRUmNBr7Gka1/oDKd90bB5QvaT9UQOsPN5QWgacAEtWs1AwUZX1wTvEzNNj92OCmCwbvd6ydd fK/NdCFQ+iv5jOzT8jdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1irjYq-00055r-RS; Wed, 15 Jan 2020 14:22:20 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1irjYk-00054l-VC for linux-snps-arc@lists.infradead.org; Wed, 15 Jan 2020 14:22:20 +0000 Received: from mail-qk1-f179.google.com ([209.85.222.179]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MPXMa-1j4THU3kVm-00McsN for ; Wed, 15 Jan 2020 15:22:11 +0100 Received: by mail-qk1-f179.google.com with SMTP id c16so15748207qko.6 for ; Wed, 15 Jan 2020 06:22:09 -0800 (PST) X-Gm-Message-State: APjAAAVRQia4CK9utaThMxjP4ykKibYmmDactrC9mRv2MpbWlf4mGg5c hsY1KeYin11aS7rCXDjpFcUsu11XjOBx94eWmiA= X-Google-Smtp-Source: APXvYqxx2a39ERgImZn16gvReU3L59K4NPZ7rVI6r40qbh59bC6C4RPdM9GIKIPaH4dZYMYOAUlFtEAF/+VlIcIk3y8= X-Received: by 2002:a37:84a:: with SMTP id 71mr26665185qki.138.1579098128765; Wed, 15 Jan 2020 06:22:08 -0800 (PST) MIME-Version: 1.0 References: <20200114200846.29434-1-vgupta@synopsys.com> <20200114200846.29434-2-vgupta@synopsys.com> <20200115141224.GH8904@ZenIV.linux.org.uk> In-Reply-To: <20200115141224.GH8904@ZenIV.linux.org.uk> From: Arnd Bergmann Date: Wed, 15 Jan 2020 15:21:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 1/4] asm-generic/uaccess: don't define inline functions if noinline lib/* in use To: Al Viro X-Provags-ID: V03:K1:z57FHwBbzM2trjJ6E3KMlSX1p8HNdeVz0I21dpwqIzmIZPAhg3P D45Iv3F1QWBiAKmaw8tkeAOwYcj0PNPFNIxe5ZTlp4AM3wQojH1TRtlJ3Z8ChZM+8lDnbzx v/oPkervKUKGqK+d4rIVVOrv/YPpvTrMPL/sOs7EnkOUpr1oQTaBx7+Xv6qmR8psMRIVjgM uQCedyfgGkGM5Fi7aboYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ut3yalytkPM=:lsxBN8Z+MoN6yKGPDqErOx t1Kw8JEZWYp758+Ha8oQ13+b0Y0SRQzxQZqoQT1A/pfYL8k6lii0iSP4iB7rIBgxofnKD51WV 5De1T+DKajZSkG+mhxU3RWdwn29ni0dX1NPX9sHjYFz/WH44A3Xoqws/a18FdxeaBZPNNh9Ez dw5hzbLJSLcNKYz8lorQ09GsHOmNFzloi2hMh4Iw3I9hVEvqbmoEot6TygsvRPSt1fkeIW5Xj PdIFQtuHJ3ljz/uhXLTem5UxB0GYCym7e9lY+PWKDCqDshfnFoqyLsL2p5pi1DWz7tZA6ZVe3 f5jLa1rQZR+epE0h6W5fQeqqONUWP/uH/uF/lwO/TKnzjZqK2/uROhWfGPdybzxeNfa1TD12O H0c8vqQGWlmARehlMCVH+51TseIDNX+1rODOBabMb0MiEli9Yb9c8T/dCz/K3r/J6DBgs7Xb2 705ErbuKrgKjeiR4sJ6/RDNlne9WvZrpOHC1TOkp3Ppmu4Fj2VIHLc8IruUBYPD+CJ+Z9kWen rEKr2fXYPP6aqy6F3qwjgJZN2bKXorWywpbKrMLG2g4qTo4sYbgF5xSsq13kZ7mvbkNjHGlpS AM6YBxQaiQT4q5NQ5prMl3Pd3pM1qHTpcBWakzaxVr/Uha+E6z8vM0qq6RH+JtQApRPv/HTHf 03Wuq9MygavzFaLr2CngOId8mNsae8n9EeJrsI/lwydC7nHz7gIRX9QqbEO1dC2oSXrKxxclF jlGEuwAmGffauqk/LxeVkT6nw5fMGeuZ2ID9Fm8oO4ueg5e/gAh8Afgs0lDAavmXIhTMQsD21 0MFyahVUP9Uespl8yDiDLTz/03m2iygcFUH6p+Pv29N1Iuf2Aflaq3REP0+ueMjM2TL8YYZMl zlq6nj3tx4ZeQGVHLzRQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200115_062215_294666_652BB80F X-CRM114-Status: GOOD ( 11.95 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , Peter Zijlstra , Andrey Konovalov , Vineet Gupta , Aleksa Sarai , Ingo Molnar , Khalid Aziz , Andrew Morton , "open list:SYNOPSYS ARC ARCHITECTURE" , Linus Torvalds , Christian Brauner , Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Wed, Jan 15, 2020 at 3:12 PM Al Viro wrote: > > On Wed, Jan 15, 2020 at 10:08:31AM +0100, Arnd Bergmann wrote: > > > > I would suggest that anybody who uses asm-generic/uaccess.h needs to > > > simply use the generic library version. > > > > Or possibly just everybody altogether: the remaining architectures that > > have a custom implementation don't seem to be doing any better either. > > No go for s390. There you really want to access userland memory in > larger chunks - it's oriented for block transfers. IIRC, the insn > they are using has a costly setup phase, independent of the amount > to copy, followed by reasonably fast transfer more or less linear > by the size. Right, I missed that one while looking through the remaining implementations. Arnd _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc