From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C89C2BB55 for ; Thu, 16 Apr 2020 11:15:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CF7821D7F for ; Thu, 16 Apr 2020 11:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2632820AbgDPLPa (ORCPT ); Thu, 16 Apr 2020 07:15:30 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:40531 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2506125AbgDPLKu (ORCPT ); Thu, 16 Apr 2020 07:10:50 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MLz3X-1jgyo13MSv-00Hzkr; Thu, 16 Apr 2020 13:10:37 +0200 Received: by mail-qt1-f172.google.com with SMTP id q17so15700545qtp.4; Thu, 16 Apr 2020 04:10:36 -0700 (PDT) X-Gm-Message-State: AGi0Publh/6A1ywhzJFXljY1iei2ApTYHDxrHvtwIUqAcPAotF8yROQ+ q1xzUFVjdnNi5WJySQLFnyo1y1tIhKA9ehA3AL0= X-Google-Smtp-Source: APiQypKTnCrAJKWmvxQPPtXXxzoAVa6UTCMFQ9ATB3ibHu7YaQVTiYtm10ABd1Vj8N7EIF+bQAx1sinndyRxZBuK7IM= X-Received: by 2002:ac8:296f:: with SMTP id z44mr23735521qtz.18.1587035435488; Thu, 16 Apr 2020 04:10:35 -0700 (PDT) MIME-Version: 1.0 References: <1586937773-5836-1-git-send-email-abel.vesa@nxp.com> <1586937773-5836-12-git-send-email-abel.vesa@nxp.com> In-Reply-To: <1586937773-5836-12-git-send-email-abel.vesa@nxp.com> From: Arnd Bergmann Date: Thu, 16 Apr 2020 13:10:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 11/13] dt-bindings: reset: imx8mp: Add ids for audiomix reset To: Abel Vesa Cc: Lee Jones , Shawn Guo , Peng Fan , Philipp Zabel , Stephen Boyd , Sascha Hauer , Anson Huang , Leonard Crestez , Jacky Bai , NXP Linux Team , Linux Kernel Mailing List , DTML , linux-clk , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:KQ+T8D0HvWvxIDVOE8VSY51PYvng9yj5NHqSmIvlwfO7JKnO5+S SyTDOtWMwBqH30u7KqZszvunI9Gy+oOeWkYtwLBdTaoVQCdSD7tXPTMQQzfbflEEvyZljL4 sKUgxwAN5/T7NVY1qV1j8z56OGqu8ONaJTqgOuKExuA1TH9AYwj/eHnkQw/bKR8luJjhHVr 2PIG2FlBc9rAj+B8Ug9Ag== X-UI-Out-Filterresults: notjunk:1;V03:K0:F6L9vopFEUo=:LqVBk8PtrZdoNV8X1XRXaz bNSd4Es1iOJgq+MB61ogStg0FrWUFWRzO53jNw0J8sI8VnHK01dInOk0/jzlAAdM0yLKQpvcP FP200WdBfSHjeewvHvJQP4ZwvBhGEcTfhN1/M1WmuxEYU6iEv0YB8yUprLxN4+h6awPn5e00y DDURCXpt2xe8miGl8Td3eLWMFu9dUxhd7b+MIbsZpzY2dG9t/MomCF0lV9zhO03cz0ZEU7n1L +OoASIpQkVflGCGRTJoAeAE76q3lZ5gmwbWpTrYaNXQlFHzjaDLwkHEVun6eemUupm3INKqWu AVN/I5vOk7kjsUEgO4CFn2RVGeY8sPHnswV5kt9jD6v+7bBoGO09tbpFJxiAp3GpNURmo9VFV 72US6hNy46Ngmv4yje+qytpO8PBfOpphu8Qg7Pnw1K+2CBcq7u0w5Uq3ZavN+jaYJFnzAqdxD fZMlVQHsioUibV/RF7syAR5lSGyo/mUC+TzrFZDqXVeUUVMUG9stQ/wOR8ACD4zr6pJQUOWaR ORadF8TzZHqPXYiYVcrxwnJkc8rkz11nub2q2Rfz6TzESWptjf4EpscRPyFv5Qlw/og+ixiIQ 9Tk4MINlJTS23ogvmD0SfnUHELS5PPBEv4gFFpKugpDNFh9LaCAtO/gzL+kly2+8zzJcCtrL2 s/gQVITXhCYPPJcN1WZpDPKu/ID1tuRzgQ4vKWREpoBVx0NqrN86tZEY24GLQ3HzaBL9/9BjW RtbOAR7/KruHaCn2R8gYSzXZRC4KWBt7F4haW2zsY6abTv6CkpS4FXSR2AhDitTCGclgmRl4G G+ib1vdnPUFJi2E3cUIoRzmlgsMaiKqLAuvtc8shbSEGKYAKec= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 10:04 AM Abel Vesa wrote: > > Add all the reset ids for the audiomix reset. > > Signed-off-by: Abel Vesa > --- > include/dt-bindings/reset/imx-audiomix-reset.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/reset/imx-audiomix-reset.h > > diff --git a/include/dt-bindings/reset/imx-audiomix-reset.h b/include/dt-bindings/reset/imx-audiomix-reset.h > new file mode 100644 > index 00000000..67392c3 > --- /dev/null > +++ b/include/dt-bindings/reset/imx-audiomix-reset.h > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright 2019 NXP. > + */ > + > +#ifndef DT_BINDING_RESET_IMX_AUDIOMIX_H > +#define DT_BINDING_RESET_IMX_AUDIOMIX_H > + > +#define IMX_AUDIOMIX_EARC_RESET 0x0 > +#define IMX_AUDIOMIX_EARC_PHY_RESET 0x1 > + > +#define IMX_AUDIOMIX_RESET_NUM 2 > + This list doesn't seem necessary, as the number you pass ends up simply being the bit index in a single register. In a case like this you should better not have macros at all, those are only needed when there is no easy way to the numbers in the DT into something the driver can make sense of. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE908C2BB55 for ; Thu, 16 Apr 2020 11:10:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92EA9208E4 for ; Thu, 16 Apr 2020 11:10:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="apr+ZbpS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92EA9208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YKKHHD6ZFfOg0QC16n7IE1T0ogu7toAWqSP+uuzG5PA=; b=apr+ZbpS0/pMi7 bEz9+5dsVGevs0FIuFfO8n2+5wki2QZPWTOwwGnB2qnc3dNxQiETmtNBrKC0v2Yza9KQY8PqoneHa JD84UnQFBsQyciRh+9QCuS9TM9tQp5Zk8jXwel8kDT376ci6f2y2VkoeiPM7XH0r/KJF87ZTDzaAm rvY1H25NVd4V7oFYOFHcyaVHyJrCDt4NFliKUrSsRYB2JHuW0yUQ/B41+uKYTauKfUBi0PguIAW4A 6Pqca/b/f1Ybl1GWOAoLkfQfEIjiC3Ev9JTCueAflxiJU7kCI1hoLN06LgcuK6prMs7oUvn8tQxXN 3a9ocMwpTw9dRZYjONag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP2Pr-0000gs-18; Thu, 16 Apr 2020 11:10:43 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP2Po-0000gM-2I for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 11:10:41 +0000 Received: from mail-qt1-f181.google.com ([209.85.160.181]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MLQgv-1jhX2N2MCJ-00IXwf for ; Thu, 16 Apr 2020 13:10:36 +0200 Received: by mail-qt1-f181.google.com with SMTP id b10so15954575qtt.9 for ; Thu, 16 Apr 2020 04:10:36 -0700 (PDT) X-Gm-Message-State: AGi0PuYlpcvKvqydsffezeBzPxOOOQ+EFsnqZdk0U68itRm+88n+lyQm LXxwfOkSK+v1aAukwktI9gsdtIiHhxGbTAiEXEk= X-Google-Smtp-Source: APiQypKTnCrAJKWmvxQPPtXXxzoAVa6UTCMFQ9ATB3ibHu7YaQVTiYtm10ABd1Vj8N7EIF+bQAx1sinndyRxZBuK7IM= X-Received: by 2002:ac8:296f:: with SMTP id z44mr23735521qtz.18.1587035435488; Thu, 16 Apr 2020 04:10:35 -0700 (PDT) MIME-Version: 1.0 References: <1586937773-5836-1-git-send-email-abel.vesa@nxp.com> <1586937773-5836-12-git-send-email-abel.vesa@nxp.com> In-Reply-To: <1586937773-5836-12-git-send-email-abel.vesa@nxp.com> From: Arnd Bergmann Date: Thu, 16 Apr 2020 13:10:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 11/13] dt-bindings: reset: imx8mp: Add ids for audiomix reset To: Abel Vesa X-Provags-ID: V03:K1:60/tgC1tAfheOsTFP4mnLtiNeiTqALmvRmSMbDp+nvV8xl+sF3A M80m/swMQd3toPYCrpm4RQV0sjSXJTQiFHwEuTlW1K/srjkbEEJTdn5VYOX/ZmwIyMhMcvg RRh/p9E2121xKD8rAeAF37HVG2RzUWRYl/+aWUOHXKPYmlO7e2jDTS2PsGZ4/Ylt08XbakD NtZQf5uIa+eOBXeTWCU8g== X-UI-Out-Filterresults: notjunk:1;V03:K0:O2sXIoPi0LY=:UQ2eWTDJNV3QIKV3j+FYsZ BTWXA/ptRHzVCIvmbrOMaSPSodjXjZmgW1//uiZPOHM9pLwbrbeJ3QwSayPtLcScfNRrsbg4P qMAuUUjwrdC494j+fooiiRn4fAzn9umnCRopY57yQftFcrCgNclar+EZHnQvcE1+Otn6Xigoc /1LsHRELL0Uj2oH38zEgdjoA3vR78I7Crj66bKB/UyRb+tw+Y6bL6J7WQRVhSTg7M5flIEzkp nH2Nqc2yrNbWq/IXxxskC3aFnsVqW5dSoBKABzUomNuHS7Hrez1q6qW2TWFsy+Noz6YW50QGU p/ohPpxv33/Hnd1VFcrZ/2+pxiTIPWCguSXGhTIlQOIkITMC2k8o+gvOXQ1cXmFuRSOg51wDL xeeO4RxMueDh6FQgl+7isbP+eSu5xQfltCcr/QAhgoIbq2VMpXIPhzArG2n5tkYh9cmy1+W0B B5IaP6iSwsY575UbdtR+wPZ31KXNTruJdtzIziI2dehHhrBSv1IzZqsc++6PfsVWh7YSjLW5D Tlak4V84hZ9QJfxbq0U1tXqYZBRG4D9pBGkTpOvf2fadm1Yrap5/bJSMB8aDqteKxIVeuguAp /1zbOEsG3xkK0AqA1y7vj/gmJDN6yUU6j9b9726z+CnnSDEpm5FHuN7tVnllaY/X97S6XzXuK BygzXD1ORXbdGHJVklebziFLLUKsoF0iBQVba6Qbc+DBXPZU7PxIfdrS6mfl+RsPTDTaBZ0Y5 UOmeHiQbQQzC6F99WOgjSkKKgHI/1bVRFJiv+frm31bhk/fGvO45he3UtEw3aQl4XjKEVyF7n FkuEB+ItClvZZUQ5wPdvKMk4SgQbJ8+5GPS/bShucukkdo8+iI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_041040_399448_9A111F34 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Peng Fan , Philipp Zabel , Anson Huang , Stephen Boyd , Lee Jones , Linux Kernel Mailing List , NXP Linux Team , Sascha Hauer , Leonard Crestez , Shawn Guo , linux-clk , Linux ARM , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 15, 2020 at 10:04 AM Abel Vesa wrote: > > Add all the reset ids for the audiomix reset. > > Signed-off-by: Abel Vesa > --- > include/dt-bindings/reset/imx-audiomix-reset.h | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 include/dt-bindings/reset/imx-audiomix-reset.h > > diff --git a/include/dt-bindings/reset/imx-audiomix-reset.h b/include/dt-bindings/reset/imx-audiomix-reset.h > new file mode 100644 > index 00000000..67392c3 > --- /dev/null > +++ b/include/dt-bindings/reset/imx-audiomix-reset.h > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright 2019 NXP. > + */ > + > +#ifndef DT_BINDING_RESET_IMX_AUDIOMIX_H > +#define DT_BINDING_RESET_IMX_AUDIOMIX_H > + > +#define IMX_AUDIOMIX_EARC_RESET 0x0 > +#define IMX_AUDIOMIX_EARC_PHY_RESET 0x1 > + > +#define IMX_AUDIOMIX_RESET_NUM 2 > + This list doesn't seem necessary, as the number you pass ends up simply being the bit index in a single register. In a case like this you should better not have macros at all, those are only needed when there is no easy way to the numbers in the DT into something the driver can make sense of. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel