From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A854EC433EF for ; Thu, 11 Nov 2021 16:42:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 848B5610C8 for ; Thu, 11 Nov 2021 16:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234260AbhKKQo5 convert rfc822-to-8bit (ORCPT ); Thu, 11 Nov 2021 11:44:57 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:56687 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232033AbhKKQo4 (ORCPT ); Thu, 11 Nov 2021 11:44:56 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N8oKc-1mgNHX38OU-015uAI; Thu, 11 Nov 2021 17:42:05 +0100 Received: by mail-wr1-f47.google.com with SMTP id r8so10767656wra.7; Thu, 11 Nov 2021 08:42:05 -0800 (PST) X-Gm-Message-State: AOAM532Z+w+8SsgL78FVABcQUZaZ+T1ec2cuGNN8CKSDejqBWmygqN1F eB9sA1ZCUIQBS2QLOEWcbmt38VeIawq/OClHTS0= X-Google-Smtp-Source: ABdhPJx5ixmh9byW4TqjJFz6i36pu47gOG4MxdfEYwBa5JydmjzUlgQx1s3/1U2xifm5YWSSfQVw+Cg26iEzj2rLnyo= X-Received: by 2002:adf:d1c2:: with SMTP id b2mr10347630wrd.369.1636648925333; Thu, 11 Nov 2021 08:42:05 -0800 (PST) MIME-Version: 1.0 References: <20211111091123.50853-1-krzysztof.kozlowski@canonical.com> <16fbb472-4a82-1267-9971-db453ba009e3@canonical.com> In-Reply-To: <16fbb472-4a82-1267-9971-db453ba009e3@canonical.com> From: Arnd Bergmann Date: Thu, 11 Nov 2021 17:41:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr To: Krzysztof Kozlowski Cc: Arnd Bergmann , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux Kernel Mailing List , kernel test robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:Cs/rc3gJ8ojIGgdSVIXXfhFLSRK8r4TlA31y65LNadohR+T0v2L s2Mt33oVTImE4oDEshV/YwvEwCxq1YEQWnvnZ+QAcO6p8ISgsWPYByEziMWJQvgJ8OpcWvt rTrEHL94Fv2q4D/U/e3SAPX/inWjEPldeTYfdR11w4GnsW9hvcusrX4yJN8C3o8eOB0rV8N wKS8vth2jV6C+hifG8esA== X-UI-Out-Filterresults: notjunk:1;V03:K0:M4rL7yPVZm8=:vnkqUG2+9anc8XP8PL1oyG TeSJDCe4OOdtj/xWUQ90OfoH2jqaxfHR5TsGcppIBg4f+2aDnxUk9+wIjR6CivQHHj0VLFxZy hij4Vinnp1Y0nV/H+WFGc15z7QmhjAFq4oE0LrV0TMKgfzNJKbfPN+AmfDlVKCTibcokFFxlJ Q3lW+q0yLYkK4vPlUgGfY41+pQO9hKReE/LLiUauCGGNxiWYATAxu+tInzOJd3IeLl0xsdOGX ej6yL77KrpQZWeZbLtxQTCorCMPFaNuYLSDBxSsClWqBlylCmuneYqO/8z5VDysRKjsrS2SAj jFe6+Dp+rHKR61TiwEhdu3nXKSZKR4t28FlWZCZdzMXYHXgqFLLHxUlHuIn3SAeWfbChR/TYb yJuNVvx19q14DevBAEn7hjnkrZsxDexgpja1CgZt3A0wB5F4yI0Ojf01hWwewahGG98GFEq6R Ul7VlpVt9yi3JhJoSuFjhgRFfa/dnLiyVwikxxx49zQqWjLOaZKDaQmF3SqDqIsD9PV19VHo5 3LtlAo3LQ7ZVrcudrUtxwr+Un15CR7MaogFH3wYYlYDiXjHRy7QuamqM1lBhnbwFvyOYgt6KK hi8uLAD95wH6av4J5PWBBXNQ2QLTNpgCBE9BXrUvV12Elg5ndtio67WAdiWqpyJlL/HnAqjkG QylQcU2hOJvLsOs5iGrsPjky4DsQsiTBOFs4LMIRp2+3X5383jKK0fpivue+Jh0/WdSw= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 11, 2021 at 10:56 AM Krzysztof Kozlowski wrote: > > On 11/11/2021 10:46, Arnd Bergmann wrote: > > On Thu, Nov 11, 2021 at 10:11 AM Krzysztof Kozlowski > > wrote: > >> > >> Include the header with prototype of s3c2410_modify_misccr to fix W=1 > >> warning: > >> > >> arch/arm/mach-s3c/gpio-samsung.c:1309:14: warning: > >> no previous prototype for ‘s3c2410_modify_misccr’ [-Wmissing-prototypes] > >> > >> Reported-by: kernel test robot > >> Signed-off-by: Krzysztof Kozlowski > > > > Thank you for fixing it, > > > > Acked-by: Arnd Bergmann > > > > If you like, I can put it into the fixes branch of the soc tree directly, > > otherwise I expect you'll send it in a pull request later. > > It's not a serious bug and was there since long time, so maybe let's > send it via regular pull request. Ok, sounds good. I was worried for a bit that this would break builds with CONFIG_WERROR, but of course that is already broken in many ways with W=1. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1FF6C4332F for ; Thu, 11 Nov 2021 16:43:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B0FA61354 for ; Thu, 11 Nov 2021 16:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B0FA61354 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eOSnh69ff67XOoKRC0WsEYS/ZTuYu0/OyIlCj+ZKsyM=; b=gDeA9wvWgGy5sb fPf4IhoFK+t0szDvULhWtAdPVhU1ykiEmvrVUJk3Remf3DxkJJ+2rQhl78s5crI9PeAC/1jvlvnvz HM2FOpbTgQ8KPF0+lup4gV4YCdId5NaUy6sUmotcsnlA3pHgGARbUmHvgQw+4UdaRpD8Ad4Onm719 M0iWLXmzC+zzyuN8jA2jYQxiZ4REq/J7fNm4lMqCzI+4RHXrHpO09ddOo+zfx3rsAEWCH+RWTcCd3 khmpE/+0WNTO591diNSi3GxEMBfG45uMz0ukBgErTnZ47f05xPVtTnkMlkdbV76fgCdMLFvgRP71C 9bHjQc3EJRa1vibFNTUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlD9W-008QNP-0C; Thu, 11 Nov 2021 16:42:18 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlD9R-008QLZ-BQ for linux-arm-kernel@lists.infradead.org; Thu, 11 Nov 2021 16:42:14 +0000 Received: from mail-wr1-f45.google.com ([209.85.221.45]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M5wc7-1mnhyw3m5z-007W5y for ; Thu, 11 Nov 2021 17:42:05 +0100 Received: by mail-wr1-f45.google.com with SMTP id b12so10834936wrh.4 for ; Thu, 11 Nov 2021 08:42:05 -0800 (PST) X-Gm-Message-State: AOAM532zpeb6KKs0VOvnOvxRx+uPTqApcJZyHpQI3Yv2g+a4Pl16Y/11 JmJaSqCrCWb/vtakDL5lT406HIHG7IBgK7OjKuY= X-Google-Smtp-Source: ABdhPJx5ixmh9byW4TqjJFz6i36pu47gOG4MxdfEYwBa5JydmjzUlgQx1s3/1U2xifm5YWSSfQVw+Cg26iEzj2rLnyo= X-Received: by 2002:adf:d1c2:: with SMTP id b2mr10347630wrd.369.1636648925333; Thu, 11 Nov 2021 08:42:05 -0800 (PST) MIME-Version: 1.0 References: <20211111091123.50853-1-krzysztof.kozlowski@canonical.com> <16fbb472-4a82-1267-9971-db453ba009e3@canonical.com> In-Reply-To: <16fbb472-4a82-1267-9971-db453ba009e3@canonical.com> From: Arnd Bergmann Date: Thu, 11 Nov 2021 17:41:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: s3c: include header for prototype of s3c2410_modify_misccr To: Krzysztof Kozlowski Cc: Arnd Bergmann , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux Kernel Mailing List , kernel test robot X-Provags-ID: V03:K1:Ip2ptOW1hWXbq433PFCXp4B7t38uwNSEMXr8XD7URXYyV5KBAHT uqRGKsP3B5QpZdjz2wpHeqWF9A8H0FIo+fT4ftfA1HJudlHKoQMfa7nD+oMJrkDPrHZ6uhi RXoDJEL4Dp2zQkctCZ31EVnjfgjQPvAYq91CRSGF4Jf7FMbbguwk8Uxr75x4GaynQDokqEj OmlA+BSXBE1fbupdPtf0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:g9HMHqc2wyU=:IJu8gS5Ur+OROOAZO6EuLz 2zQTLJ3uDhLb4AedLGPhTv3qdLJlMK1co0EoFAqHPY4e+T9//nLeFf/NJhPs0Wkq5wjn25n2S aSk7ZUNyzGdemk+Hu30xxCCR2kDQYfpJ986tTR26IJvgLPHqGWEJNx88uDzfncg4iR396C22R JWdSZJ4nfYcDVPEZX3Xh3Dj03+jvA4/3H40/Q5r+BCW9JCjWp7EgZq8HlytCBT0LivXX/iXhc p68fs22g5JCU/xhJ1MjwdI8wFnAm9SO8M3g7frjzq5SMdDxp7vafLAwtiH9VxeLI1J+6+8WTb 4dHB7TSEQwpf/sZMA2S6mB+Q65UDnbRoUwOnQpwvFwLsO+NCKBMtJcAwwxeMYKSBB8SYrzN+e Fjh5cHSWrFQhZzaxrBxlNA4naJlwma/oD0hmIPyap6ZFxL4nrl/civ9nC38rLcbOnvgyqqwYX k72eVok61DtwenoGP1JYgX52QleqBlxIR/vlTeLtdfs0CfSEc3jJPpeWpzvai8krlRIpKSvBF +4hzwyFU094bgb4c7o9taCjXH4etU5gSfafN5dLogptpzh/H2kUCVLMx4buH8AJQTtynGfjK3 kPp7f8a/1gPqhnfhpeMrGl5PlMiwCa5koc1V6wrAArrTLPYfclWr8LMvG23DFPMS8cTcviUaH YMloqdZsUTWlEfFfDEa1tXHAB0710e/D1uxqD6Jx0JSNFA7/2Cj9S5XeZh0thX84AApE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_084213_734706_1EFBAD0A X-CRM114-Status: GOOD ( 18.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMTEsIDIwMjEgYXQgMTA6NTYgQU0gS3J6eXN6dG9mIEtvemxvd3NraQo8a3J6 eXN6dG9mLmtvemxvd3NraUBjYW5vbmljYWwuY29tPiB3cm90ZToKPgo+IE9uIDExLzExLzIwMjEg MTA6NDYsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAxMSwgMjAyMSBhdCAx MDoxMSBBTSBLcnp5c3p0b2YgS296bG93c2tpCj4gPiA8a3J6eXN6dG9mLmtvemxvd3NraUBjYW5v bmljYWwuY29tPiB3cm90ZToKPiA+Pgo+ID4+IEluY2x1ZGUgdGhlIGhlYWRlciB3aXRoIHByb3Rv dHlwZSBvZiBzM2MyNDEwX21vZGlmeV9taXNjY3IgdG8gZml4IFc9MQo+ID4+IHdhcm5pbmc6Cj4g Pj4KPiA+PiAgIGFyY2gvYXJtL21hY2gtczNjL2dwaW8tc2Ftc3VuZy5jOjEzMDk6MTQ6IHdhcm5p bmc6Cj4gPj4gICAgIG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig4oCYczNjMjQxMF9tb2RpZnlf bWlzY2Ny4oCZIFstV21pc3NpbmctcHJvdG90eXBlc10KPiA+Pgo+ID4+IFJlcG9ydGVkLWJ5OiBr ZXJuZWwgdGVzdCByb2JvdCA8bGtwQGludGVsLmNvbT4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBLcnp5 c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGNhbm9uaWNhbC5jb20+Cj4gPgo+ ID4gVGhhbmsgeW91IGZvciBmaXhpbmcgaXQsCj4gPgo+ID4gQWNrZWQtYnk6IEFybmQgQmVyZ21h bm4gPGFybmRAYXJuZGIuZGU+Cj4gPgo+ID4gSWYgeW91IGxpa2UsIEkgY2FuIHB1dCBpdCBpbnRv IHRoZSBmaXhlcyBicmFuY2ggb2YgdGhlIHNvYyB0cmVlIGRpcmVjdGx5LAo+ID4gb3RoZXJ3aXNl IEkgZXhwZWN0IHlvdSdsbCBzZW5kIGl0IGluIGEgcHVsbCByZXF1ZXN0IGxhdGVyLgo+Cj4gSXQn cyBub3QgYSBzZXJpb3VzIGJ1ZyBhbmQgd2FzIHRoZXJlIHNpbmNlIGxvbmcgdGltZSwgc28gbWF5 YmUgbGV0J3MKPiBzZW5kIGl0IHZpYSByZWd1bGFyIHB1bGwgcmVxdWVzdC4KCk9rLCBzb3VuZHMg Z29vZC4gSSB3YXMgd29ycmllZCBmb3IgYSBiaXQgdGhhdCB0aGlzIHdvdWxkIGJyZWFrIGJ1aWxk cwp3aXRoIENPTkZJR19XRVJST1IsIGJ1dCBvZiBjb3Vyc2UgdGhhdCBpcyBhbHJlYWR5IGJyb2tl biBpbgptYW55IHdheXMgd2l0aCBXPTEuCgogICAgICAgIEFybmQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK