From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03E1C2D0A3 for ; Fri, 6 Nov 2020 14:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 440DC2087E for ; Fri, 6 Nov 2020 14:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604674017; bh=XLMTTC2awluKxedLZISCKHbkm9xxvmnFXJZX4qOXmO4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=X5QDwcijq+H0TF1dz2M8yGaquQpuxQMDApBamZEeeL77ulRZgfnR1QZTOvI/XdUaL z0Z0ds5/eY5YWvM5756YCw00ztu34KzKXtSW2DKy5A4+BF4e4dNyEWz5nxHFT3R+FY e0lCwZBD/5CRf1cSMhRg8eeBEJys7t2Y47DagDj8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbgKFOq4 (ORCPT ); Fri, 6 Nov 2020 09:46:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:40402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbgKFOqz (ORCPT ); Fri, 6 Nov 2020 09:46:55 -0500 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB8622151B for ; Fri, 6 Nov 2020 14:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604674015; bh=XLMTTC2awluKxedLZISCKHbkm9xxvmnFXJZX4qOXmO4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=seymZ1Zt/wxhBysHJmHQcL/EDAIeaqe9y5cWypfEtdYsNSDNXDWce+jI47J4DW+gB R7tqfEB3WfJxNr7kQiIGTRjAE+LC0/ETMUYNhfvmnhFY0bZR3KZ0HXrhuxe+AogWxN IBzYldfjPaYMQFKYP7kPCKW/+e4TVz6kTGXqX7KM= Received: by mail-wm1-f52.google.com with SMTP id h62so1567711wme.3 for ; Fri, 06 Nov 2020 06:46:54 -0800 (PST) X-Gm-Message-State: AOAM5338jCMDNVl2yfl5qeqkViio90MhWBnBnD2uDngxMvBY4F5Sxlqs qqPuCoeLSaW59T371VoJMA3UgEUGxAwAY8r6v1U= X-Google-Smtp-Source: ABdhPJxluRfkoGw+7yKjOxgY55CAPQ2wZrfY/51FKfV8mad50nwDywDUEUH2tKvT7MaL8Bu8hzMB2roRmIXlzf5GHAo= X-Received: by 2002:a05:600c:256:: with SMTP id 22mr2845332wmj.120.1604674013090; Fri, 06 Nov 2020 06:46:53 -0800 (PST) MIME-Version: 1.0 References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-2-adrian.ratiu@collabora.com> In-Reply-To: <20201106051436.2384842-2-adrian.ratiu@collabora.com> From: Arnd Bergmann Date: Fri, 6 Nov 2020 15:46:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning To: Adrian Ratiu Cc: Linux ARM , Nathan Chancellor , Nick Desaulniers , Arnd Bergmann , clang-built-linux , Russell King , "linux-kernel@vger.kernel.org" , Collabora kernel ML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 6, 2020 at 6:14 AM Adrian Ratiu wrote: > > From: Nathan Chancellor > > Drop warning because kernel now requires GCC >= v4.9 after > commit 6ec4476ac825 ("Raise gcc version requirement to 4.9"). > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > Signed-off-by: Adrian Ratiu > --- > arch/arm/lib/xor-neon.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c > index b99dd8e1c93f..e1e76186ec23 100644 > --- a/arch/arm/lib/xor-neon.c > +++ b/arch/arm/lib/xor-neon.c > @@ -19,15 +19,8 @@ MODULE_LICENSE("GPL"); > * -ftree-vectorize) to attempt to exploit implicit parallelism and emit > * NEON instructions. > */ > -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) > +#ifdef CONFIG_CC_IS_GCC > #pragma GCC optimize "tree-vectorize" > -#else > -/* > - * While older versions of GCC do not generate incorrect code, they fail to > - * recognize the parallel nature of these functions, and emit plain ARM code, > - * which is known to be slower than the optimized ARM code in asm-arm/xor.h. > - */ > -#warning This code requires at least version 4.6 of GCC > #endif I think we still need the #else path, otherwise we don't warn about clang being broken here. If it is intentional that we now silently build this code with clang without it working as intended, that should be mentioned in the changelog. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412DCC2D0A3 for ; Fri, 6 Nov 2020 14:47:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3E72087E for ; Fri, 6 Nov 2020 14:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jESdLcb0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="seymZ1Zt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3E72087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dzDIawX0nZb6asMgW/woE/DFRgZ8+uOZt5pAIhIoWTw=; b=jESdLcb0xIVRNf46NB3nyUmaB Lvr79VAn4t0kqjz+JDPeeiu7B+/WJx9plRUx8E9kExaZ/ur0KIOuTNr8rYYzUZ7tuIeP/ZbDcU05g xRwUeSuDFjNjavXykX0OBD/yr6CNdFnWyhldzh7lQhV1AeC3OfrflZdsLSuzcwSiefjCKXPLAzXW3 FmfQPc8YaHvYab+EE48QaeamjVRih3QIF6tYMkYHdlbtIgUGJ+gGPEl767YdfCG72VLElNSfx7LE/ wI/Yk5+ln672witp9zlCGm15G3dxIoHFszgeeR6DJ/vUm8gO+OsA36tPJ1J5XIz9P9yeATY7M4UsS fevbjBANQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb311-0007YY-6X; Fri, 06 Nov 2020 14:46:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kb30y-0007Xs-24 for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 14:46:56 +0000 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF0152087E for ; Fri, 6 Nov 2020 14:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604674015; bh=XLMTTC2awluKxedLZISCKHbkm9xxvmnFXJZX4qOXmO4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=seymZ1Zt/wxhBysHJmHQcL/EDAIeaqe9y5cWypfEtdYsNSDNXDWce+jI47J4DW+gB R7tqfEB3WfJxNr7kQiIGTRjAE+LC0/ETMUYNhfvmnhFY0bZR3KZ0HXrhuxe+AogWxN IBzYldfjPaYMQFKYP7kPCKW/+e4TVz6kTGXqX7KM= Received: by mail-wm1-f51.google.com with SMTP id h62so1567710wme.3 for ; Fri, 06 Nov 2020 06:46:54 -0800 (PST) X-Gm-Message-State: AOAM533tajdnkx3oV6IG5IJXEAs3uojR0TXQZvBckxYBZMhPxO21LHEC y8B6EXnT1h+s+Kmxaq8AP+47gzzmFEO/GZLU6OE= X-Google-Smtp-Source: ABdhPJxluRfkoGw+7yKjOxgY55CAPQ2wZrfY/51FKfV8mad50nwDywDUEUH2tKvT7MaL8Bu8hzMB2roRmIXlzf5GHAo= X-Received: by 2002:a05:600c:256:: with SMTP id 22mr2845332wmj.120.1604674013090; Fri, 06 Nov 2020 06:46:53 -0800 (PST) MIME-Version: 1.0 References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-2-adrian.ratiu@collabora.com> In-Reply-To: <20201106051436.2384842-2-adrian.ratiu@collabora.com> From: Arnd Bergmann Date: Fri, 6 Nov 2020 15:46:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning To: Adrian Ratiu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_094656_207678_03211D67 X-CRM114-Status: GOOD ( 21.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Nick Desaulniers , Russell King , "linux-kernel@vger.kernel.org" , clang-built-linux , Nathan Chancellor , Collabora kernel ML , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 6, 2020 at 6:14 AM Adrian Ratiu wrote: > > From: Nathan Chancellor > > Drop warning because kernel now requires GCC >= v4.9 after > commit 6ec4476ac825 ("Raise gcc version requirement to 4.9"). > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > Signed-off-by: Adrian Ratiu > --- > arch/arm/lib/xor-neon.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c > index b99dd8e1c93f..e1e76186ec23 100644 > --- a/arch/arm/lib/xor-neon.c > +++ b/arch/arm/lib/xor-neon.c > @@ -19,15 +19,8 @@ MODULE_LICENSE("GPL"); > * -ftree-vectorize) to attempt to exploit implicit parallelism and emit > * NEON instructions. > */ > -#if __GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6) > +#ifdef CONFIG_CC_IS_GCC > #pragma GCC optimize "tree-vectorize" > -#else > -/* > - * While older versions of GCC do not generate incorrect code, they fail to > - * recognize the parallel nature of these functions, and emit plain ARM code, > - * which is known to be slower than the optimized ARM code in asm-arm/xor.h. > - */ > -#warning This code requires at least version 4.6 of GCC > #endif I think we still need the #else path, otherwise we don't warn about clang being broken here. If it is intentional that we now silently build this code with clang without it working as intended, that should be mentioned in the changelog. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel