From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AE8670 for ; Thu, 22 Apr 2021 15:26:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C661F61425 for ; Thu, 22 Apr 2021 15:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619105166; bh=cNV6IkI3EWzn8eh94ZL3mGzZvUvtIXIKPP3ff/Wu2r0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WJZxSKgRGaYojFqnI5Xw3j6lv7JhY7L98wi+C+a1WMBbFsFJ1H7l3zaqGAqDdwzS+ IleJy4AsqgKVCCRwk1Z3sp72pXPeTTQnrtzW+RPNrizfomALb5atfy2nZg/rLhKuB/ gW1K0myY7rh//GXDX4NPFFfZSpExnTWLiXIRYz3KEottrfk+4LNZ+X55vjxQMm2FiU YAprcp304ebdB5zm43yXtykwrFoaoT8qBblOSPgbW7jMLt6GcYNyjIUFb8gXrjQW9S lmVaXl202s2MrcE5HvT8Lte0ENIrNQpUTz4svtsy/QXoGzGWOJtVxZ2ZOsSK8B2Vd9 cjCJeZmPJaUgQ== Received: by mail-wm1-f52.google.com with SMTP id o9-20020a1c41090000b029012c8dac9d47so3499058wma.1 for ; Thu, 22 Apr 2021 08:26:06 -0700 (PDT) X-Gm-Message-State: AOAM533vx0+G/rU2RAke6kS36U+FNO7TuTABH4WVp8rt+o0VGJfmwGJN c9s90p3JaWVb5Df+mY8UVOP2C2yG+dH3Ww0B3o4= X-Google-Smtp-Source: ABdhPJw0ywSPUuI3ypsEpkKqT93BmtVIDmqQz9BrkPsEzaNRiU2utOqsHbURvWDUj66X33ir670K0POBCVRbOl/79Mk= X-Received: by 2002:a7b:c344:: with SMTP id l4mr610378wmj.120.1619105165273; Thu, 22 Apr 2021 08:26:05 -0700 (PDT) X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20210422133219.1689027-1-arnd@kernel.org> <20210422151740.GI1981@kadam> In-Reply-To: <20210422151740.GI1981@kadam> From: Arnd Bergmann Date: Thu, 22 Apr 2021 17:25:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] staging: rtl8723bs: avoid bogus gcc warning To: Dan Carpenter Cc: Greg Kroah-Hartman , Fabio Aiuto , Ross Schmidt , Marco Cesati , Johannes Berg , Ivan Safonov , linux-staging@lists.linux.dev, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Thu, Apr 22, 2021 at 5:19 PM Dan Carpenter wrote: > On Thu, Apr 22, 2021 at 03:32:04PM +0200, Arnd Bergmann wrote: > > @@ -762,7 +764,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa > > } > > > > } > > - > > Since you're going to need to redo this, then please don't do this > unrelated whitespace change. > > > +#if 1 > > These seems unintetional? > Indeed, both (and another removed line) are artifacts from debugging that ended up making it into the commit by accident. Sending v2 now. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB303C433B4 for ; Thu, 22 Apr 2021 15:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9663661450 for ; Thu, 22 Apr 2021 15:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236580AbhDVP0p (ORCPT ); Thu, 22 Apr 2021 11:26:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:57900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236356AbhDVP0m (ORCPT ); Thu, 22 Apr 2021 11:26:42 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CF02E613F6 for ; Thu, 22 Apr 2021 15:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619105166; bh=cNV6IkI3EWzn8eh94ZL3mGzZvUvtIXIKPP3ff/Wu2r0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WJZxSKgRGaYojFqnI5Xw3j6lv7JhY7L98wi+C+a1WMBbFsFJ1H7l3zaqGAqDdwzS+ IleJy4AsqgKVCCRwk1Z3sp72pXPeTTQnrtzW+RPNrizfomALb5atfy2nZg/rLhKuB/ gW1K0myY7rh//GXDX4NPFFfZSpExnTWLiXIRYz3KEottrfk+4LNZ+X55vjxQMm2FiU YAprcp304ebdB5zm43yXtykwrFoaoT8qBblOSPgbW7jMLt6GcYNyjIUFb8gXrjQW9S lmVaXl202s2MrcE5HvT8Lte0ENIrNQpUTz4svtsy/QXoGzGWOJtVxZ2ZOsSK8B2Vd9 cjCJeZmPJaUgQ== Received: by mail-wm1-f53.google.com with SMTP id n4-20020a05600c4f84b029013151278decso3344707wmq.4 for ; Thu, 22 Apr 2021 08:26:06 -0700 (PDT) X-Gm-Message-State: AOAM531qsLdgD2ToZOVJjJHbIgUa5fNRK8H26IS/U9XJHY3FXfKyU6IQ WGEUQRu5DsN86vGWFBPPwMYfmzm4Um9im0MirEY= X-Google-Smtp-Source: ABdhPJw0ywSPUuI3ypsEpkKqT93BmtVIDmqQz9BrkPsEzaNRiU2utOqsHbURvWDUj66X33ir670K0POBCVRbOl/79Mk= X-Received: by 2002:a7b:c344:: with SMTP id l4mr610378wmj.120.1619105165273; Thu, 22 Apr 2021 08:26:05 -0700 (PDT) MIME-Version: 1.0 References: <20210422133219.1689027-1-arnd@kernel.org> <20210422151740.GI1981@kadam> In-Reply-To: <20210422151740.GI1981@kadam> From: Arnd Bergmann Date: Thu, 22 Apr 2021 17:25:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] staging: rtl8723bs: avoid bogus gcc warning To: Dan Carpenter Cc: Greg Kroah-Hartman , Fabio Aiuto , Ross Schmidt , Marco Cesati , Johannes Berg , Ivan Safonov , linux-staging@lists.linux.dev, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 22, 2021 at 5:19 PM Dan Carpenter wrote: > On Thu, Apr 22, 2021 at 03:32:04PM +0200, Arnd Bergmann wrote: > > @@ -762,7 +764,6 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, struct ieee_pa > > } > > > > } > > - > > Since you're going to need to redo this, then please don't do this > unrelated whitespace change. > > > +#if 1 > > These seems unintetional? > Indeed, both (and another removed line) are artifacts from debugging that ended up making it into the commit by accident. Sending v2 now. Arnd