From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A69C433F5 for ; Wed, 20 Apr 2022 12:10:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352815AbiDTMNK (ORCPT ); Wed, 20 Apr 2022 08:13:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378442AbiDTMNJ (ORCPT ); Wed, 20 Apr 2022 08:13:09 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 719DD28E3A; Wed, 20 Apr 2022 05:10:21 -0700 (PDT) Received: from mail-wr1-f46.google.com ([209.85.221.46]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N9M5y-1o1nCx3k9c-015M8y; Wed, 20 Apr 2022 14:10:19 +0200 Received: by mail-wr1-f46.google.com with SMTP id x18so2019503wrc.0; Wed, 20 Apr 2022 05:10:19 -0700 (PDT) X-Gm-Message-State: AOAM530HBRqZVdBx6mQC9a2skGh625UftjxhGT9wSh3x8APaCuzki3ce KqJGXpGYGVLe4QlzSfnlm1qnPnQ/5E3aENZVbrU= X-Google-Smtp-Source: ABdhPJwEzMpW3Z+El4kjnHs87k1+HrjytUR9IDBIcg8LlQbi6Kg0Yw1ngl3fa6HiSMPMMkT1ObfluHZ9iQTS11evFFo= X-Received: by 2002:a5d:6389:0:b0:207:a7d8:2b64 with SMTP id p9-20020a5d6389000000b00207a7d82b64mr15261455wru.12.1650456619497; Wed, 20 Apr 2022 05:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20220420115512.175917-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220420115512.175917-1-krzysztof.kozlowski@linaro.org> From: Arnd Bergmann Date: Wed, 20 Apr 2022 14:10:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config To: Krzysztof Kozlowski Cc: Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Arnd Bergmann , Necip Fazil Yildiran , "# 3.4.x" Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:9HTFVXbF8thm6W+pemK9kzBhMavi6QDXkUIgNwn+le/z7kbKJ92 ZvJUkoZ8qmqzWiQ9tXqtRDDQCZhpAvncbnXGxiXolRPXTgdbc8gXjvPzPAwj8tMu8ODKGxg VZexpZbWDhsO0/saIdV1TVoXT8/B5B+/rGEK2bAgaEBo0085Rtcai4/qrH+GQUZuFwYLhiF uk+bvnOm2RWyXYaBkqT3g== X-UI-Out-Filterresults: notjunk:1;V03:K0:6eg226EKkx4=:Gzm/re6sjLggt33JpQubg3 dtzvmwLw1AYDrz+cNiJ52HCzMTQjNFbGdKl7O4TDQemDeK17AdISpVSMbbP9PzaGj4yvbfb2Q naSiyX1RbsRgMGd75DPi8b72Nu4Zx+Lj6LHxCWMHsbjHPuLDAOAYna0ZcC3JkEOEVA5fJTHH7 qmjyTCdw7s1HQ1e2uEx/6GAFAH1tT0RGfh7ippdD6ly8o4Mpxc0GN+INZBRL7ZngEScEhdMvo PjFTFl3PJyw8B91Ac545iyzNtDsuNMAIy46BVtUKjntLFnZ9XL6blTi2gNTvTl/B1s3yGBgBP B+wdKzK2BbXOtT92QUNtinSwacTtepjf1SAS5YtzJ0XOvlEVCMZfzIoZJwIM7S8CADK6E+ULQ oGp0KfjJw8clKgg4L1KgLgJkx0P+m81fKdMFl9yWexoN0/yQdGDmKjE2CO6bWyTw6/nNt0/Ub Z3y7bcPnATlmmJaqB6by4Yd8NHfq3+YZ7YVuWpI0YFyvzg+herDsp0mt9RoCZp629oV/XULgA Xf8D1c8A/xnNadyfwXRw+uChn33CPqD55nmPirAnbRy8tK5ppC9SzqvGbZQACPtSBg+xYh5mO 2el0LCYogE/9Cf/M/zFU6Qqjst66bxDbCLrqxWPX90v8qVtE0JN3QdTz09dr0FhBJdipMhhh7 7HbknufRdM1VmmfLcsmC6IY99lxD8EX6DW4tNRLNp8JdU9dZng2aVO50onghHcEff0RFcghY7 QWoVMBxn5MJ5smxrCNUVUgLnzAfmnLZydcSR/I4cEOIqc6cUuJdMbvhDkaILc4ARnz+hy9hHy h1WUHvMlWliDAmLC+UQNK73p8o/DPoyaQKIuxC6YQ6wtU7hJv0= Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Apr 20, 2022 at 1:55 PM Krzysztof Kozlowski wrote: > > The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB. > ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8 > Exynos selects only the latter leading to possible wrong configuration > on ARMv8 build: > > WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS > Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y]) > Selected by [y]: > - ARCH_EXYNOS [=y] > > Reported-by: Necip Fazil Yildiran > Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig") > Cc: > Signed-off-by: Krzysztof Kozlowski > This does not look like a correct fix: > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > index dfd805e76862..c852fd1dd284 100644 > --- a/drivers/pinctrl/samsung/Kconfig > +++ b/drivers/pinctrl/samsung/Kconfig > @@ -4,13 +4,13 @@ > # > config PINCTRL_SAMSUNG > bool > - depends on OF_GPIO > + select GPIOLIB > + select OF_GPIO > select PINMUX > select PINCONF OF_GPIO is an automatic symbol that is always enabled when both GPIOLIB and OF are enabled. Selecting it from somewhere else cannot really work at all. I see we have a few other instances and should probably fix those as well. > config PINCTRL_EXYNOS > bool "Pinctrl common driver part for Samsung Exynos SoCs" > - depends on OF_GPIO > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > select PINCTRL_SAMSUNG > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) The problem here is that PINCTRL_EXYNOS and the others can be built for compile-testing without CONFIG_OF on non-arm machines. I think the correct dependency line would be depends on ARCH_EXYNOS || ARCH_S5PV210 || (COMPILE_TEST && OF) which guarantees that OF_GPIO is also enabled. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E47CC433EF for ; Wed, 20 Apr 2022 12:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lc5G8plDSOw4wKgwFo1VJCKQeHqJBniuJbpslm9IQsw=; b=ELTgmgCUTjdK5Q JFyQP+3FoxGpY6IDa1IDWxVRl2JW9O/g/qnxDNXAMjGfuqPcBFEQg2VjM/YrcYSzBtDIKMT8PrKkx c4GHQDOM6ob7M90bKQWLhIYn4dLVtBNKJUM0DcT7vJs3s1r19MUuulhpMuaPn3luNTlvgoZ4OOkRw TIlxoZEW8e4B6w/aUD7sJywkyFvKKYCcIlhMz1iQq2SWbPIKpe3OZr10Wct7ml86Zuvfxy2xhnyPg eQ5NUtSo5k2tsgbIq1CJY2FJr0vGwFh+OFbslvYadl3+yxLVK3erLciCvYOWdQ1vFsaOsfmzkmkT+ rDfOXe9fZD/p0szmgbHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9AE-008v5k-GF; Wed, 20 Apr 2022 12:10:30 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9AA-008v3i-Tl for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 12:10:28 +0000 Received: from mail-wr1-f51.google.com ([209.85.221.51]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MmDAW-1oOyMB0wiG-00iFam for ; Wed, 20 Apr 2022 14:10:23 +0200 Received: by mail-wr1-f51.google.com with SMTP id g18so1957460wrb.10 for ; Wed, 20 Apr 2022 05:10:19 -0700 (PDT) X-Gm-Message-State: AOAM532ldVyItxrpoTNemJNGhG8diWpyF1AXPKMLvXjuqDoakw42l2De AIQou+YSmIe4sLqIfMuchrGxtMrmTaJLAHVHRgY= X-Google-Smtp-Source: ABdhPJwEzMpW3Z+El4kjnHs87k1+HrjytUR9IDBIcg8LlQbi6Kg0Yw1ngl3fa6HiSMPMMkT1ObfluHZ9iQTS11evFFo= X-Received: by 2002:a5d:6389:0:b0:207:a7d8:2b64 with SMTP id p9-20020a5d6389000000b00207a7d82b64mr15261455wru.12.1650456619497; Wed, 20 Apr 2022 05:10:19 -0700 (PDT) MIME-Version: 1.0 References: <20220420115512.175917-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220420115512.175917-1-krzysztof.kozlowski@linaro.org> From: Arnd Bergmann Date: Wed, 20 Apr 2022 14:10:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] pinctrl: samsung: fix missing GPIOLIB on ARM64 Exynos config To: Krzysztof Kozlowski Cc: Alim Akhtar , Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , Arnd Bergmann , Necip Fazil Yildiran , "# 3.4.x" X-Provags-ID: V03:K1:3hAzQ7HlzMGcX7XNTCHtgBDs3fw3LKSjlaSYjKS2iN5Uvo5lAPF 34mKdINURjfTP4ZX6iBu/iWdtQQ4EuRVZ0v5Kb/hh7hYNM7yM7Tm/f30BpKvDE5qufAD3mu Fy7dje0LGbSoZHE840SsA5e1qIewYyj5kZLPzA6zIAT3D5jmT3/0FJG+sJ/Me7s5i6RMc9V mUZtbR5jjUH/nUCuds2CQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:lVeBwFd8Yk4=:X36QT4Gl0vG+TUqArBQNNW LgIl6ffiLHp06GIPfn1huq5vyX9Y6tHd/t7fQdepegU5tjv5R+tRnzj+dUsi0+z9ugLeMBclC x6tb23YttvTbpzE8Q2/aKlHu83LNqjUc8Wwt/1JrpzRZqOSTTZYydcsTyganZg6dJNE+XTOOq WIN6fbwMDsu3WPYqOnnVAfBXmVBDrBvdoXAU3UmvXXQ0SLvAVxgLS2tCI0NaLzTySZhpE1ElF 8Kiq6ZCOcCpfhRnk8fACeoy/BfOlmbKHvWSVipY5SwXQV7qCLMITI8ww/Yt3zzVEdClmR5tzh DMGgeV9p9OILrhEKo0hlTc9aiMD75FNZgFXz4drUn3fl5pzK6WUXx/Zik3v1Tr69gSbBFg6F1 adxMc5niFOFlDQ/75KnWZjw6k7KXbcOm+62u4X5qfI/G3YfPoimYUon3XBO4SGsEqYWbOdKGo QszsLnAOQo2Q7lxxIQ053b1g0JDEAhp97XRam/L86TMMY1ZfI5UZWDc1OzFUPiUP9MxR+87Mu HyPbJ5Gnvg5pTo1/tpXGjdbtmEjNt9xx0d4txRwGPQGRTj6mpApwNT+dv6sXJROBBloRvWNtG 5QmhAteQooVKflWBc9yQoJehIdMMwQDKT+RXBj78Kox5TtPT7g3y8BoDBLBGQVMLsfSZk6Wse 3BI8rgMFf1hgM/7Ztaa0qDwaY44JneitiYZZcJXNGhLJpx/ta+q1fErUdA/f648ooHXVYY32p X9o5y6SDYO43FN8BNE8jylvqEp63WiVgmROBkYD6OXXNcMqlvFNafrAlotQoGnttVOjlg6aLU 5b9tFXEDaDOBJG70xhp6M/iSX1VKES/lEsQT52cm2goHQY6HUc= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_051027_289212_90B12D50 X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 20, 2022 at 1:55 PM Krzysztof Kozlowski wrote: > > The Samsung pinctrl drivers depend on OF_GPIO, which is part of GPIOLIB. > ARMv7 Exynos platform selects GPIOLIB and Samsung pinctrl drivers. ARMv8 > Exynos selects only the latter leading to possible wrong configuration > on ARMv8 build: > > WARNING: unmet direct dependencies detected for PINCTRL_EXYNOS > Depends on [n]: PINCTRL [=y] && OF_GPIO [=n] && (ARCH_EXYNOS [=y] || ARCH_S5PV210 || COMPILE_TEST [=y]) > Selected by [y]: > - ARCH_EXYNOS [=y] > > Reported-by: Necip Fazil Yildiran > Fixes: eed6b3eb20b9 ("arm64: Split out platform options to separate Kconfig") > Cc: > Signed-off-by: Krzysztof Kozlowski > This does not look like a correct fix: > diff --git a/drivers/pinctrl/samsung/Kconfig b/drivers/pinctrl/samsung/Kconfig > index dfd805e76862..c852fd1dd284 100644 > --- a/drivers/pinctrl/samsung/Kconfig > +++ b/drivers/pinctrl/samsung/Kconfig > @@ -4,13 +4,13 @@ > # > config PINCTRL_SAMSUNG > bool > - depends on OF_GPIO > + select GPIOLIB > + select OF_GPIO > select PINMUX > select PINCONF OF_GPIO is an automatic symbol that is always enabled when both GPIOLIB and OF are enabled. Selecting it from somewhere else cannot really work at all. I see we have a few other instances and should probably fix those as well. > config PINCTRL_EXYNOS > bool "Pinctrl common driver part for Samsung Exynos SoCs" > - depends on OF_GPIO > depends on ARCH_EXYNOS || ARCH_S5PV210 || COMPILE_TEST > select PINCTRL_SAMSUNG > select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) The problem here is that PINCTRL_EXYNOS and the others can be built for compile-testing without CONFIG_OF on non-arm machines. I think the correct dependency line would be depends on ARCH_EXYNOS || ARCH_S5PV210 || (COMPILE_TEST && OF) which guarantees that OF_GPIO is also enabled. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel