From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751665AbdFGO3x (ORCPT ); Wed, 7 Jun 2017 10:29:53 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:36599 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbdFGO3v (ORCPT ); Wed, 7 Jun 2017 10:29:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170607125256.GG2345@mai> References: <20170605074846.30925-1-andrew@aj.id.au> <20170607125256.GG2345@mai> From: Arnd Bergmann Date: Wed, 7 Jun 2017 16:29:50 +0200 X-Google-Sender-Auth: 0SMeridTVUij4EcWUin9Wt6KwZI Message-ID: Subject: Re: [PATCH] arm: aspeed: Add clock-names property to timer node To: Daniel Lezcano Cc: Joel Stanley , Andrew Jeffery , Linux ARM , Linux Kernel Mailing List , Linus Walleij Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 7, 2017 at 2:52 PM, Daniel Lezcano wrote: > On Tue, Jun 06, 2017 at 11:41:11AM +0200, Arnd Bergmann wrote: >> On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: >> > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >> >> The merging of a number of clocksource drivers into fttmr010 means we >> >> require clock-names to be specified in the Aspeed timer node, else the >> >> clocksource fails to probe and boot hangs. >> > >> > Arnd, >> > >> > Linus' reworked timer driver will go into 4.13. >> > >> > Can we get this patch merged into 4.12 as a fix so we don't end up >> > with a broken boot at any stage? >> >> Hmm, can't we make the driver backward-compatible and have it fall >> back on the first clock if no clk named "PCLK" is found? Otherwise >> you still have an incompatible change in the DT binding and it will >> break if someone uses an older dtb with a newer kernel. > > I would like to avoid to hack the kernel code for backward DT compatible > things. How about a fixup in the platform code to add the property then? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 7 Jun 2017 16:29:50 +0200 Subject: [PATCH] arm: aspeed: Add clock-names property to timer node In-Reply-To: <20170607125256.GG2345@mai> References: <20170605074846.30925-1-andrew@aj.id.au> <20170607125256.GG2345@mai> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 7, 2017 at 2:52 PM, Daniel Lezcano wrote: > On Tue, Jun 06, 2017 at 11:41:11AM +0200, Arnd Bergmann wrote: >> On Mon, Jun 5, 2017 at 10:59 AM, Joel Stanley wrote: >> > On Mon, Jun 5, 2017 at 5:18 PM, Andrew Jeffery wrote: >> >> The merging of a number of clocksource drivers into fttmr010 means we >> >> require clock-names to be specified in the Aspeed timer node, else the >> >> clocksource fails to probe and boot hangs. >> > >> > Arnd, >> > >> > Linus' reworked timer driver will go into 4.13. >> > >> > Can we get this patch merged into 4.12 as a fix so we don't end up >> > with a broken boot at any stage? >> >> Hmm, can't we make the driver backward-compatible and have it fall >> back on the first clock if no clk named "PCLK" is found? Otherwise >> you still have an incompatible change in the DT binding and it will >> break if someone uses an older dtb with a newer kernel. > > I would like to avoid to hack the kernel code for backward DT compatible > things. How about a fixup in the platform code to add the property then? Arnd