From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D7DAC43334 for ; Tue, 19 Jul 2022 13:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VXhwHxHawH0URAnNqtEo5MNLOHUTbKopZHU8TlOZel0=; b=b/xlzsYGlX9est K/K1Ky92rOiuIt2Xl+w2lGcykUi8vn9d9LND0z25WIl+62qe+fdZAt5BRVW/wtoKUmmqJqRor9uR4 ulCZfG8Bw9h9PWor3bZSDJCceIZybgKu0AcErgwbsNY+epay3yj4q1fLvgNVs6COFFV8m9ayifsEn 2Y5P3BVzYZ5w4SsX0nLZn6POfFYjDsvqoRm0pAVbhEW5RgVeYhgE8raAvkrcd3p1ijPTYY+DUEDN6 Ee64wj9jGAPRwwWfZXP3nT4qMdX0lB0iaMnNqC68tY9yl7mC5lOTPDebAZHjj0EH8gj373uDjyHP+ r90qujqwKZZrYtf+LDqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDn7c-0095ve-5J; Tue, 19 Jul 2022 13:18:44 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDn7Y-0095sW-Ul; Tue, 19 Jul 2022 13:18:42 +0000 Received: from mail-yb1-f171.google.com ([209.85.219.171]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MgNxZ-1nasni2QU3-00hthB; Tue, 19 Jul 2022 15:18:37 +0200 Received: by mail-yb1-f171.google.com with SMTP id e69so26402925ybh.2; Tue, 19 Jul 2022 06:18:34 -0700 (PDT) X-Gm-Message-State: AJIora8JgwERiUj68G8NwUaaj6aSCitiqDgexZmJ9YIO3DvIbNeppJOq NING8yvRXEC1FVE3PJPricKZbZooJhtgAuzOYog= X-Google-Smtp-Source: AGRyM1sj2ZRWajYGSg8uf4g3MyEJ6xSd//jFiMZ2PQtMebEv5Hsb8H9cSwLXrU5Amq5R5Ua/8gA/pnz1fLkON0xIlXo= X-Received: by 2002:a25:6706:0:b0:670:8d4d:7832 with SMTP id b6-20020a256706000000b006708d4d7832mr812105ybc.106.1658236713658; Tue, 19 Jul 2022 06:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 15:18:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch X-Provags-ID: V03:K1:QnEsLhHFuN/k5dGjibT5aKorkPyAB/9tKLaXdBTY4hNo81MEs7k AiK8QAVse+8d6ltyP6RCnTHKpnAvNiR98a7pbW1ZsCBwhuv0u2aKiuWGKn+zKsbBu5NpIrb TVsWtuWNUAcudJuyuzNQ6G12F905jjD2YtXM6LT/4t0nZwsRNkm/WxGuV5NQD75jkmN1HHV MNq5BFrPq+ohuzn+Usw/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:iEhXTT7Cu6Q=:QVOBih1HqzdgLQv3B07d/g 2qv6H8wbOu9q/XvbhbxrAxdiGmS+tITNt8SsrMb1vmZXRTqlHJl9Nn55nO3PIJYCXTuPTDZPs ETQm8roqz4IBeMnaiGM3NkCEcy7Vwnnn5EjsXSKIDSSYHsR1MnLu9Ev5/EViO27glHeVfk607 lrfj8MiaX0g/fEGVyjBXlLL2Rgb421d+19eWK6fTipSutj52cczViKjoHLR1g44S0ZSrVVak/ WPZIh1wwg/0qWgWxtKvtcKDlm8ww4E/8cIkcnwfQ0dturpAZSOpwaRAVqQKY0+li2DOlh2XFi spg9AYhijD+8x8oaJ4yiEwExBV4V8h3+2oXjNrnuEjY0OvCOkGTjIB1oM6VaSYY0zVNu1SXQ8 1XmTrK6zLC5i1tu0oCfEJQ6cC9czOjgnuRnbpst1zM8s4Syl3v6vwM8Wde0n+RCfovt6sy8sx DYbjcz4Don+iUPtQY9Vw4mvbIkXvRUsZc1p5CakC/VK3RbeqcyPR/7NrwFSwJdYqXNg1EkxcY h9wn6j2Vu1/hNN/7F+vR/4lK9sCp4zF0xCKg9g1lSoAZqTnXZ70QAvazq3p32WLT0ef21Bqnb CS9aCkjGXWdu5YS0kfgguamfIhtBhvnQjtydZ2hpKyGrW3yx8km0sAf1SCwBQW6vll+AVnT27 wj6CXTN8Zz6Oo+NturRxZwtgL7N8TDLxLBQom8Z+Xpp2YYMIR0zKdlxoLghjpC3StPkRs0S3I pofMxVvi8TDK8N9GslmE/3797k1FCtlvOImRmg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_061841_305457_973CFB1A X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > And this is the result, I will get this into the series and create a v4 tomorrow > if no issues. Looks good to me, just one detail: > diff --git a/include/linux/isa-dma.h b/include/linux/isa-dma.h > new file mode 100644 > index 000000000000..9514f0949fa1 > --- /dev/null > +++ b/include/linux/isa-dma.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __LINUX_ISA_DMA_H > +#define __LINUX_ISA_DMA_H > + > +#if defined(CONFIG_PCI) && defined(CONFIG_X86_32) > +extern int isa_dma_bridge_buggy; > +#else > +#define isa_dma_bridge_buggy (0) > +#endif > + > +#endif /* __LINUX_ISA_DMA_H */ I would make this file #include as a step towards making linux/isa-dma.h the official replacement for it in the driver api. Including asm/dma.h from a driver is already a bit awkward, since we are generally moving towards including only linux/*.h type headers, and the dma.h name is too generic for something that is completely obsolete. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD8A0C43334 for ; Tue, 19 Jul 2022 13:19:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LNhlIR482OCY+RaP5PzdLRuhJzOZkgaSZx4IsjjnRso=; b=vrDGOCXNIkCikT Si6ydEIz0noMrEU93LmsTuMTJ88jwrHnyjhwkM5M+BGepL8VzDdWbmCD47f2k4laOxtWWT+TmPpaa gF0J8x9wTq23MPNOskusn0xYBoJBJ/YBGeBhLl9/7c9QU8yKHgmsTPJfuoWTcL9HaRz0H/YVvEai1 ughjIyBEwfCNqrhbFJ/z7WRjJ9zCpkJPgP3dCZMPlxzRSJs/ojDwY1I8E9vlZu7E2IN8IfxdC6NG9 0nvF76kQv9I5HHF+FwDSaWjF/h91aeqFWZFpOTJHB83AptyzGmWnu2uOQmCPA+UWP4EVrXQTw3uom 3n5mlsqTl4Zr6ZywwxCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDn7g-0095y1-QO; Tue, 19 Jul 2022 13:18:49 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDn7Y-0095sW-Ul; Tue, 19 Jul 2022 13:18:42 +0000 Received: from mail-yb1-f171.google.com ([209.85.219.171]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MgNxZ-1nasni2QU3-00hthB; Tue, 19 Jul 2022 15:18:37 +0200 Received: by mail-yb1-f171.google.com with SMTP id e69so26402925ybh.2; Tue, 19 Jul 2022 06:18:34 -0700 (PDT) X-Gm-Message-State: AJIora8JgwERiUj68G8NwUaaj6aSCitiqDgexZmJ9YIO3DvIbNeppJOq NING8yvRXEC1FVE3PJPricKZbZooJhtgAuzOYog= X-Google-Smtp-Source: AGRyM1sj2ZRWajYGSg8uf4g3MyEJ6xSd//jFiMZ2PQtMebEv5Hsb8H9cSwLXrU5Amq5R5Ua/8gA/pnz1fLkON0xIlXo= X-Received: by 2002:a25:6706:0:b0:670:8d4d:7832 with SMTP id b6-20020a256706000000b006708d4d7832mr812105ybc.106.1658236713658; Tue, 19 Jul 2022 06:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 15:18:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch X-Provags-ID: V03:K1:QnEsLhHFuN/k5dGjibT5aKorkPyAB/9tKLaXdBTY4hNo81MEs7k AiK8QAVse+8d6ltyP6RCnTHKpnAvNiR98a7pbW1ZsCBwhuv0u2aKiuWGKn+zKsbBu5NpIrb TVsWtuWNUAcudJuyuzNQ6G12F905jjD2YtXM6LT/4t0nZwsRNkm/WxGuV5NQD75jkmN1HHV MNq5BFrPq+ohuzn+Usw/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:iEhXTT7Cu6Q=:QVOBih1HqzdgLQv3B07d/g 2qv6H8wbOu9q/XvbhbxrAxdiGmS+tITNt8SsrMb1vmZXRTqlHJl9Nn55nO3PIJYCXTuPTDZPs ETQm8roqz4IBeMnaiGM3NkCEcy7Vwnnn5EjsXSKIDSSYHsR1MnLu9Ev5/EViO27glHeVfk607 lrfj8MiaX0g/fEGVyjBXlLL2Rgb421d+19eWK6fTipSutj52cczViKjoHLR1g44S0ZSrVVak/ WPZIh1wwg/0qWgWxtKvtcKDlm8ww4E/8cIkcnwfQ0dturpAZSOpwaRAVqQKY0+li2DOlh2XFi spg9AYhijD+8x8oaJ4yiEwExBV4V8h3+2oXjNrnuEjY0OvCOkGTjIB1oM6VaSYY0zVNu1SXQ8 1XmTrK6zLC5i1tu0oCfEJQ6cC9czOjgnuRnbpst1zM8s4Syl3v6vwM8Wde0n+RCfovt6sy8sx DYbjcz4Don+iUPtQY9Vw4mvbIkXvRUsZc1p5CakC/VK3RbeqcyPR/7NrwFSwJdYqXNg1EkxcY h9wn6j2Vu1/hNN/7F+vR/4lK9sCp4zF0xCKg9g1lSoAZqTnXZ70QAvazq3p32WLT0ef21Bqnb CS9aCkjGXWdu5YS0kfgguamfIhtBhvnQjtydZ2hpKyGrW3yx8km0sAf1SCwBQW6vll+AVnT27 wj6CXTN8Zz6Oo+NturRxZwtgL7N8TDLxLBQom8Z+Xpp2YYMIR0zKdlxoLghjpC3StPkRs0S3I pofMxVvi8TDK8N9GslmE/3797k1FCtlvOImRmg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_061841_305457_973CFB1A X-CRM114-Status: GOOD ( 16.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > And this is the result, I will get this into the series and create a v4 tomorrow > if no issues. Looks good to me, just one detail: > diff --git a/include/linux/isa-dma.h b/include/linux/isa-dma.h > new file mode 100644 > index 000000000000..9514f0949fa1 > --- /dev/null > +++ b/include/linux/isa-dma.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __LINUX_ISA_DMA_H > +#define __LINUX_ISA_DMA_H > + > +#if defined(CONFIG_PCI) && defined(CONFIG_X86_32) > +extern int isa_dma_bridge_buggy; > +#else > +#define isa_dma_bridge_buggy (0) > +#endif > + > +#endif /* __LINUX_ISA_DMA_H */ I would make this file #include as a step towards making linux/isa-dma.h the official replacement for it in the driver api. Including asm/dma.h from a driver is already a bit awkward, since we are generally moving towards including only linux/*.h type headers, and the dma.h name is too generic for something that is completely obsolete. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0C5C433EF for ; Tue, 19 Jul 2022 14:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238145AbiGSOFc (ORCPT ); Tue, 19 Jul 2022 10:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235397AbiGSOE4 (ORCPT ); Tue, 19 Jul 2022 10:04:56 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65150643F; Tue, 19 Jul 2022 06:18:36 -0700 (PDT) Received: from mail-yb1-f170.google.com ([209.85.219.170]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M4KFF-1oE46M0Qq1-000ODC; Tue, 19 Jul 2022 15:18:35 +0200 Received: by mail-yb1-f170.google.com with SMTP id j67so3792601ybb.3; Tue, 19 Jul 2022 06:18:34 -0700 (PDT) X-Gm-Message-State: AJIora+Ln0DM5rLJQh6Z2mZo2QKV84RRscnpXoCcMKargdVnDqJVW0cE o3tLkld5Udhdw57vb0/Sg0Hw9rJAeGrCeTlcrhw= X-Google-Smtp-Source: AGRyM1sj2ZRWajYGSg8uf4g3MyEJ6xSd//jFiMZ2PQtMebEv5Hsb8H9cSwLXrU5Amq5R5Ua/8gA/pnz1fLkON0xIlXo= X-Received: by 2002:a25:6706:0:b0:670:8d4d:7832 with SMTP id b6-20020a256706000000b006708d4d7832mr812105ybc.106.1658236713658; Tue, 19 Jul 2022 06:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 15:18:17 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:JReNJ9TYqYW1jG6zuflAcJYsrp8I3rPMcDbRtNPOKoS2FAa86k6 OxpXUiNMAdh4Ky+6PWw9PG8aDaUih9cykdTd5priqmosuvWf7BDjjsz8kU3OwqD3OOdXiYj LoSu7WWtVpiGM0bo6/n1WJ4jbcurAyqvrjiI7gQOpain4yPLtL+6Vw8DxpqOJBjIsfQuBum tYSTxLQODl4yLkXRKUq0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:z6KeR9UUFvA=:t+hxNbe8GOzxAp5FaaiHSz 2P0eAqogTjA364gKUdh58byK4qEVqtCsINoYeHcwDWyo/Z8R+vDlllPZ7dtsNzUe5ULDS6sIR byNXURRPPmw4aH8dDneeyh109l8Z/FgQyqcYwqmnqCil/p0NT/wSnoMceblb22JXBn8y34sxC TiBf2ZH5aZbUBwFvWKGm+aZA5X6/2Q20psvNbFXTtEjMrCgxnlNkUJ71Ohvv+EVLC0SrKNAlv Gj0HKR3RLZou7xTBbMJlzCG12yQdQAnUhiGTmntN9UdlsiT5ExjI9tv8PsYpC7ARJB89lWb9w 6O1TGAfzFh8mjeg/4ykqTD3Lh/yyX9ggoaLyu4Y6+K2AWRQhDtXmZeMRde68EARxa/wBBa/bp G75reux/Gd69IjIVq0tm1F36LyvJHF+YCmHW1FdXUCG8JWFJSU/6Wm81Y7qHPu6qiWl2O9tlj a9djNZ1Uv9ajTfWr9Mr8JX9hUOsZ/k30PnBIrCvjPLUH3Q6yDA21osLjWRTljAvfdLRHfuTEO 6ilkNOkSR4Rk4/QgUIAheoQVOHpAprRZY8QHYLoz5nZXb9H3JiLmQDOxE09Kyg3azykNMIZvL Sf2gRdEeOefvfn9xLoeg28grFYBxv9IwtL/z7eeNMUG+foc/eRiOqTUYaG+7Skswh3X6izmQX RSxvYa1FDpZtLDUhrQuLpdBZygsyfIYXJ5PwK015FvobQ99UGof0FTM+DCrE0IGpYQmaNB7Sq vODWY9ScGTPNvfHbkaGLDaYzOCSNZoUt3kJ19g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > And this is the result, I will get this into the series and create a v4 tomorrow > if no issues. Looks good to me, just one detail: > diff --git a/include/linux/isa-dma.h b/include/linux/isa-dma.h > new file mode 100644 > index 000000000000..9514f0949fa1 > --- /dev/null > +++ b/include/linux/isa-dma.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __LINUX_ISA_DMA_H > +#define __LINUX_ISA_DMA_H > + > +#if defined(CONFIG_PCI) && defined(CONFIG_X86_32) > +extern int isa_dma_bridge_buggy; > +#else > +#define isa_dma_bridge_buggy (0) > +#endif > + > +#endif /* __LINUX_ISA_DMA_H */ I would make this file #include as a step towards making linux/isa-dma.h the official replacement for it in the driver api. Including asm/dma.h from a driver is already a bit awkward, since we are generally moving towards including only linux/*.h type headers, and the dma.h name is too generic for something that is completely obsolete. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 15:18:17 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch On Tue, Jul 19, 2022 at 3:05 PM Stafford Horne wrote: > On Tue, Jul 19, 2022 at 09:23:36PM +0900, Stafford Horne wrote: > > On Tue, Jul 19, 2022 at 01:55:03PM +0200, Arnd Bergmann wrote: > > And this is the result, I will get this into the series and create a v4 tomorrow > if no issues. Looks good to me, just one detail: > diff --git a/include/linux/isa-dma.h b/include/linux/isa-dma.h > new file mode 100644 > index 000000000000..9514f0949fa1 > --- /dev/null > +++ b/include/linux/isa-dma.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef __LINUX_ISA_DMA_H > +#define __LINUX_ISA_DMA_H > + > +#if defined(CONFIG_PCI) && defined(CONFIG_X86_32) > +extern int isa_dma_bridge_buggy; > +#else > +#define isa_dma_bridge_buggy (0) > +#endif > + > +#endif /* __LINUX_ISA_DMA_H */ I would make this file #include as a step towards making linux/isa-dma.h the official replacement for it in the driver api. Including asm/dma.h from a driver is already a bit awkward, since we are generally moving towards including only linux/*.h type headers, and the dma.h name is too generic for something that is completely obsolete. Arnd _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um