From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A3F7C2D0E4 for ; Tue, 24 Nov 2020 11:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C493206F7 for ; Tue, 24 Nov 2020 11:49:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nQfU56RO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733049AbgKXLtl (ORCPT ); Tue, 24 Nov 2020 06:49:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:43126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728491AbgKXLtk (ORCPT ); Tue, 24 Nov 2020 06:49:40 -0500 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E18CD20857 for ; Tue, 24 Nov 2020 11:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606218580; bh=PUBX3pg96iPTmC+3ajxfCSWd3GB4JF9umJhidh4JYJQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nQfU56ROXDVHIurupdILBePZen1/uVeHEm/0DLxWG2v7+s7F+4eTCATK2V5DhvJZc HJNPaOBdZj33efQR7+itzU9K7JxjCZ5MBID2FP6iUJE53q4DuT56zOZrlgXruQOtb/ ISxeAF36yLCE3PrqLuWeZftLHrHsK4WwkZL5vcgU= Received: by mail-ot1-f53.google.com with SMTP id n11so19046294ota.2 for ; Tue, 24 Nov 2020 03:49:39 -0800 (PST) X-Gm-Message-State: AOAM5337o1wVkOp2RWvVuWtz64RY/1ZtcDj41/1/BtE7nmw1woFN2Qfh 5ezsn3hGSE4syXRge//7XrfxK+Nv1G9RdFc1Ms8= X-Google-Smtp-Source: ABdhPJy9c3s/Jeb9nfLEN+BPcVb1IbuR24GoD2eAR6YCiec9vq6xxo/J70frTg0AHuEAYwvM+JTd6bTj8JpwCLoCBXM= X-Received: by 2002:a05:6830:22d2:: with SMTP id q18mr2674436otc.305.1606218579150; Tue, 24 Nov 2020 03:49:39 -0800 (PST) MIME-Version: 1.0 References: <20201124103242.2971199-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20201124103242.2971199-1-u.kleine-koenig@pengutronix.de> From: Arnd Bergmann Date: Tue, 24 Nov 2020 12:49:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] amba: reorder functions To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Russell King , Greg Kroah-Hartman , Arnd Bergmann , Linus Walleij , Ulf Hansson , Rob Herring , Sascha Hauer , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 11:32 AM Uwe Kleine-K=C3=B6nig wrote: > > Put helpers (here: amba_get_enable_pclk and amba_put_disable_pclk) at > the top of the file and then define callbacks directly before the > structs they are used in; in the same order. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Looks good, I checked the whole series and this seems like a useful cleanup. All four patches: Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7876DC2D0E4 for ; Tue, 24 Nov 2020 11:50:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA8CE2076B for ; Tue, 24 Nov 2020 11:50:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T8TWgkFD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nQfU56RO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA8CE2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TyR6PKpdM2op79sRsb3oFE37OOMpNszWL32Bb4eVz0I=; b=T8TWgkFDpMEDWVPRZb/200s4Z foKOumoixdrRuyg1/Nohag7idG2Ez7j+ZuNNiHvu908zsWCHEz74mj8p2x0vDQk/OWxcyL6I8HlSZ LYlYqrR4gtuiwO4XI2rVL2fIfaHMt7bOvQjclhzvgvZJ6OVFp1CluhDBq/AewrXc2i2qZPvGd/6zW mKzU3vUahKND0iSqT96U99Dw0833pywRWTIb7khQG7Xg9tlRzcPDie9AnX1LYxFWBCgHpXJwM1ikn O2NcdROp/I+/XtdI2CYnWCD622lodhIREjGr1GA93sBsYuIv+5c5z76zWCELgV3eDwnnO6AeGbmGw 0QQR5FU3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khWpM-00053p-8m; Tue, 24 Nov 2020 11:49:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khWpI-000539-TV for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 11:49:41 +0000 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF9F12076B for ; Tue, 24 Nov 2020 11:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606218580; bh=PUBX3pg96iPTmC+3ajxfCSWd3GB4JF9umJhidh4JYJQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=nQfU56ROXDVHIurupdILBePZen1/uVeHEm/0DLxWG2v7+s7F+4eTCATK2V5DhvJZc HJNPaOBdZj33efQR7+itzU9K7JxjCZ5MBID2FP6iUJE53q4DuT56zOZrlgXruQOtb/ ISxeAF36yLCE3PrqLuWeZftLHrHsK4WwkZL5vcgU= Received: by mail-ot1-f50.google.com with SMTP id 11so6509846oty.9 for ; Tue, 24 Nov 2020 03:49:39 -0800 (PST) X-Gm-Message-State: AOAM530WCHXlTjlElY4PhA216eI/40fIQrcUjmuDAmgfQW36ofW/JFh4 nUCgaybcSE9uiZmJt6IGK86Gw9iGHoTWXhF52dk= X-Google-Smtp-Source: ABdhPJy9c3s/Jeb9nfLEN+BPcVb1IbuR24GoD2eAR6YCiec9vq6xxo/J70frTg0AHuEAYwvM+JTd6bTj8JpwCLoCBXM= X-Received: by 2002:a05:6830:22d2:: with SMTP id q18mr2674436otc.305.1606218579150; Tue, 24 Nov 2020 03:49:39 -0800 (PST) MIME-Version: 1.0 References: <20201124103242.2971199-1-u.kleine-koenig@pengutronix.de> In-Reply-To: <20201124103242.2971199-1-u.kleine-koenig@pengutronix.de> From: Arnd Bergmann Date: Tue, 24 Nov 2020 12:49:23 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/4] amba: reorder functions To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_064941_034618_1A476F7B X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Ulf Hansson , Arnd Bergmann , Greg Kroah-Hartman , Linus Walleij , Russell King , "linux-kernel@vger.kernel.org" , Sascha Hauer , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMjQsIDIwMjAgYXQgMTE6MzIgQU0gVXdlIEtsZWluZS1Lw7ZuaWcKPHUua2xl aW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4gd3JvdGU6Cj4KPiBQdXQgaGVscGVycyAoaGVyZTog YW1iYV9nZXRfZW5hYmxlX3BjbGsgYW5kIGFtYmFfcHV0X2Rpc2FibGVfcGNsaykgYXQKPiB0aGUg dG9wIG9mIHRoZSBmaWxlIGFuZCB0aGVuIGRlZmluZSBjYWxsYmFja3MgZGlyZWN0bHkgYmVmb3Jl IHRoZQo+IHN0cnVjdHMgdGhleSBhcmUgdXNlZCBpbjsgaW4gdGhlIHNhbWUgb3JkZXIuCj4KPiBT aWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJv bml4LmRlPgoKTG9va3MgZ29vZCwgSSBjaGVja2VkIHRoZSB3aG9sZSBzZXJpZXMgYW5kIHRoaXMg c2VlbXMgbGlrZSBhIHVzZWZ1bApjbGVhbnVwLiBBbGwgZm91ciBwYXRjaGVzOgoKUmV2aWV3ZWQt Ynk6IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdAps aW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==