From: Arnd Bergmann <arnd@arndb.de>
To: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-mmc@vger.kernel.org,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH/RFC 0/5] mmc: renesas-sdhi: refactor DMA support
Date: Tue, 2 May 2017 14:03:06 +0200 [thread overview]
Message-ID: <CAK8P3a10fwLwA=DzMoCbxoCewA8YqcJSzW8Avqt-vX+kSx0apA@mail.gmail.com> (raw)
In-Reply-To: <1493723743-22821-1-git-send-email-horms+renesas@verge.net.au>
On Tue, May 2, 2017 at 1:15 PM, Simon Horman <horms+renesas@verge.net.au> wrote:
> Hi Wolfram, Hi Arnd, Hi all,
>
> the intention of this patch-set is to refactor the DMA support in
> the Renesas SDHI driver in order to make it easier to add support
> for using the SDHI hardware with different DMA implementations.
>
> This is based on earlier work, posted as "[PATCH/RFC v3 0/6] mmc:
> renesas_sdhi: add R-Car Gen-3 DMA support". It attempts to implement
> the reworking of the driver proposed by Arnd[1] in his review of that
> patch-set.
>
> [1] http://www.spinics.net/lists/linux-mmc/msg38004.html
>
> Unlike that patch-set this patch-set does not add support for
> R-Car Gen-3 DMA. Rather it focuses on refactoring the code.
Looks fine overall. Remind me why we are not using the dma-engine
framework though. IIRC this is because at least one of the possible
DMA implementations is tightly integrated with the TMIO register
set and not easily split out into another driver, right?
Arnd
next prev parent reply other threads:[~2017-05-02 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 11:15 [PATCH/RFC 0/5] mmc: renesas-sdhi: refactor DMA support Simon Horman
2017-05-02 11:15 ` [PATCH/RFC 1/5] mmc: renesas-sdhi, tmio: make dma more modular Simon Horman
2017-05-02 12:01 ` Arnd Bergmann
2017-05-02 12:57 ` Simon Horman
2017-05-02 13:03 ` Simon Horman
2017-05-02 11:15 ` [PATCH/RFC 2/5] mmc: tmio: rename tmio_mmc_{pio => core}.c Simon Horman
2017-05-02 13:11 ` Wolfram Sang
2017-05-09 13:14 ` Simon Horman
2017-05-02 11:15 ` [PATCH/RFC 3/5] mmc: renesas-sdhi: rename tmio_mmc_dma.c => renesas_sdhi_sys_dmac.c Simon Horman
2017-05-02 11:15 ` [PATCH/RFC 4/5] mmc: renesas-sdhi: rename sh_mobile_sdhi.c => renesas_sdhi_core.c Simon Horman
2017-05-02 11:15 ` [PATCH 5/5] mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file Simon Horman
2017-05-02 12:03 ` Arnd Bergmann [this message]
2017-05-09 9:28 ` [PATCH/RFC 0/5] mmc: renesas-sdhi: refactor DMA support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a10fwLwA=DzMoCbxoCewA8YqcJSzW8Avqt-vX+kSx0apA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.