From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4A2C18E5A for ; Wed, 11 Mar 2020 14:31:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72A9D204EC for ; Wed, 11 Mar 2020 14:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729875AbgCKObn (ORCPT ); Wed, 11 Mar 2020 10:31:43 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:43183 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729719AbgCKObn (ORCPT ); Wed, 11 Mar 2020 10:31:43 -0400 Received: from mail-qv1-f51.google.com ([209.85.219.51]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MXpM2-1iop5V2Doy-00Y7pz; Wed, 11 Mar 2020 15:31:41 +0100 Received: by mail-qv1-f51.google.com with SMTP id l17so951015qvu.4; Wed, 11 Mar 2020 07:31:41 -0700 (PDT) X-Gm-Message-State: ANhLgQ0nb0jq9k7IMpYf08xQ+SH5299hnUKxYLLXj3/69SriKK/tNsXC Fcm+OJWKHCA8ppinDQXhE7YRn4sCsk7Cu+nO93M= X-Google-Smtp-Source: ADFU+vs7vsHRRk5DF+sIH0AM5qI2NZuKa/my/Rqt4Fil9rQRSzu8NXrbadx7Co2qeP3BJvqRxzROzp3/R4yRw9+b1xg= X-Received: by 2002:ad4:52eb:: with SMTP id p11mr2880124qvu.211.1583937100255; Wed, 11 Mar 2020 07:31:40 -0700 (PDT) MIME-Version: 1.0 References: <20200311112120.30890-1-zhang.lyra@gmail.com> In-Reply-To: <20200311112120.30890-1-zhang.lyra@gmail.com> From: Arnd Bergmann Date: Wed, 11 Mar 2020 15:31:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH] arm64: dts: specify console via command line To: Chunyan Zhang List-Id: Cc: SoC Team , Rob Herring , Mark Rutland , DTML , "linux-kernel@vger.kernel.org" , Linux ARM , Orson Zhai , Baolin Wang , Chunyan Zhang Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:CLt4UGhYEFuPuQIoW/xfHJnWHUF1vh0zPPhR4y6r6NbTUEGmV5V QLW9hYN9gDzNQV/Wu/cJtDhyP2/ljICttwKTgusnrim6lFYY9rvJfrIai8uevx8B/bSs/bt eOxvC03C25dU8QvO2zeix7G602ro0VZkwwx3Ps6Oczh9hUZyagJIUWPfwwnn7tJJCvL6aXD 78H8pb9nRwls4SGXSRvdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:+t3kxDfZUqE=:PY7qPIJNe78YFLzEC/WUWm SqI6fl1r3EydEtOj4vQNOcDBzFrkUeJ1rNzS2iILUFo8ngrQyQ1Lxchglbh5IK0VGodjJxvms 5dAyeO/NktaE29+8RLONAyeJEoKzVbegL78sIeEjMPYeK3DFhboSaZWxQCx+V5uHHQ0oQUXTk pDWdbYdg8qalRE5d42VG3u04ZGPO4vUp49Mi+tqyKdbdziI9gis+GZrCqNIKxBPHnOcXzj3Lg Bl8K2bGCwUEUR1VqGVC1HoL3PbZbZpgp51jTHfRNo2RugvXmZjWrGtgX3QIF5/IWuMp67mnPF CKni6tFCkpsaE42L2DQi1llQKu/pvK0TUh7VEy+YgLYwljpwYEOE58IoZ2nDBPFeCTJFRNsg/ wSWuNCNyXJD7LIDbtXmeqznxj+eDHpnHI6woVCvDBFb2tzK92qiOBFZOaL800C8aIa2DiI0up dm+VcMvYS2fwDfbfwh96MC9DzT22IGFZByET9a0H32seTB5MBjVSl/NnDxBXlfPn4PINTqaVV /ZFsJCprS2n9AUbkkMi75avJXDWUF2nLa30oE7GQSYlU2YG3qjMw7XAuNy1W07L0j2HmqJLj/ MvLFJPfPhWUXwW1ysP/Jwz626XppZwVekyIFK8xY/5MJGCQHiDwsmBkh3pawqh7ObhO/e0aDQ xKUrQZT9IhQ6ZWTegn/E01wqoME/vKo40gfO0ck2A2twSjl/Ima68NQ1otbhLxfGwwh1jW+vT WNbwXMO0uEpYxjNXHtW9C69b2J0VuEPs0Y8EoZOCmRXPGJ7wisnYVr6v/xAyieSOIxG5hEHXD UtrSmnYnhAceAhwZNqUTzcobE2OSf9FbeHcf8BV2E/DBucW9Qo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 12:21 PM Chunyan Zhang wrote: > > diff --git a/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts b/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > index 2047f7a74265..510f65f4d8b8 100644 > --- a/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > +++ b/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > @@ -28,7 +28,7 @@ > > chosen { > stdout-path = "serial1:115200n8"; > - bootargs = "earlycon"; > + bootargs = "earlycon console=ttyS1"; > }; > }; Hi Chunyan, I would expect that you need to either specify the stdout-path, or the console= kernel parameter, but not both. If earlycon was used, shouldn't the driver know which port is the console? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3B5C10F27 for ; Wed, 11 Mar 2020 14:47:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBCF3206B1 for ; Wed, 11 Mar 2020 14:47:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hnHA1myF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBCF3206B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LdtsBGDoJdn6dj4paPAgFfs/SztVBCmMx/IqdwPhDUs=; b=hnHA1myFUr2/M0 ohIw8AjMnuDA0cAxOeYuQ75KxkvWk3FyqUA3qms7Cv5RTTgRMsDAIYXnPAAgCSRJtk+DTTjy5Enk1 rSOUaPFZxOrN4TVzqK/e6/U8oXSxc1x9oEIEJmgqEhHIliKyT8ioEEExzMf2I6ZsKrUKOf7e6QUcD 6M4SQ9yF+k+c1dGXEaUyFwkgP9ZkWr0gMWgWpEAC7echVPk6bn/CV5sDLmGq8cA8af5Iy/MzHiYJm MpGu5dUomz0jxi4CqdkcQLyt+NfIyEFZnDblR+bZJY6FLMNxLrXov5Q2pgt+EvPFNC8bmxg4vKpLs iCxyevU+abeHspt/BFvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2Oj-0007ec-BM; Wed, 11 Mar 2020 14:31:49 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jC2Og-0007dx-6S for linux-arm-kernel@lists.infradead.org; Wed, 11 Mar 2020 14:31:47 +0000 Received: from mail-qv1-f53.google.com ([209.85.219.53]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MLAZe-1iuux51ppa-00IFVr for ; Wed, 11 Mar 2020 15:31:41 +0100 Received: by mail-qv1-f53.google.com with SMTP id du17so936633qvb.12 for ; Wed, 11 Mar 2020 07:31:41 -0700 (PDT) X-Gm-Message-State: ANhLgQ35gttT1LzfkYGJXHF9gLdbDUHIU1ccmvZCWlh78jbTEfl1TtWw YIzgkWWwMNnIdk+wZlVdUB8WkRv17Wyc45+MHxw= X-Google-Smtp-Source: ADFU+vs7vsHRRk5DF+sIH0AM5qI2NZuKa/my/Rqt4Fil9rQRSzu8NXrbadx7Co2qeP3BJvqRxzROzp3/R4yRw9+b1xg= X-Received: by 2002:ad4:52eb:: with SMTP id p11mr2880124qvu.211.1583937100255; Wed, 11 Mar 2020 07:31:40 -0700 (PDT) MIME-Version: 1.0 References: <20200311112120.30890-1-zhang.lyra@gmail.com> In-Reply-To: <20200311112120.30890-1-zhang.lyra@gmail.com> From: Arnd Bergmann Date: Wed, 11 Mar 2020 15:31:24 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH] arm64: dts: specify console via command line To: Chunyan Zhang X-Provags-ID: V03:K1:+Dz7NY5sydY2G/O3gzVwVoD8OQkGdfjysTz0b88lu/hjla3SGpq i0gzqmjuuVNDbQR2y/zQkbiWoAgvxmZRwnPcNN0tdyNCIQz6Ione352tzHeAF8wHLfc1EJK FzIhdl5HMTVRZPnJRR50UWa57H/M9TQRsqgggFqMhAfKBUnfyvVACac5FIY/UtGF91ZZVb3 LAbXSZPNtj0BVTswlbDIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:vdu8ITmBXiw=:duJM/fT8KYoQahXy7kz6+W NgsiuDjBHEBYXuVM8Y7/R8ACJn0eEBdFNbcYBus+GA75UOoIEwSFAD5f5qSrANmX8RxrtCYp5 mR/0ePYiye4ZT3OdBlzMQzi05KWa+AiwH0x66n7VUrJY4+w1JpnqNWG/hj/gSSkVwy5k76TqO VqQvZ/RemGCmsAcFyIIeYhcOIcyZ8PXCRXWevhXYF91wcGblY9sZBaNJfyVSzOdXqN+ocV4Vb QlF833lWC/PUxZprimwy7y4lYUWk77POVdNZorNqp7mQYE86wmBmExMtylr25ggprteguHocP lvUilFm1cPeQyWQHErqAp2NBnZAnaLdv7aJpj4v9PTJSBpdwns59W0lnl4bcNqUrWmUKSl800 kQ17vqSvZbxiQ7AkYQesQF59+uPw+O1ziPG12BsPsbbgPtyu8/kbvwNMxjW2o3hpL+ruN2Yhq fjxx4vbBQ7ilCEvLK8O2+Aedd5gEbfxRaT/gyLA1bOIJ1yNhqMxxxqZx/G5uOlq8sfvtZYMl4 rZnKrV/LA+sHf8XSS0S75GQu6+OPcBMti49fIMCO1KgjVYf0gGtfJG/ix3qEiLfoVZv7775WI nqsc7QWHDROFEy1n82ceVonpUYWnutwDzmYh9VrQ79WUxxdBLrmM+Z7XceHW+yA9rnmqnhk0d uzwBnzjk3UOLNROpVdSGJmAdloHbmdifRPC380LKOgw+eOqzSoI1NFXXVak1pd5kQFoPHB2R4 aTTPODwyMfSFolanau9jXv1bHF3XJBcWhePzqRdGHLFILMtqG25xE5ezy5u+zYROIlu6UPerj yswBEE+nLFiOaVhQZLCbUK4yVy1hk8BoEjAH19cTLjPCRrGUAE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200311_073146_523149_793795BE X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Mark Rutland , DTML , "linux-kernel@vger.kernel.org" , Chunyan Zhang , SoC Team , Rob Herring , Baolin Wang , Orson Zhai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 11, 2020 at 12:21 PM Chunyan Zhang wrote: > > diff --git a/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts b/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > index 2047f7a74265..510f65f4d8b8 100644 > --- a/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > +++ b/arch/arm64/boot/dts/sprd/sp9863a-1h10.dts > @@ -28,7 +28,7 @@ > > chosen { > stdout-path = "serial1:115200n8"; > - bootargs = "earlycon"; > + bootargs = "earlycon console=ttyS1"; > }; > }; Hi Chunyan, I would expect that you need to either specify the stdout-path, or the console= kernel parameter, but not both. If earlycon was used, shouldn't the driver know which port is the console? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel