From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE058C1B0D8 for ; Tue, 8 Dec 2020 13:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1C0223B1F for ; Tue, 8 Dec 2020 13:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729552AbgLHN7o (ORCPT ); Tue, 8 Dec 2020 08:59:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:59146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728546AbgLHN7o (ORCPT ); Tue, 8 Dec 2020 08:59:44 -0500 X-Gm-Message-State: AOAM531/rjdkMLkXtJZqVh5ndqjD594BchOThXkrKcJs18slVv3cmf9L oRx+KUWS7DMO98zLBub/n/4W7TgZpyDBeqTpkpM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607435943; bh=77HVStyyXX1Pgy5zmoyOyQEPooYc3GGLgYGD12JjNMw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=V7qDwVhG3gecJGhol6Ike5wg7CosFyxhl1m1sYpQdPBixF5UVNgETKJaj3Q8j0VqM DnSfS+iAy2AYNiMsrBDyBqDsHUcmQXdhB/88XprAJULuyhu7mSx5/nAUIVkTmU5jZb UoEnwyt0Phn+3MP9pbluTpxm1jjr+RsrBtFNrAGPKP+e18Cg1L8cUHPKydqO+vW7lr sep53IjAfdBKspkmrT8HzTaqvCKYFyPtBp6G5/hYGqA4Y25UHHtR882SSuUOtLyMT7 YnpnnZ+xpkag+KWK2t1w2AQlIavNpBtudPADLTaEOSNZurvhzo6Q/gMnsVCT7d0pZs SgkPQmwVGqlFg== X-Google-Smtp-Source: ABdhPJzbbFo39L5/f8usODzWGuXBtaIc9x6K8uqLzlRNVMHrBQiyt8ZvbtR8IVirlhP18K9q04YQVyIqIjNM4nND/bM= X-Received: by 2002:a5d:4101:: with SMTP id l1mr7874896wrp.196.1607435941883; Tue, 08 Dec 2020 05:59:01 -0800 (PST) MIME-Version: 1.0 References: <20201207084752.1665-1-thunder.leizhen@huawei.com> <20201207084752.1665-2-thunder.leizhen@huawei.com> In-Reply-To: <20201207084752.1665-2-thunder.leizhen@huawei.com> From: Arnd Bergmann Date: Tue, 8 Dec 2020 14:58:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] ARM: dts: mmp2-olpc-xo-1-75: clear the warnings when make dtbs To: Zhen Lei Cc: Lubomir Rintel , Pavel Machek , Arnd Bergmann , Rob Herring , linux-arm-kernel , devicetree , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 7, 2020 at 9:47 AM Zhen Lei wrote: > > The check_spi_bus_bridge() in scripts/dtc/checks.c requires that the node > have "spi-slave" property must with "#address-cells = <0>" and > "#size-cells = <0>". But currently both "#address-cells" and "#size-cells" > properties are deleted, the corresponding default values are 2 and 1. As a > result, the check fails and below warnings is displayed. > > arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ > /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus > also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 > arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ > /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus > also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 > arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): \ > Failed prerequisite 'spi_bus_bridge' > > Because the value of "#size-cells" is already defined as zero in the node > "ssp3: spi@d4037000" in arch/arm/boot/dts/mmp2.dtsi. So we only need to > explicitly add "#address-cells = <0>" and keep "#size-cells" no change. > > Signed-off-by: Zhen Lei Right, I already sent the same patch earlier. Lubomir, can I apply this to the fixes branch? > arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > index adde62d6fce73b9..82da44dacba7172 100644 > --- a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > +++ b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > @@ -224,7 +224,7 @@ > > &ssp3 { > /delete-property/ #address-cells; > - /delete-property/ #size-cells; > + #address-cells = <0>; > spi-slave; > status = "okay"; > ready-gpios = <&gpio 125 GPIO_ACTIVE_HIGH>; > -- > 1.8.3 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097D5C433FE for ; Tue, 8 Dec 2020 14:00:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF5D823B21 for ; Tue, 8 Dec 2020 14:00:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF5D823B21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tiM6L0P+IUH+klQaDznPAZitPAPPZGXka3AI/Ux5V20=; b=F9ejmHqevRAGJRhyyAmNJoAoU 6fFdgELm7TVbKCpYkRu0c+ZpgT81DOziCbJY/LZ7fzeozdqHi/vA0YuAtAQsoVAQwQQmdv/H7y+iq 1/pGtJwMHjRCDr/VNqjoj7NhVgAo3Ba8JkF7CmtpyJ4Plj2k9N9+1CcQ+6bFO5SIc+O62AAUKPFRd JghCgGiPvJZLyno2Gp1aV5act3pkmLZ1yf8hp/ejdYqHh5KPLYvYSQ1rvUqj9bQliDFkHJMXABt5j ZKbfOYruFr6pa1CXw0CHNZZ3UQQgn9tGvm1K02wmUwRWaTHYculV3c9sTc2NVl1YysVxwNaQ2ico9 fm4cnC9Vw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmdWG-0001Tc-RT; Tue, 08 Dec 2020 13:59:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmdWC-0001SF-TO for linux-arm-kernel@lists.infradead.org; Tue, 08 Dec 2020 13:59:06 +0000 X-Gm-Message-State: AOAM53044iK60rMlNtkAE1iLwHMrnUDzfYt2bmPPrscQs8l/zMuBntQc WCKMmzApngF5nLmhSSpkSNRlzuoPPJpfDTglTTc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607435943; bh=77HVStyyXX1Pgy5zmoyOyQEPooYc3GGLgYGD12JjNMw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=V7qDwVhG3gecJGhol6Ike5wg7CosFyxhl1m1sYpQdPBixF5UVNgETKJaj3Q8j0VqM DnSfS+iAy2AYNiMsrBDyBqDsHUcmQXdhB/88XprAJULuyhu7mSx5/nAUIVkTmU5jZb UoEnwyt0Phn+3MP9pbluTpxm1jjr+RsrBtFNrAGPKP+e18Cg1L8cUHPKydqO+vW7lr sep53IjAfdBKspkmrT8HzTaqvCKYFyPtBp6G5/hYGqA4Y25UHHtR882SSuUOtLyMT7 YnpnnZ+xpkag+KWK2t1w2AQlIavNpBtudPADLTaEOSNZurvhzo6Q/gMnsVCT7d0pZs SgkPQmwVGqlFg== X-Google-Smtp-Source: ABdhPJzbbFo39L5/f8usODzWGuXBtaIc9x6K8uqLzlRNVMHrBQiyt8ZvbtR8IVirlhP18K9q04YQVyIqIjNM4nND/bM= X-Received: by 2002:a5d:4101:: with SMTP id l1mr7874896wrp.196.1607435941883; Tue, 08 Dec 2020 05:59:01 -0800 (PST) MIME-Version: 1.0 References: <20201207084752.1665-1-thunder.leizhen@huawei.com> <20201207084752.1665-2-thunder.leizhen@huawei.com> In-Reply-To: <20201207084752.1665-2-thunder.leizhen@huawei.com> From: Arnd Bergmann Date: Tue, 8 Dec 2020 14:58:45 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/1] ARM: dts: mmp2-olpc-xo-1-75: clear the warnings when make dtbs To: Zhen Lei X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_085905_111318_E10997FF X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Arnd Bergmann , linux-kernel , Lubomir Rintel , Rob Herring , Pavel Machek , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 7, 2020 at 9:47 AM Zhen Lei wrote: > > The check_spi_bus_bridge() in scripts/dtc/checks.c requires that the node > have "spi-slave" property must with "#address-cells = <0>" and > "#size-cells = <0>". But currently both "#address-cells" and "#size-cells" > properties are deleted, the corresponding default values are 2 and 1. As a > result, the check fails and below warnings is displayed. > > arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ > /soc/apb@d4000000/spi@d4037000: incorrect #address-cells for SPI bus > also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 > arch/arm/boot/dts/mmp2.dtsi:472.23-480.6: Warning (spi_bus_bridge): \ > /soc/apb@d4000000/spi@d4037000: incorrect #size-cells for SPI bus > also defined at arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:225.7-237.3 > arch/arm/boot/dts/mmp2-olpc-xo-1-75.dtb: Warning (spi_bus_reg): \ > Failed prerequisite 'spi_bus_bridge' > > Because the value of "#size-cells" is already defined as zero in the node > "ssp3: spi@d4037000" in arch/arm/boot/dts/mmp2.dtsi. So we only need to > explicitly add "#address-cells = <0>" and keep "#size-cells" no change. > > Signed-off-by: Zhen Lei Right, I already sent the same patch earlier. Lubomir, can I apply this to the fixes branch? > arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > index adde62d6fce73b9..82da44dacba7172 100644 > --- a/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > +++ b/arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts > @@ -224,7 +224,7 @@ > > &ssp3 { > /delete-property/ #address-cells; > - /delete-property/ #size-cells; > + #address-cells = <0>; > spi-slave; > status = "okay"; > ready-gpios = <&gpio 125 GPIO_ACTIVE_HIGH>; > -- > 1.8.3 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel