From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B698C433E0 for ; Wed, 12 Aug 2020 09:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 422722078B for ; Wed, 12 Aug 2020 09:15:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbgHLJPG (ORCPT ); Wed, 12 Aug 2020 05:15:06 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:60651 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbgHLJPF (ORCPT ); Wed, 12 Aug 2020 05:15:05 -0400 Received: from mail-qv1-f44.google.com ([209.85.219.44]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N49Yn-1knPDq0gc5-01020t; Wed, 12 Aug 2020 11:15:03 +0200 Received: by mail-qv1-f44.google.com with SMTP id b2so683847qvp.9; Wed, 12 Aug 2020 02:15:02 -0700 (PDT) X-Gm-Message-State: AOAM532uwtt0KfQ8eMASY0ruVWWgJb0K0BmMTFRlZzRGZQ67MdwDu4PW pdoHDw4GohXQRwVEQRVaM9NJWkcWW09HONaOWCU= X-Google-Smtp-Source: ABdhPJx0VdO25VsXrKJTGh++kO4RzTD7ABEGX3vxwAEv4hRe86n9s2x2EuFs5/Fm/ZiIRZ9shvLmiOvKZowrNIwmt2A= X-Received: by 2002:ad4:44e5:: with SMTP id p5mr5592821qvt.197.1597223701843; Wed, 12 Aug 2020 02:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> In-Reply-To: <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> From: Arnd Bergmann Date: Wed, 12 Aug 2020 11:14:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Stephen Boyd Cc: Alexandre Torgue , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Sylwester Nawrocki , Tomasz Figa , Will Deacon , Wim Van Sebroeck , Linux ARM , linux-clk , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG , patches@opensource.cirrus.com, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:bTDtJI1lkKkLvgsIHRpW0ziEP8zpHuLUYZ7SCV7CWDb0QxoD296 NDdAfDIk8grOWNJr2ySjYHegmKgJuUgb2o/U9UWi6oBle997lCfw5E8r2BCzIRnBvIILa2i /auQ0xMRDZJumI0NRAyowADabdngizQKolsLaXYJiv18nb+TI9PNB3FgOMSF3F8YGDz9zqj 2RIyZEUzuh1qz87OO0UZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:qTeOd2VnZz0=:I3Y6DTZUjvmV44dOocq9k9 lQryWn0PqQ3kDhTthk/FFhhnE2GuVsh+hJP4jyoOGFexkP5xPiSZ6elmY5aSsloMGdUWB2Wt4 8vsCZpRg346I6WRR683y/dOCMmzN5Qx1snUHlthWUaT5rgDDDV2VYYU/1Z2rIQI453dd+MLZk RFQGV5Pa/T61PWy2Rqj7Q+br/wW419+pJae0Q4W7/L6G9mlbp5Gv6maXTWbQ0Q64LIgIp+aj5 aX8q355XZQxPvNPLoCoKTZ0+3NzGyd/NbC5InBNVFDsVcF/qtsBWElMnB9XHVDMsxYIbGtLsx i7Xdh/TcRa3/Gdn85iJ0DiIorYkmac6xqa4oqXDFShkMmlybnwqJh52lv+61ZkGlThJzBB6c/ 2H+p3xsv9dx07pTNqEHLBTF3x6hNwCsfayVa9LAYrca80r5neuC5PGttscvdOAhUFNMGT/lZJ Oxhu9GzVTx8HGasmPBx9RGYeVKT+Fm5nr8zgzA7WBc7hLAyhhOqMKPOVmoboJVp/wd6BwiTmw AnT6D3q76IRI0KjEqZWn8ZfjYuclswA8Dd4BFKwiv/DrxpHW8lQVrYRAdOd7QzWdqSqN8ZXHj 3Sy7fSqjD9T+sgxRrKR66cATjMtv1iFeklH5QmEIzKnFX3vbPRha/r16EjEG3RYnEGtBQBrRC +fq9yVrA1gqq9UW6iC6dqGWB0Z6jeiRjGUfPCW4BQgCqylSudgOJ2a6Akmploy37qf/p3NQB7 MhX/HADQHvthTwbv5GaZCrajPvYCCyDkwvcZiH+danDQzjbkHXtIWcjAtMmJcDchhhVZGY4Pr Nmlj6EtNODw2apz26ei/kNhnMJ46uyb4aVITnVJVpXyjNOXfxkr1kY3vYQ+/l29ewvkX6RWp3 JcRf9Drf4ZDIsbmpvHrWvDlyLKgSNsF0ppFAA94nsvWm50iDwFxQuz5EChjU5y2Ai09BxyWsv 6cSv0UOeRZYMLZFfCn7XSsKeSoag/C5UnLhS2QGtd16vrai4GVTNR Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Aug 12, 2020 at 9:59 AM Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-08-04 12:26:54) > > The s3c_camif_gpio_put() declaration in > > include/media/drv-intf/s3c_camif.h header was different than definition. > > Fixing this allows to include that header to also fix the W=1 compile > > warnings: > > > > arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] > > 28 | int s3c_camif_gpio_get(void) > > arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes] > > 56 | void s3c_camif_gpio_put(void) > > Maybe it should have been void all along? It seems there have never been any callers and the entire file can just be removed, with the rest of that platform_data header file moved to drivers/media/platform/s3c-camif/. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D71EC433E0 for ; Wed, 12 Aug 2020 09:16:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED920206C3 for ; Wed, 12 Aug 2020 09:16:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sekRpqxi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED920206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GGZ8k71XSWvHEKoqT39ydIbFmpsn0YB1PC/Bs3oqWOg=; b=sekRpqxib9+0neFBUCPDFnOyf 1b7ra1iLSwIS23kHRpiHIJcb/yKM7hCkRd8eKiTbmlayUf+2DCRcGxPCCRkgPYzzG1bdTN1kHOG2Q XKKwnNB4eMH2JcGTTezC2ktBBTuiyaymyD5RMw3+w+nVjQ9ca8lcRn6lF2v/8UX/aV07Nso50wLF0 uzMAMxOyM1SUMN3X1eyK7yeuxr/4zyyawL/DFgPwZdP00uNNZ7c1EEsfe9ybCt8Vsig7hc7AqivV4 A+0SRUb4Ij+f6FJd621hB3SewrOF6AFfjoXkDgXs0GWe7x4NuNc6wA61nQsy+2S1jUI/itX+ogCko Gt35RrnEA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mqo-00025c-E9; Wed, 12 Aug 2020 09:15:14 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mql-00024j-FD for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 09:15:12 +0000 Received: from mail-qv1-f43.google.com ([209.85.219.43]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MdNse-1keqcL1YGW-00ZSjz for ; Wed, 12 Aug 2020 11:15:05 +0200 Received: by mail-qv1-f43.google.com with SMTP id y11so700343qvl.4 for ; Wed, 12 Aug 2020 02:15:02 -0700 (PDT) X-Gm-Message-State: AOAM530e3cybenQuNZ9P2dhSVkbLRcIz3D+UbQFxWldwfAR1OEhBfu6N tMBbQ4MHMWoqHeChZZam3K1wuhgLWsKrNN6LcBQ= X-Google-Smtp-Source: ABdhPJx0VdO25VsXrKJTGh++kO4RzTD7ABEGX3vxwAEv4hRe86n9s2x2EuFs5/Fm/ZiIRZ9shvLmiOvKZowrNIwmt2A= X-Received: by 2002:ad4:44e5:: with SMTP id p5mr5592821qvt.197.1597223701843; Wed, 12 Aug 2020 02:15:01 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> In-Reply-To: <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> From: Arnd Bergmann Date: Wed, 12 Aug 2020 11:14:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Stephen Boyd X-Provags-ID: V03:K1:5FPzaYrh56/kPan+o5alySryFTpME9Qh/H/5Mza2GX/+ojPevBe b4nv4o8Qc7/GpU4JSpxiHStmrnuYY8EdGKhWbu47sFqf+tXLIC1LAAKAFtCKGwwfhodlTTC rwAVAZ5zthj9yzwPa/4/b6MzLnPfLcW0kT3zvkFA1U73+bGUP661Ue2L73fFQRb2ub0nyJ+ exdBB7iNMn0gsiP644UaQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:dD9MvIc+gGQ=:HAE7OuoxogI+q/Uxsnp6WN V5Xc1xQphDND3c+P5cIv4/ArhCrVYsXUku1Mx7uiO8ux9Qhod2HHTDI51eQanSgtgYfRcLibz 8b+JaC6bqeBJt3SJB4H3N1OJ6QhFQTsLSMC8LsV3X9REjWZ2j3jcjSWSjDWuyiIg7Tgv48I7v XCfQqL4dOvoqlB/xS+lsb3EN/ATAhoA3M6XbLx4t4okq7iDA4dsd1hleJ0WA+pxTfazjmtqgY ZBEVUANW+CkuhUtQWuyo+htHNkh4ZqE7q4/QBFa2EQH8/lATdEKHSBWxOtXZyOwp4pZyC3cZT 6SGbTbk9kZqIWbH8/5fsPP8YdMH0fw9aY9U10kcinYLaANk/+KO7d8FA8l5fX2DGWrd9g89H7 MyB+TPsCb1SCrFUxhNI+n9Ij69ofydQ3SE0o9VNU4JlmOLNAqDKH2Ca2E59sHTFKKHtnxslQr +mLUkradtDtmTgdVK6ZAMSdDTvnKfQ2gXPtWrdmGYa4hM6mtpPtXxKCECeEGzJVOtU39U6D5A KfRhEhugB6IvwgJ+GIaLWCYPFnuAO7oeJ3P36u13y+t3KFrDVOwLD2PUkA3MQAawp01AJjJ7K f2nhy+vQbewo+V0DnbORNexgpZJlmmP8Fa8WBXtc/N3JPe0vnpS5UjVNtW1zdn4MT44sb49vu Nomra6SZqATmKjsuD3JMwxHflGMmbnuEVTdNJk/pEpAQLBRShKCipObCD3IsljyXawGBk6NJC 7L/S0+UcGAK/g1B5/Px6ZPc7zQOsArHVRXba6Rz4girxg1EeGdRdlVmJVF1TjwfrT6hx70lJH 1B6uDSq1v74UxbWHJOeJQwATr5cJWxKSq0gE3TRovT6WQcqNfvcxRrKOLxU0Ej3bULspbq3RN itzei4hJPlti1CuFyFjUqhQgyqPWq2iaNPcj+R3r6hlKV8RsQkrEh248xdO0j5e7sBE858bxe Ia2k+sggQHozDbTqx0RsyPuXoeO0/hkef4KLRsrvJXupGONoyEm9i X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_051511_739290_603721B5 X-CRM114-Status: GOOD ( 17.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Tomasz Figa , Sylwester Nawrocki , Will Deacon , linux-clk , LINUXWATCHDOG , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Sylwester Nawrocki , Cedric Roux , Russell King , Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Wim Van Sebroeck , Simtec Linux Team , Linux ARM , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2020 at 9:59 AM Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-08-04 12:26:54) > > The s3c_camif_gpio_put() declaration in > > include/media/drv-intf/s3c_camif.h header was different than definition. > > Fixing this allows to include that header to also fix the W=1 compile > > warnings: > > > > arch/arm/mach-s3c24xx/setup-camif.c:28:5: warning: no previous prototype for 's3c_camif_gpio_get' [-Wmissing-prototypes] > > 28 | int s3c_camif_gpio_get(void) > > arch/arm/mach-s3c24xx/setup-camif.c:56:6: warning: no previous prototype for 's3c_camif_gpio_put' [-Wmissing-prototypes] > > 56 | void s3c_camif_gpio_put(void) > > Maybe it should have been void all along? It seems there have never been any callers and the entire file can just be removed, with the rest of that platform_data header file moved to drivers/media/platform/s3c-camif/. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel