From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE41B513F; Mon, 28 Feb 2022 08:11:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 730B7C36AEC; Mon, 28 Feb 2022 08:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646035915; bh=zMDLEB8toWf2EIp4Gbj5PSCBFzWdzLn4mVbcpqFSMxs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G5/HKt1YcKrybKD+1q8UgQW8r6UniPBg+HgJCRHDiawTCCJy2G9uMVmVMIrAH+MIY uUZuQAmqf+UgQqG4LSwOUKjuA8mlT2hPXWXAetE6/wffM3OsZ6cQuw+SmzDdC9fizY tnKAD3prEcX2CmRCAP5e0Sp4+MmIaoIy7bEgoECFMmrlcDv1M29iegogMcMJXx4EzC Ww6E2vE2Ei6Ccl+33CFLA3ixlnEAH6a8FHRWu+p6u8hOq0ib6UliPV2J7DZbNT/orL Z5vh8VINzIAjIFdahYuMGIJkpIkpdyHyDhOYN0mcWcjSY+6pRXFj43dgIYPqjgmCqP vBf0o1GuFv9eA== Received: by mail-wm1-f44.google.com with SMTP id bg16-20020a05600c3c9000b00380f6f473b0so5239875wmb.1; Mon, 28 Feb 2022 00:11:55 -0800 (PST) X-Gm-Message-State: AOAM5326gkaP9J9IbS16cgunRRJMCZZOHQmWr2ev0OCtG84K+ekBdOMJ lyGmgh9Id/vK42lx9ZzLQ19G4L0yQ68cowGA3kM= X-Google-Smtp-Source: ABdhPJx0yttNosgz0Dhhih9aIMEkkBewvoulgcXNOZok4rXBWTX7Xo99SrIvGnmvPy9Xsi9me/xpLhkH8sj6MYMy+yQ= X-Received: by 2002:a05:600c:4802:b0:381:3b27:89b7 with SMTP id i2-20020a05600c480200b003813b2789b7mr11349875wmo.173.1646035913752; Mon, 28 Feb 2022 00:11:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20220227215408.3180023-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 28 Feb 2022 09:11:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments To: john@quad.stoffel.home Cc: Linux Kbuild mailing list , Arnd Bergmann , Linus Torvalds , Masahiro Yamada , llvm@lists.linux.dev, Jonathan Corbet , Federico Vaga , Alex Shi , Hu Haowen , Michal Marek , Nick Desaulniers , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-doc-tw-discuss@lists.sourceforge.net, Linux ARM , Intel Graphics , dri-devel , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-btrfs Content-Type: text/plain; charset="UTF-8" On Mon, Feb 28, 2022 at 1:14 AM John Stoffel wrote: > > On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > > declaration inside of a for() loop. While the C99, C11 and later standards > > introduce many other features, most of these are already available in > > gnu89 as GNU extensions as well. > > > > An earlier attempt to do this when gcc-5 started defaulting to > > -std=gnu11 failed because at the time that caused warnings about > > designated initializers with older compilers. Now that gcc-5.1 is the > > minimum compiler version used for building kernels, that is no longer a > > concern. Similarly, the behavior of 'inline' functions changes between > > gnu89 and gnu89, but this was taken care of by defining 'inline' to > > Typo here? Second one should be gnu99 right? Fixed, thanks! Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C069BC433F5 for ; Mon, 28 Feb 2022 08:11:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E629F10E259; Mon, 28 Feb 2022 08:11:58 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2987C10E259; Mon, 28 Feb 2022 08:11:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9443861130; Mon, 28 Feb 2022 08:11:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 726E0C36AEA; Mon, 28 Feb 2022 08:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646035915; bh=zMDLEB8toWf2EIp4Gbj5PSCBFzWdzLn4mVbcpqFSMxs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G5/HKt1YcKrybKD+1q8UgQW8r6UniPBg+HgJCRHDiawTCCJy2G9uMVmVMIrAH+MIY uUZuQAmqf+UgQqG4LSwOUKjuA8mlT2hPXWXAetE6/wffM3OsZ6cQuw+SmzDdC9fizY tnKAD3prEcX2CmRCAP5e0Sp4+MmIaoIy7bEgoECFMmrlcDv1M29iegogMcMJXx4EzC Ww6E2vE2Ei6Ccl+33CFLA3ixlnEAH6a8FHRWu+p6u8hOq0ib6UliPV2J7DZbNT/orL Z5vh8VINzIAjIFdahYuMGIJkpIkpdyHyDhOYN0mcWcjSY+6pRXFj43dgIYPqjgmCqP vBf0o1GuFv9eA== Received: by mail-wm1-f52.google.com with SMTP id l1-20020a7bcf01000000b0037f881182a8so5233504wmg.2; Mon, 28 Feb 2022 00:11:55 -0800 (PST) X-Gm-Message-State: AOAM530oZzEVp+F/L+i7unNZqdXCJFw7wCetHNuZmcL+MyGSkA8Cc+RT T0Jg3XXHCptsPalwD3dvQM96k71Y86mPKrDynyY= X-Google-Smtp-Source: ABdhPJx0yttNosgz0Dhhih9aIMEkkBewvoulgcXNOZok4rXBWTX7Xo99SrIvGnmvPy9Xsi9me/xpLhkH8sj6MYMy+yQ= X-Received: by 2002:a05:600c:4802:b0:381:3b27:89b7 with SMTP id i2-20020a05600c480200b003813b2789b7mr11349875wmo.173.1646035913752; Mon, 28 Feb 2022 00:11:53 -0800 (PST) MIME-Version: 1.0 References: <20220227215408.3180023-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 28 Feb 2022 09:11:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments To: john@quad.stoffel.home Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Michal Marek , "open list:DOCUMENTATION" , Arnd Bergmann , Jonathan Corbet , linux-staging@lists.linux.dev, Masahiro Yamada , llvm@lists.linux.dev, Nick Desaulniers , Linux Kernel Mailing List , dri-devel , greybus-dev@lists.linaro.org, Alex Shi , Federico Vaga , Hu Haowen , Intel Graphics , linux-btrfs , Linus Torvalds , linux-doc-tw-discuss@lists.sourceforge.net, Linux Kbuild mailing list Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 28, 2022 at 1:14 AM John Stoffel wrote: > > On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > > declaration inside of a for() loop. While the C99, C11 and later standards > > introduce many other features, most of these are already available in > > gnu89 as GNU extensions as well. > > > > An earlier attempt to do this when gcc-5 started defaulting to > > -std=gnu11 failed because at the time that caused warnings about > > designated initializers with older compilers. Now that gcc-5.1 is the > > minimum compiler version used for building kernels, that is no longer a > > concern. Similarly, the behavior of 'inline' functions changes between > > gnu89 and gnu89, but this was taken care of by defining 'inline' to > > Typo here? Second one should be gnu99 right? Fixed, thanks! Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFF2EC433EF for ; Mon, 28 Feb 2022 08:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Ydyu34jZrl3KlrTqc+ihCSEfiivb39+BiY3T7Mkg5M=; b=K0qOHCorTNus0f D42ExCYTSnOODjGDCH8xP4zhYgBFCzSbGcKAn0S4KGzPpHhZ0fNJR3CADPL4e1aPwGUWUHWwKTgPE xhyN7ci8TK/Bta76c4vxXGxtIhOnjE4umjuz/cq78YygMZdDstxu0/RHSdW+krGkSenUW2NvW/SKt Q44s9pSrwa1pDeCKoGpvF6NZaqok550S9cepXhTlb9DRDqQkpnsSykp/NYP8GHFF1B/JZiK/saL4B 9earNdEi0SvsQ2bhM13fEwNFPe1SDQ6m8Xj34D4AuRzpIQPiltycPJwy+bjtC77ZSz2aS11rZfiIc Ea1bVhCVpqrYArskK/Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOb8U-00B4R8-Ob; Mon, 28 Feb 2022 08:12:02 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOb8Q-00B4Pp-Pk for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 08:12:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59B35B80E63 for ; Mon, 28 Feb 2022 08:11:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 729DBC36AEB for ; Mon, 28 Feb 2022 08:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646035915; bh=zMDLEB8toWf2EIp4Gbj5PSCBFzWdzLn4mVbcpqFSMxs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G5/HKt1YcKrybKD+1q8UgQW8r6UniPBg+HgJCRHDiawTCCJy2G9uMVmVMIrAH+MIY uUZuQAmqf+UgQqG4LSwOUKjuA8mlT2hPXWXAetE6/wffM3OsZ6cQuw+SmzDdC9fizY tnKAD3prEcX2CmRCAP5e0Sp4+MmIaoIy7bEgoECFMmrlcDv1M29iegogMcMJXx4EzC Ww6E2vE2Ei6Ccl+33CFLA3ixlnEAH6a8FHRWu+p6u8hOq0ib6UliPV2J7DZbNT/orL Z5vh8VINzIAjIFdahYuMGIJkpIkpdyHyDhOYN0mcWcjSY+6pRXFj43dgIYPqjgmCqP vBf0o1GuFv9eA== Received: by mail-wm1-f49.google.com with SMTP id c18-20020a7bc852000000b003806ce86c6dso5214224wml.5 for ; Mon, 28 Feb 2022 00:11:55 -0800 (PST) X-Gm-Message-State: AOAM53006i3nQ+S8PabPfa9KXofu/q9K1NOH/322bb1NMibKDPLRc8R4 /U7sk9+xfhJz2wfNH+N6nFTE1uMBLRn3RoaBUNU= X-Google-Smtp-Source: ABdhPJx0yttNosgz0Dhhih9aIMEkkBewvoulgcXNOZok4rXBWTX7Xo99SrIvGnmvPy9Xsi9me/xpLhkH8sj6MYMy+yQ= X-Received: by 2002:a05:600c:4802:b0:381:3b27:89b7 with SMTP id i2-20020a05600c480200b003813b2789b7mr11349875wmo.173.1646035913752; Mon, 28 Feb 2022 00:11:53 -0800 (PST) MIME-Version: 1.0 References: <20220227215408.3180023-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 28 Feb 2022 09:11:37 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Kbuild: remove -std=gnu89 from compiler arguments To: john@quad.stoffel.home Cc: Linux Kbuild mailing list , Arnd Bergmann , Linus Torvalds , Masahiro Yamada , llvm@lists.linux.dev, Jonathan Corbet , Federico Vaga , Alex Shi , Hu Haowen , Michal Marek , Nick Desaulniers , "open list:DOCUMENTATION" , Linux Kernel Mailing List , linux-doc-tw-discuss@lists.sourceforge.net, Linux ARM , Intel Graphics , dri-devel , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-btrfs X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_001159_195450_EF85AD07 X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 28, 2022 at 1:14 AM John Stoffel wrote: > > On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > > declaration inside of a for() loop. While the C99, C11 and later standards > > introduce many other features, most of these are already available in > > gnu89 as GNU extensions as well. > > > > An earlier attempt to do this when gcc-5 started defaulting to > > -std=gnu11 failed because at the time that caused warnings about > > designated initializers with older compilers. Now that gcc-5.1 is the > > minimum compiler version used for building kernels, that is no longer a > > concern. Similarly, the behavior of 'inline' functions changes between > > gnu89 and gnu89, but this was taken care of by defining 'inline' to > > Typo here? Second one should be gnu99 right? Fixed, thanks! Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC4F2C433EF for ; Mon, 28 Feb 2022 14:27:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EABA10E83E; Mon, 28 Feb 2022 14:27:05 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2987C10E259; Mon, 28 Feb 2022 08:11:57 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9443861130; Mon, 28 Feb 2022 08:11:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 726E0C36AEA; Mon, 28 Feb 2022 08:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646035915; bh=zMDLEB8toWf2EIp4Gbj5PSCBFzWdzLn4mVbcpqFSMxs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G5/HKt1YcKrybKD+1q8UgQW8r6UniPBg+HgJCRHDiawTCCJy2G9uMVmVMIrAH+MIY uUZuQAmqf+UgQqG4LSwOUKjuA8mlT2hPXWXAetE6/wffM3OsZ6cQuw+SmzDdC9fizY tnKAD3prEcX2CmRCAP5e0Sp4+MmIaoIy7bEgoECFMmrlcDv1M29iegogMcMJXx4EzC Ww6E2vE2Ei6Ccl+33CFLA3ixlnEAH6a8FHRWu+p6u8hOq0ib6UliPV2J7DZbNT/orL Z5vh8VINzIAjIFdahYuMGIJkpIkpdyHyDhOYN0mcWcjSY+6pRXFj43dgIYPqjgmCqP vBf0o1GuFv9eA== Received: by mail-wm1-f52.google.com with SMTP id l1-20020a7bcf01000000b0037f881182a8so5233504wmg.2; Mon, 28 Feb 2022 00:11:55 -0800 (PST) X-Gm-Message-State: AOAM530oZzEVp+F/L+i7unNZqdXCJFw7wCetHNuZmcL+MyGSkA8Cc+RT T0Jg3XXHCptsPalwD3dvQM96k71Y86mPKrDynyY= X-Google-Smtp-Source: ABdhPJx0yttNosgz0Dhhih9aIMEkkBewvoulgcXNOZok4rXBWTX7Xo99SrIvGnmvPy9Xsi9me/xpLhkH8sj6MYMy+yQ= X-Received: by 2002:a05:600c:4802:b0:381:3b27:89b7 with SMTP id i2-20020a05600c480200b003813b2789b7mr11349875wmo.173.1646035913752; Mon, 28 Feb 2022 00:11:53 -0800 (PST) MIME-Version: 1.0 References: <20220227215408.3180023-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 28 Feb 2022 09:11:37 +0100 X-Gmail-Original-Message-ID: Message-ID: To: john@quad.stoffel.home Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 28 Feb 2022 14:26:05 +0000 Subject: Re: [Intel-gfx] [PATCH] Kbuild: remove -std=gnu89 from compiler arguments X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Michal Marek , "open list:DOCUMENTATION" , Arnd Bergmann , Jonathan Corbet , linux-staging@lists.linux.dev, Masahiro Yamada , llvm@lists.linux.dev, Nick Desaulniers , Linux Kernel Mailing List , dri-devel , greybus-dev@lists.linaro.org, Alex Shi , Federico Vaga , Hu Haowen , Intel Graphics , linux-btrfs , Linus Torvalds , linux-doc-tw-discuss@lists.sourceforge.net, Linux Kbuild mailing list Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 28, 2022 at 1:14 AM John Stoffel wrote: > > On Sun, Feb 27, 2022 at 10:52:43PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > During a patch discussion, Linus brought up the option of changing > > the C standard version from gnu89 to gnu99, which allows using variable > > declaration inside of a for() loop. While the C99, C11 and later standards > > introduce many other features, most of these are already available in > > gnu89 as GNU extensions as well. > > > > An earlier attempt to do this when gcc-5 started defaulting to > > -std=gnu11 failed because at the time that caused warnings about > > designated initializers with older compilers. Now that gcc-5.1 is the > > minimum compiler version used for building kernels, that is no longer a > > concern. Similarly, the behavior of 'inline' functions changes between > > gnu89 and gnu89, but this was taken care of by defining 'inline' to > > Typo here? Second one should be gnu99 right? Fixed, thanks! Arnd