From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC718C433DB for ; Fri, 26 Mar 2021 20:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68DCC61A18 for ; Fri, 26 Mar 2021 20:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhCZUEI (ORCPT ); Fri, 26 Mar 2021 16:04:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:60790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229986AbhCZUDt (ORCPT ); Fri, 26 Mar 2021 16:03:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A60E161A02; Fri, 26 Mar 2021 20:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789028; bh=4LKLYKqudMoB6aEd0Ps7uLTpOx51F1Icssxa7AiFOw0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=prkDcNQpdnFzJnZv4Ul12AA/8zLGY27K6F+rBjzHhJq5NBK64WHUpsTem8eBtcfq8 HEU/kcqmBG6bk7WnfZ/IM91KhzhQE2pUDGa/zVEP4ococfpu86/s24LCtrU8wT2GyK m6gUaMsN8IGte6bF3v8K/u3vkltqzOTXU/j30NXMfmjBWUvpR3aJWYqOM0+15uxvEs LyEnaWEoeurwpOM/zxMXBSi9YSAaeaglJTAllj1WTCQJMYJTZ7QrGQhjLmJ3ajNCyS LXCywYD3hnmQcNFxE9Lud5JbQkq41i3G35jD0V1uR7vTEi10VW2BiRXNMLm/7ThHYG Kx2Z0hgshZvtw== Received: by mail-ot1-f54.google.com with SMTP id y19-20020a0568301d93b02901b9f88a238eso6311170oti.11; Fri, 26 Mar 2021 13:03:48 -0700 (PDT) X-Gm-Message-State: AOAM531uQ3TdQMWAMEyblGZEI/rkSNWF040dmZKC3+tccVON8I7jjC1l w3BixtdxNeuUdPmdWZZBKU8izULwbFZw/NB2M+8= X-Google-Smtp-Source: ABdhPJyPEunl4Ngli4e/a9ttTgDySVGUAx1snwV7toHx9J8Evv0fmZt1qQLI1SgPLsSAWwUdD3HAzaFQDSDeIqyJHRs= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr13387334otq.251.1616789027968; Fri, 26 Mar 2021 13:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210320151903.60759-1-sven@svenpeter.dev> <20210323205346.GA1283560@robh.at.kernel.org> <43685c67-6d9c-4e72-b320-0462c2273bf0@www.fastmail.com> <9f06872d-f0ec-43c3-9b53-d144337100b3@www.fastmail.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 26 Mar 2021 21:03:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] Apple M1 DART IOMMU driver To: Mark Kettenis Cc: sven@svenpeter.dev, Rob Herring , "open list:IOMMU DRIVERS" , Joerg Roedel , Will Deacon , Robin Murphy , Hector Martin , Marc Zyngier , Mohamed Mediouni , Stan Skowronek , Linux ARM , Linux Kernel Mailing List , DTML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 6:28 PM Mark Kettenis wrote: > I haven't figured out how the bypass stuff really works. Corellium > added support for it in their codebase when they added support for > Thunderbolt, and some of the DARTs that seem to be related to > Thunderbolt do indeed have a "bypass" property. But it is unclear to > me how the different puzzle pieces fit together for Thunderbolt. As a general observation, bypass mode for Thunderbolt is what enabled the http://thunderclap.io/ attack. This is extremely useful for debugging a running kernel from another machine, but it's also something that should never be done in a production kernel. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE5EC433C1 for ; Fri, 26 Mar 2021 20:03:53 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32CAF6197C for ; Fri, 26 Mar 2021 20:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32CAF6197C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E2E836060C; Fri, 26 Mar 2021 20:03:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8V00FlPCF0Uj; Fri, 26 Mar 2021 20:03:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTP id DCDBF605B7; Fri, 26 Mar 2021 20:03:51 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B5B9BC000C; Fri, 26 Mar 2021 20:03:51 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5896CC000A for ; Fri, 26 Mar 2021 20:03:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 46BC784CC9 for ; Fri, 26 Mar 2021 20:03:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0_q0mU5vGw9p for ; Fri, 26 Mar 2021 20:03:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9B29684CAC for ; Fri, 26 Mar 2021 20:03:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AAC1F61A18 for ; Fri, 26 Mar 2021 20:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789028; bh=4LKLYKqudMoB6aEd0Ps7uLTpOx51F1Icssxa7AiFOw0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=prkDcNQpdnFzJnZv4Ul12AA/8zLGY27K6F+rBjzHhJq5NBK64WHUpsTem8eBtcfq8 HEU/kcqmBG6bk7WnfZ/IM91KhzhQE2pUDGa/zVEP4ococfpu86/s24LCtrU8wT2GyK m6gUaMsN8IGte6bF3v8K/u3vkltqzOTXU/j30NXMfmjBWUvpR3aJWYqOM0+15uxvEs LyEnaWEoeurwpOM/zxMXBSi9YSAaeaglJTAllj1WTCQJMYJTZ7QrGQhjLmJ3ajNCyS LXCywYD3hnmQcNFxE9Lud5JbQkq41i3G35jD0V1uR7vTEi10VW2BiRXNMLm/7ThHYG Kx2Z0hgshZvtw== Received: by mail-ot1-f53.google.com with SMTP id m21-20020a9d7ad50000b02901b83efc84a0so6301290otn.10 for ; Fri, 26 Mar 2021 13:03:48 -0700 (PDT) X-Gm-Message-State: AOAM530mAZRhFqFUwLDlcUJmvMsKEI2WFGrqrjnIVlZ0Jlgb94QSUwBA tzuKUHd/x6F6NyGKTl8L3PRxLSUkTOo3SPjbQZE= X-Google-Smtp-Source: ABdhPJyPEunl4Ngli4e/a9ttTgDySVGUAx1snwV7toHx9J8Evv0fmZt1qQLI1SgPLsSAWwUdD3HAzaFQDSDeIqyJHRs= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr13387334otq.251.1616789027968; Fri, 26 Mar 2021 13:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210320151903.60759-1-sven@svenpeter.dev> <20210323205346.GA1283560@robh.at.kernel.org> <43685c67-6d9c-4e72-b320-0462c2273bf0@www.fastmail.com> <9f06872d-f0ec-43c3-9b53-d144337100b3@www.fastmail.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 26 Mar 2021 21:03:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] Apple M1 DART IOMMU driver To: Mark Kettenis Cc: Rob Herring , sven@svenpeter.dev, DTML , Will Deacon , Hector Martin , Linux Kernel Mailing List , "open list:IOMMU DRIVERS" , Marc Zyngier , Mohamed Mediouni , Robin Murphy , Linux ARM , Stan Skowronek X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Mar 26, 2021 at 6:28 PM Mark Kettenis wrote: > I haven't figured out how the bypass stuff really works. Corellium > added support for it in their codebase when they added support for > Thunderbolt, and some of the DARTs that seem to be related to > Thunderbolt do indeed have a "bypass" property. But it is unclear to > me how the different puzzle pieces fit together for Thunderbolt. As a general observation, bypass mode for Thunderbolt is what enabled the http://thunderclap.io/ attack. This is extremely useful for debugging a running kernel from another machine, but it's also something that should never be done in a production kernel. Arnd _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D63C433E1 for ; Fri, 26 Mar 2021 20:05:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7940261A02 for ; Fri, 26 Mar 2021 20:05:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7940261A02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K6xPTODE+KwPPytHwzMl3719/fBy2fVM+hFzq8hsSvo=; b=h42NmWb1QP/NI7agq9CtC4Ux9 BIhv4CHzTf4aRKptz28BnkT/D/EExnNdGZlVAtG1/NMiLkP0GGZxUfEv5RWTlH2D34U7eJo/pdLzr 7Ur1hMD+QB3E7PYNIvOzkLqTYV5Uf8/SdD0DX/mQfhzRUR8qOseM77cR369imMeibppTGWgV0ekZV T1YUKLLJjHHt75429ASuty2LjjKKjGbnDjj6Sv6RyJ3yfy1xyEqUuAhMCgx3RAdbhOI3KpDIQa2M7 j5uozoewn1JkOc9H2df8sHeAoBM1eFK8jBRQ4GNuAMDHPBG4hY6//MPDz649p7vGeRfkpkMvxkR61 /+yYwrc1A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPsgW-004GOA-Rs; Fri, 26 Mar 2021 20:03:57 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPsgQ-004GN7-1j for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 20:03:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AABA619D3 for ; Fri, 26 Mar 2021 20:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616789028; bh=4LKLYKqudMoB6aEd0Ps7uLTpOx51F1Icssxa7AiFOw0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=prkDcNQpdnFzJnZv4Ul12AA/8zLGY27K6F+rBjzHhJq5NBK64WHUpsTem8eBtcfq8 HEU/kcqmBG6bk7WnfZ/IM91KhzhQE2pUDGa/zVEP4ococfpu86/s24LCtrU8wT2GyK m6gUaMsN8IGte6bF3v8K/u3vkltqzOTXU/j30NXMfmjBWUvpR3aJWYqOM0+15uxvEs LyEnaWEoeurwpOM/zxMXBSi9YSAaeaglJTAllj1WTCQJMYJTZ7QrGQhjLmJ3ajNCyS LXCywYD3hnmQcNFxE9Lud5JbQkq41i3G35jD0V1uR7vTEi10VW2BiRXNMLm/7ThHYG Kx2Z0hgshZvtw== Received: by mail-ot1-f50.google.com with SMTP id g8-20020a9d6c480000b02901b65ca2432cso6334329otq.3 for ; Fri, 26 Mar 2021 13:03:48 -0700 (PDT) X-Gm-Message-State: AOAM530RLmfWRL6wWK20oo2WvdvOV5thsmTJOcnyN/OEQ436FBkC2wEB u8y5M3eSD5ILDLzjHoZara57FSlsUJ6El2/V3aM= X-Google-Smtp-Source: ABdhPJyPEunl4Ngli4e/a9ttTgDySVGUAx1snwV7toHx9J8Evv0fmZt1qQLI1SgPLsSAWwUdD3HAzaFQDSDeIqyJHRs= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr13387334otq.251.1616789027968; Fri, 26 Mar 2021 13:03:47 -0700 (PDT) MIME-Version: 1.0 References: <20210320151903.60759-1-sven@svenpeter.dev> <20210323205346.GA1283560@robh.at.kernel.org> <43685c67-6d9c-4e72-b320-0462c2273bf0@www.fastmail.com> <9f06872d-f0ec-43c3-9b53-d144337100b3@www.fastmail.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 26 Mar 2021 21:03:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/3] Apple M1 DART IOMMU driver To: Mark Kettenis Cc: sven@svenpeter.dev, Rob Herring , "open list:IOMMU DRIVERS" , Joerg Roedel , Will Deacon , Robin Murphy , Hector Martin , Marc Zyngier , Mohamed Mediouni , Stan Skowronek , Linux ARM , Linux Kernel Mailing List , DTML X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_200352_550844_D7DC3221 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 26, 2021 at 6:28 PM Mark Kettenis wrote: > I haven't figured out how the bypass stuff really works. Corellium > added support for it in their codebase when they added support for > Thunderbolt, and some of the DARTs that seem to be related to > Thunderbolt do indeed have a "bypass" property. But it is unclear to > me how the different puzzle pieces fit together for Thunderbolt. As a general observation, bypass mode for Thunderbolt is what enabled the http://thunderclap.io/ attack. This is extremely useful for debugging a running kernel from another machine, but it's also something that should never be done in a production kernel. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel