From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66D83C433E0 for ; Sun, 31 Jan 2021 22:23:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 01A3564E30; Sun, 31 Jan 2021 22:23:34 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D0A9764DFA; Sun, 31 Jan 2021 22:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612131813; bh=1zFi1O/OfYRPJDpm+YetAkissf3owl4zMydwrZGKhtA=; h=References:In-Reply-To:From:Date:Subject:To:List-Id:Cc:From; b=MUbLbdjUeCXbxiVgfjEXG2ihyyp9M4WwCgQdHAuD/RzXKZS8qXaIkbl7AHg1v8yTc GGfGWegIqvjTX7Hm2Ya2Ft161tSG1rqVeGgOinO1L3+MMnKegKeNOduHqN9gCCGL+Q +Ewj16WzYrgoJkRFZ3Nt6LvAbpLqNq8+T3O2gm+qt16iUuWAI38JbrJVe3WLSDnq+w y4EZordAg7oFFNZTIeL2EPZleIsZbdbwHLkcRlHGrKQ3FFLqXVlCkW8Whn1Uo1hohd Y+pINktCqaf3sAFwANCbXtVkg9lUITip89Uo6l8oimoLcL61tF7eD+BcmcM2ud53cc yuLyf8iPi1fQw== Received: by mail-oo1-f49.google.com with SMTP id r199so3804216oor.2; Sun, 31 Jan 2021 14:23:33 -0800 (PST) X-Gm-Message-State: AOAM531nbaj/zsZoe4M5Np6nGjmLM088lhCHeR2EyRH79o9E/1pnAjQO jvP6XXBeTxAz/PydPFw03JORKpbeuoS7CoriQm8= X-Google-Smtp-Source: ABdhPJzJdLOj/vjVeCo4tCU0t8VtADnGPEnXFXXeUhxRbWkkiD6RvXIuBjxJ2kZqzBEd/nUmDyfOMYGYA4dCL0LKoBk= X-Received: by 2002:a4a:870c:: with SMTP id z12mr3228398ooh.15.1612131813154; Sun, 31 Jan 2021 14:23:33 -0800 (PST) MIME-Version: 1.0 References: <1608713092-26952-1-git-send-email-neal.liu@mediatek.com> <1608713092-26952-3-git-send-email-neal.liu@mediatek.com> <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> From: Arnd Bergmann Date: Sun, 31 Jan 2021 23:23:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms To: Matthias Brugger List-Id: Cc: Neal Liu , Rob Herring , Catalin Marinas , Will Deacon , SoC Team , DTML , wsd_upstream , Hanks Chen , lkml , "moderated list:ARM/Mediatek SoC..." , Jackson-kt Chang , Linux ARM Content-Type: text/plain; charset="UTF-8" On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger wrote: > On 23/12/2020 09:44, Neal Liu wrote: > > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC. > > > > Signed-off-by: Neal Liu > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 17a2df6..a373776 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y > > CONFIG_MTD_NAND_FSL_IFC=y > > CONFIG_MTD_NAND_QCOM=y > > CONFIG_MTD_SPI_NOR=y > > +CONFIG_MTK_DEVAPC=m > > CONFIG_SPI_CADENCE_QUADSPI=y > > CONFIG_BLK_DEV_LOOP=y > > CONFIG_BLK_DEV_NBD=m > > > > From my understanding, defconfig is for a minimal config that allows to boot a > machine. As MTK_DEVAPC is a rather exotic driver to detect bus access > violations, I think it's not a good candidate for inclusion in defconfig. > > In any case, I added the SoC maintainer, so that they can correct me, if I'm > wrong :) I generally don't mind adding platform specific drivers as loadable modules even if they are somewhat obscure. For built-in drivers, this is different though, as those have a noticeable impact on other platforms. I haven't kept track of what this particular driver does, but from the Kconfig description, I'd say it should get enabled in defconfig. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64514C433E0 for ; Sun, 31 Jan 2021 22:23:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FFD364DFA for ; Sun, 31 Jan 2021 22:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FFD364DFA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TeT8GrfVUBt7eeZyfP1+z/Op4kJ+xEBEoxWmfm2ydWY=; b=onDHkb11u4dCBO/mJLvOHX6BB 4zWyFrzLsaWQCqm8KJ4IDjy0zUYrwYj+wpvAYs5atmDWCUHwmnJDEA43IwllP85CcY5dzJIcZRymy fGBHCCcO9rQTFSUO+SmmyZ5AFvvMdLy0XaUXEQkZYHUc8hzuSZkKPjx1nnUnfJlRvT3rzjka66xYg dc+B5rbvHy9Ph6PAGjsJVsKGU4wMTqnFGuJ3cAZO/uc735B+i8msV2lJi9tSJz8XVK0/vcWOYH14r Bd1A7ROv84hNS9elOUA9h/t13F+D0LxcT1eMspC8wv5Xi3n/kLd1XCxSPc9U9i8bUMHIDgc3Z4YZL K6nYCh8RA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6L88-0002Fk-7d; Sun, 31 Jan 2021 22:23:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6L84-0002ED-BZ; Sun, 31 Jan 2021 22:23:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE09564E2A; Sun, 31 Jan 2021 22:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612131814; bh=1zFi1O/OfYRPJDpm+YetAkissf3owl4zMydwrZGKhtA=; h=References:In-Reply-To:From:Date:Subject:To:List-Id:Cc:From; b=c/SetFTgjDQen2386CJ8OpClyi1IQL+o1fM0exttg7g76Edj/2OnTgpANm4CGLIoU 9AUmk+fosA9M5z2V5SWEmOYhl/ALjJ8FJhdulR7cbUe2vxnbWWT1DPcjMRlxbYQ3k2 AxqjNQhSD0IJMXro4+G+3EVrC4QNsSqtHfZzH3fBZV7EwxBTnxbKq5kifeBagRy8IP EHml06Cl256UCTYXiDCsQ0i8ILsdV8Z4qaGVWgy2HSKpbNi3cZcHLUd37F1qWEaZFO f7hlxApr48faFQaEUCwS6htTA2BKKO2G1dSqNLJnjJwfH1mewrWC3mLMlXpbQPEKVn zQQz4Ieb7Utaw== Received: by mail-oo1-f54.google.com with SMTP id g46so3774424ooi.9; Sun, 31 Jan 2021 14:23:33 -0800 (PST) X-Gm-Message-State: AOAM533WEuuG2w5UN3T5iMsO1J4JhGvKExhVJ+wlGvu9Lan7QA60ASai 3IOrQScYSGrL/RM43fmGsJMZ5juofu/2PbrxTXs= X-Google-Smtp-Source: ABdhPJzJdLOj/vjVeCo4tCU0t8VtADnGPEnXFXXeUhxRbWkkiD6RvXIuBjxJ2kZqzBEd/nUmDyfOMYGYA4dCL0LKoBk= X-Received: by 2002:a4a:870c:: with SMTP id z12mr3228398ooh.15.1612131813154; Sun, 31 Jan 2021 14:23:33 -0800 (PST) MIME-Version: 1.0 References: <1608713092-26952-1-git-send-email-neal.liu@mediatek.com> <1608713092-26952-3-git-send-email-neal.liu@mediatek.com> <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> From: Arnd Bergmann Date: Sun, 31 Jan 2021 23:23:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms To: Matthias Brugger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_172336_501785_543F0578 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: DTML , wsd_upstream , Catalin Marinas , Hanks Chen , lkml , SoC Team , Rob Herring , Neal Liu , Linux ARM , "moderated list:ARM/Mediatek SoC..." , Will Deacon , Jackson-kt Chang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Message-ID: <20210131222317.YHPPoIwQtlHsA_ZEgoPXdU9XRWRDfcJeMH5n3YOVWqE@z> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger wrote: > On 23/12/2020 09:44, Neal Liu wrote: > > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC. > > > > Signed-off-by: Neal Liu > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 17a2df6..a373776 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y > > CONFIG_MTD_NAND_FSL_IFC=y > > CONFIG_MTD_NAND_QCOM=y > > CONFIG_MTD_SPI_NOR=y > > +CONFIG_MTK_DEVAPC=m > > CONFIG_SPI_CADENCE_QUADSPI=y > > CONFIG_BLK_DEV_LOOP=y > > CONFIG_BLK_DEV_NBD=m > > > > From my understanding, defconfig is for a minimal config that allows to boot a > machine. As MTK_DEVAPC is a rather exotic driver to detect bus access > violations, I think it's not a good candidate for inclusion in defconfig. > > In any case, I added the SoC maintainer, so that they can correct me, if I'm > wrong :) I generally don't mind adding platform specific drivers as loadable modules even if they are somewhat obscure. For built-in drivers, this is different though, as those have a noticeable impact on other platforms. I haven't kept track of what this particular driver does, but from the Kconfig description, I'd say it should get enabled in defconfig. Arnd _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A8CC433DB for ; Sun, 31 Jan 2021 22:24:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BC0264DFA for ; Sun, 31 Jan 2021 22:24:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BC0264DFA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J7UZ9F8p8bM1JOc5XKMnZFRhaLgYFpIxuh1vheB4wY8=; b=tBU6mGmX3exzb00K8eAUY8vC9 IfAMscbFNd29beEgEevAHv7/XJZ4DcRDuyElEeARgGH7+xr8V+rh47nHsNp17dSPjFjWIg4+Pmina uruSLcxk3A7wKaa91FQMNG27nly/VsbjcDVgyShnPD9NhPCsQ+hSVZx0aoj8a+WSJypDNJv+i1LW7 A7sGs4vg/1iNAeJdnpnd34S+iTwtC6rjwO6FTDM4SU2mId3lhqkj81tSDhprA2DmzmIWh1X8eHFrv GsTc5QDTJwO4CPdALgf20NoIQcrnFOMtjHLwRqHS3R4bjU/cARLdpSOdCRx8Mwcx/BxR0j6Im9dQx twXl8uw3A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6L87-0002FP-8J; Sun, 31 Jan 2021 22:23:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6L84-0002ED-BZ; Sun, 31 Jan 2021 22:23:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE09564E2A; Sun, 31 Jan 2021 22:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612131814; bh=1zFi1O/OfYRPJDpm+YetAkissf3owl4zMydwrZGKhtA=; h=References:In-Reply-To:From:Date:Subject:To:List-Id:Cc:From; b=c/SetFTgjDQen2386CJ8OpClyi1IQL+o1fM0exttg7g76Edj/2OnTgpANm4CGLIoU 9AUmk+fosA9M5z2V5SWEmOYhl/ALjJ8FJhdulR7cbUe2vxnbWWT1DPcjMRlxbYQ3k2 AxqjNQhSD0IJMXro4+G+3EVrC4QNsSqtHfZzH3fBZV7EwxBTnxbKq5kifeBagRy8IP EHml06Cl256UCTYXiDCsQ0i8ILsdV8Z4qaGVWgy2HSKpbNi3cZcHLUd37F1qWEaZFO f7hlxApr48faFQaEUCwS6htTA2BKKO2G1dSqNLJnjJwfH1mewrWC3mLMlXpbQPEKVn zQQz4Ieb7Utaw== Received: by mail-oo1-f54.google.com with SMTP id g46so3774424ooi.9; Sun, 31 Jan 2021 14:23:33 -0800 (PST) X-Gm-Message-State: AOAM533WEuuG2w5UN3T5iMsO1J4JhGvKExhVJ+wlGvu9Lan7QA60ASai 3IOrQScYSGrL/RM43fmGsJMZ5juofu/2PbrxTXs= X-Google-Smtp-Source: ABdhPJzJdLOj/vjVeCo4tCU0t8VtADnGPEnXFXXeUhxRbWkkiD6RvXIuBjxJ2kZqzBEd/nUmDyfOMYGYA4dCL0LKoBk= X-Received: by 2002:a4a:870c:: with SMTP id z12mr3228398ooh.15.1612131813154; Sun, 31 Jan 2021 14:23:33 -0800 (PST) MIME-Version: 1.0 References: <1608713092-26952-1-git-send-email-neal.liu@mediatek.com> <1608713092-26952-3-git-send-email-neal.liu@mediatek.com> <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> In-Reply-To: <68442164-d649-aee0-cfe8-c9ebb868612d@gmail.com> From: Arnd Bergmann Date: Sun, 31 Jan 2021 23:23:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms To: Matthias Brugger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_172336_501785_543F0578 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: DTML , wsd_upstream , Catalin Marinas , Hanks Chen , lkml , SoC Team , Rob Herring , Neal Liu , Linux ARM , "moderated list:ARM/Mediatek SoC..." , Will Deacon , Jackson-kt Chang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20210131222317.atJy4aTb2PFWIQSOWTt9R4wWvBt4skbKWLJnWNtEikg@z> On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger wrote: > On 23/12/2020 09:44, Neal Liu wrote: > > Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC. > > > > Signed-off-by: Neal Liu > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 17a2df6..a373776 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y > > CONFIG_MTD_NAND_FSL_IFC=y > > CONFIG_MTD_NAND_QCOM=y > > CONFIG_MTD_SPI_NOR=y > > +CONFIG_MTK_DEVAPC=m > > CONFIG_SPI_CADENCE_QUADSPI=y > > CONFIG_BLK_DEV_LOOP=y > > CONFIG_BLK_DEV_NBD=m > > > > From my understanding, defconfig is for a minimal config that allows to boot a > machine. As MTK_DEVAPC is a rather exotic driver to detect bus access > violations, I think it's not a good candidate for inclusion in defconfig. > > In any case, I added the SoC maintainer, so that they can correct me, if I'm > wrong :) I generally don't mind adding platform specific drivers as loadable modules even if they are somewhat obscure. For built-in drivers, this is different though, as those have a noticeable impact on other platforms. I haven't kept track of what this particular driver does, but from the Kconfig description, I'd say it should get enabled in defconfig. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel