From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235E7C433F5 for ; Mon, 7 Mar 2022 13:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242335AbiCGNRW (ORCPT ); Mon, 7 Mar 2022 08:17:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241581AbiCGNRW (ORCPT ); Mon, 7 Mar 2022 08:17:22 -0500 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FBCD8BF46; Mon, 7 Mar 2022 05:16:25 -0800 (PST) Received: from mail-wm1-f54.google.com ([209.85.128.54]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mlf8e-1nrEZB2dTG-00iih2; Mon, 07 Mar 2022 14:16:23 +0100 Received: by mail-wm1-f54.google.com with SMTP id bi14-20020a05600c3d8e00b00386f2897400so5559291wmb.5; Mon, 07 Mar 2022 05:16:23 -0800 (PST) X-Gm-Message-State: AOAM530Z21qC5OU6RfI9f7s+aOzJUCNxoQ+zVqSZ7JFRXBBxbhqP3wr9 cgD37uURIsN7wXV01A8jPzgrpMtqNWvK4t7v2lo= X-Google-Smtp-Source: ABdhPJysabRPmKcRrE/Kx/6xr0pdCTUYYBYzw9UdGhnsD750vY5MOm+A6ymUb8srsaOas8KbFQonhsx1JUb8yl80qaQ= X-Received: by 2002:a1c:7919:0:b0:389:79c5:fe83 with SMTP id l25-20020a1c7919000000b0038979c5fe83mr10387102wme.173.1646658983039; Mon, 07 Mar 2022 05:16:23 -0800 (PST) MIME-Version: 1.0 References: <20211224041352.29405-1-quan@os.amperecomputing.com> <20211224041352.29405-9-quan@os.amperecomputing.com> <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com> In-Reply-To: <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com> From: Arnd Bergmann Date: Mon, 7 Mar 2022 14:16:06 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver To: Quan Nguyen Cc: Lee Jones , Open Source Submission , Phong Vo , "Thang Q . Nguyen" , Joel Stanley , Andrew Jeffery , Jean Delvare , Guenter Roeck , Rob Herring , Jonathan Corbet , linux-hwmon@vger.kernel.org, DTML , Linux Kernel Mailing List , "open list:DOCUMENTATION" , linux-aspeed , OpenBMC Maillist , Mark Brown , Greg Kroah-Hartman , "Rafael J . Wysocki" , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Gustavo Pimentel Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Pz4zb/GLH1qI19x07wJW5N9i+PPZOvCU5axiU12F9XtpS19weck b0y5o9IF0eONu5cHJidiJhMBWqr3WbNHA8PvsH3rm8nBhRQb0mwzrvuqLHIowVzMvBV1dC9 HL2OLK1WTgbZfKKsMlQhT55g72fc8M9YnEivajODS3VI1wQ3A1FL/z40siURtQQAvqJKPld hDf1WyCO7IFrR2oQpKbhw== X-UI-Out-Filterresults: notjunk:1;V03:K0:nwmwTtx+NwI=:PjFNEcviuydLjHqeumDBlC 8egcuNZTMxwVo1ZZRfu+27KDFfRydZjRnpkgsE7+kcMPu1mYSevWbTykn+cEvcdfzuqMu51RH csOWZpl2wZm/0OQFvzLDv+VIxZtt5/mur+OG0+atJQvX8mYTT6OuOVA5++Zj2E2B0e2cOmSSg aommICQ6awRLTfKyKnz+Z6k1CubhBiP+w48BNNzKSbBv00dIFgSLADvqvRM2JEOc2pnvKI/03 m2z6wO1o1n64u6IuSYky/TCWWwfqE4fvWKSBdfN2jNPrSyMtgcPUIaXmLQn8827H5QU3o6fa/ ZvhaTBn5VjtFOH7Ib1uF5NWmh0luaeJNdVw0x7idg5895WzYXZ2Cqc/GLu7ow1LVuYzCKTTHO gZXRGEIf9QkpAscFzLPt9obplKDsSv4WKzaP6lckufct9sR1lQI81opH9kg61k+qAhPD4XP0x X9e3w/dWj26pSKFLAcuam1UNPl8KlTYQqN25yaQQOs9vNJlHBezIKQGAq9Np+3nQQqNTbFzD/ TbQrG/Vt/7A/j9VSm8uv5ZWI0nnocpwQkWltCxeQuZXLfFa4KhvG45rjwFq9vIFKB+8n46KZQ PRfKZ1SR2eFUOQCieNO0Gaa/h+WfaXXLqssM9E8/Hj3FT4YIiYLPxfreHUk87G4TuyqJr1ZT1 nFxEeqNXKkOhNz1cNR/0sf8ljlImJnVRWpWqrZnyc67/MzTn9t8mhj92EN5f+lgEI/eXUVHH8 jOouD+jzcEa+2gwbsLiHWT3LvHfjgkui9RiNVaRQQ2QwjEZJHVdjaOYjR0ksmaE+s4XNYtOPf LM7uM4WRpZXpHr7BRcIUq/Khemir+0jut0HCEhqZgEJHE89ysE= Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, Mar 7, 2022 at 9:32 AM Quan Nguyen wrote: > > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c > > index a7cd64bf9eaa..5611dd30f8f4 100644 > > --- a/drivers/mfd/smpro-mfd.c > > +++ b/drivers/mfd/smpro-mfd.c > > @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = { > > static const struct mfd_cell smpro_devs[] = { > > MFD_CELL_NAME("smpro-hwmon"), > > MFD_CELL_NAME("smpro-errmon"), > > + MFD_CELL_NAME("smpro-misc"), > > [Lee Jones] > Misc is a Linuxisum which are not allowed in DT. > > What does this driver actually do? > > [Quan] > This drivers is to report the boot progress to BMC and allow BMC to > configure the Soc Power Limit of Ampere's Altra family processor. That doesn't sound like it should be platform specific at all, but rather a generic BMC interface. I see you already have the openbmc list on Cc, so I assume the right people can see this. Presumably this is a BMC that already runs on openbmc and can have a platform-independent interface for doing this. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CED9C433F5 for ; Mon, 7 Mar 2022 13:16:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KBzWV5vdFz3bVK for ; Tue, 8 Mar 2022 00:16:54 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.126.187; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KBzVy3x7yz30BF; Tue, 8 Mar 2022 00:16:25 +1100 (AEDT) Received: from mail-wm1-f42.google.com ([209.85.128.42]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MLRI3-1nibeG1my3-00IQoR; Mon, 07 Mar 2022 14:16:23 +0100 Received: by mail-wm1-f42.google.com with SMTP id r65so9175709wma.2; Mon, 07 Mar 2022 05:16:23 -0800 (PST) X-Gm-Message-State: AOAM531pVk0tk19y5nn348WqbFM9UJfFOKFvUwFV9BL7QL0Y9N+jYBuZ R106h0DeUpkrBH6zpgRDdcMt112es+CxPpx28MI= X-Google-Smtp-Source: ABdhPJysabRPmKcRrE/Kx/6xr0pdCTUYYBYzw9UdGhnsD750vY5MOm+A6ymUb8srsaOas8KbFQonhsx1JUb8yl80qaQ= X-Received: by 2002:a1c:7919:0:b0:389:79c5:fe83 with SMTP id l25-20020a1c7919000000b0038979c5fe83mr10387102wme.173.1646658983039; Mon, 07 Mar 2022 05:16:23 -0800 (PST) MIME-Version: 1.0 References: <20211224041352.29405-1-quan@os.amperecomputing.com> <20211224041352.29405-9-quan@os.amperecomputing.com> <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com> In-Reply-To: <51603aa7-4113-dba4-9a38-0a6683a1d249@os.amperecomputing.com> From: Arnd Bergmann Date: Mon, 7 Mar 2022 14:16:06 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver To: Quan Nguyen Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:/Io6Ks6I9pcY068kSw94wWMYdRGfCRr3GVwmcryyCmlvZ725Mbs 0TUeGyidkjDnEhWmp9gY2RUwYgOtjt6MuUmtut75V0/nmhxrRPJaKPpBWYQ/fIsQWEqKmTL H5EH9DrGOu0afi31jW9fBnfv2IbMs7QjRNbmzyEGl/4w7naIFJG8ft5qH2a86lzl2W0QoEp GB20nsNsShZh8fcnP66VA== X-UI-Out-Filterresults: notjunk:1;V03:K0:n+Mi6XyyCq8=:AxQV9L4M5Qt/oeb0TolL3v 79dnqb4XJSxrInjC7K2u5LCC+7BbVd09Py2P1+KH6YUWC9MDOCsS0RpFrqR50L9xmCHr+qO7j a2DrmCXunzs6+chUh73B5Bl82mGv6rwB24/Vk5qi2LvsL0+RiHh311xzN2fRqBqIl7xKi219P fXF+HVDhCD9qBuDp/FGnf3yTKXW10kvOkCm1wAItvfsRa9idOtX3bEHm15/H3Cm1hHFfyGqSb mFNSw+uVgQEMyoKigdj9ZecRtEKCY77dIXdLuqRLm0Qmxt9NuMKN6lMLkv+WFx5bCb5zorghH oD1q7IahQA+j7LDUaaXorn+7nlttNe9YTOPJ8uDnP1HYwL4+sTJ8YG+leI4M2V5MAN/TrzMJ5 Z+wfpBNmVVVHyoZDi1pcHRQ7yrVtZT3b3wNhUydH3L7+KBlHKW4CDSsh/oIm3wioZZnVN/WrO yjjgwOK0TH8r+vGJ+L4D1ofZsC4QQIlkH/RaLlTGVacx3SZqSVIruTn6vtdWgnOHECdGGjVTA 3ih2MTHnHf/SyjD8D0D5nvTzQwd1cABKyc6MVqS7jNgLMMkWoeW8xzz6cgh+ta9N/iPqjQomw JZqWFnz6xBuOcDUqtIdOG3E8phCpgkBuOWdsLIoPWFZgZO48NJj8+DhXyfwkwg98h4wb5LcWL AwYvUWVA4u0k1JyWxGgVAeVES07z8iTXgNZVGqxKXtFKA32Ce2950nt1YKyJ3Ng0oDDxBKapZ z4kxpt4MS204zpLOD/c9TSIoWrSbs0k+u+Udkf7PSSkAYILC0nqqzzIiACF+TZ7WN6cIeZvme ENFxmLn4OtSZj7QTFZy/AEvoMWooXUyrD4osQ8RrcnMgyY5Fuk= X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed , "open list:DOCUMENTATION" , Dragan Cvetic , Linux Kernel Mailing List , Lee Jones , Jonathan Corbet , OpenBMC Maillist , "Rafael J . Wysocki" , Joel Stanley , Open Source Submission , Guenter Roeck , DTML , Jean Delvare , Arnd Bergmann , "Thang Q . Nguyen" , Rob Herring , Derek Kiernan , linux-hwmon@vger.kernel.org, Andrew Jeffery , Greg Kroah-Hartman , Phong Vo , Mark Brown , Gustavo Pimentel Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, Mar 7, 2022 at 9:32 AM Quan Nguyen wrote: > > diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c > > index a7cd64bf9eaa..5611dd30f8f4 100644 > > --- a/drivers/mfd/smpro-mfd.c > > +++ b/drivers/mfd/smpro-mfd.c > > @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = { > > static const struct mfd_cell smpro_devs[] = { > > MFD_CELL_NAME("smpro-hwmon"), > > MFD_CELL_NAME("smpro-errmon"), > > + MFD_CELL_NAME("smpro-misc"), > > [Lee Jones] > Misc is a Linuxisum which are not allowed in DT. > > What does this driver actually do? > > [Quan] > This drivers is to report the boot progress to BMC and allow BMC to > configure the Soc Power Limit of Ampere's Altra family processor. That doesn't sound like it should be platform specific at all, but rather a generic BMC interface. I see you already have the openbmc list on Cc, so I assume the right people can see this. Presumably this is a BMC that already runs on openbmc and can have a platform-independent interface for doing this. Arnd