From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFAEDC433FE for ; Mon, 14 Mar 2022 10:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238466AbiCNK2e (ORCPT ); Mon, 14 Mar 2022 06:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232855AbiCNK2d (ORCPT ); Mon, 14 Mar 2022 06:28:33 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D4E2434AC; Mon, 14 Mar 2022 03:27:23 -0700 (PDT) Received: from mail-wr1-f41.google.com ([209.85.221.41]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N2E5Q-1o85pv1l0w-013hgA; Mon, 14 Mar 2022 11:27:21 +0100 Received: by mail-wr1-f41.google.com with SMTP id r10so23114352wrp.3; Mon, 14 Mar 2022 03:27:21 -0700 (PDT) X-Gm-Message-State: AOAM533wi1wQFKz/jjWWoA7OIi+D1FVHiKPc6L98q8OBtKOPpvcimtkL NbM+B+UpI1VmRhW9zYjTFTJXrifH5mXi/liRfHs= X-Google-Smtp-Source: ABdhPJzEqI1LonVZ6bGY0Zc5X1CtCNLufMa4XfGQ0mQSVCry0VjHQXsTUbzVOBx8Utrgu6D459mOK3Qcxj1FOdSYpI8= X-Received: by 2002:adf:edc3:0:b0:1ec:5f11:5415 with SMTP id v3-20020adfedc3000000b001ec5f115415mr15782141wro.317.1647253641105; Mon, 14 Mar 2022 03:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20220312180615.68929-1-singh.kuldeep87k@gmail.com> <20220312180615.68929-2-singh.kuldeep87k@gmail.com> <20220314035118.gbjbrwbsywxljjti@vireshk-i7> <20220314065434.GA43329@9a2d8922b8f1> <20220314073102.l6vokyookzyo76hj@vireshk-i7> In-Reply-To: <20220314073102.l6vokyookzyo76hj@vireshk-i7> From: Arnd Bergmann Date: Mon, 14 Mar 2022 11:27:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: spear13xx: Update SPI dma properties To: Viresh Kumar Cc: Kuldeep Singh , SoC Team , Arnd Bergmann , Viresh Kumar , Shiraz Hashim , Rob Herring , Linux ARM , DTML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:t28q1Kl8p8y/OBfeV9ZIJ96sVsdvnyOLTTMw9weIAt2vbSH/DUv yL1LMMqmRs3xnHa17t1mulBn0ysPW3mUFsSQTFwLzWwmta2M4Jku2peA2D/XSbC/XVbitna Kw4eQIE2bJW69R7k1wcIMMae0tpvAMLU1vkmYAc4s4+issN27rM45N5XRNH3jObAisvV+EV aJc70dSYzCclOWoHPyAPw== X-UI-Out-Filterresults: notjunk:1;V03:K0:Xeeq591h+34=:xxQi5QwfOEbLzqbQOb2f3V 5WlpQ5tZ+s+yu9A0UoaQGV86rl8AKvomDSy1o9kojwOGrsXfYaA3TTh2A7OrHJRmw+S+YZUOH e1Y+2bBDS8l4pWOL72naVxOOeopUzd6Pg2tgYERAi1gNXAQDNWJE658Wz6W4EMAp7Qurq4X2d mKWVYcNtqXZhfgmPgP1BYc2Onww95DRevGecy5/HEzf68E2iOs/0NctrrWUlb9DxAnpxkl63l MZ3zPceTRYDECdRo78FwByz+tOswz5ALs00IkcsRWBVUdaAeSV3aYYEqOUJQ7N1VgYCZmmqcT 0dZzRo8wry92g9Ejsmzgqkf1taILTvH4/TPe1J6fSpMHiARXKIOkBkuOYFkpB+p95Scj0L/U7 pOEBrSJUAwoJc7ur9/SuDTWkIAZ16xHxUt02n1vCDdrFC7O7sM2nvBK7W/gHUOeEQkA6LsGBC K0Z1TphVLVL3gMGUzGKLFeTUptRjG5Ycc0EjPIwzb2DzneVnI+2o8Tl5sVLfrWIA20BpcZDsg zdfP5/7ar6ZV/qQq6He85v3pAUXB9Vt/6e1jnvCqJq50x5HFUiB5F+ntGqH2wVqDN/lDFxUoh jlMiL5T3rMBRcouoM//J5UlgRDhI5URj0ec96mLxh8a3lL8hBgbmGm8cv28Z/V/DJ+8wEqn2g PfY355G6A8Bpae+CDg6cyTsYjZuLFq7yxxoIQduv7NWwxouhP5+zIUGoCIQPGhAfSQuA= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 14, 2022 at 8:31 AM Viresh Kumar wrote: > > On 14-03-22, 12:24, Kuldeep Singh wrote: > > Dma-names order matters here. > > As per pl022 binding, dma-names order specify rx,tx and all DTs which > > have tx,rx as order start raising dtbs_chek warning. Thus, need to > > reverse this order. Please note, no functional change in this patch > > apart from just fixing warning. > > > > Warning: > > 'rx' was expected > > 'tx' was expected > > Hmm. I see your point now. > > dma-names: > description: > There must be at least one channel named "tx" for transmit and named "rx" > for receive. > minItems: 2 > maxItems: 32 > additionalItems: true > items: > - const: rx > - const: tx > > > I was expecting above to allow adding the items in any order, but > looks like the order is fixed with this. I don't think that it was meant to have a fixed order: unlike the other bindings that define xxx-names properties, dmas require giving names to allow the DT to specify more than one possible DMA specifier for a given name. This means that nothing may ever just rely on an index but has to use the name for lookup. OTOH, while fixing the order in the binding does not add any value, it's also harmless as this should never be able to break anything that worked for any combination of old/new dtb and kernel, and it's probably easier to express in the binding. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64AE5C433F5 for ; Mon, 14 Mar 2022 10:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yDEahmglPq2XaJMoNYx0moH6FQDO3CfQxqV+Ta2gQkg=; b=nXlaidx3JRXKqy s97+F21bwhaCG3H0GjSZVlRi8GhFd/NO3ivVJJQUmqZZExnqYok856IDW0lQKPqmvR90Qv2lxjtyj sJIe4LInJJafaw130vJHrXo8dQEpnJpoSkLX3ZzQwN3hRDJx+NAa3eNrjkvEOMVumBS5gWFGgTvvo 5rD1+ZR2WE2T5I3clIhWP+CWTXJxTeVmAY7gmpMflWa9FDkT0x+YC7RllOXBhdxfbYkaUK+WstnrS 0WdGv8zkMgvZneO2dPQPTzAsIQOvt1JICPTvI+ANYYrrdMKprjh6/xQRXiKXDpQSfURS038rxRJDY quceQ6TJ3wz+rFdULh4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nThvJ-004xCo-74; Mon, 14 Mar 2022 10:27:33 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nThvE-004x96-5Q for linux-arm-kernel@lists.infradead.org; Mon, 14 Mar 2022 10:27:30 +0000 Received: from mail-wr1-f44.google.com ([209.85.221.44]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MTzjI-1nc3wJ1yEM-00R56K for ; Mon, 14 Mar 2022 11:27:21 +0100 Received: by mail-wr1-f44.google.com with SMTP id j26so23127701wrb.1 for ; Mon, 14 Mar 2022 03:27:21 -0700 (PDT) X-Gm-Message-State: AOAM533FBH5+ZshsTFB7vvxTMxCb3e7yENt2mhd5bs8b/uCjkxS3v90W FkqrFnmb7C4Gwlk1iHNCwQrghVCBG7DexqXR78g= X-Google-Smtp-Source: ABdhPJzEqI1LonVZ6bGY0Zc5X1CtCNLufMa4XfGQ0mQSVCry0VjHQXsTUbzVOBx8Utrgu6D459mOK3Qcxj1FOdSYpI8= X-Received: by 2002:adf:edc3:0:b0:1ec:5f11:5415 with SMTP id v3-20020adfedc3000000b001ec5f115415mr15782141wro.317.1647253641105; Mon, 14 Mar 2022 03:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20220312180615.68929-1-singh.kuldeep87k@gmail.com> <20220312180615.68929-2-singh.kuldeep87k@gmail.com> <20220314035118.gbjbrwbsywxljjti@vireshk-i7> <20220314065434.GA43329@9a2d8922b8f1> <20220314073102.l6vokyookzyo76hj@vireshk-i7> In-Reply-To: <20220314073102.l6vokyookzyo76hj@vireshk-i7> From: Arnd Bergmann Date: Mon, 14 Mar 2022 11:27:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] ARM: dts: spear13xx: Update SPI dma properties To: Viresh Kumar Cc: Kuldeep Singh , SoC Team , Arnd Bergmann , Viresh Kumar , Shiraz Hashim , Rob Herring , Linux ARM , DTML , Linux Kernel Mailing List X-Provags-ID: V03:K1:Bs/TF4iJaD8/iAPdy/eln8Mi9UV6NNUnxwFATNWMsPl6a8vGGcP tXiaDoL+cmRAvINCxaATGs38rKux7N0XsrDfWPUfN98F057Y8kCbhZfwbgONNO9QEv3JS8f mraNR9YSUcyhsM6l36bCp4hiyIX0CtyIpqqVZ0DNwM1sCwzirQj4Vf4yEi2ftdSYkIqzG75 wRw/fkMY7idH8BR54HiRA== X-UI-Out-Filterresults: notjunk:1;V03:K0:PVSyw4huyYA=:MFbQo3E6vG7FoM5k3s24BK 0V5c+/Ygda6WdQ9MYR9OH1ry/psg89kNWPK/arCnkVPrWXv7i0PFOpxZcQwybR8LFF38bBKVF hkiUCkMe8463FU92Ljgt4hbhnaD8iWBQULxGFt+a52ECtQVsufqr/+vGJsODo7KBUQOYo6YFY OoQTijM8ipCJpwPrDmXy8dnj51r/8OVvJaLQoqKN9TOhZ2tT78W2FDTcxpzBZYAIu+F12t7LS plY8DkwCaPAilZe01OFcwWHL7PXsFO42etCvtsOLWoqXkiAVLR/Sw7+qfp/xvkcpgnumotrES toooJR1kznEngc6k0JhbdUQmXxZblTMqMfL8jUApiJTBZ54EE3N/1FbuD2qmIE158cOJRGx+H tD90g0eI7gEokZqQxqG6FFxsnYLlLdCJsepEP+nd9an8qal06qFeyKEhg1ZzRnbpAHlRiWaik xX7G1LsiHTmnkZyg9UsiV6IHqUZGFloAHqC/dOl97EhXO0XE1wqg8qLFdKkFFeVZKI13u5trk kcSAexJOaaQK0osz5KOGpyctRaaVjHmXFq3hmA4Jkld5xZR9nNxzcu1RPsjSVpg4TlZJvSK3Q BRP1FcprrMtPWleLhljw1WbP/260JGvT7Pai8tpgY2ujDsND75zU4uk7GzXeaMkOYVVHLVDET WrjDVEjfV16xIF6mAxp5D/tTPEBhZruwjPyyYQA6+4qHG/LixMuXs/jl35uvs4Ar5N4bgGltQ haOyIAz71l68fGHPa7eaTdsZvbuZdY0jRWrwWsg3lRcbJ25RENoZzQhEitLDkXMsJCQYuaWQU 4YcKdgg0tvPX89wNFy1Ay9vs0tCGwJTyHb7Y10v4Je6QgkjF1I= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_032728_539457_2CA688C2 X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 14, 2022 at 8:31 AM Viresh Kumar wrote: > > On 14-03-22, 12:24, Kuldeep Singh wrote: > > Dma-names order matters here. > > As per pl022 binding, dma-names order specify rx,tx and all DTs which > > have tx,rx as order start raising dtbs_chek warning. Thus, need to > > reverse this order. Please note, no functional change in this patch > > apart from just fixing warning. > > > > Warning: > > 'rx' was expected > > 'tx' was expected > > Hmm. I see your point now. > > dma-names: > description: > There must be at least one channel named "tx" for transmit and named "rx" > for receive. > minItems: 2 > maxItems: 32 > additionalItems: true > items: > - const: rx > - const: tx > > > I was expecting above to allow adding the items in any order, but > looks like the order is fixed with this. I don't think that it was meant to have a fixed order: unlike the other bindings that define xxx-names properties, dmas require giving names to allow the DT to specify more than one possible DMA specifier for a given name. This means that nothing may ever just rely on an index but has to use the name for lookup. OTOH, while fixing the order in the binding does not add any value, it's also harmless as this should never be able to break anything that worked for any combination of old/new dtb and kernel, and it's probably easier to express in the binding. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel