From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED0DC433ED for ; Fri, 9 Apr 2021 07:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E913761206 for ; Fri, 9 Apr 2021 07:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231897AbhDIH4X (ORCPT ); Fri, 9 Apr 2021 03:56:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:48160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232060AbhDIH4X (ORCPT ); Fri, 9 Apr 2021 03:56:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A500D611BE; Fri, 9 Apr 2021 07:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617954970; bh=g5uN6Pl+84n19Wf10nEdkopoOYV20QI0EjR4ZGbc7jw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u2BbVFCGWc0iS4ph2dc5d1nDl187zG5P9pXL1Cm6UOvWXL3L0dBEsKrg9/h1POc19 h1WrlG2N5RR70AfSyZdWdMlRfjSGxKElfDb2SekhNnbfeKF4rnj6bxkOif0Ar50QQN L8FOwMyG1mXV7kTv/r2whQZMJUOhdTOYVDxPMGm6ArRqHL3EPwgc0LK+44RK7rTaEo QtrxjBMbCvXDQloY7nyKYEsuVDzznNlhD0KJKBz6g7AEXPQ+O+gkf4K5ostmrJzQXT Ao9W8Dtp2lp0FyPZk/qIJzxaOuEHjUxNrPcTk6TwRCsXKnPbtf7wW4aI220hiiVUBS iOtE6CzaWBe6Q== Received: by mail-ot1-f43.google.com with SMTP id c24-20020a9d6c980000b02902662e210895so4871507otr.9; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) X-Gm-Message-State: AOAM533wqrDde4EzYCMRg7e5KTjTRx1/w++3Ha+pEjFrIcSEOZ1h+CHZ lnaaGkQHSE4W/ziTuOS2o46325t3o/c07NGzehg= X-Google-Smtp-Source: ABdhPJyqkLL/YHm17TDMQcZw+JH1/6IOKmDcxX4k29Ovd57mDpReYbYM6BJUI+r5hcy0H4zXnuBQh0qM5jt0HH/0Mc4= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr11539093otq.251.1617954970003; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) MIME-Version: 1.0 References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-16-andrew@aj.id.au> In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au> From: Arnd Bergmann Date: Fri, 9 Apr 2021 09:55:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface To: Andrew Jeffery Cc: openipmi-developer@lists.sourceforge.net, OpenBMC Maillist , Corey Minyard , Joel Stanley , Ryan Chen , DTML , Tomer Maimon , linux-aspeed , "open list:GPIO SUBSYSTEM" , Avi Fishman , Patrick Venture , Linus Walleij , Linux Kernel Mailing List , Tali Perry , Rob Herring , Lee Jones , chiawei_wang@aspeedtech.com, Linux ARM , Benjamin Fair Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > However, KCS devices are useful beyond IPMI (or keyboards), as they > provide a means to generate IRQs and exchange arbitrary data between a > BMC and its host system. I only noticed the series after Joel asked about the DT changes on the arm side. One question though: How does this related to the drivers/input/serio/ framework that also talks to the keyboard controller for things that are not keyboards? Are these separate communication channels on adjacent I/O ports, or does there need to be some arbitration? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63277C433B4 for ; Fri, 9 Apr 2021 07:56:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D23C3611AB for ; Fri, 9 Apr 2021 07:56:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D23C3611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FGr7B0FDCz30L8 for ; Fri, 9 Apr 2021 17:56:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=u2BbVFCG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=arnd@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=u2BbVFCG; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FGr6j67vTz30Dl; Fri, 9 Apr 2021 17:56:13 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id B481C611B0; Fri, 9 Apr 2021 07:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617954970; bh=g5uN6Pl+84n19Wf10nEdkopoOYV20QI0EjR4ZGbc7jw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u2BbVFCGWc0iS4ph2dc5d1nDl187zG5P9pXL1Cm6UOvWXL3L0dBEsKrg9/h1POc19 h1WrlG2N5RR70AfSyZdWdMlRfjSGxKElfDb2SekhNnbfeKF4rnj6bxkOif0Ar50QQN L8FOwMyG1mXV7kTv/r2whQZMJUOhdTOYVDxPMGm6ArRqHL3EPwgc0LK+44RK7rTaEo QtrxjBMbCvXDQloY7nyKYEsuVDzznNlhD0KJKBz6g7AEXPQ+O+gkf4K5ostmrJzQXT Ao9W8Dtp2lp0FyPZk/qIJzxaOuEHjUxNrPcTk6TwRCsXKnPbtf7wW4aI220hiiVUBS iOtE6CzaWBe6Q== Received: by mail-ot1-f54.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so4878484otb.7; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) X-Gm-Message-State: AOAM533muVICQ6W/qTv3pju4iCSx/xvUccfquM6ImreQ2AonW3jxDcpn VGf/P/MhGlSlunO38L52mi5x2UeHN6DsHncI3lc= X-Google-Smtp-Source: ABdhPJyqkLL/YHm17TDMQcZw+JH1/6IOKmDcxX4k29Ovd57mDpReYbYM6BJUI+r5hcy0H4zXnuBQh0qM5jt0HH/0Mc4= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr11539093otq.251.1617954970003; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) MIME-Version: 1.0 References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-16-andrew@aj.id.au> In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au> From: Arnd Bergmann Date: Fri, 9 Apr 2021 09:55:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface To: Andrew Jeffery Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , DTML , chiawei_wang@aspeedtech.com, Ryan Chen , Tomer Maimon , Corey Minyard , Avi Fishman , Patrick Venture , OpenBMC Maillist , Linux Kernel Mailing List , Tali Perry , "open list:GPIO SUBSYSTEM" , Rob Herring , openipmi-developer@lists.sourceforge.net, Lee Jones , Linus Walleij , linux-aspeed , Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > However, KCS devices are useful beyond IPMI (or keyboards), as they > provide a means to generate IRQs and exchange arbitrary data between a > BMC and its host system. I only noticed the series after Joel asked about the DT changes on the arm side. One question though: How does this related to the drivers/input/serio/ framework that also talks to the keyboard controller for things that are not keyboards? Are these separate communication channels on adjacent I/O ports, or does there need to be some arbitration? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EE2C433B4 for ; Fri, 9 Apr 2021 07:59:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E0CC61182 for ; Fri, 9 Apr 2021 07:59:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E0CC61182 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yR5aCOWtIQ+B19jQSOhaqYgWf6Qw3PAAtOnXfmY1ryA=; b=Tn2j5gPRaP7yHwe2euz+ZQOSm yIj5CjxlyTP/VfdSiLb4uHKwa+Qq+GBIkuJRzWMYjMlNK3HXxAHL09qlygacDQLrfJmXHZoN2Qn+T 8ROkj1BAMD5gbI0jNojhW8dhl0kuya7qht54Kg+4LhTHMzV4zbfD2mEdL2tPibaQpUti/CzpDbAtr jGSXqUzyhz9Ez3JpQXQeoW1KcBGb1y2TAeq2FboHC+9bveQWNEIfR5j+ykaTeCQNnY7lVJ51QmcYZ 22IPSyHlNEUDoYL5SjkrdSaK6c42kUVixQQlSmre6w0ckk3VeqSaOqIyvCU4U5FyDGsp62IKQpdTY Oqw6v/RDQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUm0q-00AWKe-DS; Fri, 09 Apr 2021 07:57:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUlzw-00AW4N-8a for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 07:56:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A0B3B611AF for ; Fri, 9 Apr 2021 07:56:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617954970; bh=g5uN6Pl+84n19Wf10nEdkopoOYV20QI0EjR4ZGbc7jw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u2BbVFCGWc0iS4ph2dc5d1nDl187zG5P9pXL1Cm6UOvWXL3L0dBEsKrg9/h1POc19 h1WrlG2N5RR70AfSyZdWdMlRfjSGxKElfDb2SekhNnbfeKF4rnj6bxkOif0Ar50QQN L8FOwMyG1mXV7kTv/r2whQZMJUOhdTOYVDxPMGm6ArRqHL3EPwgc0LK+44RK7rTaEo QtrxjBMbCvXDQloY7nyKYEsuVDzznNlhD0KJKBz6g7AEXPQ+O+gkf4K5ostmrJzQXT Ao9W8Dtp2lp0FyPZk/qIJzxaOuEHjUxNrPcTk6TwRCsXKnPbtf7wW4aI220hiiVUBS iOtE6CzaWBe6Q== Received: by mail-ot1-f54.google.com with SMTP id y19-20020a0568301d93b02901b9f88a238eso4862363oti.11 for ; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) X-Gm-Message-State: AOAM532U73Ugv2GOi6QQkBQp9/RW09yFAHYsWWMU57secYAJPtDNqKj+ S+zZpEJmm4aWoJZCaE2W86F5w13uZgTtYYgzKSc= X-Google-Smtp-Source: ABdhPJyqkLL/YHm17TDMQcZw+JH1/6IOKmDcxX4k29Ovd57mDpReYbYM6BJUI+r5hcy0H4zXnuBQh0qM5jt0HH/0Mc4= X-Received: by 2002:a05:6830:148c:: with SMTP id s12mr11539093otq.251.1617954970003; Fri, 09 Apr 2021 00:56:10 -0700 (PDT) MIME-Version: 1.0 References: <20210319062752.145730-1-andrew@aj.id.au> <20210319062752.145730-16-andrew@aj.id.au> In-Reply-To: <20210319062752.145730-16-andrew@aj.id.au> From: Arnd Bergmann Date: Fri, 9 Apr 2021 09:55:53 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 16/21] ipmi: kcs_bmc: Add a "raw" character device interface To: Andrew Jeffery Cc: openipmi-developer@lists.sourceforge.net, OpenBMC Maillist , Corey Minyard , Joel Stanley , Ryan Chen , DTML , Tomer Maimon , linux-aspeed , "open list:GPIO SUBSYSTEM" , Avi Fishman , Patrick Venture , Linus Walleij , Linux Kernel Mailing List , Tali Perry , Rob Herring , Lee Jones , chiawei_wang@aspeedtech.com, Linux ARM , Benjamin Fair X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_085613_662516_782E6ECC X-CRM114-Status: GOOD ( 12.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 19, 2021 at 7:31 AM Andrew Jeffery wrote: > > The existing IPMI chardev encodes IPMI behaviours as the name suggests. > However, KCS devices are useful beyond IPMI (or keyboards), as they > provide a means to generate IRQs and exchange arbitrary data between a > BMC and its host system. I only noticed the series after Joel asked about the DT changes on the arm side. One question though: How does this related to the drivers/input/serio/ framework that also talks to the keyboard controller for things that are not keyboards? Are these separate communication channels on adjacent I/O ports, or does there need to be some arbitration? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel