From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-f195.google.com ([209.85.216.195]:37261 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967369AbeCAKKT (ORCPT ); Thu, 1 Mar 2018 05:10:19 -0500 Received: by mail-qt0-f195.google.com with SMTP id r16so6805330qtm.4 for ; Thu, 01 Mar 2018 02:10:19 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <877eqwqfml.fsf@kamboji.qca.qualcomm.com> References: <1518685448-15317-1-git-send-email-govinds@codeaurora.org> <877eqwqfml.fsf@kamboji.qca.qualcomm.com> From: Arnd Bergmann Date: Thu, 1 Mar 2018 11:10:18 +0100 Message-ID: (sfid-20180301_111050_939622_72366107) Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target To: Kalle Valo Cc: Govind Singh , ath10k@lists.infradead.org, linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Mar 1, 2018 at 11:01 AM, Kalle Valo wrote: > Govind Singh writes: > >> When an IOMMU device is available on the platform bus, allocate >> an IOMMU domain and attach the wlan target to it. >> WCN3990 target can then attach an DMA I/O virtual address >> space to scan out of bound transactions. >> >> Signed-off-by: Govind Singh >> --- >> drivers/net/wireless/ath/ath10k/snoc.c | 100 ++++++++++++++++++++++++++++++++- >> drivers/net/wireless/ath/ath10k/snoc.h | 3 + >> 2 files changed, 101 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c >> index cd21b25..502263d 100644 >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -26,6 +26,10 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include > > Kbuild bot reported a problem with arm64 but strangely I cannot find the > full report. Anyway, this was the warning: > > drivers/net/wireless/ath/ath10k/snoc.c:29:10: fatal error: > asm/dma-iommu.h: No such file or directory > > Any ideas? Adding also Arnd, the grand master of compilation problems :) > > Full patch here: > > https://patchwork.kernel.org/patch/10220719/ > The asm/dma-iommu.h header file exsists only on arm32, no other architecture. I'm not sure about the purpose of the patch to start with: it's normally up to the platform code to allocate IOMMU domains, device drivers should only need to manually interact with the IOMMU layer if they need more than one domain, but this ath10k patch appears to be using the default domain and should have no effect as long as the platform code works correctly. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1erLAU-0007wn-7U for ath10k@lists.infradead.org; Thu, 01 Mar 2018 10:11:45 +0000 Received: by mail-qt0-x242.google.com with SMTP id l25so6827469qtj.1 for ; Thu, 01 Mar 2018 02:10:19 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <877eqwqfml.fsf@kamboji.qca.qualcomm.com> References: <1518685448-15317-1-git-send-email-govinds@codeaurora.org> <877eqwqfml.fsf@kamboji.qca.qualcomm.com> From: Arnd Bergmann Date: Thu, 1 Mar 2018 11:10:18 +0100 Message-ID: Subject: Re: [PATCH] ath10k: Enable IOMMU support for WCN3990 target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Govind Singh , linux-wireless , ath10k@lists.infradead.org On Thu, Mar 1, 2018 at 11:01 AM, Kalle Valo wrote: > Govind Singh writes: > >> When an IOMMU device is available on the platform bus, allocate >> an IOMMU domain and attach the wlan target to it. >> WCN3990 target can then attach an DMA I/O virtual address >> space to scan out of bound transactions. >> >> Signed-off-by: Govind Singh >> --- >> drivers/net/wireless/ath/ath10k/snoc.c | 100 ++++++++++++++++++++++++++++++++- >> drivers/net/wireless/ath/ath10k/snoc.h | 3 + >> 2 files changed, 101 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c >> index cd21b25..502263d 100644 >> --- a/drivers/net/wireless/ath/ath10k/snoc.c >> +++ b/drivers/net/wireless/ath/ath10k/snoc.c >> @@ -26,6 +26,10 @@ >> #include >> #include >> #include >> +#include >> +#include >> +#include > > Kbuild bot reported a problem with arm64 but strangely I cannot find the > full report. Anyway, this was the warning: > > drivers/net/wireless/ath/ath10k/snoc.c:29:10: fatal error: > asm/dma-iommu.h: No such file or directory > > Any ideas? Adding also Arnd, the grand master of compilation problems :) > > Full patch here: > > https://patchwork.kernel.org/patch/10220719/ > The asm/dma-iommu.h header file exsists only on arm32, no other architecture. I'm not sure about the purpose of the patch to start with: it's normally up to the platform code to allocate IOMMU domains, device drivers should only need to manually interact with the IOMMU layer if they need more than one domain, but this ath10k patch appears to be using the default domain and should have no effect as long as the platform code works correctly. Arnd _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k