From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FDAC43334 for ; Tue, 19 Jul 2022 07:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235331AbiGSHqY (ORCPT ); Tue, 19 Jul 2022 03:46:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232085AbiGSHqU (ORCPT ); Tue, 19 Jul 2022 03:46:20 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E9CF22532; Tue, 19 Jul 2022 00:46:18 -0700 (PDT) Received: from mail-yw1-f180.google.com ([209.85.128.180]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mg6i8-1napXy1zRe-00hiJM; Tue, 19 Jul 2022 09:46:16 +0200 Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-31dfe25bd49so94755227b3.2; Tue, 19 Jul 2022 00:46:15 -0700 (PDT) X-Gm-Message-State: AJIora9xv1V6445pTlUMk3XevKq+sssi4rBtfZ5xUI19oFcCyBlG5LwA ok/pgLbdjDKVyjLmVdS8kLyaiMYNI95J3y2VLXM= X-Google-Smtp-Source: AGRyM1uMUiVIGFjzA5TwWJRveS7h+exlQBS7bP6K2zksjYwuZuF4ih7u9nFVzpOHSizyHdxkqT+sJR2F1c3sqVPvIcs= X-Received: by 2002:a81:1914:0:b0:31c:e12a:f33a with SMTP id 20-20020a811914000000b0031ce12af33amr34887188ywz.209.1658216774978; Tue, 19 Jul 2022 00:46:14 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 09:45:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:6Wsbwu5+/Md0neanrtNmqGmxxhxkKwehWq/5AFSS6561YGKDWOK 4yVOQr1uiPyk1OHWow5WyiqTvdgIK9bNlys0oZYmNPMc1Rly77q7t2qYUjOqpfqvZ7zodfe PUq4E21derg05mubU0FVuW4Zmi+H5cz5qKJue1BELa8Abt2Z5OAt9cF/Mfmx4I7SjskMvXL YSMWCTYchqAdUmFydJW/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:M3/Ty2MYcKw=:c8NLiwITQfbvzv1FCRulYV oQLMLSCrI5sQ4Z679DdOtXgYLTkCAHJejxlX34vfPmXZQTdWoIDwGYKYJq710r5usU3G8pwOo KjM0+zZzwQImCBzOinuPaCuhTybjmTOPcF+TE/0L4qgp55LEbKiQtPkmR1WOhssXpPueKEtsB C3xcLdGp29jaGrkxyJBaeOr63GN6UlZCfpG/fiylkdNJh4UZr3rWBh+9BeGNuXtVRVaFMLcla YpFkvD/9gS11xfOcgSrYHtoDZzDKhIiWlVn9buQzqfvSnypwK84DFN1y2FLsDiprVkWRs2gEH bgaNVVW2Pax0M8uJegUh9Mk1WpoyttJUeWHXP7qYx6HMqr8Z5hUbTXZM4A6a25hb3kozK2rM2 W4beARS5KzBV9WvBxAQxzYLCW2+xWabxZI1tWbFuZzc4sVYQ3l3NwelqhFCsosPQE/2zKrguN V0L7CNgc471nHFZLeV0M+c4ZOvHuV0MpiRlKJZ3tIYujmxkF0A26OBMixhR7yjHeJJFw3KLsR g5yncPe89L4lDvvIa68HK9+Wmg5R4g5jLA9wOT3iuPvE5jHHdaJx/FX1lRcGMoyFzbDQr1nOl RmaR+gLo3zhbWIZkqEbFo4MaaAMrOBauWaEpBZPEeNtVDPjRRhLGPDVAlRGhhn/5TvWq40UOD S+8wbv06+6S+kDZvz6euq6T8CkhWgMLqm1gauv8unWFFWjmLi7E0J+W0RWS48TjK+FcOdNe2j xoblL9+s8p6MLjuePejwzEi/kj7GHZMxWkHK4Lx89FMs/USETjWKE+RTaYDdQ4i//it03j4LB ZmnEMO6PJ63PJaIL4QvR5WPk8h/PQXjeKE8Iu5HTc07a1MHKdnQhh/6nhRhafi1UgxfjHtw69 1boV4xNM3HG+Vll82jCQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: >> >> As mentioned before, it would be even better to just remove it >> entirely from everything except x86, and enclose the four >> references in an explicit "#ifdef X86_32". The variable declaration >> only exists because drivers/pci/quirks.c is compiled on all >> architecture, but the individual quirk is only active based on >> the PCI device ID of certain early PCI-ISA bridges. > > > Ok, I was thinking of that route but once I saw the pci device IDs I > wasn't so sure it was limited to x86. I'll go ahead with that approach. Ok, thanks! I checked all the PCI IDs yesterday, and I'm fairly sure they are x86 specific. While some related products are general-purpose PCI-ISA bridges that have shown up on mips or arm boards, the ones listed here should all be safe. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B67BAC433EF for ; Tue, 19 Jul 2022 07:46:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3tlvnCdCiOpsmiPjLPiUuXwkhjeSYHnI6Cv1arZ7ubg=; b=2y+f2E6ogZpYHM qjtfqncrLKmzSvA+jUiTBi6LPuDVDe3N5UKYKtRv+ExGsl0Zm59h1kB1pKMaCkmURpqIrMXDGsa8A pxyzqI6rN6YhGhCa5uEjpiZR5bdqyTIFs0kdYwiPc0U8c6XgIRZrycq59Zr6A3D0WnrkPCatzyE2g dt22r1h6oXQNYTplHnBF/JvnfcIAer/iSnCNDiB9UXQyFNb+vXsda+xz3DVfdi8Pg7XziHkHaYqNW xPq3VdrzaGd+9AbPterBsVxHeNzas0UDMaMcqfuYdueYxCV4uA7ikaIaAyzAqedIunoIYlqUc4RCh oinlXIRlYd73pcJiB/XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDhwB-0062q8-0o; Tue, 19 Jul 2022 07:46:35 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDhvx-0062jr-P0; Tue, 19 Jul 2022 07:46:24 +0000 Received: from mail-yw1-f169.google.com ([209.85.128.169]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N8XHV-1nRdX60aYb-014Soz; Tue, 19 Jul 2022 09:46:17 +0200 Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-31c89653790so131734347b3.13; Tue, 19 Jul 2022 00:46:15 -0700 (PDT) X-Gm-Message-State: AJIora8yI/t1hSJ/OxZ7EpQfcerTRveEuwA7lKB2yqYLI8EWo4Zwz4HN TnLtJVrLNCU0PPJPsK/x3yDWHat2fN1w078RvKg= X-Google-Smtp-Source: AGRyM1uMUiVIGFjzA5TwWJRveS7h+exlQBS7bP6K2zksjYwuZuF4ih7u9nFVzpOHSizyHdxkqT+sJR2F1c3sqVPvIcs= X-Received: by 2002:a81:1914:0:b0:31c:e12a:f33a with SMTP id 20-20020a811914000000b0031ce12af33amr34887188ywz.209.1658216774978; Tue, 19 Jul 2022 00:46:14 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 09:45:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch X-Provags-ID: V03:K1:7giq/taAA80iDrRGeytiiycaOr+J7mwbln189QJA9Qxq3gFQWEC 5gGUSjlIu6CChqNtO/DirykqQztIS9O2xl+ga8P10jgKyVApL9o6UWlani3z7xrIYtkjiJ3 OcFb+Y0WeUIGX20bcUtGI1cqNNgJukLrDh8BZa6/e+FyYCZm4TAYCYpYugTkVC67KxBLMJK jb5S8qNrkrGiGdBkGXMXA== X-UI-Out-Filterresults: notjunk:1;V03:K0:4DaNf5TPFPQ=:heulTc26qqL2SFjOnCwxUx jrP5IlWTvmv4h29w9pJtRj2zHyU3/hHGyI4mZOkEZj8+Bok0iRUzUXGaETR5jKgsJ7NqmqAId z1X4z60cO8XZDLHMsoE72OrNj0P6bIHh7Bg9Opsqa/DuJACVAvxs+A7qiwZGQiR+PgMWMK2hH CKNiT5ENJAOT3FINZd3GUU1YzSlxM7iKJDL/JBFX/WIi1Kuiwsa3dyfAOd2XNVXP5eMFJAHwh Z2na2rDjkI1EDkCPa+NBRk6SC22niuCLCFAeYErxeDNDyYQnNZYj80CPwwLi7ZHJsepoD12Qp yZ+j2VK6mdnmuBhiGBbbDEKt/ZtQnqup57eIBNeKBdqGFlBpQCm9L6XqB4aCY1JWs7Nkl96nO XXoJU8XzprHgNhLhBkxT3LLubUZj17X6W/Fq9k+uWwN9bpCSleKgE0BGUvhLnuecsDMAncRhq yJIA/ENGwxHCxf5skL810HjHHlAcHjpIGDPGbptXAA6r3bcPAHh0GGrLWZPOX6OEcNqF1+jCf My9jM9O2F3vw4gHwpS94wnZCTiTJ667+UWechoww9ZwVh7lmI77SvSRD189P+c3HALSs/LbhM baWyObkB0JKKgRSWObcKqYcIlKZMAKrDg1XznGeBFCS1EmBtwNAtDa3O9SoH4ExjTiqU1kYXn a8rlGR8mKAR18EAoFuvCw4aJpcvpawWWMAQIUtf/+CBuSO2/llYkBe0a1hEIZMnZGINEmQOLa /m3QzYBykurOZ7B1foR+32kPgn+L9xgBcsfYhFNRcywW5jDsK8tUg8PTzQQyxSwbu+K+FuMZp yOfQbc6C9gAA+ZqfGonxdr5PZxKbNFyuGYqX7aNkjYK7Nbil6Tv0LuhJ2ir1gJW5wOOJD5952 LaW2j8/HUZQFLQPxyPfW41N9baRN7p9Hlsyvca/G4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_004622_151997_23BD9B1D X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: >> >> As mentioned before, it would be even better to just remove it >> entirely from everything except x86, and enclose the four >> references in an explicit "#ifdef X86_32". The variable declaration >> only exists because drivers/pci/quirks.c is compiled on all >> architecture, but the individual quirk is only active based on >> the PCI device ID of certain early PCI-ISA bridges. > > > Ok, I was thinking of that route but once I saw the pci device IDs I > wasn't so sure it was limited to x86. I'll go ahead with that approach. Ok, thanks! I checked all the PCI IDs yesterday, and I'm fairly sure they are x86 specific. While some related products are general-purpose PCI-ISA bridges that have shown up on mips or arm boards, the ones listed here should all be safe. Arnd _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AA6AC43334 for ; Tue, 19 Jul 2022 07:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0FGF4+rDZLy1d2E9S6WB+Wgedlb/kKN7Z2wum9wsa/0=; b=z9S7BoK5cegxoj R1BFSoVlTZ+ONW+dVYKYvmSeY+2E5+Vk0Wq5KSefRWteY7fsmeeFLqF5SJ9d3vuZ2ZaWHS/Tcr12+ NHtPGRQyBIlBo22r8Q8taNxaP2VdZXfcr2iz2vk1aoYhKNI9BoedAkRm1/w53jaBG7kRUJf7t2eHz d1x+/C826DVvXwqXtEhqg5+DhNwYA2GlatR1ZgGPCWEIPBtbklD7C03Ol+rscIaMvCBRRDRkY1Hfi ZeEtymn5HqUarTahTHEAkops6EjXiQlYUpUXud/5p+WmrUJX5nfoZNWrQPvQsobQt6XY0rWVxzzBA N+zcdmy7uEOG9kPgp5Lg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDhw3-0062nQ-9b; Tue, 19 Jul 2022 07:46:27 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDhvx-0062jr-P0; Tue, 19 Jul 2022 07:46:24 +0000 Received: from mail-yw1-f169.google.com ([209.85.128.169]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N8XHV-1nRdX60aYb-014Soz; Tue, 19 Jul 2022 09:46:17 +0200 Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-31c89653790so131734347b3.13; Tue, 19 Jul 2022 00:46:15 -0700 (PDT) X-Gm-Message-State: AJIora8yI/t1hSJ/OxZ7EpQfcerTRveEuwA7lKB2yqYLI8EWo4Zwz4HN TnLtJVrLNCU0PPJPsK/x3yDWHat2fN1w078RvKg= X-Google-Smtp-Source: AGRyM1uMUiVIGFjzA5TwWJRveS7h+exlQBS7bP6K2zksjYwuZuF4ih7u9nFVzpOHSizyHdxkqT+sJR2F1c3sqVPvIcs= X-Received: by 2002:a81:1914:0:b0:31c:e12a:f33a with SMTP id 20-20020a811914000000b0031ce12af33amr34887188ywz.209.1658216774978; Tue, 19 Jul 2022 00:46:14 -0700 (PDT) MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 09:45:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch X-Provags-ID: V03:K1:7giq/taAA80iDrRGeytiiycaOr+J7mwbln189QJA9Qxq3gFQWEC 5gGUSjlIu6CChqNtO/DirykqQztIS9O2xl+ga8P10jgKyVApL9o6UWlani3z7xrIYtkjiJ3 OcFb+Y0WeUIGX20bcUtGI1cqNNgJukLrDh8BZa6/e+FyYCZm4TAYCYpYugTkVC67KxBLMJK jb5S8qNrkrGiGdBkGXMXA== X-UI-Out-Filterresults: notjunk:1;V03:K0:4DaNf5TPFPQ=:heulTc26qqL2SFjOnCwxUx jrP5IlWTvmv4h29w9pJtRj2zHyU3/hHGyI4mZOkEZj8+Bok0iRUzUXGaETR5jKgsJ7NqmqAId z1X4z60cO8XZDLHMsoE72OrNj0P6bIHh7Bg9Opsqa/DuJACVAvxs+A7qiwZGQiR+PgMWMK2hH CKNiT5ENJAOT3FINZd3GUU1YzSlxM7iKJDL/JBFX/WIi1Kuiwsa3dyfAOd2XNVXP5eMFJAHwh Z2na2rDjkI1EDkCPa+NBRk6SC22niuCLCFAeYErxeDNDyYQnNZYj80CPwwLi7ZHJsepoD12Qp yZ+j2VK6mdnmuBhiGBbbDEKt/ZtQnqup57eIBNeKBdqGFlBpQCm9L6XqB4aCY1JWs7Nkl96nO XXoJU8XzprHgNhLhBkxT3LLubUZj17X6W/Fq9k+uWwN9bpCSleKgE0BGUvhLnuecsDMAncRhq yJIA/ENGwxHCxf5skL810HjHHlAcHjpIGDPGbptXAA6r3bcPAHh0GGrLWZPOX6OEcNqF1+jCf My9jM9O2F3vw4gHwpS94wnZCTiTJ667+UWechoww9ZwVh7lmI77SvSRD189P+c3HALSs/LbhM baWyObkB0JKKgRSWObcKqYcIlKZMAKrDg1XznGeBFCS1EmBtwNAtDa3O9SoH4ExjTiqU1kYXn a8rlGR8mKAR18EAoFuvCw4aJpcvpawWWMAQIUtf/+CBuSO2/llYkBe0a1hEIZMnZGINEmQOLa /m3QzYBykurOZ7B1foR+32kPgn+L9xgBcsfYhFNRcywW5jDsK8tUg8PTzQQyxSwbu+K+FuMZp yOfQbc6C9gAA+ZqfGonxdr5PZxKbNFyuGYqX7aNkjYK7Nbil6Tv0LuhJ2ir1gJW5wOOJD5952 LaW2j8/HUZQFLQPxyPfW41N9baRN7p9Hlsyvca/G4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220719_004622_151997_23BD9B1D X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: >> >> As mentioned before, it would be even better to just remove it >> entirely from everything except x86, and enclose the four >> references in an explicit "#ifdef X86_32". The variable declaration >> only exists because drivers/pci/quirks.c is compiled on all >> architecture, but the individual quirk is only active based on >> the PCI device ID of certain early PCI-ISA bridges. > > > Ok, I was thinking of that route but once I saw the pci device IDs I > wasn't so sure it was limited to x86. I'll go ahead with that approach. Ok, thanks! I checked all the PCI IDs yesterday, and I'm fairly sure they are x86 specific. While some related products are general-purpose PCI-ISA bridges that have shown up on mips or arm boards, the ones listed here should all be safe. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 References: <20220717033453.2896843-1-shorne@gmail.com> <20220717033453.2896843-3-shorne@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 19 Jul 2022 09:45:58 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] asm-generic: Add new pci.h and use it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Stafford Horne Cc: Arnd Bergmann , Christoph Hellwig , LKML , Catalin Marinas , Will Deacon , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Richard Weinberger , Anton Ivanov , Johannes Berg , Bjorn Helgaas , Linux ARM , linux-csky@vger.kernel.org, linux-riscv , linux-um , linux-pci , linux-arch On Tue, Jul 19, 2022 at 1:19 AM Stafford Horne wrote: > On Mon, Jul 18, 2022, 3:56 PM Arnd Bergmann wrote: >> >> As mentioned before, it would be even better to just remove it >> entirely from everything except x86, and enclose the four >> references in an explicit "#ifdef X86_32". The variable declaration >> only exists because drivers/pci/quirks.c is compiled on all >> architecture, but the individual quirk is only active based on >> the PCI device ID of certain early PCI-ISA bridges. > > > Ok, I was thinking of that route but once I saw the pci device IDs I > wasn't so sure it was limited to x86. I'll go ahead with that approach. Ok, thanks! I checked all the PCI IDs yesterday, and I'm fairly sure they are x86 specific. While some related products are general-purpose PCI-ISA bridges that have shown up on mips or arm boards, the ones listed here should all be safe. Arnd _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um