From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A28FC43219 for ; Tue, 26 Jan 2021 19:13:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81D1622EBD for ; Tue, 26 Jan 2021 19:13:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728866AbhAZFzQ (ORCPT ); Tue, 26 Jan 2021 00:55:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:57582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729708AbhAYOmU (ORCPT ); Mon, 25 Jan 2021 09:42:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4EF632151B; Mon, 25 Jan 2021 14:38:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611585504; bh=dKASY5gYt7wu7ypbIVbzvYFsutHeIkgRRS4d6AHPgZM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ctMiaYdPSdQST1yuDBkNjUZzTN5ZXtpU+jPNgU7RNQUN5qPU7PvKyQ3hsJz9ybFSn 7zjXEXhcMgH+mK3cimXX+jJMtoMqveFvUE8KY0uRCxr3e3k+MkRmyXBTFZa4Qhr+H7 Ljot7n5VNTSDsB1yai7R2z4IytFw2zo+1C71EEG9TbovblsRjDfblpuEjAPkHVT86R OMq8yE+F0bZX6idrQPoqH4QKTS58q64a1MK6mS6qPxAYexFJ8f3Jaum+wZSzB9WuMy uR5fT6HKNFAVP+b6G2Upl3llnEo8fbtGDR4MpAwxLcJYsLr5ge+rKr/Q9Nm/BE3SPX UBfmPuR0yVdjw== Received: by mail-ot1-f48.google.com with SMTP id f6so12895141ots.9; Mon, 25 Jan 2021 06:38:24 -0800 (PST) X-Gm-Message-State: AOAM530+3LAuqZaqHE3sEGhDpSkh6L2yq+nt0UTCSS+d//jWT7IwHwUO 5dV4Qcy0rhf5iSSlyvVTP5vgq+sjAcwri/Gzlao= X-Google-Smtp-Source: ABdhPJy3yKLSrYt9jUlyr1APJcIFI+0p/ceH9eu86GDAWpte4vsT+j8IcsxYMvm2Rk6P2vnIXbCwiICnO/24bPPgePk= X-Received: by 2002:a9d:741a:: with SMTP id n26mr662146otk.210.1611585503621; Mon, 25 Jan 2021 06:38:23 -0800 (PST) MIME-Version: 1.0 References: <20210125113654.2408057-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 25 Jan 2021 15:38:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ath9k: fix build error with LEDS_CLASS=m To: Krzysztof Kozlowski Cc: QCA ath9k Development , Kalle Valo , "David S. Miller" , Jakub Kicinski , Johannes Berg , Arnd Bergmann , Masahiro Yamada , Flavio Suligoi , linux-wireless , Networking , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Jan 25, 2021 at 2:27 PM Krzysztof Kozlowski wrote: > On Mon, 25 Jan 2021 at 14:09, Arnd Bergmann wrote: > > On Mon, Jan 25, 2021 at 12:40 PM Krzysztof Kozlowski wrote: > > > On Mon, 25 Jan 2021 at 12:36, Arnd Bergmann wrote: > > > But we do not want to have this dependency (selecting MAC80211_LEDS). > > > I fixed this problem here: > > > https://lore.kernel.org/lkml/20201227143034.1134829-1-krzk@kernel.org/ > > > Maybe let's take this approach? > > > > Generally speaking, I don't like to have a device driver specific Kconfig > > setting 'select' a subsystem', for two reasons: > > > > - you suddenly get asked for tons of new LED specific options when > > enabling seemingly benign options > > > > - Mixing 'depends on' and 'select' leads to bugs with circular > > dependencies that usually require turning some other 'select' > > into 'depends on'. > > > > The problem with LEDS_CLASS in particular is that there is a mix of drivers > > using one vs the other roughly 50:50. > > Yes, you are right, I also don't like it. However it was like this > before my commit so I am not introducing a new issue. The point is > that in your choice the MAC80211_LEDS will be selected if LEDS_CLASS > is present, which is exactly what I was trying to fix/remove. My WiFi > dongle does not have a LED and it causes a periodic (every second) > event. However I still have LEDS_CLASS for other LEDS in the system. What is the effect of this lost event every second? If it causes some runtime warning or other problem, then neither of our fixes would solve it completely, because someone with a distro kernel would see the same issue when they have the symbol enabled but no physical LED in the device. Arnd