From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754963AbdCaNhh (ORCPT ); Fri, 31 Mar 2017 09:37:37 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:32837 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754661AbdCaNhf (ORCPT ); Fri, 31 Mar 2017 09:37:35 -0400 MIME-Version: 1.0 In-Reply-To: <871stqc1ps.fsf@intel.com> References: <20170320215713.3086140-1-arnd@arndb.de> <877f3javde.fsf@intel.com> <20170321103302.fnrt4tnze46grmdi@phenom.ffwll.local> <871stqc1ps.fsf@intel.com> From: Arnd Bergmann Date: Fri, 31 Mar 2017 15:37:33 +0200 X-Google-Sender-Auth: y0zoC4NUh1--si5kJ4aII22SMbo Message-ID: Subject: Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro To: Jani Nikula Cc: Daniel Vetter , Ander Conselvan de Oliveira , David Airlie , Linux Kernel Mailing List , dri-devel , Daniel Vetter , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 21, 2017 at 12:23 PM, Jani Nikula wrote: > On Tue, 21 Mar 2017, Daniel Vetter wrote: >> On Tue, Mar 21, 2017 at 09:44:07AM +0100, Arnd Bergmann wrote: > Arnd, can you check that with kasan please? (I don't have gcc 7.) For me > the size diff against current git is > > text data bss dec hex filename > -1137236 31211 2948 1171395 11dfc3 drivers/gpu/drm/i915/i915.ko > +1139702 31211 2948 1173861 11e965 drivers/gpu/drm/i915/i915.ko Sorry for the late reply. I was rather sure that I had done the numbers and replied to you earlier, but I see no evidence of that, so here it comes again, using gcc-7 and kasan: text data bss dec hex filename 2623339 511153 12064 3146556 30033c obj-x86/drivers/gpu/drm/i915/i915-original.o 2634886 511153 12064 3158103 303057 obj-x86/drivers/gpu/drm/i915/i915-linux-next.o 2617989 520561 12064 3150614 301316 obj-x86/drivers/gpu/drm/i915/i915-arndpatch.o The first one is linux-next with ce64645d86ac ("drm/i915: use variadic macros and arrays to choose port/pipe based registers") reverted, the second one is the current version, and the third is with my patch applied on top. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [Intel-gfx] [PATCH] drm/i915: use static const array for PICK macro Date: Fri, 31 Mar 2017 15:37:33 +0200 Message-ID: References: <20170320215713.3086140-1-arnd@arndb.de> <877f3javde.fsf@intel.com> <20170321103302.fnrt4tnze46grmdi@phenom.ffwll.local> <871stqc1ps.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <871stqc1ps.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: Ander Conselvan de Oliveira , intel-gfx@lists.freedesktop.org, Linux Kernel Mailing List , dri-devel , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBNYXIgMjEsIDIwMTcgYXQgMTI6MjMgUE0sIEphbmkgTmlrdWxhCjxqYW5pLm5pa3Vs YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IE9uIFR1ZSwgMjEgTWFyIDIwMTcsIERhbmllbCBW ZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4+IE9uIFR1ZSwgTWFyIDIxLCAyMDE3IGF0 IDA5OjQ0OjA3QU0gKzAxMDAsIEFybmQgQmVyZ21hbm4gd3JvdGU6Cj4gQXJuZCwgY2FuIHlvdSBj aGVjayB0aGF0IHdpdGgga2FzYW4gcGxlYXNlPyAoSSBkb24ndCBoYXZlIGdjYyA3LikgRm9yIG1l Cj4gdGhlIHNpemUgZGlmZiBhZ2FpbnN0IGN1cnJlbnQgZ2l0IGlzCj4KPiAgICAgdGV4dCAgICAg ICAgICAgZGF0YSAgICAgYnNzICAgICBkZWMgICAgIGhleCBmaWxlbmFtZQo+IC0xMTM3MjM2ICAg ICAgICAgIDMxMjExICAgIDI5NDggMTE3MTM5NSAgMTFkZmMzIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTUua28KPiArMTEzOTcwMiAgICAgICAgICAzMTIxMSAgICAyOTQ4IDExNzM4NjEgIDExZTk2 NSBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1LmtvCgpTb3JyeSBmb3IgdGhlIGxhdGUgcmVwbHku CgpJIHdhcyByYXRoZXIgc3VyZSB0aGF0IEkgaGFkIGRvbmUgdGhlIG51bWJlcnMgYW5kIHJlcGxp ZWQgdG8geW91IGVhcmxpZXIsIGJ1dApJIHNlZSBubyBldmlkZW5jZSBvZiB0aGF0LCBzbyBoZXJl IGl0IGNvbWVzIGFnYWluLCB1c2luZyBnY2MtNyBhbmQga2FzYW46CgogICB0ZXh0ICAgZGF0YSAg ICBic3MgICAgZGVjICAgIGhleCBmaWxlbmFtZQoyNjIzMzM5IDUxMTE1MyAgMTIwNjQgMzE0NjU1 NiAzMDAzM2MKb2JqLXg4Ni9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1LW9yaWdpbmFsLm8KMjYz NDg4NiA1MTExNTMgIDEyMDY0IDMxNTgxMDMgMzAzMDU3Cm9iai14ODYvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNS1saW51eC1uZXh0Lm8KMjYxNzk4OSA1MjA1NjEgIDEyMDY0IDMxNTA2MTQgMzAx MzE2Cm9iai14ODYvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNS1hcm5kcGF0Y2gubwoKVGhlIGZp cnN0IG9uZSBpcyBsaW51eC1uZXh0IHdpdGggY2U2NDY0NWQ4NmFjICgiZHJtL2k5MTU6IHVzZSB2 YXJpYWRpYyBtYWNyb3MKYW5kIGFycmF5cyB0byBjaG9vc2UgcG9ydC9waXBlIGJhc2VkIHJlZ2lz dGVycyIpIHJldmVydGVkLCB0aGUgc2Vjb25kIG9uZSBpcwp0aGUgY3VycmVudCB2ZXJzaW9uLCBh bmQgdGhlIHRoaXJkIGlzIHdpdGggbXkgcGF0Y2ggYXBwbGllZCBvbiB0b3AuCgogICAgICAgQXJu ZApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK