From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) Date: Tue, 7 Jan 2020 18:10:07 +0100 Message-ID: References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , open list:SYNOPSYS ARC ARC List-Id: linux-arch.vger.kernel.org On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C53C33C8C for ; Tue, 7 Jan 2020 17:32:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58AF9208C4 for ; Tue, 7 Jan 2020 17:32:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58AF9208C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47sfbH13rgzDqSZ for ; Wed, 8 Jan 2020 04:32:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.126.133; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47sf5g13S1zDqLt for ; Wed, 8 Jan 2020 04:10:30 +1100 (AEDT) Received: from mail-qv1-f48.google.com ([209.85.219.48]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MuluN-1jgQQj34eR-00rrKe for ; Tue, 07 Jan 2020 18:10:26 +0100 Received: by mail-qv1-f48.google.com with SMTP id l14so145129qvu.12 for ; Tue, 07 Jan 2020 09:10:25 -0800 (PST) X-Gm-Message-State: APjAAAW4ndDpsrzrsL2xekmjRVlCD/zJo4QFERKtBh6tio3ZCm+MRnEQ nRwCnEXO5y0KxRhzvLONdK9iNvOp6cHkg3GnGJk= X-Google-Smtp-Source: APXvYqxwO5AyDQus85+IK5BIt7KfSsh7NvpnQb9bzWV5OgyrFYMfLh14xqWUd9CW/X7TSfP34I+W9RVMaa5KUvf/Vb8= X-Received: by 2002:a0c:bd20:: with SMTP id m32mr365813qvg.197.1578417023930; Tue, 07 Jan 2020 09:10:23 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:10:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:rLgxK+XwwobzkJ6cqUjcXz1KHRkqvZ4JN+MqFY1h21G5DKpM7dK TfuCp50JOgPGf+gug4ujWdjksmQ4IzVBxbzmct57VVAC0PH866GcQ8FQRnoQALgx8NB4ofT HT4+1QY025ZWGbrQcCtBQSKTjDbZDat63M/DJ0tzAj02zX4ExIDdPFCDRkvry9k2bQ/eez6 /Vvjw6r4WWuPLsS3Z6RAw== X-UI-Out-Filterresults: notjunk:1;V03:K0:YC0wLCCEUj4=:LaK9vXcuk6Yd3BRtn02e1A kfIUWV2d00nuJYiJaFIWgRuaUjJzg7JqYh5ZLLB1hnJa0nGC0gYS3bu84hgpqfvT3OPKXr/fc TFnVKxxe9x/vC4whlQ3iUH7rKx/wzt9xo/UtGCSxQtmsML6Q42kgw8ysUNy9AUBUnppUiLuwR kZ6hrxh4A5iXowSY30YhtU13DaAjFgOF3rqBETCtD0WhBLIbQZko1hrwKhP2ysuHTSohT9RJH T5Uf4f8bfVmEpSuSJVtbGv3Hf2SSuw7Nl/K6CoQcnNTGPS5/q4sVb2kxufB0GYcCBoQgNwy2l coY9dQZcE//CNprOnYO4Vy0Dwh8O+bnf+mdr8ByiGfwZA0iu1RNWH3FrkGN+nlnRs9W5Dc+5e 2jctSfUIk5lgL5vZ8uYda7/TAMQEv4HmUuGjMGG24gAW35KNqPB+YnT/DCVyPg2kA9YqzIV7g CNivu9xjcoIvSEbWPfe0zbIpxNiWwy6pwLOvLZCqZoHmlD+lrhznzss56ofieexdXUDHaz+Hm /I/9t3r7hOL5A9gUTZBajdfUM70i1m0ZDNW4NAXXQMyzR2/ZAfGXTa8TrYSu7D9PWvYHPEp2n 7Fc7o8Kx34rOUIvvEqeYTZCyjmXntsg8pcr4LJLC3ITbgjvDHgvJznkZ8dWVh8C3I457ZLdVH xnHtV29VmFPnGwXy8qiy63AzJCBnOZ7GFzTdj//5zaI3DI1r3cNS5RVYxmc2qmhmQFSPjceZZ gH/Fbd4ddiZBOtRGyCJL8BYVLaD5fDpYFgdfgwkU4tYDc5Jsy8cvq2jOY7wxh59JCgy7bkqAJ Q6ZEMicSO4EPi0yyWXbaeUnOhg0NrBbQRWKd6lXAbPpKnHk7xlbXhNDIhNkhpn12JWUZBs8fp SnJP9aCvkpaKUhgDQzzw== X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918C8C33C8C for ; Tue, 7 Jan 2020 17:10:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63C3F2087F for ; Tue, 7 Jan 2020 17:10:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j48R9WgY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63C3F2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7jB21wHIaF2UKykeAtVNwK8p0W8ZqxzlFeii9qZhE8Y=; b=j48R9WgYP210Dd gRHyQXFPf7BlYEVDm9ARHgYk2jkr8PpxqgN0YWIh2CdgpMfu8o9oEKB8549v5+JOr0onxHjYL/wzI q3bBTv/c1gSR3QxE9CmMUgxTiSFtnA2c44UrMyP9mxWmHUp/dSLYWo+SI5QBhwdbDHSG2k8R5y9gL YYzU+qEKQZyDzR4TS537A0YjyAbYQOyvIzVUP7JHY2f9CWHo/SzZ5sQuDPL08rH6mkeg/aP64t7j2 0M8unr1t8sdKLgyFomNby0BYJbYOQMkhwgGFbef4X2MSkWq0cczAhIjX5nhoCnCvZEiGzjKBt+mfC 4LHGyhK0d26uF2YbCong==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iosNE-0000eM-DL; Tue, 07 Jan 2020 17:10:32 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iosNB-0000dV-Ok for linux-snps-arc@lists.infradead.org; Tue, 07 Jan 2020 17:10:31 +0000 Received: from mail-pl1-f176.google.com ([209.85.214.176]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N0nzR-1jaMh545OH-00wjb2 for ; Tue, 07 Jan 2020 18:10:27 +0100 Received: by mail-pl1-f176.google.com with SMTP id s21so20703135plr.7 for ; Tue, 07 Jan 2020 09:10:26 -0800 (PST) X-Gm-Message-State: APjAAAV5MuSGohk1SJidsja11QjTjVeKiUA0VPMTD84gA/jmDwQVUwQX MBoGrSstYfWP2DElGs5sepkSpSckcjPlHYZ0VqE= X-Google-Smtp-Source: APXvYqxwO5AyDQus85+IK5BIt7KfSsh7NvpnQb9bzWV5OgyrFYMfLh14xqWUd9CW/X7TSfP34I+W9RVMaa5KUvf/Vb8= X-Received: by 2002:a0c:bd20:: with SMTP id m32mr365813qvg.197.1578417023930; Tue, 07 Jan 2020 09:10:23 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:10:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:UG9L9JYgggbtFmaRVl+zrBp7VWsjXZvC6v+Q77a6n+0DwWBHA/i MLR+uWeZB4pMIjlQ1My6lO8QPcKbZWJDt2F1s5LnyTePos6A2PLY+zqzNkAyQz474j7bYCy nwU31xKKMTuxV0mf/LxP8t9P9Qo3Q9KzdB+5ilG9cCICqqTmzrSGT1U6mn2Zdlvta0tjnPj NRDIXizvALokta/cpG+pA== X-UI-Out-Filterresults: notjunk:1;V03:K0:96cKG32r+UU=:cIp+WxFcRGMmzXpx7NnFeU n2Mm98lyE587cWANtYK5bFpYZqxBKJkOKUoS3eowo10f8pnURch/KW3o26p3GifIQvCShnxJY jrzuuRnoyBH8gZHHIVsyDUVAkFVg2GLCv4XoGXkDBUcLG8E6EV53PqnGz9sPx97LM6uWtwwVa 0ZMicGb4Rft0HkH4MmhLa0XzdxL7QvUHrrq3f1fGLzrTtVsdSLsECsRVFkyk38w357F4ddBsc /Y2joF0++/CrtHE5LMtzgBZLYN7hc7o+krSyEDyroK1WFmjaUHs+9zvEeH5apVIT4ajKx3/Dd CE5zOdj+MXMNt1PQlqTtCXciu632VbsAWT5vEZp03dSPo5UlcdliZzlmR9UpxbMobi1xYZ1K3 NcXp78Y0V8Tzcl1hlId1bdaA79ufsCU0503KJNWDImpkFTzzQz0bAywqvNpt5iQ1E3o5rJjIF 4EkY/9LTn7+xRy6PDeAsEyHaOA5o6XKjYbebctJQh569Zu4eR+YewmMFf0eMMQKljk8gqvhUL KLLbHOlWpbG9+Vslf99VMpmj6qcpvMknQ+kOKB9uJZI9sOmz9K2Dua8bn9jR1rzY7PE29PDQK pHgcEeG7X3dcxXzJpGvxz8e8/IqMQcWlwpW1otg5Kt0MwNSm+Q6JipJBWts6hd8Hi2g+EAQfq 7pxIGU20iR8v6jPXcoo+BeGUvRPOp+5eAMV5oNeWu5nxYFfdRenoT1QmEXTeyJBI1eKN236kT WnkNYEko6LSBOFQL7jLb0pk+ODhqhWUWeacoir1XN3nljA0oihE99uloIGc/M7rrmdhWWPzgT dyCBR2biiwEpuMmC5O2DAs23t7L1m9T53ce6MyzPcuoqddxfiKK6grh3I/ZFWdxlcmTMYxQk6 UrtSpsSYfLbE67UCzE/w== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200107_091030_092679_348571CB X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Benjamin Herrenschmidt , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Daniel Vetter , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 903D6C33C8C for ; Tue, 7 Jan 2020 17:10:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 703472087F for ; Tue, 7 Jan 2020 17:10:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 703472087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB67489A98; Tue, 7 Jan 2020 17:10:29 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2558A89A98 for ; Tue, 7 Jan 2020 17:10:27 +0000 (UTC) Received: from mail-vs1-f42.google.com ([209.85.217.42]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MsqIi-1jhnLO0rvc-00t9uU; Tue, 07 Jan 2020 18:10:26 +0100 Received: by mail-vs1-f42.google.com with SMTP id v12so34354252vsv.5; Tue, 07 Jan 2020 09:10:25 -0800 (PST) X-Gm-Message-State: APjAAAXcFBPJhtnAplKjHRRjLF/K5QxJWJcXvXVymcNej2rvrXx/X0fi wVBu6JhvdAX+IlcD7MXeTvFjRIiiBGm7+ru0Wro= X-Google-Smtp-Source: APXvYqxwO5AyDQus85+IK5BIt7KfSsh7NvpnQb9bzWV5OgyrFYMfLh14xqWUd9CW/X7TSfP34I+W9RVMaa5KUvf/Vb8= X-Received: by 2002:a0c:bd20:: with SMTP id m32mr365813qvg.197.1578417023930; Tue, 07 Jan 2020 09:10:23 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:10:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:Wl3I5GL8oTuHF4B8uEWhwYLx8r7xgnH4MKtioAfPmsSS/JrPJvU TG6HFiwedNhpJ6mUOPialIISyutXK5Oog/2XhTpT6MaFdcte+//iRG9NyuQ4EvkOr6NYUOc J/U6C4PJ9yfOSIlagB1J0hniPJ5IBQawFd6F2t/LJUu/jofOwL6F3R/nXWUi4BUreCwiRWa dSsT0RysLpw37gzjP3tQQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:gODU33sDVPA=:/qq9hxY92f6xRXIe6UUSpT UJs5Y2vXH8WbG3KwflD/hI49fxCV+zNT+KJCf637LM9D6HT1vYyRB3fsns+siEnzXIPPY4nrv +8WisqYq0pl21yDZOR0kgNJ6UTQLE1kCsk9bhPYj+KpntYYdEUfpHWKTfgcJzOREfGYOzvSAP ZWujHMVhB9cyzMJ4oGgh/0/07jZzdtvJchVNvrs9HWQ8sd3TM58alJ9cO14M+WAUZJC8Ehjny Yol1XXcgXtZ/dTfbwaZ8qmdz79OC9PT3Tsvb9VlUWNaL14mSVNYaQePRz8JjbJdqvkwdJV4W4 AcWeQFalRb/23mXnn74g1XXP5EZifpNJKXxrekTpDUl+D44d8yemxxoVVA7DtF+iuTtUUsRpf wVyoSRmMWMG7VvB+9Dt7TfeNOydXCuCSGQpRv+jitlu0rlE0BMatzPM6agKWGUtyYqM60ulPX fb0saQxiHbByuHKwkMsc+CBOklRl8sav2m6QGrrtNBC034tHiwZ7YuUhfUGekmnPRBRF5vZ1N buLsuvmFUvpRkZ7Pjj0kzPdZEHsHG9rcZSejOmzbfxlNTEvuAHWkSBOE3kVrtRj6C92V9zPr2 jtxKkfyln5hu4WtkntnityEUcMueAA6r5YxaFXT2FIqf+u1NF9e/+FddSuagRsv6siDAKHsTO sHtbPEJBMKs80FYoXuLCrugfi20GB66c4bwjuPFsqnVW5SlsA7bpYZyzEua/+XOYcF9MMtRQd McvJC1tZGA+F2/9iCdV8DisnjiDkSA2ckpKXv6aQzhh43a54Dxz1xxKuHbIm0/Wlea6xe1OI+ tMJjz0BuFTJA6RDVPDhdz2BTD35JLL4tPkzAgzzDU22xf+aUFm9mb81FTJWUDKc94YvqFsrp2 LNb/n8abEIkT4v/ZisZg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de (mout.kundenserver.de. [217.72.192.73]) by gmr-mx.google.com with ESMTPS id 68si9784lfi.3.2020.01.07.09.10.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2020 09:10:26 -0800 (PST) Received: from mail-vs1-f49.google.com ([209.85.217.49]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MZkxd-1jAcOk3RwN-00Wlsd for ; Tue, 07 Jan 2020 18:10:26 +0100 Received: by mail-vs1-f49.google.com with SMTP id t12so34332864vso.13 for ; Tue, 07 Jan 2020 09:10:25 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-9-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-9-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:10:07 +0100 Message-ID: Subject: Re: [RFT 06/13] arc: Constify ioreadX() iomem argument (as in generic implementation) Content-Type: text/plain; charset="UTF-8" To: Krzysztof Kozlowski Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Kalle Valo , "David S. Miller" , Dave Jiang , Jon Mason , Allen Hubbe , "Michael S. Tsirkin" , Jason Wang , Andrew Morton , Thomas Gleixner , Geert Uytterhoeven , alpha , "linux-kernel@vger.kernel.org" , "open list:SYNOPSYS ARC ARCHITECTURE" , Parisc List , linuxppc-dev , Linux-sh list , dri-devel , ML nouveau , Linux Media Mailing List , linux-wireless , Networking , linux-ntb@googlegroups.com, virtualization@lists.linux-foundation.org, linux-arch List-ID: On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the > address so they can be converted to a "const" version for const-safety > and consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks correct, but I would not bother here, as it has no effect on the compiler or its output. Arnd