From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D1FC6778D for ; Wed, 12 Sep 2018 16:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B8362088E for ; Wed, 12 Sep 2018 16:20:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B8362088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbeILV0I (ORCPT ); Wed, 12 Sep 2018 17:26:08 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:38801 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727859AbeILV0I (ORCPT ); Wed, 12 Sep 2018 17:26:08 -0400 Received: by mail-qt0-f194.google.com with SMTP id x7-v6so2437650qtk.5; Wed, 12 Sep 2018 09:20:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HzSXajEIOEAaegylvrBHpi2RO12+N/sCEe0XRLpt528=; b=eWCwNRZ6vrAmpFL51vZU673oD0bRSugwvvdlT5e0/l3Pv2qI7knvDubb+nrhxVQn6u 82M7OnpLT1l/CZp86DR6UoPst/5vRKfKE5Z4pECgUQ66hgd6jl0pRRTyh1+lmIS1XBip DWyKtv+mzLiD9ijfK+ncH3zXZmRyi6SElncTPaJAp3GT9OzuTsT/97fpllrJdTjH/pgh 8hO+Wn52cWAOCtp8EPJtOx40JOMb9Z0xv0eqqc2GdESPQXqGV5av0OA3ymQHG+zY761A b1fCf4z/dpzrGXRIkFYPRR4fslDf/bZkvGyayHBP2Zn6MDG6ztt2xWpG0dDxasB8tVAN Jo/g== X-Gm-Message-State: APzg51C2+FGJ0a0ufaTG7b7E49aY8FotaS6TOgY248B+gP5Qvb+Zl71f ZSuVqb6XjizwO/DjjRBMKccj7WyqidFmJwOFHkU= X-Google-Smtp-Source: ANB0VdayHXt5KVr1v4xZIQXSVvZNkxzM/lkNiLSy16ce7jG/bLRjxMb2RRGes8TjE1wUZG2bwbThZHKkfWuSPrlYH3I= X-Received: by 2002:a0c:885b:: with SMTP id 27-v6mr2115395qvm.115.1536769251572; Wed, 12 Sep 2018 09:20:51 -0700 (PDT) MIME-Version: 1.0 References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> <20180912153300.GE5633@ziepe.ca> In-Reply-To: <20180912153300.GE5633@ziepe.ca> From: Arnd Bergmann Date: Wed, 12 Sep 2018 18:20:34 +0200 Message-ID: Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg To: Jason Gunthorpe Cc: Al Viro , Linux FS-devel Mailing List , Sudip Mukherjee , gregkh , Peter Huewe , Jarkko Sakkinen , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , "Winkler, Tomas" , Artem Bityutskiy , Marek Vasut , David Miller , Alex Williamson , OGAWA Hirofumi , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, linux1394-devel@lists.sourceforge.net, USB list , "open list:HID CORE LAYER" , linux-mtd , Networking , driverdevel , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe wrote: > > On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. > > > > We now have a generic implementation of that, so use it. > > > > For vtpm: > > Reviewed-by: Jason Gunthorpe > > Arnd, would you consider including a patch as part of/after this > series to make compat_ioctl in drivers/infiniband/core/uverbs_main.c > use this as well? Looks like a bug too? That should be included in patch 5 in this series. I may have skipped some Cc there since it had too many recipients (sent only to the mailing lists instead). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Date: Wed, 12 Sep 2018 18:20:34 +0200 Message-ID: References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> <20180912153300.GE5633@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Al Viro , Linux FS-devel Mailing List , Sudip Mukherjee , gregkh , Peter Huewe , Jarkko Sakkinen , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , "Winkler, Tomas" , Artem Bityutskiy , Marek Vasut , David Miller , Alex Williamson , OGAWA Hirofumi , Linux Kernel Mailing List , linux To: Jason Gunthorpe Return-path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:38801 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727859AbeILV0I (ORCPT ); Wed, 12 Sep 2018 17:26:08 -0400 In-Reply-To: <20180912153300.GE5633@ziepe.ca> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe wrote: > > On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. > > > > We now have a generic implementation of that, so use it. > > > > For vtpm: > > Reviewed-by: Jason Gunthorpe > > Arnd, would you consider including a patch as part of/after this > series to make compat_ioctl in drivers/infiniband/core/uverbs_main.c > use this as well? Looks like a bug too? That should be included in patch 5 in this series. I may have skipped some Cc there since it had too many recipients (sent only to the mailing lists instead). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Date: Wed, 12 Sep 2018 18:20:34 +0200 Message-ID: References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> <20180912153300.GE5633@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180912153300.GE5633@ziepe.ca> Sender: netdev-owner@vger.kernel.org To: Jason Gunthorpe Cc: Al Viro , Linux FS-devel Mailing List , Sudip Mukherjee , gregkh , Peter Huewe , Jarkko Sakkinen , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , "Winkler, Tomas" , Artem Bityutskiy , Marek Vasut , David Miller , Alex Williamson , OGAWA Hirofumi , Linux Kernel Mailing List linux List-Id: linux-input@vger.kernel.org On Wed, Sep 12, 2018 at 5:33 PM Jason Gunthorpe wrote: > > On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. > > > > We now have a generic implementation of that, so use it. > > > > For vtpm: > > Reviewed-by: Jason Gunthorpe > > Arnd, would you consider including a patch as part of/after this > series to make compat_ioctl in drivers/infiniband/core/uverbs_main.c > use this as well? Looks like a bug too? That should be included in patch 5 in this series. I may have skipped some Cc there since it had too many recipients (sent only to the mailing lists instead). Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg From: Arnd Bergmann Message-Id: Date: Wed, 12 Sep 2018 18:20:34 +0200 To: Jason Gunthorpe Cc: Al Viro , Linux FS-devel Mailing List , Sudip Mukherjee , gregkh , Peter Huewe , Jarkko Sakkinen , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , "Winkler, Tomas" , Artem Bityutskiy , Marek Vasut , David Miller , Alex Williamson , OGAWA Hirofumi , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, linux1394-devel@lists.sourceforge.net, USB list , "open list:HID CORE LAYER" , linux-mtd , Networking , driverdevel , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: T24gV2VkLCBTZXAgMTIsIDIwMTggYXQgNTozMyBQTSBKYXNvbiBHdW50aG9ycGUgPGpnZ0B6aWVw ZS5jYT4gd3JvdGU6Cj4KPiBPbiBXZWQsIFNlcCAxMiwgMjAxOCBhdCAwNTowMTowM1BNICswMjAw LCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ID4gRWFjaCBvZiB0aGVzZSBkcml2ZXJzIGhhcyBhIGNv cHkgb2YgdGhlIHNhbWUgdHJpdmlhbCBoZWxwZXIgZnVuY3Rpb24gdG8KPiA+IGNvbnZlcnQgdGhl IHBvaW50ZXIgYXJndW1lbnQgYW5kIHRoZW4gY2FsbCB0aGUgbmF0aXZlIGlvY3RsIGhhbmRsZXIu Cj4gPgo+ID4gV2Ugbm93IGhhdmUgYSBnZW5lcmljIGltcGxlbWVudGF0aW9uIG9mIHRoYXQsIHNv IHVzZSBpdC4KPiA+Cj4KPiBGb3IgdnRwbToKPgo+IFJldmlld2VkLWJ5OiBKYXNvbiBHdW50aG9y cGUgPGpnZ0BtZWxsYW5veC5jb20+Cj4KPiBBcm5kLCB3b3VsZCB5b3UgY29uc2lkZXIgaW5jbHVk aW5nIGEgcGF0Y2ggYXMgcGFydCBvZi9hZnRlciB0aGlzCj4gc2VyaWVzIHRvIG1ha2UgY29tcGF0 X2lvY3RsIGluIGRyaXZlcnMvaW5maW5pYmFuZC9jb3JlL3V2ZXJic19tYWluLmMKPiB1c2UgdGhp cyBhcyB3ZWxsPyAgTG9va3MgbGlrZSBhIGJ1ZyB0b28/CgpUaGF0IHNob3VsZCBiZSBpbmNsdWRl ZCBpbiBwYXRjaCA1IGluIHRoaXMgc2VyaWVzLiBJIG1heSBoYXZlIHNraXBwZWQKc29tZSBDYyB0 aGVyZSBzaW5jZSBpdCBoYWQgdG9vIG1hbnkgcmVjaXBpZW50cyAoc2VudCBvbmx5IHRvIHRoZQpt YWlsaW5nIGxpc3RzIGluc3RlYWQpLgoKICAgICAgICBBcm5kCg==