From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC38C3A5A3 for ; Tue, 27 Aug 2019 14:15:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 817E521872 for ; Tue, 27 Aug 2019 14:15:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726333AbfH0OPM (ORCPT ); Tue, 27 Aug 2019 10:15:12 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:34013 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfH0OPM (ORCPT ); Tue, 27 Aug 2019 10:15:12 -0400 Received: by mail-lj1-f196.google.com with SMTP id x18so18662088ljh.1; Tue, 27 Aug 2019 07:15:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KfeseVQWz48HAsLr5kcHWdtkdT6kJKG3U+x7h2FYyGM=; b=aOGBqq4Z85flFdMhhFl9AvnbOfU7QDOmEVBPnoX21w4aDGd0QjB01vrR0GhSwtmw1L dhb+Qa3SnEUgASCKtYNN3kRj9hV6w0R6o2tDd6/MxnXn6QZaKe/QbqKr85uzZ5w/u7bK KJMCJz8JASMbf8OyuOzrMXrdIRoO+Co4Pty/fBQZrYb8EhY7HXsktEUDWLh5OcirFdMh t01hzebLjzQVXg42WVcByA9x4z1Sb4nBlnohhoW66ooWM+JyFUzZWGpAwO3hHIj6tbok N5GbLjUaLhs68IOPk6ciZc3cZfMOt2EWaC7EuV7MAdcybjrP3cnmZpsdCwHT+5Z4i8+v 8gog== X-Gm-Message-State: APjAAAXYirbHHlrkRAL+Iyc5m62UrRLjMBQiIdVa5Q0UJ5e4JfDWNju4 7P+bfJDedfXEGPiVKhg+rvBHofBOzIY4wxZL6Y8= X-Google-Smtp-Source: APXvYqynbPEMJ5NJosXQEn553TI+EwJm9qEyttNHdgRx0B6Cd7hXJqH69rtOKEoglJrjQ9eC04IA7D0x4NcOdaJK7k0= X-Received: by 2002:a2e:980d:: with SMTP id a13mr14098210ljj.145.1566915310400; Tue, 27 Aug 2019 07:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20190822192451.5983-1-scott.branden@broadcom.com> <20190822192451.5983-7-scott.branden@broadcom.com> In-Reply-To: <20190822192451.5983-7-scott.branden@broadcom.com> From: Arnd Bergmann Date: Tue, 27 Aug 2019 16:14:54 +0200 Message-ID: Subject: Re: [PATCH 6/7] misc: bcm-vk: add Broadcom Valkyrie driver To: Scott Branden Cc: Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , Bjorn Andersson , Shuah Khan , "Rafael J . Wysocki" , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Linux FS-devel Mailing List , BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , "open list:KERNEL SELFTEST FRAMEWORK" , Desmond Yan , James Hu , Linux Media Mailing List , dri-devel Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Aug 22, 2019 at 9:25 PM Scott Branden wrote: > > Add Broadcom Valkyrie driver offload engine. > This driver interfaces to the Valkyrie PCIe offload engine to perform > should offload functions as video transcoding on multiple streams > in parallel. Valkyrie device is booted from files loaded using > request_firmware_into_buf mechanism. After booted card status is updated > and messages can then be sent to the card. > Such messages contain scatter gather list of addresses > to pull data from the host to perform operations on. > > Signed-off-by: Scott Branden > Signed-off-by: Desmond Yan > Signed-off-by: James Hu Can you explain the decision to make this is a standalone misc driver rather than hooking into the existing framework in drivers/media? There is an existing interface that looks like it could fit the hardware in include/media/v4l2-mem2mem.h. Have you considered using that? There is also support for video transcoding using GPUs in driver/gpu/drm/, that could also be used in theory, though it sounds like a less optimal fit. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 6/7] misc: bcm-vk: add Broadcom Valkyrie driver Date: Tue, 27 Aug 2019 16:14:54 +0200 Message-ID: References: <20190822192451.5983-1-scott.branden@broadcom.com> <20190822192451.5983-7-scott.branden@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190822192451.5983-7-scott.branden@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org To: Scott Branden Cc: Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , Bjorn Andersson , Shuah Khan , "Rafael J . Wysocki" , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Linux FS-devel Mailing List , BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 22, 2019 at 9:25 PM Scott Branden wrote: > > Add Broadcom Valkyrie driver offload engine. > This driver interfaces to the Valkyrie PCIe offload engine to perform > should offload functions as video transcoding on multiple streams > in parallel. Valkyrie device is booted from files loaded using > request_firmware_into_buf mechanism. After booted card status is updated > and messages can then be sent to the card. > Such messages contain scatter gather list of addresses > to pull data from the host to perform operations on. > > Signed-off-by: Scott Branden > Signed-off-by: Desmond Yan > Signed-off-by: James Hu Can you explain the decision to make this is a standalone misc driver rather than hooking into the existing framework in drivers/media? There is an existing interface that looks like it could fit the hardware in include/media/v4l2-mem2mem.h. Have you considered using that? There is also support for video transcoding using GPUs in driver/gpu/drm/, that could also be used in theory, though it sounds like a less optimal fit. Arnd