From: Arnd Bergmann <arnd@arndb.de>
To: Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH] checksyscalls: ignore -Wunused-macros
Date: Mon, 25 Apr 2022 10:49:36 +0200 [thread overview]
Message-ID: <CAK8P3a1_XoyjOPQ0ghku_QUjUL5V6BK9kSNUXoQj2RYaA=JxFg@mail.gmail.com> (raw)
In-Reply-To: <CAMZ6RqL8G4uVn--Y5pBC+_c9Ex3Sjf8OJuVRwkVFFPwWd_ezLQ@mail.gmail.com>
On Mon, Apr 25, 2022 at 9:42 AM Vincent MAILHOL
<mailhol.vincent@wanadoo.fr> wrote:
> On Mon. 25 Apr 2022 at 15:50, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Mon, Apr 25, 2022 at 8:17 AM Vincent MAILHOL> <mailhol.vincent@wanadoo.fr> wrote:
> > > When I run W=2, I want to only see the warnings of the file I am
> > > working on. So I find it useful to fix the W=2 warnings which
> > > show up when building other files to not get spammed by
> > > irrelevant issues and to simplify the triage.
> > >
> > > My initial message lacked the rationale. I will add additional
> > > explanations in the v2 of this patch.
> >
> > I agree this is worth fixing if we want to make W=2 have any meaning at all.
> >
> > Your approach is probably fine. We could try to improve this by comparing
> > against the list from include/uapi/asm-generic/unistd.h instead of the i386
> > list. I suppose that would involve rewriting the script into a simpler one,
> > but I'm not sure if anyone has an interest in working on this.
>
> If someone wants to do it, great, but I do not have the
> confidence to do it myself so I hope you will forgive me for
> taking a pass here.
Sure, no worries.
> Another alternative I considered was to only call
> checksyscalls.sh when doing a 'make all'. This way, we keep the
> warning but people won’t be spammed when building sub projects
> because the script would not be executed.
Right, I like that as well, one less thing to be done for every
iterative make as well. The syscall table really doesn't change
all that much that this needs to be run by most developers.
Arnd
next prev parent reply other threads:[~2022-04-25 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 15:17 [PATCH] checksyscalls: ignore -Wunused-macros Vincent Mailhol
2022-04-24 22:17 ` Nathan Chancellor
2022-04-25 6:17 ` Vincent MAILHOL
2022-04-25 6:50 ` Arnd Bergmann
2022-04-25 7:42 ` Vincent MAILHOL
2022-04-25 8:49 ` Arnd Bergmann [this message]
2022-04-26 15:57 ` Vincent MAILHOL
2022-04-29 17:02 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1_XoyjOPQ0ghku_QUjUL5V6BK9kSNUXoQj2RYaA=JxFg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mailhol.vincent@wanadoo.fr \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.