From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A19C4320A for ; Fri, 30 Jul 2021 16:55:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AC856054E for ; Fri, 30 Jul 2021 16:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbhG3Qz0 (ORCPT ); Fri, 30 Jul 2021 12:55:26 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:56521 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbhG3QzY (ORCPT ); Fri, 30 Jul 2021 12:55:24 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MxHLs-1n77cc1pTE-00xbBO; Fri, 30 Jul 2021 18:55:18 +0200 Received: by mail-wr1-f45.google.com with SMTP id h14so12087408wrx.10; Fri, 30 Jul 2021 09:55:18 -0700 (PDT) X-Gm-Message-State: AOAM531x36drL025206zfhSfsIdVNUVYtXIIdwh7tJXRkoxahAE6fFFe 5pch65HRs5BPODEUF4YRSt9avNT68PPACJ16s+4= X-Google-Smtp-Source: ABdhPJx8pRQBP+fRbShwuYvNiG34iB85ht3PkP357n80b2tOp0dc7/DUvny3sNOHPUMU7TLnQH+oHIK/GgO7nACZa6s= X-Received: by 2002:adf:f446:: with SMTP id f6mr4206493wrp.361.1627664118110; Fri, 30 Jul 2021 09:55:18 -0700 (PDT) MIME-Version: 1.0 References: <20210730134552.853350-1-bert@biot.com> <20210730134552.853350-5-bert@biot.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 30 Jul 2021 18:55:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC To: John Crispin Cc: Arnd Bergmann , Bert Vermeulen , DTML , Linux Kernel Mailing List , Linux ARM , Russell King , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Anshuman Khandual , Krzysztof Kozlowski , Ard Biesheuvel , YiFei Zhu , Mike Rapoport , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Nick Desaulniers , Kees Cook , Masahiro Yamada , Nathan Chancellor , Viresh Kumar , Felix Fietkau , Matthias Brugger Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Djm3HiGtPborGwABFKLa69C29V921SpSOe07xLTEUvN1ltcib6i oU/7+2bli17JFsiITTU2UsrQHCJmRtJnoY+9zlZktzDif2QGD2dXiaFyoWQmdkMc4Yn9dvz qq63H6S93Jzyzu4jS+tuYMPvIOpvPsrkTlP1ul+Z4mbsqZFt0YYJs53i4gPmF95zUdLdOsO Oz61d1ljFEleqlOSPbCNg== X-UI-Out-Filterresults: notjunk:1;V03:K0:gKgZSZRph+M=:9190HjctsZ8ZsfU/3fz5Zy XcLcDmqmyjFh8xMVT/kyrd4nwiYHOx8vPve6q0MleNDzdMM3zW8jH6qQDS/Zhvk5/P90B717m 8kFR9YakEvKAdj3dgaYyC9mdwjVNYlfPa4fshumIOzV9Ng5huI/M+TEs7HOq5slDWgVfxdwK8 vXpsWTkOke/BxCuYubNJlk06DKhovUgZ0Oa27GP2Z8cbPTUd44le8YRnh8UiHJwKINUZYS/Dy 3qNeLeELScI8Mgxao9CWL3sQTTzwDxHrwcqvy/zWCCHEtu/GmzxGEZj2FLE17uD0s2TuPVkM/ M0Ammy4P3/4+zavBbnlh2+pJ6p+TUCWLq+AWUH7djVJJPFGzQVgnV3aumJB8M2vzmaSUgl3nQ WZAz9N6OEvs7Mx9rZ9M7awuPRSsyvLf4PzKKjalNIqjEV1OlsRFWRCLZSwgaH37uQnExogVfI +awAMCrZWXtldPs1yvMOXj5Vf+W+K42oLvAUibLTTxBqP5CDrau96Z/r0N2tDld244CP1NAq1 4Qnksqd3n9GwzDid+vUU1OhjFnyN4SG88yZ1kz4Q5dvC/hWbrmGKBJbm3j7EJ2Mdm89HUcGdP 7Y4X+TUEstGvKNz/xu1Qx16PS+72YrqzoWedbSEAAhL1hOB15Iy5tQxLCAqqSdU4CnldljMT1 Z8ezGMN7kEcA7PWFA1Z9Vha9m0KP2AF8t0Jlgy7pb55J7DoLVbHNuZA2CnaS1fyOBeGsdNH0A i5/ZyrWprd6QxAxQpvAGf6GKoySxNQiKN5VrJQ7VqCFvW9yA5w2pbmCGu00eBzPDxh4eaRSNR NVd9PswvNDIe8FKva1HPGIoociPuFQmH3wN47wvm6WSAT18B7Gl5bEahKAoRSIXceWA1Yb80k Ex++Yo6sRmjecHpjyFpxpBXefdBwXsVemgc7LICKM= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 30, 2021 at 5:16 PM John Crispin wrote: > On 30.07.21 16:48, Arnd Bergmann wrote: > > Given how closely related this probably is to MT7623/MT7622, should this > > perhaps just be part of arch/arm/mach-mediatek? According to > > https://wikidevi.wi-cat.ru/MediaTek#xPON, the older (mips based) MT752x > > chips are apparently just rebranded to EN752x after the business unit > > was spun off, but I guess they are still in the same family. > > Hi, > > ECNT (what was once known as trendchip) is now a subsidary of MTK (and > not a BU if I am understanding it correctly). > > the EN7523 is rather similar to the MT7622 for some parts, other parts > (spi, flash, wdt, gpio, .. drivers all needed to be rewritten and will > be part of the next series). > > the older MIPS silicon shares almost no IP with the current ARM silicon. Ah, so I guess the old Trendchip parts were separately developed separately from the Ralink parts before the original acquisition, and then Ralink/Mediatek combined the two product lines before spinning off the dsl products into a new subsidiary. > not really my call to decide which folder this should live in. it seemed > natural to just give it its own folder, as ECNT is not a BU of MTK. > > we can change that however if required. My preference would be to have a common directory for both, but I'm not going to require that. From the kernel perspective the main question is actually not who makes the parts but who is going to maintain the code. Matthias is doing a good job taking care of the Mediatek parts, and he's familiar with the arm-soc process. If there is enough overlap between the Mediatek and EcoNet devices that we would expect either conflicts between binding/driver patches, or that you would want each other to review the patches for related parts, then it would make most sense to have a common directory and maintainer entry for both, with all patches going through the same git tree. It would also be nice to have someone listed as second maintainer for mediatek, since Matthias is currently the only one listed there. (Doesn't have to be you, I don't mean to drag you into taking up more work if you don't want to). Please discuss this between the three of you (Bert, John and Matthias), and let me know what you think works best for all of you. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51EFFC4338F for ; Fri, 30 Jul 2021 16:57:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FE7860F01 for ; Fri, 30 Jul 2021 16:57:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FE7860F01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CeSymcIZkgIxfy9DWDFqPg0HzpTWllCQpjSoqwRyAfM=; b=Di0XUyH9SbRORK uSk05lFRmFWQ+XP5LLQb5wwk2N7+It5Fknv462fQD1WcHbdPvUf0Gt9XZ7aaBXcr3FankYObTLhyN +JtGeHDCz86mX+ATx1MLGM+FT34EtSdQenVq295lwcIEkO1AWD8Vo2ptQx9NvKVeWv7TlUj6VzFES NvYT4PFdiTEgo91qV6fa0E9edo12D/VhNS4+9ZeCTRFyTsGDCSpbepugOLjN2cKfJ4mMBjpb1dXxC QcvIg0lGkEzfh1FxtuuEgzsrPoEB6fEooxYlzI430Y6vYOsqXQV8MyMk4+8a81/EINqp+bjRctRTO 95H5pG4Mi+vMJVLC6h1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9VnG-009aH4-H6; Fri, 30 Jul 2021 16:55:30 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9VnA-009aDX-D8 for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 16:55:27 +0000 Received: from mail-wr1-f53.google.com ([209.85.221.53]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Ml72g-1mshMg2qrM-00lWsr for ; Fri, 30 Jul 2021 18:55:18 +0200 Received: by mail-wr1-f53.google.com with SMTP id r2so12167983wrl.1 for ; Fri, 30 Jul 2021 09:55:18 -0700 (PDT) X-Gm-Message-State: AOAM532uhs1gVt1Cpa7ffqBoDnNgjsVpyufpaMxu52awWprIN1wLwyo3 UAlCrG542JvS/90u5YKAv3jqZmr+b5TedobqTWc= X-Google-Smtp-Source: ABdhPJx8pRQBP+fRbShwuYvNiG34iB85ht3PkP357n80b2tOp0dc7/DUvny3sNOHPUMU7TLnQH+oHIK/GgO7nACZa6s= X-Received: by 2002:adf:f446:: with SMTP id f6mr4206493wrp.361.1627664118110; Fri, 30 Jul 2021 09:55:18 -0700 (PDT) MIME-Version: 1.0 References: <20210730134552.853350-1-bert@biot.com> <20210730134552.853350-5-bert@biot.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 30 Jul 2021 18:55:02 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC To: John Crispin Cc: Arnd Bergmann , Bert Vermeulen , DTML , Linux Kernel Mailing List , Linux ARM , Russell King , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Anshuman Khandual , Krzysztof Kozlowski , Ard Biesheuvel , YiFei Zhu , Mike Rapoport , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Nick Desaulniers , Kees Cook , Masahiro Yamada , Nathan Chancellor , Viresh Kumar , Felix Fietkau , Matthias Brugger X-Provags-ID: V03:K1:tAwZut9hRmys7Wa9aFgMP/U/Xg4NYhQOBSV1pSPV5lpv8fezW+R itMIZd6u5EoYbiltcudzN8fIa0t4sJ/YnxK7gDVvV2EUYY42pZsci8ZkOYKhbGWKdmfjMeg 2NVZKUe/SdBAZ0Hg2fA10EMV/wnegonesTeDkDFnO5cXSQmDrkH8mUoAH6bWywqi1Uk1P2W vIywnf6Ko4ChMz6HK69lg== X-UI-Out-Filterresults: notjunk:1;V03:K0:GXTEwtweUqo=:9CrsdIllGlKzZRZVpf9VAi /5JkBNDhM2sqZMtA046rjyUZgRli92xVupdlSxVARCe7++wdt2XR7pVXCbJzjpLQlEPmonIPh OnZTRXQNr9r7+77eBCAzz+6gVLZBpEFMwSXITBICRd0QT4OcVFDNuUQa74uY2naLX+IUyMqhG H3WqEcJSVAceYkyy2QLIgsFxHVljkgg822UcSvhqktL56+ihY0VxKwZhg9FyqHt4TxiJHkT98 5NadSadS4K809YOXtrzyrh//yxMnhX4chEaj06+Le74Fsvar5UF3ojPGk5z44bYI8CWHJu09e SrpsV/JiCNEt6sAd3SYAHsbFxWGCXaKW835kLks5BO6B1AX8RO7r1eNe2gGNlHVAZWqQXEZvI 7FQsFPCxgS7Ge0v2QLXE9iZTYl6syLpGZnEtYP+Op8+NUzStdy3QllzVtSG3DMkm3XzQhC/c5 fttfORdHPBEvmz3IlAAio54eKtg+7haFZrmxqMNSW6uCEwTKff4sG/Yr1IButfFq3gEIsGGwc A8upH2ms6YS/yHLJDPIf7ipOnk5XwQ6Fv7r29XdVyhAB6OT+2rmff8yI3iBXOOZRO947WDwbc rxc8WRpvHrJGAbp4BkDf+BEx3ZuRvYmYH1sxVEThQbqkNV/eb6UoHK40lcQNelJDKhkj+fzNE tZz+hgHLnE04r8U+4ZCE/VHZ6jRa7AoNdpcJoLvkCU/buf4RSfl15ejaJoa9zBaPhRMB5sZ2E iKFDzIKTLTJ3P47C7Zv8YmiYWkAvvYUG46VaO/gYpmJHomBnL7yOeDlvSoQYJTkx0XWOOyg7G Axng457ED487VT8cp3ieu3IM7BypVIyRKe6CXDKiPQ4LBwZ6pigkRLYiGMnf+sdl5OwilSymS /wgKDVUHz+ug5GsDbY7Ixd/oidfl9El5LHFA2PfIEh6U9ZfXBH7fPPL4cvjMAlXRxNSYA+DG1 iX4WVltIfTRq0riCmSKr06VQ3LxdpZBvItt0YHDETSVuCWPbfLjUz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_095524_784716_9067A274 X-CRM114-Status: GOOD ( 28.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 30, 2021 at 5:16 PM John Crispin wrote: > On 30.07.21 16:48, Arnd Bergmann wrote: > > Given how closely related this probably is to MT7623/MT7622, should this > > perhaps just be part of arch/arm/mach-mediatek? According to > > https://wikidevi.wi-cat.ru/MediaTek#xPON, the older (mips based) MT752x > > chips are apparently just rebranded to EN752x after the business unit > > was spun off, but I guess they are still in the same family. > > Hi, > > ECNT (what was once known as trendchip) is now a subsidary of MTK (and > not a BU if I am understanding it correctly). > > the EN7523 is rather similar to the MT7622 for some parts, other parts > (spi, flash, wdt, gpio, .. drivers all needed to be rewritten and will > be part of the next series). > > the older MIPS silicon shares almost no IP with the current ARM silicon. Ah, so I guess the old Trendchip parts were separately developed separately from the Ralink parts before the original acquisition, and then Ralink/Mediatek combined the two product lines before spinning off the dsl products into a new subsidiary. > not really my call to decide which folder this should live in. it seemed > natural to just give it its own folder, as ECNT is not a BU of MTK. > > we can change that however if required. My preference would be to have a common directory for both, but I'm not going to require that. From the kernel perspective the main question is actually not who makes the parts but who is going to maintain the code. Matthias is doing a good job taking care of the Mediatek parts, and he's familiar with the arm-soc process. If there is enough overlap between the Mediatek and EcoNet devices that we would expect either conflicts between binding/driver patches, or that you would want each other to review the patches for related parts, then it would make most sense to have a common directory and maintainer entry for both, with all patches going through the same git tree. It would also be nice to have someone listed as second maintainer for mediatek, since Matthias is currently the only one listed there. (Doesn't have to be you, I don't mean to drag you into taking up more work if you don't want to). Please discuss this between the three of you (Bert, John and Matthias), and let me know what you think works best for all of you. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel