From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDB6C3527C for ; Sat, 26 Mar 2022 19:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234648AbiCZTZl convert rfc822-to-8bit (ORCPT ); Sat, 26 Mar 2022 15:25:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233620AbiCZTZi (ORCPT ); Sat, 26 Mar 2022 15:25:38 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45D43207F; Sat, 26 Mar 2022 12:24:00 -0700 (PDT) Received: from mail-lf1-f49.google.com ([209.85.167.49]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MrhLu-1ntDVC3m0C-00nf9d; Sat, 26 Mar 2022 20:23:59 +0100 Received: by mail-lf1-f49.google.com with SMTP id p10so12670836lfa.12; Sat, 26 Mar 2022 12:23:58 -0700 (PDT) X-Gm-Message-State: AOAM533bmgyf9gtICHhD4uX3bpHPI/aYdc1Wjn6Ki5JXbMOATEGat/Y+ Gy1rG/hWj2yhVg3daMun/t2j8RkW6hPx3SLZkuY= X-Google-Smtp-Source: ABdhPJxx8NCR/u6qmXzG17FP9feBwegQPJsf9Aqi/l68ye4U4vfPlOZSED7ECKkFvKmT885cCFviGMxdRBsqoooKkLU= X-Received: by 2002:a5d:6505:0:b0:205:9a98:e184 with SMTP id x5-20020a5d6505000000b002059a98e184mr11258676wru.317.1648322627645; Sat, 26 Mar 2022 12:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20220326165909.506926-1-benni@stuerz.xyz> In-Reply-To: <20220326165909.506926-1-benni@stuerz.xyz> From: Arnd Bergmann Date: Sat, 26 Mar 2022 20:23:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers To: =?UTF-8?Q?Benjamin_St=C3=BCrz?= Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Russell King - ARM Linux , Simtec Linux Team , Krzysztof Kozlowski , Alim Akhtar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Robert Moore , "Rafael J. Wysocki" , Len Brown , Chas Williams <3chas3@gmail.com>, Harald Welte , Arnd Bergmann , gregkh , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Linus Walleij , Bartosz Golaszewski , mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, Jason Gunthorpe , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Dmitry Torokhov , Karsten Keil , Benjamin Herrenschmidt , Frederic Barrat , Andrew Donnellan , David Miller , Jakub Kicinski , pabeni@redhat.com, Nicolas Pitre , loic.poulain@linaro.org, kvalo@kernel.org, Pkshih , Bjorn Helgaas , Linux ARM , Linux Kernel Mailing List , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-ia64@vger.kernel.org, ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , linux-atm-general@lists.sourceforge.net, Networking , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-rdma , "open list:HID CORE LAYER" , linuxppc-dev , Linux Media Mailing List , wcn36xx@lists.infradead.org, linux-wireless , linux-pci Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:9figIUnCgtvaf/cKMq2S8Mrl7ngptWVGWjzOtUo3hOJ8JuZUqXf uGJHsYnWe/msKkwufx5cx8GjLMtmeUa4P0UGqi2U5Ehg8teMr5a6CVVLi/oFydUeqagKVDu 3Vvsy5IH4R2SidR4u3VseNYZpAa9Csqs9tqhrAAeU9/eoVB7bNuRhKsZXmCiVLDG5heinbb Fo2pPNQpCoAlPoGAryzUw== X-UI-Out-Filterresults: notjunk:1;V03:K0:RlqtZ8kYXZg=:weygU+7tyLUDVksTpjS8e5 HMK6a3RwJ4pP/DourG9N6pv/FKqMEGI+hY/rz9ZEkyBfPdVkwMhwkf75UAwHmKUqLiIJ4X16S fERCRgYWtzpSZo5S/1ir1vo+pLydwh5/vJoO4jjki7XDP0mVHb7VcMLUH2KMcATjZEQpBxP5/ Le8AXBRQbX0WX4mu1jAQQRUngcl6lVuJ1N0hdMcMMHSV1FjZjnUpBcy6TF8sTFzV/Ku2/DO86 XJGfxC0muugsEI3U+JUJGN+eBjFzkg6xS1u57ZMaauo4ALrhTdEi+PO7YxjVvscnqa1Pkx3bI 16XQ0Vt5urqXFfb7WPiNmvS0VF9EYpjL/2Xbi4Ygx4oMcluDFY7y/lgjRWqamPp5v6/mV5Joi hMFe6szOl0BsDPOXMuLdYmXUlkAnsFzL3m/3DhYUko5pP9kD4lRW6ea769aI3pTKOhWQ1/WhZ 2sBRqCre4vFTPxO7FLmbuDIDrgW8YS7mJfyh2dBxfL5qfG0KLCKLLuhoxy2PF86/ZpkzKkSSY TnWCjOoGCAe/Tp+NXlEZ0HKO2mTfVq/vc26d/9rCKENTUPCDGml73zyXYdOoOeXYI97YXlrHH 1/yZ+w9fQMQ4GVXmNtdmjsQTA6+8u8Mfj/oAsvjhc/7Du7Kx+nKd+VVT5m3SLPrK1qC+Oo9ns WO5HxobIpnBO2OVQOgap63NODBQtF5TxKHN5sX6NRJBG24d7dV5t3kW93fmrf+2QNq3W8hLTs xyTuMkuS7qKlerszk+X0tFneKJO4KuUui7P+wsIrahl5OwoahacsFleLfRqSV3i5DFizM/1rv k1jFyA4vTU3aAlFBb3cj/2kYzyHcjB0KWr8wUwgz2924c1/53s= Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz wrote: > > This replaces comments with C99's designated > initializers because the kernel supports them now. The change looks fine, but the comment looks misplaced, as enum initializers are not c99 feature. Also, the named array and struct intializers have been supported by gnu89 for a long time and widely used in the kernel, so it's not a recent change even for the others. Also, Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86AA5C433EF for ; Sun, 27 Mar 2022 02:05:43 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KQzgp1ttlz3bdh for ; Sun, 27 Mar 2022 13:05:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=arndb.de (client-ip=212.227.126.187; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KQrCQ12BRz2ynp for ; Sun, 27 Mar 2022 07:29:04 +1100 (AEDT) Received: from mail-lf1-f41.google.com ([209.85.167.41]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MsI4Q-1oMKZd2SpG-00tjJx for ; Sat, 26 Mar 2022 21:28:59 +0100 Received: by mail-lf1-f41.google.com with SMTP id d5so18688950lfj.9 for ; Sat, 26 Mar 2022 13:28:59 -0700 (PDT) X-Gm-Message-State: AOAM530Jgelks5j6QckBuDJsgKhzO0eMeSd9sPDfgjP/9CqX4kdFLthp shoHfqkHqaxQ+X+KqAu00MnwLXum3HiJBpBmvRg= X-Google-Smtp-Source: ABdhPJxx8NCR/u6qmXzG17FP9feBwegQPJsf9Aqi/l68ye4U4vfPlOZSED7ECKkFvKmT885cCFviGMxdRBsqoooKkLU= X-Received: by 2002:a5d:6505:0:b0:205:9a98:e184 with SMTP id x5-20020a5d6505000000b002059a98e184mr11258676wru.317.1648322627645; Sat, 26 Mar 2022 12:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20220326165909.506926-1-benni@stuerz.xyz> In-Reply-To: <20220326165909.506926-1-benni@stuerz.xyz> From: Arnd Bergmann Date: Sat, 26 Mar 2022 20:23:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers To: =?UTF-8?Q?Benjamin_St=C3=BCrz?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:F/Y26y5bAOzl7lj3bK5ZasFfkkjrxZ6e9+mJkGKfDKUMRBQ8dFY aFYxGQB3UMDpcKw836YpSCZWoKvnaYPCLOvpiZpELoxR/7z8uJGv+HRHVtojMsaRBUzCWV5 +q3/MzrPJ4Shr2DezKiZWeIipfFYVbcTH58QbDzOKZhd92FmcSEtzIJZ+/dqXB8cq0Pjvxu Hvc1AVyIPFh7iH94DflLA== X-UI-Out-Filterresults: notjunk:1;V03:K0:1sUMZCjJb8g=:xXHru0d1zDjgUmh3SpT6Nu lxdFGiEQv5nVDb4H532Q/Agx1u0sR0FItnOebfsNiCHx3w7mxhjw/LScjMPcZJO3vs4GLWIym CGMgDDI00IQO8xI/+nP5cq8ykdZoe8NUO/gHmfKSSvMMTfTskluJb1S/LrFT5ut/qD0i97GEY aWOr/bfdi8rfb9HUder2YNVCjCrD747LoLLdp5RY4SJNRcpdsga44fjEnfXKpX79kzBlJQ0nL Pk330izvjHs5CdTJUKbjsy/XTOECX5anF8Qk0Du6feJqifKYXDA0f9NdTA//vY70GRzdYltzW LdsCqPpIpA+07RGoJhhv3+DKLo9nlHXiAftPxCvtrpYlDi8iG0c1odcEKfDPBMcT6DHFzRBrV RjzaEk0+YMtCcU3WoMAUooSiHG+iNqudCbDDVOAm93+hOONNb5sJ26r/bw9WYGZp2cXymVhdy P+JLgJ2nnqbnD9NTHC0iy/Q/SxRjX62W2XeIYmSbQ1/91ADl+htlq/SoBF98VTm27GRxBHLoj 0X3BJDiloClfcbSHJYmeKFe0YjY1Qq1bYpqvQSneF0MsdDd8d9as/oOmsVBtL1rZQjVaoZkmc L+TZkwzoTLknaDFLTHJgsoUgDn+pb7VLUmqzRITuRDD6h91oHQPD3SxAqTXlYrjTwA7VJpCm7 lk/lmWTfKDSzCltNckwWfQqVYsmpfp/kOR4Ll0fA74QMATqxTHLRYoDWGpaeiabHiD2PvrsAi YFUMRLf9qQvTeCaT+TWrRuV2SWBz66RaQjFX5OSgoA07EIJlUpACgSl6e3NbedzCq4iIV0ImT S+w7Nkdt7LAnV4VS/JelDhRkNsv+gSE+N+RLPzdpH2GEWmtN4beoH5d+5Ax1xX7MmKOOQ42Gx HbnKusHwm78ejF9DTPCw== X-Mailman-Approved-At: Sun, 27 Mar 2022 13:03:21 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-atm-general@lists.sourceforge.net, linux-ia64@vger.kernel.org, Linus Walleij , Dave Hansen , linux-pci , Robert Moore , Harald Welte , Alim Akhtar , "H. Peter Anvin" , wcn36xx@lists.infradead.org, Pkshih , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , ACPI Devel Maling List , linux-edac@vger.kernel.org, dennis.dalessandro@cornelisnetworks.com, linux-rdma , Gregory CLEMENT , "Rafael J. Wysocki" , Russell King - ARM Linux , Krzysztof Kozlowski , Jason Gunthorpe , Ingo Molnar , Chas Williams <3chas3@gmail.com>, "open list:HID CORE LAYER" , Jakub Kicinski , pabeni@redhat.com, Len Brown , mike.marciniszyn@cornelisnetworks.com, Robert Richter , Andrew Donnellan , Arnd Bergmann , kvalo@kernel.org, linuxppc-dev , "open list:GPIO SUBSYSTEM" , loic.poulain@linaro.org, Borislav Petkov , Bjorn Helgaas , Thomas Gleixner , Mauro Carvalho Chehab , Linux Media Mailing List , Simtec Linux Team , Linux ARM , "open list:ACPI COMPONENT ARCHITECTURE \(ACPICA\)" , Karsten Keil , Tony Luck , Nicolas Pitre , gregkh , Dmitry Torokhov , linux-wireless , Linux Kernel Mailing List , David Miller , James Morse , Networking , Frederic Barrat , Sebastian Hesselbarth , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Bartosz Golaszewski Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Mar 26, 2022 at 5:58 PM Benjamin St=C3=BCrz wrot= e: > > This replaces comments with C99's designated > initializers because the kernel supports them now. The change looks fine, but the comment looks misplaced, as enum initializer= s are not c99 feature. Also, the named array and struct intializers have been supported by gnu89 for a long time and widely used in the kernel, so it's not a recent change even for the others. Also, Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Sat, 26 Mar 2022 19:23:31 +0000 Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers Message-Id: List-Id: References: <20220326165909.506926-1-benni@stuerz.xyz> In-Reply-To: <20220326165909.506926-1-benni@stuerz.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset="macroman" Content-Transfer-Encoding: base64 To: =?UTF-8?Q?Benjamin_St=C3=BCrz?= Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Russell King - ARM Linux , Simtec Linux Team , Krzysztof Kozlowski , Alim Akhtar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Robert Moore , "Rafael J. Wysocki" , Len Brown , Chas Williams <3chas3@gmail.com>, Harald Welte , Arnd Bergmann , gregkh , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Linus Walleij , Bartosz Golaszewski , mike.marciniszyn@cornelisnetworks.com, dennis.dalessandro@cornelisnetworks.com, Jason Gunthorpe , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Dmitry Torokhov , Karsten Keil , Benjamin Herrenschmidt , Frederic Barrat , Andrew Donnellan , David Miller , Jakub Kicinski , pabeni@redhat.com, Nicolas Pitre , loic.poulain@linaro.org, kvalo@kernel.org, Pkshih , Bjorn Helgaas , Linux ARM , Linux Kernel Mailing List , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-ia64@vger.kernel.org, ACPI Devel Maling List , "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" , linux-atm-general@lists.sourceforge.net, Networking , linux-edac@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-rdma , "open list:HID CORE LAYER" , linuxppc-dev , Linux Media Mailing List , wcn36xx@lists.infradead.org, linux-wireless , linux-pci T24gU2F0LCBNYXIgMjYsIDIwMjIgYXQgNTo1OCBQTSBCZW5qYW1pbiBTdMO8cnogPGJlbm5pQHN0 dWVyei54eXo+IHdyb3RlOgo+Cj4gVGhpcyByZXBsYWNlcyBjb21tZW50cyB3aXRoIEM5OSdzIGRl c2lnbmF0ZWQKPiBpbml0aWFsaXplcnMgYmVjYXVzZSB0aGUga2VybmVsIHN1cHBvcnRzIHRoZW0g bm93LgoKVGhlIGNoYW5nZSBsb29rcyBmaW5lLCBidXQgdGhlIGNvbW1lbnQgbG9va3MgbWlzcGxh Y2VkLCBhcyBlbnVtIGluaXRpYWxpemVycwphcmUgbm90IGM5OSBmZWF0dXJlLiBBbHNvLCB0aGUg bmFtZWQgYXJyYXkgYW5kIHN0cnVjdCBpbnRpYWxpemVycyBoYXZlIGJlZW4Kc3VwcG9ydGVkIGJ5 IGdudTg5IGZvciBhIGxvbmcgdGltZSBhbmQgd2lkZWx5IHVzZWQgaW4gdGhlIGtlcm5lbCwgc28g aXQncwpub3QgYSByZWNlbnQgY2hhbmdlIGV2ZW4gZm9yIHRoZSBvdGhlcnMuCgpBbHNvLAoKICAg ICAgQXJuZA==