From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B49DAC433EF for ; Wed, 1 Dec 2021 14:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kBPAy/0mil0IUIg+oKj3ixgP3ayHuOCWEiDKi0Xr4fQ=; b=X6BsRH3ycST/Lr L4EwVQFHstWMXbjy0WrAoByRFn2hQAigwqjU8kCHSGOBcRYtrpST6XktTI2UClx+V5kpgZ4keC8Kb nT0HCxvhPbEg8Uy3zXqgbSDgGBIOV1jsr5Xp5EdViJCTKKPgKtm2XE626zvNh3UJU0U/3sJC5Kdeq dUfkOwkL+OZUGdnEliZzy+z00Mu6qucNu8g/gQtMMGP/DJIXTY87jABmmRHQZE0iFO2BakNbAOkOS z6ry+FntSFBCeNHdikZJuGrNiKh7XDqDwZVNIqLEQVYWJ6itOhuHWESv04jH1f4VEH5cMNAJ/81sC XdfKUKuUmuNqDepujVaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msQFc-008yJS-Iu; Wed, 01 Dec 2021 14:06:24 +0000 Received: from mout.kundenserver.de ([212.227.17.13]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msQFY-008yIR-NP for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 14:06:22 +0000 Received: from mail-wm1-f54.google.com ([209.85.128.54]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MQMqN-1nEELx0t1t-00MMyi for ; Wed, 01 Dec 2021 15:06:16 +0100 Received: by mail-wm1-f54.google.com with SMTP id 137so20506658wma.1 for ; Wed, 01 Dec 2021 06:06:15 -0800 (PST) X-Gm-Message-State: AOAM531Ml7Snyd2p30+ghjTcuw7bLY42+7fCJkXstSxAeuorCrpjbMax RkgK/ebw0yxkImyK/2IrvblQowDip3poxNQXiOQ= X-Google-Smtp-Source: ABdhPJyl1yIVxKLsBm4gO92rX+ZKXCXXbYKJqK876KsSeXR5iNlxTXOFwENONgQnQNTM9WHQI8ZHAVF5M/1z7lzY/dQ= X-Received: by 2002:a05:600c:6d2:: with SMTP id b18mr7545643wmn.98.1638367575474; Wed, 01 Dec 2021 06:06:15 -0800 (PST) MIME-Version: 1.0 References: <20211201110259.84857-1-vladimir.murzin@arm.com> <20211201110259.84857-2-vladimir.murzin@arm.com> <26a97bb9-9b00-b162-8924-6b77309365b8@arm.com> In-Reply-To: <26a97bb9-9b00-b162-8924-6b77309365b8@arm.com> From: Arnd Bergmann Date: Wed, 1 Dec 2021 15:05:59 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] irqchip: nvic: Use GENERIC_IRQ_MULTI_HANDLER To: Vladimir Murzin Cc: Arnd Bergmann , Linux ARM , Russell King - ARM Linux , Mark Rutland , Marc Zyngier , Ard Biesheuvel X-Provags-ID: V03:K1:YpAgxT2XVBNkKQEqcOI9lI5FAR/RNZGDJHV8oQtqxzLCWddFfts hHHH/kMOZ0AXydMyqni4rXAP34bfSkBDq6Irh17urBo4W51022Lg0eDnPdKvEOYH+tUgJM4 tuTUzRL8jTOTAhEgQYM2sZfYSWu6sW2QO6M1ea3uDRgHHFJIw1lF9DxmFNK4XpzQfy+nruy gK5OBAVwwgPpX/I0/ho/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:0+1nafJqDX8=:jjeSxRWWX0y4j9pb4YEGFU mpLXC1eyE6XiajajS5axeMuWzsxhx1vs0cDmKOOEnU0XORUQQ/AQHbCllF82ZqPeAiemvpx4c q/XDHBUqx45rrYc31ouMuZ+mQ9movX5ywkq5OzDnjpMEkD4JuMY/m3osY6HM8MXzH1YERBqDt gWKXKy7l87WOpzIhn8OelWm7T8nC9TNYB7pSnQef9st6JpZg7sfNR+3UxFgC0yUSOuGrDDz/j 6ODpsTHI+NcISRHghI098hd5F9v2c2gIroHbPyG9O3Sw+Sk/nfDjdN4U3YVLRwi3MF45FgkK1 vpY5xQlMTfRblY5VQoTlarAG7ur2SQmeAEiBYRP1DlFjtx74tZlQ0nAN3HuRzrFXO6xGdBRI5 bgg6OI24wRCc2Jo/rZ8y9LZsYYGyWx07X53gW8yajhBCxJbrp71AW2wEmghO2JmoNX10OyJgv BfFTj275K2oH/M6OSEnWKBFl3q9FkflnB0tCpzNQLqfJFrStwpUjS+N4yo279zmZhpmOXcAFC HDDiOqi5WOlyxReaGPpufVg4BE5wPs4EapeiXyJFVk3u0C1zbEF56pUsKuqq5e3gQmIpduicT pmi9sE/1rw9BDWH14AyXn9E9gaiblgwTIlzRhZLTBHgaPfiKNJpM2z8wA028gIJsjXoBKTicm Df77HxY8l9sAvH7+zCocrays83zcTLUnjOHSWCJeD10kq6HEIOmtZ64u59hAJLxYrGbY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_060621_096783_514BDCA4 X-CRM114-Status: GOOD ( 27.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 1, 2021 at 2:43 PM Vladimir Murzin wrote: > On 12/1/21 12:30 PM, Arnd Bergmann wrote: > > On Wed, Dec 1, 2021 at 12:02 PM Vladimir Murzin wrote: > >> > >> Rather then restructuring the ARMv7M entrly logic per TODO, just move > >> NVIC to GENERIC_IRQ_MULTI_HANDLER. > >> > >> Signed-off-by: Vladimir Murzin > > > > Acked-by: Arnd Bergmann > > > > Thanks for finishing this one off as well! I don't know if you did this as a > > reaction to me doing the same for the three other platforms that don't > > use GENERIC_IRQ_MULTI_HANDLER yet[1], or if this was just a lucky > > coincidence. It sounds like this should be part of Ard's IRQ stack series > > as well then (adding him to Cc), as it fits in with my patches there. > > It was reaction to Mark's TODO statement in his original submission [1]. > I'd let maintainers to decide on the path it should land :) Ah, nice, so it was a coincidence after all. I guess my patches were easier because of Mark's (and Marc's) earlier work on related bits. > > Would you mind also implementing and testing the missing bits > > for the stack switching on nommu irq entry, corresponding to [2] so > > we can just use that part unconditionally as well? > > I can have a look but no promises since I have few issues with NOMMU > ATM (one of them seems to be cross-arch [2]) Yes, I saw that, but I'm not too worried about this on Arm, as we don't support that combination (SMP without MMU) in any of our platforms or in Kconfig without additional patches. What target are you actually testing on? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel