From: Arnd Bergmann <arnd@arndb.de>
To: "Loh, Tien Hock" <tien.hock.loh@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nguyen, Dinh" <dinh.nguyen@intel.com>,
"thloh85@gmail.com" <thloh85@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Gerlach, Matthew" <matthew.gerlach@intel.com>
Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver
Date: Wed, 1 Mar 2017 10:01:36 +0100 [thread overview]
Message-ID: <CAK8P3a1iH=+D7X0MR3DUDWDAytjs3X5xbWq3qUAcK07Us-5fcw@mail.gmail.com> (raw)
In-Reply-To: <1488353034.3544.3.camel@intel.com>
On Wed, Mar 1, 2017 at 8:23 AM, Loh, Tien Hock <tien.hock.loh@intel.com> wrote:
> Arnd, Greg,
Please don't top-post.
> I checked the attributes returned by the soc attribute subsystem, but
> it seems that it is lacking something equivalent to timestamp in the
> Intel System ID controller. Do you think it is better to add a new
> attribute (named timestamp) to soc or create a new sysfs entry like
> what I did?
It depends on how common and how important this attribute is.
- if it's not overly important, just drop it entirely.
- if it's important enough that other SoCs are likely to have the same
kind of information, make it a standard attribute
- if this SoC is most likely the only one that will ever need it, but it has
important uses, I'd make it a custom attribute
Another option would be to fold the timestamp into the revision attribute,
but whether that is a reasonable place for it would in turn depend on
what the timestamp signifies.
Can you explain what the timestamp is used for? Does it identify the
time that the hardware revision was made, the time that a software
was built which was loaded into it, or something else?
What kind of user space application would need this information?
Arnd
next prev parent reply other threads:[~2017-03-01 9:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1487156981-4550-1-git-send-email-user@thloh-VirtualBox>
2017-02-15 17:17 ` [PATCH 1/1] drivers/misc: Add Intel System ID driver Greg KH
2017-02-15 19:51 ` Arnd Bergmann
2017-02-23 5:58 ` Loh, Tien Hock
2017-02-23 8:05 ` Arnd Bergmann
2017-02-23 8:15 ` Loh, Tien Hock
2017-03-01 7:23 ` Loh, Tien Hock
2017-03-01 9:01 ` Arnd Bergmann [this message]
2017-03-01 10:42 ` Loh, Tien Hock
2017-03-01 11:34 ` Arnd Bergmann
2017-03-02 2:17 ` Loh, Tien Hock
2017-02-23 5:50 ` Loh, Tien Hock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1iH=+D7X0MR3DUDWDAytjs3X5xbWq3qUAcK07Us-5fcw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=dinh.nguyen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=thloh85@gmail.com \
--cc=tien.hock.loh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.