From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91854C433F5 for ; Tue, 10 May 2022 07:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237980AbiEJHgQ (ORCPT ); Tue, 10 May 2022 03:36:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239174AbiEJHMQ (ORCPT ); Tue, 10 May 2022 03:12:16 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11BC52AC6FB; Tue, 10 May 2022 00:08:18 -0700 (PDT) Received: from mail-yb1-f177.google.com ([209.85.219.177]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N1fag-1nv9Y11NdY-0123Gc; Tue, 10 May 2022 09:08:17 +0200 Received: by mail-yb1-f177.google.com with SMTP id j2so29119964ybu.0; Tue, 10 May 2022 00:08:16 -0700 (PDT) X-Gm-Message-State: AOAM532ylf6yHyeBsJKvV2LztCvkyKV3YsOQ/ShOQjJ+2PKvWx0qITuv AtiMAxGtKE6mNvFuap/IqIOv5kbWyIJCIBu96xg= X-Google-Smtp-Source: ABdhPJxWna6rlyrTKaLzkGLXfLQ5G36EvqX7iK3snQCVCxZJEjl921KjovbWJOm/HvkmjLf51wP/GU+2IK3ZKdNeooU= X-Received: by 2002:a25:31c2:0:b0:641:660f:230f with SMTP id x185-20020a2531c2000000b00641660f230fmr16728943ybx.472.1652166495925; Tue, 10 May 2022 00:08:15 -0700 (PDT) MIME-Version: 1.0 References: <20220510032558.10304-1-ychuang3@nuvoton.com> In-Reply-To: <20220510032558.10304-1-ychuang3@nuvoton.com> From: Arnd Bergmann Date: Tue, 10 May 2022 09:07:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC To: Jacky Huang Cc: Linux Kernel Mailing List , DTML , linux-clk , Linux ARM , ychuang570808@gmail.com, Rob Herring , Stephen Boyd , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , Catalin Marinas , Will Deacon , SoC Team , cfli0@nuvoton.com Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:AfVDd0F7X2lkWYQBHKX3m/O5w1goVick1k2D/8QnsT2lZ76G6rl c3bztW6lGea6meDExjBavSFzRcQX7NRekcihf7PsWDQi6g6xi9iZf/zGBYbsXaHAX9kCWjp nTMOuSvUNCXgevEVk/lqVo+pLyGNzPVrt/fUILdJKjce1hjWZAtVsGriulv6A9yHmSr2HwA R9NqvJ7kDrrNhmEWx/pRw== X-UI-Out-Filterresults: notjunk:1;V03:K0:soJ1UPUwGqA=:GOvMO455rTUxZPmYL0g3tt LKyZGFkdmK5Sy1bnjjo9B63HACyIlqGTIAcJ/g30MTl4adxNla4I55dywaLYW88cFNSluuLoA QAsgabz6a+Nkd/3HDRSRM1+Kv5JFDrput7MlWrPTG1tAYOwvenyjfZKt5s1H8CH4c0EKa9RuT EoBHQY8bx5VQcDofv3jg7bxihEzZr0GIKbZZ5lpyu38BWRrCyjik0rzFi0dSSEsLAWbeY9yxa 1f7GUdAXo2h1604T2x++NXrcVAShyDUT8KH5FyZm9fktRZIw/c3W9k+6jM2AIscm/UmcKKsiP tF6+6Pgv5nYLOtTSjYvUHYa8XIarT/6rmy0WE3VHzVUAj/O9awxgAkNqFtudMMX1xiGWs/b5e ymy00fMwtMxi2qn0KdlU5I3AWbKl3WvxsE4DAOd5IetvFOqiC9hCjst7cbeQuu1htws1dBRZc TWSW1kGbkM60MQOQGF2QMRgz/MOkhSwtcxf9erYpua8ylyVSkIMfX1H0S/iUC0PPrG1P1X5eY PdMgR8SVZd8MgHUZKwLzCArcq3LTxTQOYe8cxxfozfW6o7ylkkTvCE88xlwVAvCisu7aBC11F 8Ec9uXq+P+/gIprYA1yZUOgkVX2xLcyjGRPcGw5TXU+nVDNiq3PLjpvdHDKhWZOqw/6m/Zgig TKit7PqakpFD49yDtjLrjA6GfcaoPLOr+ngjLNq3+JvmKblBTZyGWUJCEPYw4Ta9lx33SmVOd 4b93vLfGpXXZoep9YGCuru5c1ebS56oEdZBSkNr6oO6OSwTMgSI2MljGwqrFQFecTSrVmqo6Q rW45qrfMoc/CYG6Msf8EjMQaYKGykRbX3dN2pnfDQG2l/snbdk= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 5:25 AM Jacky Huang wrote: > > This patch series adds initial support for Nuvoton MA35D1 SoC, > include initial dts and clock controller binding. > This looks fine in principle, but we are getting close to the merge window and should finalize this quickly to make it into v5.19. I see that you don't have a console device, as commented in the .dts patch. Normally I prefer merging platforms only when there is at least rudimentary support for booting into an initramfs with a serial console, but this is a flexible rule. As with the changelog text for the .dts file, please explain in the [PATCH 0/5] cover letter what the status is. Regarding continued maintainership, we should discuss how you plan to maintain this platform. In particular, there should be an entry in the MAINTAINERS file for the platform, either pointing to yourself, or adding it to the NPCM or WPCM450 entries if this chip is in the same family. Is this also a BMC implementation, or is it something different? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E99FC433FE for ; Tue, 10 May 2022 07:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RM7h2TYxwbGitwNb1wzPhO++9cmUShoaLE0RqdmPsUY=; b=g6AH2AMvm2C/Q8 xgQ2L6Zaz5t5egojiGXOpm9gVSobZeXsaDGdUqKSoqYD3a5wd85mQ8yyllOwV9lKH+aJh23J7IiaS mA0oGS7/FaaowHYsbm6hQAMufE/9zhPC/jt4frSrbnjdITkGJNXddJsRO0zvLQAIbaeCVQrmSZQbq sw0yXiCUb151hgplzkW9hq7Fy5tbXqeQAiyRqVVKQ3IlYUb1oIF2yhKbYXLck1aJDyvSl10jOcTV/ /6+UP1vlUIrHKMF99tHXhuXh4rfR9BX6HVWg2rw0gxDE5yOl/IKfmLprAAq2b2v3SCiJ+/RGCPK0p gCtuflld/TNV3LKZLceg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1noJyt-000HJh-Qq; Tue, 10 May 2022 07:08:27 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1noJyn-000HHe-3b for linux-arm-kernel@lists.infradead.org; Tue, 10 May 2022 07:08:22 +0000 Received: from mail-yb1-f169.google.com ([209.85.219.169]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MF45G-1nYxtx2fm4-00FSs6 for ; Tue, 10 May 2022 09:08:17 +0200 Received: by mail-yb1-f169.google.com with SMTP id r11so29039123ybg.6 for ; Tue, 10 May 2022 00:08:17 -0700 (PDT) X-Gm-Message-State: AOAM532kQO/iFemKM/u704eRaFdCoBVdM+6HtdjMfgue3tR1MGwpFAtr RL9dtejYVamdii8/8U1PSCUIMK1Z1dlQ8pX26/Q= X-Google-Smtp-Source: ABdhPJxWna6rlyrTKaLzkGLXfLQ5G36EvqX7iK3snQCVCxZJEjl921KjovbWJOm/HvkmjLf51wP/GU+2IK3ZKdNeooU= X-Received: by 2002:a25:31c2:0:b0:641:660f:230f with SMTP id x185-20020a2531c2000000b00641660f230fmr16728943ybx.472.1652166495925; Tue, 10 May 2022 00:08:15 -0700 (PDT) MIME-Version: 1.0 References: <20220510032558.10304-1-ychuang3@nuvoton.com> In-Reply-To: <20220510032558.10304-1-ychuang3@nuvoton.com> From: Arnd Bergmann Date: Tue, 10 May 2022 09:07:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 0/5] Add initial support for MA35D1 SoC To: Jacky Huang Cc: Linux Kernel Mailing List , DTML , linux-clk , Linux ARM , ychuang570808@gmail.com, Rob Herring , Stephen Boyd , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , Catalin Marinas , Will Deacon , SoC Team , cfli0@nuvoton.com X-Provags-ID: V03:K1:Cp2k4DMe6HSCTOAAnSsf8J7hsvF9MUNT6tLJpR3eyJ8F+6HkDN4 oyjGjTiFQvA9Jp45RXhIJgrKa0pPlqM86nR3p5JEdHozSscLb78Uicc1n8I4ORPjLCfQ2E2 R3rniMmklmSHJrv0LHfHmpYy1tJrjU3i+r5M51P0kAtEl88AHbDJpEY9Vpofjv80T07U0LZ z4whzzFEtWalH/dN638Yg== X-UI-Out-Filterresults: notjunk:1;V03:K0:gXtp+RjeE1E=:478lADGRx0ua6DBb/qvUrW IVkoVmwY5S/fmItwRW2RN8jGstVNy/qrk8MqPrPzfBXss2HOdPKKnJVmcfjMJLUlfC9pgS4Q2 3VaSPVLvGVhvwOY9XX7aCTdol8C4WPMi1C26A0RgYgGlXPnT0QHVp62Uo27+IOoz0epxPbILN fFXOq5q+VDcwT6gg+XEmPGkrn+J87++ecBsOAq5xmHMbozFmK/G8xIivpos5K6tBS6UKTGPFy RFImpAXKCU+yZhm4z3OlHQDW+1rlP1RL8U6R6zcD3k0dnBAWehKdP2NoQv7SWL9sbCfeL8GxO d6rpuioosO5b+/B5qOPtaTD0xX45eszUHczTaYbnwfgmuVhWJ8PGez1wPHn5TPQIlk67aN20O 4blzpA8mGTyMB6Nza07GfZgGOhyjTx9dphLHNOVt5j9rqnPxchCVqoANJ3zD+4RQKslQOsyir d7oTxcEyDXL9J2VmYtJHenuk6aCOP0vru1DhdJ3J1d+8wlknjXOb1C4zkBYJFIp6zZgh2qrGA JI6iRcOiwzy4eL+2Vj0+EJxHr2cSrO9uBGxVk1mG5s6hra9d/8e9b6t/J1xha6B/+K38j6+B/ f1xOBYofBxH44NlD4mvHzdXBNjiXqLm5M44i3yqjKbQB+a74oY9O5VwKbiPt5COzu149tMwJa OvuUBmWgxvzU+3ypZ+INDfEIHHvFHZERyC2BwfMuwth7ZN6oqXPp0Sj4mu0HucUU+nJj0hUTQ NhqgEfYrnUJTSQtJ9VUxDRnYdp5y92MVZCUtJrlti+JvxfPVI88MwaIOip2VMRw6X/sEcXBYe 3hWzIDtpsCoyEJAvp1KFKwDg5QStSwl6tHdXlKgvLIrtdY6fRM= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220510_000821_486682_85F2D404 X-CRM114-Status: GOOD ( 18.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 10, 2022 at 5:25 AM Jacky Huang wrote: > > This patch series adds initial support for Nuvoton MA35D1 SoC, > include initial dts and clock controller binding. > This looks fine in principle, but we are getting close to the merge window and should finalize this quickly to make it into v5.19. I see that you don't have a console device, as commented in the .dts patch. Normally I prefer merging platforms only when there is at least rudimentary support for booting into an initramfs with a serial console, but this is a flexible rule. As with the changelog text for the .dts file, please explain in the [PATCH 0/5] cover letter what the status is. Regarding continued maintainership, we should discuss how you plan to maintain this platform. In particular, there should be an entry in the MAINTAINERS file for the platform, either pointing to yourself, or adding it to the NPCM or WPCM450 entries if this chip is in the same family. Is this also a BMC implementation, or is it something different? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel