From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Thu, 09 Apr 2020 08:58:36 +0000 Subject: Re: [PATCH v2 00/10] Allow COMMON_CLK to be selectable Message-Id: List-Id: References: <20200409064416.83340-1-sboyd@kernel.org> In-Reply-To: <20200409064416.83340-1-sboyd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Stephen Boyd Cc: Ulf Hansson , Rich Felker , Linux-sh list , Catalin Marinas , Michael Turquette , Jiaxun Yang , "open list:BROADCOM NVRAM DRIVER" , Manivannan Sadhasivam , Huacai Chen , Will Deacon , linux-clk , linux-c6x-dev@linux-c6x.org, Alexander Shiyan , Neil Armstrong , Russell King , Yoshinori Sato , Geert Uytterhoeven , Mark Salter , Thierry Reding , "moderated list:H8/300 ARCHITECTURE" , Aurelien Jacquiot , Lubomir Rintel , linux-m68k , Mark Brown , Guan Xuetao , Linux ARM , Paul Walmsley , Thomas Bogendoerfer , Paul Burton , "linux-kernel@vger.kernel.org" , Tony Prisk , =?UTF-8?Q?Andreas_F=C3=A4rber?= On Thu, Apr 9, 2020 at 8:44 AM Stephen Boyd wrote: > > This patch series cleans up a handful of selects that were redundant and > deletes presumably dead code with the goal of making it possible to add > kunit tests for the CCF in the future. To do that, we introduce a > "legacy" clk Kconfig option to mark code that hasn't migrated to the > common clk framework and then make the COMMON_CLK config option visible > in the menuconfig as long as that legacy option isn't enabled. I've also > included a couple patches at the end that may be more controversial but > helped me consolidate all this logic/code. > > I haven't done more than compile test a few configs for arm, arm64, > h8300, and mips. More testing is welcome. > > The plan is that I'll just merge the whole pile through the clk tree. If > the first five patches or the last three patches are better going > through another tree like arm-soc or architecture trees that's fine too, > but there are potential conflicts between trees so maybe it's better to > just leave it all in one tree. > > Changes from v1: > * Fixed MIPS ralink build problem pointed out by Arnd > * Fixed meson mx sdio build due to bad Kconfig exposed by this change > * Picked up acks Whole series Reviewed-by: Arnd Bergmann I also made a patch to completely remove the private clk implementation for mips/loongson2f, but it obviously clashes with your series at the moment. I'll send you what I have today and you can decide if you want to add it to your series after it gets an Ack from the maintainers, or I'll send it separately later. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3105AC2BB55 for ; Thu, 9 Apr 2020 08:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FF4D20757 for ; Thu, 9 Apr 2020 08:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726749AbgDII64 (ORCPT ); Thu, 9 Apr 2020 04:58:56 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:50675 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgDII6z (ORCPT ); Thu, 9 Apr 2020 04:58:55 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MhDAi-1iqzpE2uFW-00eI3c; Thu, 09 Apr 2020 10:58:54 +0200 Received: by mail-qt1-f178.google.com with SMTP id g7so2144406qtj.13; Thu, 09 Apr 2020 01:58:54 -0700 (PDT) X-Gm-Message-State: AGi0PuZnwcp+Tqdgl47obk3LyDCyWlo4dBmaaM0KkS9BIjsXI+mDHzu3 XEwP+Ipc4/ubF7jRNKv0i7K/1IVuQPRS8ER+J7s= X-Google-Smtp-Source: APiQypJGQnSKvwEmA3Uxqr21N7C28AlJ4H4USNdYjJ7jBa7oUXIlp/5GQn3RknUCUlZR5y4GP5LLx3U/KPQi69ASHsQ= X-Received: by 2002:aed:3b4c:: with SMTP id q12mr10854453qte.18.1586422733282; Thu, 09 Apr 2020 01:58:53 -0700 (PDT) MIME-Version: 1.0 References: <20200409064416.83340-1-sboyd@kernel.org> In-Reply-To: <20200409064416.83340-1-sboyd@kernel.org> From: Arnd Bergmann Date: Thu, 9 Apr 2020 10:58:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/10] Allow COMMON_CLK to be selectable To: Stephen Boyd Cc: Michael Turquette , "linux-kernel@vger.kernel.org" , linux-clk , Alexander Shiyan , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Aurelien Jacquiot , Catalin Marinas , Huacai Chen , Geert Uytterhoeven , Guan Xuetao , Jiaxun Yang , Linux ARM , linux-c6x-dev@linux-c6x.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Linux-sh list , Lubomir Rintel , Manivannan Sadhasivam , Mark Brown , Mark Salter , Neil Armstrong , Paul Burton , Paul Walmsley , Rich Felker , Russell King , Thierry Reding , Thomas Bogendoerfer , Tony Prisk , "moderated list:H8/300 ARCHITECTURE" , Ulf Hansson , Will Deacon , Yoshinori Sato Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:O1q931hCZ40T0tLkpVu7G+bihKn8ZKa+7Q36I2aOnANCcD9rGPv bNiYtUO1D51Vlkj+7/CjCy8tt3nrbLkCvViBQyHvFelIwFAPWhVlrNhVKKHjGdr9KoTxIlF r67KKVv1oWwEiP5GAlv3JelwY2d3v8nfKlYfEbnhR2yCiAg42IaoG+JqXlsiN2+1/RZ1rE0 GY/sQddB5aPnMh3dufYOA== X-UI-Out-Filterresults: notjunk:1;V03:K0:2AqidcnxkcA=:Hgp3RZDeZIgahRHJ/yk7nE Ulqh8jc6o/Z+yMvq7M10nOyZxnr7eip5vdx1DIfSMCTMELWDmZBF0lxuo/QJ8nUGK/29NfnXD B6dIoA072qWvbBqMbk5tNevgw/s2qWs/QhQqdoeSbFP0Xs6TeAsjBF8gcNEKo3bdPhAapgMXF tiBDTacTW3a701mf+Hf/iBvexQ81Ui7JIClEs/xmQfVwVMbur5WlTINhgZ6aXtnt/Qxz617A5 Gu25OVYlcy/+wOGROa38MQwR1RZZvpt73ioF9Te5bYZPp4sC038OgxbZeNkPoVMaWb0h1L/q4 aLGdyPWfuI7878M6nv6dokLnav68ecWblRGBsJJ1A33KqDYvibuUPSb2rfx0dWDy+flUbbcXB yjUtTz5NCsGhx8Z7A/2ms1FIi7P7EWhY/dZpMjR6JgKVzKzVxq48t0bc1y2tkXA9wV8V2rrqF xwGhxQcAe1u69AvnVWQTMX5dD9JyHgJvdszBeOQTcbIVMPKUrNrXf+UU0cmPxq8PNO0Xpl57V rClHRH0l4oFV2EkyLf8GS/vCfVDJny3RAQ/AOKzP5vxaVsmNH4YagBWKwapsPjgXcbeq14S2u JqxgZ3TD1NmODtlIF4dzEyP+fvgmeagmYPEy4wtLw50777om8U+8ObPsozZcdMOBJzlJW4NY/ D88RxxGlgB9nV2tn0QEOEXnJHnlpDDD7ofucFN3mAdp5KPz5g9NZEmh4vsqrk5ZBbbDxXmZkC ebUgF7k8cBaIBjJejSYhrRUuLN+Z4ISdfTNh5VBGy64rJsBNqCf2Uh1Kb62WN8zbGzS4IBdxj 1wjjdT2t6f8d2eOsrSnyIGAnST+ls5XOE4pAXXP7wjCyNPJ4rE= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 9, 2020 at 8:44 AM Stephen Boyd wrote: > > This patch series cleans up a handful of selects that were redundant and > deletes presumably dead code with the goal of making it possible to add > kunit tests for the CCF in the future. To do that, we introduce a > "legacy" clk Kconfig option to mark code that hasn't migrated to the > common clk framework and then make the COMMON_CLK config option visible > in the menuconfig as long as that legacy option isn't enabled. I've also > included a couple patches at the end that may be more controversial but > helped me consolidate all this logic/code. > > I haven't done more than compile test a few configs for arm, arm64, > h8300, and mips. More testing is welcome. > > The plan is that I'll just merge the whole pile through the clk tree. If > the first five patches or the last three patches are better going > through another tree like arm-soc or architecture trees that's fine too, > but there are potential conflicts between trees so maybe it's better to > just leave it all in one tree. > > Changes from v1: > * Fixed MIPS ralink build problem pointed out by Arnd > * Fixed meson mx sdio build due to bad Kconfig exposed by this change > * Picked up acks Whole series Reviewed-by: Arnd Bergmann I also made a patch to completely remove the private clk implementation for mips/loongson2f, but it obviously clashes with your series at the moment. I'll send you what I have today and you can decide if you want to add it to your series after it gets an Ack from the maintainers, or I'll send it separately later. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE93C2BB1D for ; Thu, 9 Apr 2020 08:59:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 444E920730 for ; Thu, 9 Apr 2020 08:59:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mlhQjjDz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 444E920730 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lSCamSjs0SrB9gzAspKHwTOPZrOXnmyvjNiyTpaP+C8=; b=mlhQjjDz197TkZ EK0ysEPpu2FI0rv0hIgPw2qwbBidPSbzxuhTJiTQmbvoqmNykRdlR/4f5TkM4wiIoY8XqnjX5cEBB xaa1ea6ix2t4d4k4QTH4UBTogKlithIBbAiEivXmZRooZI+xVzPKOrKv73Ghq5CnnNN5RxAk/zhco j+kmu+K+Qsrksx/SU2ncxRP9cemDuuEV1zna1z8iGp3ejSR/OtrHL9PAp/iT0yViOkvBKcAaNaA/5 0WhDFd1Q+CchP9eIGnOp9ziI7fclL/ZZnyfhKxw6rs3S2rwBTD8p/69Zc9Y82K/DGi0IHj0srf+1j GySVoUPz23CzDEHRq3Qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMT1X-0006z1-OW; Thu, 09 Apr 2020 08:58:59 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMT1U-0006yd-AQ for linux-arm-kernel@lists.infradead.org; Thu, 09 Apr 2020 08:58:57 +0000 Received: from mail-qt1-f181.google.com ([209.85.160.181]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MpDRp-1iwkSX1csR-00qfhQ for ; Thu, 09 Apr 2020 10:58:54 +0200 Received: by mail-qt1-f181.google.com with SMTP id 13so2179292qtt.5 for ; Thu, 09 Apr 2020 01:58:54 -0700 (PDT) X-Gm-Message-State: AGi0PuaAQTvspev2kSXRPdaWd8iNix1kz8pPsB7VSwUe1RXp3tU80fND 3RXbd70PdyLFUyMbbJCnJ8o0iSm+c6H9Qj/YmXs= X-Google-Smtp-Source: APiQypJGQnSKvwEmA3Uxqr21N7C28AlJ4H4USNdYjJ7jBa7oUXIlp/5GQn3RknUCUlZR5y4GP5LLx3U/KPQi69ASHsQ= X-Received: by 2002:aed:3b4c:: with SMTP id q12mr10854453qte.18.1586422733282; Thu, 09 Apr 2020 01:58:53 -0700 (PDT) MIME-Version: 1.0 References: <20200409064416.83340-1-sboyd@kernel.org> In-Reply-To: <20200409064416.83340-1-sboyd@kernel.org> From: Arnd Bergmann Date: Thu, 9 Apr 2020 10:58:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/10] Allow COMMON_CLK to be selectable To: Stephen Boyd X-Provags-ID: V03:K1:rlO5QZFNG/WnK39ukFr3WyrZl/xl8gnQCdQAwBeHYx/sCKdBpwb a1olA+IJz6FlKVBFqccHc1/zSm80VhAARsmSR7o1ZMXUBZAy5TGS9Lh1SexfTEve4C8WTFn mLLZVpSvra9waqjipyuNw+MAZSifRwAAcHTuRlD8Y0S+36FxNEHEjcduzP7fmf3/ZkmMJGW h8VCM03XhT/YxjM7zVNZg== X-UI-Out-Filterresults: notjunk:1;V03:K0:5ys664IrDVk=:UIUMBaG7PLagGGACOuzldi 13YKEb5unNT2mX4tI9jSw+Y6ZbvtcvCY41iyiYTQfhbxdU2wUXl/jATvpP4cEssbecCe+4EJU Vs276UbLwCg5bFML2u4pC86d+63HQhOCWGt2WFmRLjkNOZPp2ED1ewb7x5GW+Tu3p85RMhw6V gGUdLhTBJGLAu8AhajcDWT/lDiYTB1aN7IzrbKZHOynxWAJfA8vOrzv6i6R5wfIB0ydZNFxrD nUkM6Jcam96IqeQI+h+abWgOQq3cI8A2gN0fPgIfYkmJrOmZY7gxkEs/8mP/UOfIjMYlOoKg7 Ysibvjg+koeJgxwl7BumOwZtndEzIPvOsasAt4bAQn/9yp41mjOdCKNz+fXvD9LunlU/eJFEo cdQw7LdnanTwp6/vxfJ+V3uEmuHnSi+tFWNo288w65ehQxJvdAfPVk2gyeFOG0Fzpo6f9SxY1 fp3HlEffC54q2cmeaM2XUqFSvDXowzp9Yapv4F0qIvcS2dmzP+xQX52CMWKK2Cm2Cv33cpNDH 0apHzxwQMC+SuPIXQnMWnf71CZpCBW2fAyJBG+Qn5afD5XeWyw+Iu5m724xBY5VkuMZoFUfjY 6+7uj7/a23Yg4W6g76e7e3ySnrSPh/TZYEPv01nsmxUXMy3f/ZZnInoZUsL0/VYqJPPIbb9Pb DhDYxflL/ZBsTtuakU/c5ufY3VVoCoUsJTIyFyp38QOUQE/FwoOBpty7S0l3oq3n4V3PwzW4L RieqZVCnXR3XhkeA1wLGpZf5Jc8PqIgz0bXPnhJU0W0IjR543nHNogz+X2iqHMaFF8HbcmVdh 0B/FyjXHZcL0XCs2g/siR+Q7MtoWl+dQJK880Rs19lg1Pgoe4Y= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200409_015856_654724_B058D4E4 X-CRM114-Status: GOOD ( 18.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Rich Felker , Linux-sh list , Catalin Marinas , Michael Turquette , Jiaxun Yang , "open list:BROADCOM NVRAM DRIVER" , Manivannan Sadhasivam , Huacai Chen , Will Deacon , linux-clk , linux-c6x-dev@linux-c6x.org, Alexander Shiyan , Neil Armstrong , Russell King , Yoshinori Sato , Geert Uytterhoeven , Mark Salter , Thierry Reding , "moderated list:H8/300 ARCHITECTURE" , Aurelien Jacquiot , Lubomir Rintel , linux-m68k , Mark Brown , Guan Xuetao , Linux ARM , Paul Walmsley , Thomas Bogendoerfer , Paul Burton , "linux-kernel@vger.kernel.org" , Tony Prisk , =?UTF-8?Q?Andreas_F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 9, 2020 at 8:44 AM Stephen Boyd wrote: > > This patch series cleans up a handful of selects that were redundant and > deletes presumably dead code with the goal of making it possible to add > kunit tests for the CCF in the future. To do that, we introduce a > "legacy" clk Kconfig option to mark code that hasn't migrated to the > common clk framework and then make the COMMON_CLK config option visible > in the menuconfig as long as that legacy option isn't enabled. I've also > included a couple patches at the end that may be more controversial but > helped me consolidate all this logic/code. > > I haven't done more than compile test a few configs for arm, arm64, > h8300, and mips. More testing is welcome. > > The plan is that I'll just merge the whole pile through the clk tree. If > the first five patches or the last three patches are better going > through another tree like arm-soc or architecture trees that's fine too, > but there are potential conflicts between trees so maybe it's better to > just leave it all in one tree. > > Changes from v1: > * Fixed MIPS ralink build problem pointed out by Arnd > * Fixed meson mx sdio build due to bad Kconfig exposed by this change > * Picked up acks Whole series Reviewed-by: Arnd Bergmann I also made a patch to completely remove the private clk implementation for mips/loongson2f, but it obviously clashes with your series at the moment. I'll send you what I have today and you can decide if you want to add it to your series after it gets an Ack from the maintainers, or I'll send it separately later. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel