All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: kernel test robot <lkp@intel.com>,
	clang-built-linux <clang-built-linux@googlegroups.com>,
	 kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	 Quentin Perret <qperret@google.com>,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [linux-next:master 6632/9522] include/linux/pm_opp.h:458:58: warning: unused parameter 'dev'
Date: Mon, 23 Aug 2021 11:07:13 +0200	[thread overview]
Message-ID: <CAK8P3a1o6uvDo_ttPFOw_pRdtok3-9=dFMLToyUxSmTxs0YfOg@mail.gmail.com> (raw)
In-Reply-To: <20210823031546.fupzmdxjntacsq2e@vireshk-i7>

On Mon, Aug 23, 2021 at 5:15 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 21-08-21, 03:30, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   86ed57fd8c93fdfaabb4f58e78455180fa7d8a84
> > commit: c17495b01b72b53bd290f442d39b060e015c7aea [6632/9522] cpufreq: Add callback to register with energy model
> > config: i386-randconfig-a016-20210820 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d9c5613e856cf2addfbf892fc4c1ce9ef9feceaa)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c17495b01b72b53bd290f442d39b060e015c7aea
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout c17495b01b72b53bd290f442d39b060e015c7aea
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >    static inline void pm_vt_switch_unregister(struct device *dev)
> >                                                              ^
> >    In file included from drivers/gpu/drm/i915/gt/intel_llc.c:6:
> >    In file included from include/linux/cpufreq.h:12:
> >    In file included from include/linux/cpu.h:17:
> >    In file included from include/linux/node.h:18:
> >    include/linux/device.h:653:46: warning: unused parameter 'dev' [-Wunused-parameter]
> >    static inline int dev_to_node(struct device *dev)
>
> False positives ? These are mostly inline dummies, which simply return
> errors. Their parameters aren't supposed to be used.

It's a clang-14 W=1 build, probably something went wrong with the clang specific
warning flags there. I think we do want "-Wunused -Wno-unused-parameter". Not
sure what changed compared to older clang builds.

        Arnd


WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 6632/9522] include/linux/pm_opp.h:458:58: warning: unused parameter 'dev'
Date: Mon, 23 Aug 2021 11:07:13 +0200	[thread overview]
Message-ID: <CAK8P3a1o6uvDo_ttPFOw_pRdtok3-9=dFMLToyUxSmTxs0YfOg@mail.gmail.com> (raw)
In-Reply-To: <20210823031546.fupzmdxjntacsq2e@vireshk-i7>

[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]

On Mon, Aug 23, 2021 at 5:15 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 21-08-21, 03:30, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   86ed57fd8c93fdfaabb4f58e78455180fa7d8a84
> > commit: c17495b01b72b53bd290f442d39b060e015c7aea [6632/9522] cpufreq: Add callback to register with energy model
> > config: i386-randconfig-a016-20210820 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d9c5613e856cf2addfbf892fc4c1ce9ef9feceaa)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c17495b01b72b53bd290f442d39b060e015c7aea
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout c17495b01b72b53bd290f442d39b060e015c7aea
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> >    static inline void pm_vt_switch_unregister(struct device *dev)
> >                                                              ^
> >    In file included from drivers/gpu/drm/i915/gt/intel_llc.c:6:
> >    In file included from include/linux/cpufreq.h:12:
> >    In file included from include/linux/cpu.h:17:
> >    In file included from include/linux/node.h:18:
> >    include/linux/device.h:653:46: warning: unused parameter 'dev' [-Wunused-parameter]
> >    static inline int dev_to_node(struct device *dev)
>
> False positives ? These are mostly inline dummies, which simply return
> errors. Their parameters aren't supposed to be used.

It's a clang-14 W=1 build, probably something went wrong with the clang specific
warning flags there. I think we do want "-Wunused -Wno-unused-parameter". Not
sure what changed compared to older clang builds.

        Arnd

  reply	other threads:[~2021-08-23  9:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 19:30 [linux-next:master 6632/9522] include/linux/pm_opp.h:458:58: warning: unused parameter 'dev' kernel test robot
2021-08-20 19:30 ` kernel test robot
2021-08-23  3:15 ` Viresh Kumar
2021-08-23  3:15   ` Viresh Kumar
2021-08-23  9:07   ` Arnd Bergmann [this message]
2021-08-23  9:07     ` Arnd Bergmann
2021-08-23 20:28     ` Nathan Chancellor
2021-08-23 20:28       ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAK8P3a1o6uvDo_ttPFOw_pRdtok3-9=dFMLToyUxSmTxs0YfOg@mail.gmail.com' \
    --to=arnd@kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=lukasz.luba@arm.com \
    --cc=qperret@google.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.