From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932990AbdC2V3l (ORCPT ); Wed, 29 Mar 2017 17:29:41 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34337 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932896AbdC2V3i (ORCPT ); Wed, 29 Mar 2017 17:29:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170329133318.16189-1-msuchanek@suse.de> References: <20170329133318.16189-1-msuchanek@suse.de> From: Arnd Bergmann Date: Wed, 29 Mar 2017 23:29:36 +0200 X-Google-Sender-Auth: JbgRckEvgw1VfCZzQydsCjBvjI8 Message-ID: Subject: Re: [PATCH] macintosh: Do not arbitrarily limit architecture for macintosh drivers. To: Michal Suchanek Cc: Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2017 at 3:33 PM, Michal Suchanek wrote: > The mac mouse emulation is neat solution for notebooks with suboptimal > touchpads. For historical reason this is available on x86 but not arm or > mips so remove the limitation. > > The other more specific drivers depend on various platform drivers > anyway so users will not select those by accident. > > Signed-off-by: Michal Suchanek > --- > drivers/macintosh/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig > index 97a420c11eed..c23c040bc668 100644 > --- a/drivers/macintosh/Kconfig > +++ b/drivers/macintosh/Kconfig > @@ -1,7 +1,6 @@ > > menuconfig MACINTOSH_DRIVERS > bool "Macintosh device drivers" > - depends on PPC || MAC || X86 > default y if (PPC_PMAC || MAC) > ---help--- > Say Y here to get to see options for devices used with Macintosh > -- Why not move the mac_hid module to drivers/input instead so it no longer depends on MACINTOSH_DRIVERS? For the other mac drivers, it may be helpful to to add '|| COMPILE_TEST' to the dependency line here to allow building them on ARM (after you have verified that we can in fact build them all without warnings), but that would be unrelated. Arnd