From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4BFAC433E3 for ; Wed, 12 Aug 2020 11:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82EA7208B3 for ; Wed, 12 Aug 2020 11:28:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbgHLL2z (ORCPT ); Wed, 12 Aug 2020 07:28:55 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:39803 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbgHLL2y (ORCPT ); Wed, 12 Aug 2020 07:28:54 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MLzeb-1kN4o136Y5-00HzPW; Wed, 12 Aug 2020 13:28:52 +0200 Received: by mail-qt1-f170.google.com with SMTP id o22so1127966qtt.13; Wed, 12 Aug 2020 04:28:52 -0700 (PDT) X-Gm-Message-State: AOAM531AkD4/0SayogMk90hrDyOlkL9n8c4b64soJbT5S3a1qLWmHG/m IYvV+PJEgv5C7QxchBD1kn9srofSiSMizNVGqf8= X-Google-Smtp-Source: ABdhPJxsW8KvhXUS1ojoIaqN362ISA/JDUik1npds+V9z2Z/6a42INf5aMjjkxMPeXquVPo4e7r0h6AJVgmGkNoG4Tw= X-Received: by 2002:aed:33e7:: with SMTP id v94mr5752270qtd.18.1597231731435; Wed, 12 Aug 2020 04:28:51 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> In-Reply-To: <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> From: Arnd Bergmann Date: Wed, 12 Aug 2020 13:28:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Sylwester Nawrocki Cc: Stephen Boyd , Alexandre Torgue , Catalin Marinas , Chanwoo Choi , Guenter Roeck , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maxime Coquelin , Michael Turquette , Russell King , Simtec Linux Team , Tomasz Figa , Will Deacon , Wim Van Sebroeck , Linux ARM , linux-clk , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , linux-stm32@st-md-mailman.stormreply.com, LINUXWATCHDOG , patches@opensource.cirrus.com, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:2C/lhlOU3R2lkBbParLcFu4HTCZmdLUHTi3gkwxRTTYn4h+FnJw ezp9uvaYSpdsqf/cwkshQq32GCk8qrX26af3HGamFCEFfhUzXLETkoCXm2/4/Z+lZ1x/vi4 cS6woBG4E5rpy6FEr90UlnDwI6fvIxvFXda/d3/GAV7ORck5VKk4Y+3bwmLjdA7gUpyGReZ ouz1QWSh3nwK9W2vlgoYg== X-UI-Out-Filterresults: notjunk:1;V03:K0:YY5ax/N2kRs=:dL4ZaISW56P3jQkQRTrGSb ZIIicumDg7fpoDKvbKFrbVkrm+v9+l5TI1kxINFI0Yhu87iqnQQ9ARixHZt2poF0zLooRZHls Rq2uFWr4Qckeq6c7AU+uoOJP7g71bvGDCCAVDCKGkGuOmvWovR7DJJRdWt4pdAaTeZ/pvuHe3 sGwIXL5U+d5Vi80rY/vfxE+ZDOPWdqyHri7L4UYiACtpKTxy4inHzklxXjG6b5FYi+JIZw40j 6peAEHbpSyDUa+E7LbtJapLg2mXyhsofKB6eiHTQImggrFyAKSbZzlHeofN7DzEEbf62PiP7I nmdI9+UqhY0E6kyyDjLNEmN6OLDXX1lGiyrl9+SaNgQKJvOra8I/Wo2hnrLzzZX473xzJWtYu YeWsB80Ga5IdRqEBPPp57dP8Zr3FZCZSvfhge5BbFuerBxEOKNa+YU+OVCpy/WGpeP102VB8b rncYSJDyfkCPWIPeufO9W/fQZIw9zARfi1eVCzzEG3QpfdMZb0M/rTd7NmS0KlzS/XYaETnVQ Rczlo85V2naNkZ5roTAPiiurQWbdykC0bA6Vlxrt6FtQ/DDm0dmmACkoeeUVwkr+SX6yT1xxa 07LL6N0CLx7gpsB3Sqz1CRdWtjNk7ZZ75MiUgeeEYvuQ99j3qz8JYbR/gKktg5KvBhaPRMEyK iGr50JkotdeF/3fBk09vexA8tV/DXTMbvJY9vysf6fhHTILX9kgibgab+tx3iGsvlSFrYwYXb qHJojb0NOcnAEkT4C3Cf4Y4VRn6EdPlvC7JzdYVVOUyqwRKyh7EuQA8wmxlLOjVDG/QyW+Id+ xEcgbiQhK5Djs6M8pLZhJp2LJq38ECS+FdW+l1v+gVCCVawC/NxrvghQb+tv9ucd3VJnFGbrN h+/GFsM7KYEF1awB2RWLWbLAQOYam8LynA+C1NOFxLIGAF77vW0WiDQoYLQCoIGo79tuo5d4u skhRnA6nY+TnbQgl6fEHP26E95WRdy3DUFZDFoW8YpFQIt0v3/aVB Sender: linux-watchdog-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki wrote: > On 12.08.2020 11:14, Arnd Bergmann wrote: > > > > It seems there have never been any callers and the entire file > > can just be removed, with the rest of that platform_data header > > file moved to drivers/media/platform/s3c-camif/. > > Yes, it seems that patch never made it to mainline: > https://git.linuxtv.org/snawrocki/media.git/commit/?h=testing/s3c-camif&id=355cbf835aff2aabf78390931cbbaa608af77967 I suppose it would still apply if anyone was interested, but I see your point. > I doubt there are still users of camera on the s3c2440 boards > with current mainline kernels, if any at all, there are much > better HW alternatives right now. I see two board files (and no DT) instantiate the camif device: NexVision Nexcoder 2440 and the FriendlyARM mini2440. Can you say whether the camif on those would actually work at all without your patch? If not, we know that there are no users of that driver and could either drop it completely or move it to staging for a release or two. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3BDEC433DF for ; Wed, 12 Aug 2020 11:30:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5C19207DA for ; Wed, 12 Aug 2020 11:30:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p+t+1aBI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5C19207DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EEomnUpHCVfcpIDKbDMmIUdytQkv4MRb4Q66eivAVnI=; b=p+t+1aBIV6qTt20DuV/8f+7A6 rqVZN5MPFHsajlsYMMnXkDrSymTCxAhP4ikVedRGSsQSXZwuwUUz/cS7HoGgVY1gPoV/i1PEW77o6 4Giuttyge5IYNVX/VzUJlAN6Myn+aRL+SwLoeVcA7kBaLz7GkYja2/GoT2c1c9pgsLI7jUmuNAqXC NSV0pZFxdvJPoEyiKwGqSLyNzdTZffU3jEz3Hx35T1binl4Ckhzr2cFsQVxY19Homo+Hho+KMhr5J FFVgUbHsPunKsm8W2xUSO6IuBo0qQUOF0ZnnNNCuft1bF004+YK3r7IRiycnZe11qA/E8UwUmTIr5 zD8ZjzFbA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5owG-0002fi-1y; Wed, 12 Aug 2020 11:29:00 +0000 Received: from mout.kundenserver.de ([212.227.17.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5owD-0002fF-Iq for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 11:28:58 +0000 Received: from mail-qt1-f171.google.com ([209.85.160.171]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MNKqC-1kKadB3lVq-00Opwi for ; Wed, 12 Aug 2020 13:28:56 +0200 Received: by mail-qt1-f171.google.com with SMTP id h21so1131974qtp.11 for ; Wed, 12 Aug 2020 04:28:52 -0700 (PDT) X-Gm-Message-State: AOAM531PoFd7Wf18pJdi4uGXm9fDJGyvgljZa3atS8xELP5Z4Op5a0mn R2McJ2EVPs9gEq/QKLKZCmaZNCPcO9YJ5TSoIMQ= X-Google-Smtp-Source: ABdhPJxsW8KvhXUS1ojoIaqN362ISA/JDUik1npds+V9z2Z/6a42INf5aMjjkxMPeXquVPo4e7r0h6AJVgmGkNoG4Tw= X-Received: by 2002:aed:33e7:: with SMTP id v94mr5752270qtd.18.1597231731435; Wed, 12 Aug 2020 04:28:51 -0700 (PDT) MIME-Version: 1.0 References: <20200804192654.12783-1-krzk@kernel.org> <20200804192654.12783-14-krzk@kernel.org> <159721917443.33733.7919188364233003142@swboyd.mtv.corp.google.com> <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> In-Reply-To: <8066413c-367d-2f8d-3e7b-dacd954675be@samsung.com> From: Arnd Bergmann Date: Wed, 12 Aug 2020 13:28:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 13/13] ARM: s3c24xx: camif: include header with prototypes and unify declaration To: Sylwester Nawrocki X-Provags-ID: V03:K1:6YH35sgZMbYdN6c45ooptCLjcsx+NwF2Cs8UXqEsUbI1Ml1s8NO LtnFX+0zy6OuDyWbQUs8ub/UvcvBy6kAOQ/jesdyoiJfE7VrySixRA1JhVC6Dgvch4mKGJ0 gPnnZqCXhgUfBkYH8Q//xct/9csCsJioNTFiP7qVqxS7Lmy4Tcw2f70M2VJmkU9buGeMXlG uVki779zX1J/XRWs6xI8w== X-UI-Out-Filterresults: notjunk:1;V03:K0:QcsedAMX9No=:LU5T89wSLG0GMpKMyEl8nU 6kXhXZjCY4lXpmriFY4414V1np+wUiMAy8Iaqu1B98tToCwf+0R4gVRfMh/cFOG/76In743KL nPBGVz96L7NJRebNCq/CnrThOJo7oY719UEMsrojLnVj3ooERNZasPhxorDf0DFZIbwU7D/MM 1o62JjDqPdn2/mSrvqvOfZJwelNeJ6T3wQNoO1jDrj4I9I07WOLWwaTAdh5nek7HYhyUeZEt9 NWzBiTfw7BO4PBByDcKtlNS7IyYn2+mx5/VJq8ewb9K1rlxne5fDtUIqryjvtJcUgIiLaqicV Qg8E2J1UuGdJRyCKlBEwz/tAjHjIOVVF7xWk417Qk4n9gGnhLx0kIAudmEdjBFtbOsEOTSbEJ 7IgNXy9wcboRQ4X8Jwol4WE0lA/tWRyO9x4bUCOcg4zkPcyUJ9ihMph/llXq6VzmZUWiBJ0Yq Y2sstxWocEK9Qg9xO7JtxmHRpMP5ZaJE5aCA8afxuR4657zTd05Rs3SpUu6lQyXE4khMPgwTM v1LZHTSn2fRe4daxlqWtkhReMKPOz5aVj5T0oUZaeq0gR09w1tGY0/sYZxuslaOeTHzDX6uvB 081++EAp12VQQiL+aUYcl76pxiwXBJ27nwZxAI2PYkARErzPPGFuusxuDQSmeC4HuW3nBupno uzZ1mkUK2xMB8JaXiRptUgcjEFc0rrpExksPrQXALO5Ujfgpmu8nEX+hw7SPDFcPTDs4tgu2J ZfFGYAfmFLXh4svF7tpBMZsElEfF2AyQHEXvTwfVkk8cG22YXMEOf2W9RQ6g/CHC5oVLXpkCp pv/rcwWNV/jYcj2W6INgNXDClgcII67txbDnOZM8H9asxd3dakexjPpIsQMFg0jRUM9vXuI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_072857_869570_75D7D279 X-CRM114-Status: GOOD ( 20.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Michael Turquette , Tomasz Figa , Will Deacon , linux-clk , LINUXWATCHDOG , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Sylwester Nawrocki , Cedric Roux , Russell King , Krzysztof Kozlowski , linux-stm32@st-md-mailman.stormreply.com, Lihua Yao , Chanwoo Choi , Kukjin Kim , Marek Szyprowski , Guenter Roeck , Sergio Prado , Alexandre Torgue , Wim Van Sebroeck , Simtec Linux Team , Linux ARM , Stephen Boyd , patches@opensource.cirrus.com, Kyungmin Park , Maxime Coquelin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 12, 2020 at 12:46 PM Sylwester Nawrocki wrote: > On 12.08.2020 11:14, Arnd Bergmann wrote: > > > > It seems there have never been any callers and the entire file > > can just be removed, with the rest of that platform_data header > > file moved to drivers/media/platform/s3c-camif/. > > Yes, it seems that patch never made it to mainline: > https://git.linuxtv.org/snawrocki/media.git/commit/?h=testing/s3c-camif&id=355cbf835aff2aabf78390931cbbaa608af77967 I suppose it would still apply if anyone was interested, but I see your point. > I doubt there are still users of camera on the s3c2440 boards > with current mainline kernels, if any at all, there are much > better HW alternatives right now. I see two board files (and no DT) instantiate the camif device: NexVision Nexcoder 2440 and the FriendlyARM mini2440. Can you say whether the camif on those would actually work at all without your patch? If not, we know that there are no users of that driver and could either drop it completely or move it to staging for a release or two. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel