From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB8FC433DF for ; Mon, 18 May 2020 09:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 840AE207D3 for ; Mon, 18 May 2020 09:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbgERJal (ORCPT ); Mon, 18 May 2020 05:30:41 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:45503 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726040AbgERJal (ORCPT ); Mon, 18 May 2020 05:30:41 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N30VJ-1iwITr3ZlN-013KC9 for ; Mon, 18 May 2020 11:30:39 +0200 Received: by mail-qk1-f174.google.com with SMTP id i5so9362828qkl.12 for ; Mon, 18 May 2020 02:30:38 -0700 (PDT) X-Gm-Message-State: AOAM531vErg581ItIlIbXLYBJUgawe5hU1rIIPJIWAmonQGyyCRYRcZ+ iCw2jXqNaYzNZO+d5WnwVu2wMeJw0Q2+4Cxg240= X-Google-Smtp-Source: ABdhPJxRqWQIj9CjL9GR9FsX53141b4RwqeRLWTo40Ql7QOtN7iteNEnTf9KKJLcV8J+ZKUnKb5gG3rk3PdK7Chz1lE= X-Received: by 2002:ae9:ed95:: with SMTP id c143mr14877840qkg.394.1589794237799; Mon, 18 May 2020 02:30:37 -0700 (PDT) MIME-Version: 1.0 References: <20200518091222.27467-1-sudeep.holla@arm.com> <20200518091222.27467-8-sudeep.holla@arm.com> In-Reply-To: <20200518091222.27467-8-sudeep.holla@arm.com> From: Arnd Bergmann Date: Mon, 18 May 2020 11:30:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support To: Sudeep Holla Cc: Linux ARM , Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , Steven Price , "linux-kernel@vger.kernel.org" , harb@amperecomputing.com Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:HZubW3EcYdXsdU11J3kNXOpT7zY8kXCxBtl6oOPgRK6AVl1UAkb uC4N/aGNszqVreLRS2AEf6BmmVN52veXmJi//gA0Rrxix7FisldM2ZsxDxbipFU/ZsJPn+2 Dt8/+6pAyIUJSnlfnk2YcJDiXWbkDgtpefSHnRsJzmHDMe/qQ4a9nmeAZvcRCXqhEcLeKRN se/YWgXx7ktVkWeIeqh5Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:VGXT3xbwVaQ=:roa4Clbkc9i3Mb5gAgWh54 hBoLaLwefpiZJAal7DfXniL/VWqrrUGyBEl8iKSkQxPasaUV/gOD+enCk9PPDsrtzUtqZu6Qh zFbq9fvUOMDvXfq5kEoGTzTO+bsT/UdUo9Ori9M1P+oO7LigLTey8uJRid6Xz5xgUivDaL2zc If7SXV9GeAdSlwRXug0V9UX64/bkDGyKvzHHFD77EryxZA/g7EVcauKm4p3258frcYkwbbhlL P7WhLDfhEfoz+80xE2iwJH4D5GzYTsQ7eQ/etRWXmYlQQqCUW+bZ7+I4xx/tE4pq4FtLIXMxW pXOAtG6TVx1iB6YtEiqmDXDJajdzAF1zRi/VgkfOPBTGMFxQ0D0fcsZZwl8zQLtHyLUiaLxKK YprXuOgSc7xZGBZDEPzHLX7hdXnosTN6VZ+67Ya/ClsyIchE0QXlhs3A81qSGm0s807TTAcTq qEe3hnt416TZUtePd1P8kVcNXuFZGNA7IsAwBwdhuHG+MczooSX36cdjjHmC0/8mLVNtn0+yo 5Sgtt0Izll9CVKRrPtCzGAovioVik7lAXqw0gW31HFyoQ5+FIX9IVFVIqbM1ZUQFkZo6+vXCz ZV2Jsk6BTQPR6b89ET7f+y62MG/44FrgEz2VrFICeg6o8pZJtnA471iFOl8+/yHIuRv+6VMc1 tGyN17AlRGfhQrV+aGLCPZsLduNnarD9BgYRSGGsJb1ljfe71ji5Oz+YNjXmGS0O+RmcKd0Zc 76suxu/7B2zdWHTIbvjrWySeeGBqbyzOkJKuqSQCah6qhUalT3dM9tiF97bltuiKB0IwJ/29k ZQjHjH2JI3xX46CtOky9riQ10iqzUF6CQ7CsfY6jdWgSANYxCs= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 11:12 AM Sudeep Holla wrote: > +static ssize_t > +jep106_cont_bank_code_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_BANK_CONT_CODE(soc_id_version)); > +} > + > +static DEVICE_ATTR_RO(jep106_cont_bank_code); > + > +static ssize_t > +jep106_identification_code_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_ID_CODE(soc_id_version)); > +} I think we should try hard to avoid nonstandard attributes for the soc device. Did you run into a problem with finding one of the existing attributes that can be used to hold the fields? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA00FC433E0 for ; Mon, 18 May 2020 09:30:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B70D7207ED for ; Mon, 18 May 2020 09:30:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aqIAR8zS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70D7207ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mZugO8G8f0UVBlmokvKkl7aOV3GCZaGgzqa1YAzIfGI=; b=aqIAR8zSTr9jre drBBvToyq+aOnGQMdyI3J9TaOVZRbQ2fLmDXE4LBCNqC0EH14ga9yPdxxHArXmbq2SdnvOKDpGYVQ w9YTNYpF+4LiyydYB/ukoi58UssYnVtn0Rn1dzkjm9TSf8z/tlKMByWI7/1oK+oktypPAFYOU4hnr MzQ83/VUadjsr8lbEqVistGhY2wilxz34uWJZE4sUd3EXdzYJUL2D8xuOVoVuKeTO0AsJeT1Rw4CV O6HgCjQyW2Yshw8LVhbuiR2MAQuVjK0gxTg/HSATNlYVkG+2HEIMnC1pPt/MsejXWnbNJg8WvDn9V e/gvPsIOy8T5v+QN3xxg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jac6h-00049O-Ay; Mon, 18 May 2020 09:30:47 +0000 Received: from mout.kundenserver.de ([212.227.126.131]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jac6e-00048S-OO for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 09:30:46 +0000 Received: from mail-qk1-f181.google.com ([209.85.222.181]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MkYLW-1jD8uP0sJy-00m2mx for ; Mon, 18 May 2020 11:30:39 +0200 Received: by mail-qk1-f181.google.com with SMTP id g185so9395765qke.7 for ; Mon, 18 May 2020 02:30:38 -0700 (PDT) X-Gm-Message-State: AOAM5306oLKkBAyIAz2nv+v9ktZwGUfnqph001FZzRCsfp1etfgKvHkI yIBjCXBLF9UQYbijrQtAHU6LCD9I2B46lPEBals= X-Google-Smtp-Source: ABdhPJxRqWQIj9CjL9GR9FsX53141b4RwqeRLWTo40Ql7QOtN7iteNEnTf9KKJLcV8J+ZKUnKb5gG3rk3PdK7Chz1lE= X-Received: by 2002:ae9:ed95:: with SMTP id c143mr14877840qkg.394.1589794237799; Mon, 18 May 2020 02:30:37 -0700 (PDT) MIME-Version: 1.0 References: <20200518091222.27467-1-sudeep.holla@arm.com> <20200518091222.27467-8-sudeep.holla@arm.com> In-Reply-To: <20200518091222.27467-8-sudeep.holla@arm.com> From: Arnd Bergmann Date: Mon, 18 May 2020 11:30:21 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 7/7] firmware: smccc: Add ARCH_SOC_ID support To: Sudeep Holla X-Provags-ID: V03:K1:l3a9vQV6z/eckRgnrS+/QJtj2usQU9H0PeKIANhBVS+I72ueaNU m1jgpGPF0QLZ5+1eIOTA4WD/afcf0fUnN9V32E04u9ezYGzJmqDmaKQaYbaxhrjmNBPHK71 7Ccw/Jg5upfl3e52CmBhiE77cnlu+MXK9cj0FflrAC1ANoj3sgA71lMU8ND+kx9BAvqIguw n05+Q1wDwGunmwi6P76ZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:C5B565Pg0h4=:03/tVMwEejlo6ZkuDnZnGS RwG9HEMgcjkwhtZDus8aN9gxi9Qo8l1YuQrdV6Cj7ahMh89HSUHrItxxzgn4ZyuKRuZJqC3T1 rVDVMUDrMZ36CbFLaDILvKDjs5Y4N8Q/SSaYOScolDetAmqxdyRFpkozqEHr7KybegycBMRi3 cV0tfZxRSQu0zs72u3taFzr5P1bYDh3X3AdQw9Hno6iltT+yMbj/boiD2/CTDyA0iuMUkZNKv RiypOXYU+j77qFEKek02Vb0zFO24rd5SAxPov8FEUI8gV9zOynqRk83TQtUKidTHIMR9eU+up R8N9XJPdNpQQt64vuqMalH9PtzguS6V8P30oP3qshvfqbvZxYG7xeYS1IWgxsikshjc1q0+hQ e1ZHbAcpRCG+kdoPJ+xK1gG2hQyhapDZytwmXPjIfCtSnCpGzPjSmzfFRgrJXN0d+Ax1gMj8u 1XIODuYXg4v2U7pYrjvkQ8EuAgxfklx+Ut5yir1zmir4GbmvtMpfPxIYmUubUUi007xJOF2PA AxhW42LumrFYH5NSQTlcMb0Drk3Csqkj/ZuOryIsAxwZVMiwXSs+V8jDP/775f7fWSjudjs0V t0Q1V+yvyIOSFt6im/xN3XmCzxafidmKI5Ay+M+YuvQald/yZMK11fuTmnEFp/ax+RxuOxvY7 ogd/63ajtBgsGBiXqDT3Jk0GxF+/U8NtSHL8YNCpavK77RcxAseqDSu9asmZ+4LLq12/uS0Hy /NPPmPV1H4T96gW+INjqbl7gmFHnmSe8Wvlkvf4C40lLRo7RWO9N0FnfRlE/dqEsxu8t1d3DH tZHv6kiPNyBWXtB/xuK+8xxmFpDQ4wRhTAVEBk04NRxtX+sOB8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_023045_090942_9A0CE84A X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Catalin Marinas , "linux-kernel@vger.kernel.org" , Steven Price , harb@amperecomputing.com, Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 18, 2020 at 11:12 AM Sudeep Holla wrote: > +static ssize_t > +jep106_cont_bank_code_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_BANK_CONT_CODE(soc_id_version)); > +} > + > +static DEVICE_ATTR_RO(jep106_cont_bank_code); > + > +static ssize_t > +jep106_identification_code_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sprintf(buf, "0x%02x\n", JEP106_ID_CODE(soc_id_version)); > +} I think we should try hard to avoid nonstandard attributes for the soc device. Did you run into a problem with finding one of the existing attributes that can be used to hold the fields? Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel