[PATCH net-next] ptp: ocp: Simplify Kconfig.

[PATCH net-next] ptp: ocp: Simplify Kconfig.

[Jonathan Lemon]

Remove the 'imply' statements, these apparently are not doing
what I expected.  Platform modules which are used by the driver
still need to be enabled in the overall config for them to be
used, but there isn't a hard dependency on them.

Use 'depend' for selectable modules which provide functions
used directly by the driver.

Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
 drivers/ptp/Kconfig | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 32660dc11354..f02bedf41264 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP
 	tristate "OpenCompute TimeCard as PTP clock"
 	depends on PTP_1588_CLOCK
 	depends on HAS_IOMEM && PCI
-	depends on SPI && I2C && MTD
+	depends on I2C && MTD
+	depends on SERIAL_8250
 	depends on !S390
-	imply SPI_MEM
-	imply SPI_XILINX
-	imply MTD_SPI_NOR
-	imply I2C_XILINX
-	select SERIAL_8250
 	select NET_DEVLINK
-
-	default n
 	help
 	  This driver adds support for an OpenCompute time card.
 
-- 
2.31.1

Re: [PATCH net-next] ptp: ocp: Simplify Kconfig.

[Arnd Bergmann]

On Wed, Aug 25, 2021 at 11:17 PM Jonathan Lemon
<jonathan.lemon@gmail.com> wrote:
>
> Remove the 'imply' statements, these apparently are not doing
> what I expected.  Platform modules which are used by the driver
> still need to be enabled in the overall config for them to be
> used, but there isn't a hard dependency on them.
>
> Use 'depend' for selectable modules which provide functions
> used directly by the driver.
>
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
>  drivers/ptp/Kconfig | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH net-next] ptp: ocp: Simplify Kconfig.

[Randy Dunlap]

On 8/25/21 2:17 PM, Jonathan Lemon wrote:
> Remove the 'imply' statements, these apparently are not doing
> what I expected.  Platform modules which are used by the driver
> still need to be enabled in the overall config for them to be
> used, but there isn't a hard dependency on them.
> 
> Use 'depend' for selectable modules which provide functions
> used directly by the driver.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> ---
>   drivers/ptp/Kconfig | 10 ++--------
>   1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
> index 32660dc11354..f02bedf41264 100644
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -171,16 +171,10 @@ config PTP_1588_CLOCK_OCP
>   	tristate "OpenCompute TimeCard as PTP clock"
>   	depends on PTP_1588_CLOCK
>   	depends on HAS_IOMEM && PCI
> -	depends on SPI && I2C && MTD
> +	depends on I2C && MTD
> +	depends on SERIAL_8250
>   	depends on !S390
> -	imply SPI_MEM
> -	imply SPI_XILINX
> -	imply MTD_SPI_NOR
> -	imply I2C_XILINX
> -	select SERIAL_8250
>   	select NET_DEVLINK
> -
> -	default n
>   	help
>   	  This driver adds support for an OpenCompute time card.
>   
> 

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

-- 
~Randy

Re: [PATCH net-next] ptp: ocp: Simplify Kconfig.

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 25 Aug 2021 14:17:33 -0700 you wrote:
> Remove the 'imply' statements, these apparently are not doing
> what I expected.  Platform modules which are used by the driver
> still need to be enabled in the overall config for them to be
> used, but there isn't a hard dependency on them.
> 
> Use 'depend' for selectable modules which provide functions
> used directly by the driver.
> 
> [...]

Here is the summary with links:
  - [net-next] ptp: ocp: Simplify Kconfig.
    https://git.kernel.org/netdev/net-next/c/bc8e05d6b965

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html