From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45D39C433DB for ; Fri, 5 Mar 2021 08:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C48065005 for ; Fri, 5 Mar 2021 08:07:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbhCEIHj (ORCPT ); Fri, 5 Mar 2021 03:07:39 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:42201 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhCEIH1 (ORCPT ); Fri, 5 Mar 2021 03:07:27 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N2E9Y-1lm63n2Iuc-013cng; Fri, 05 Mar 2021 09:07:25 +0100 Received: by mail-ot1-f51.google.com with SMTP id a17so1005485oto.5; Fri, 05 Mar 2021 00:07:25 -0800 (PST) X-Gm-Message-State: AOAM533vRXAxoUPaBgl0HS7R4QeB7HkjE4SSbsD5JQGn+Ai7Q32FV/Jr VTKktjB1597AN30P4meFPhnnclGiSeaf6scfXj8= X-Google-Smtp-Source: ABdhPJxqYuCXgKHG79cARIlIIknf25ifduq2VjGAMPfck87tlTFpc5wPGypB2miMGioSDWeCxnxnQNvQKnonMZbh/Ag= X-Received: by 2002:a9d:7f11:: with SMTP id j17mr7135133otq.251.1614931644090; Fri, 05 Mar 2021 00:07:24 -0800 (PST) MIME-Version: 1.0 References: <20210305034927.3232386-1-weiyongjun1@huawei.com> In-Reply-To: <20210305034927.3232386-1-weiyongjun1@huawei.com> From: Arnd Bergmann Date: Fri, 5 Mar 2021 09:07:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: fix return value check in s3c2410_udc_probe() To: "'Wei Yongjun" Cc: Felipe Balbi , Greg Kroah-Hartman , Krzysztof Kozlowski , Nathan Chancellor , Nick Desaulniers , "Gustavo A. R. Silva" , USB list , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , kernel-janitors@vger.kernel.org, Hulk Robot Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:CHaEdIqKwG3T/zUOLoGwZ+zqo2NWAkLmBho1rTOPqdisV4PiNP+ p2BGL6Q3j4YElrJqtgJ0o+1tGRMu8oUgm/3q2ZwfdvGNdm1Je991tSuA6vtAXxLadkSn3+n TDeIbKI8GghsJ8E+CASotghhBdxVV5DNk25IdsXCY0Gy7eMWszfT/87jIszIV5Q4ddxxJfr Of4cRQmKPi1MOkGbYkZ+A== X-UI-Out-Filterresults: notjunk:1;V03:K0:7k9th40rb8E=:MQtw6gUY57uOyLuH0qWkNF dPl9Agm9R6lbXDEFuWukb4gGg2zYEOJCSJe4cNKq/9oB9N0y8i/o1OZi0TK+4sZT2al0ka9my /nfWdxpRpiclWz/usb14gkbBtKnsqezHe1W44tMlE7a48LPokBpWeQz2Upr2pLslsujrWEEgz AOJMqvujkTBkOluSxrVLw1Cu6IDTTAJq5wgFaY6b0+jOHs2gu0ZXzy/6JrCkWHYZWuOnOT8J+ 8KbfLEwdoy/9XaC//8J6RkWlqYTsSJwkDUduksZn0oX+C1AaXmgzq/dOl85KjEpiXLdb/3kWL unlMUMg/TZKp9LCsVoqxxc6BtGOZXlT/G+zdhTa3o8/1zPaFV6xPodN8O8o4pCcAmXmOQGGsg fKM21bYLumKTLw2F1tPcn3obW2HlES2Qay5peToR1P3NbZ4kOwCbk4Kg/tmrKTAYuxA7/CuXT ynRj/JyD1Hh5oize37vVhh4m4LVla0yiomQwL1GyK1udOn2P5+YCHqaIQQLran5SDafm76VyV M5Vjcp06TwEaplNVrcI8SgAfP1cFkgM6NwUTBBxrRQi Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Fri, Mar 5, 2021 at 4:49 AM 'Wei Yongjun wrote: > > From: Wei Yongjun > > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Nice find, thanks for fixing it! Reviewed-by: Arnd Bergmann From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E39C433E0 for ; Fri, 5 Mar 2021 08:09:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1692465005 for ; Fri, 5 Mar 2021 08:09:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1692465005 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DyBce1jFtLJ842gFN3Hoy4+ZyPSm9v4WIdq+2lwXLPQ=; b=dXJ6zgubycHW1CwGK/7X3xT8e bXQPQVf8uYySaOXxbZ4bI19HFn+yALrzhXHNPUHAcjRsKTENhJ7aPyVWAndRRkzEmnw4iLxhZctzG G5BY/0WwO/BiyRX53k2IbBRyfV/QfujgOCVOR7hO8BxYdO7vXo+VCqVakMws4FedXDfHOgu8dmR5s UwQyw6Bmgc5zNcaw+eaxjaPo2su4RRm+Rsk56IH5PLfjN8SYLtXk9FxChCKjfdkZjkhH9wVu0FlGS t5v3eKAKaaBI/F5AHNIrmdklHKIN5vukctMoyelJY0neR6AhVrtICUbkzMQ21PU3ITOSsGTrxZc4m Taf6QZcZA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI5Uk-00Du8H-PJ; Fri, 05 Mar 2021 08:07:34 +0000 Received: from mout.kundenserver.de ([212.227.126.135]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI5Uf-00Du6h-Gy for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 08:07:31 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1M26iv-1lK1Qq2dEP-002Ug3 for ; Fri, 05 Mar 2021 09:07:25 +0100 Received: by mail-ot1-f44.google.com with SMTP id g8so1008725otk.4 for ; Fri, 05 Mar 2021 00:07:25 -0800 (PST) X-Gm-Message-State: AOAM531Q5aeLZI2IamNZ4JltZw3nBEfNYyOkAX4ZmXIDaLYpKk9EGu2o vFk9S/t27v31QzAiZKtt1lj17cODLzypuRF1fJo= X-Google-Smtp-Source: ABdhPJxqYuCXgKHG79cARIlIIknf25ifduq2VjGAMPfck87tlTFpc5wPGypB2miMGioSDWeCxnxnQNvQKnonMZbh/Ag= X-Received: by 2002:a9d:7f11:: with SMTP id j17mr7135133otq.251.1614931644090; Fri, 05 Mar 2021 00:07:24 -0800 (PST) MIME-Version: 1.0 References: <20210305034927.3232386-1-weiyongjun1@huawei.com> In-Reply-To: <20210305034927.3232386-1-weiyongjun1@huawei.com> From: Arnd Bergmann Date: Fri, 5 Mar 2021 09:07:07 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] USB: gadget: udc: s3c2410_udc: fix return value check in s3c2410_udc_probe() To: "'Wei Yongjun" Cc: Felipe Balbi , Greg Kroah-Hartman , Krzysztof Kozlowski , Nathan Chancellor , Nick Desaulniers , "Gustavo A. R. Silva" , USB list , Linux ARM , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , kernel-janitors@vger.kernel.org, Hulk Robot X-Provags-ID: V03:K1:SamFgZCI/+wpTHMkW7rEYD1pqKlu7KKwDOArdk4HxtG+0cjs5uQ F7JaH6DR2W/18WP8kRNiCXdZqVheLcx+YgMuYNqyX49XJpGh+fJIz55KnNS+7FFsSqW1EWp D9lKYqhqeT25HRBEVVFgZaRdkLgK5e4qTGkCYNwq21z3HggQ5K7cwSCJkjOVl99Fl85g3/C KyyjXT4AO1uoVEWurk67g== X-UI-Out-Filterresults: notjunk:1;V03:K0:19Z8VB76Cgw=:jvAiB9LqVXlbnVXQTAl+2G RayDwiNu9kQFEVi7/ixC++g8+5r+OSENTCTHf0OHH9hiHYljBBobOMwpaL7dVnYahuEpYsfTc z20sFQLa6HXLBkMQRYnHgukmWWuyvtSlHVs/S1Jktgo217VWwFUFDivwOMCvbZzcM5WgrsPP2 2NbBshLE5lrE3VbBgIk09PVHct6AZY5yJxJcgps+sI7Urd7wkP98f5CSwK5oKUgrBn7sWoE8k odf4Tbh42ouJ1aqvK1qbL5lpeMBbln2ygB6XRAKQWM7AM6YiSAmYDRocCWEgGmwDGZ9Y2TtPm 4Fpa8zxcLkzlKettGSbujFiOreG8kwsObMg5Um+V/p1vu4s74bjkyFqQxF0k0FgHu8opyj3sN brtH9kHMR/0B+Rhj8xsb+de45Kj+V2IkM3kpUlStH05iOunxxhNWx6Z97SDXP X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_080729_836202_A566A156 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 5, 2021 at 4:49 AM 'Wei Yongjun wrote: > > From: Wei Yongjun > > In case of error, the function devm_platform_ioremap_resource() > returns ERR_PTR() and never returns NULL. The NULL test in the > return value check should be replaced with IS_ERR(). > > Fixes: 188db4435ac6 ("usb: gadget: s3c: use platform resources") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Nice find, thanks for fixing it! Reviewed-by: Arnd Bergmann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel