From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751732AbdFIJTR (ORCPT ); Fri, 9 Jun 2017 05:19:17 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:36523 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbdFIJTO (ORCPT ); Fri, 9 Jun 2017 05:19:14 -0400 MIME-Version: 1.0 In-Reply-To: <20170609073037.21871-1-andrew@aj.id.au> References: <20170609073037.21871-1-andrew@aj.id.au> From: Arnd Bergmann Date: Fri, 9 Jun 2017 11:19:13 +0200 X-Google-Sender-Auth: MOyE5UzloEFYBxlswYoavnmX-RA Message-ID: Subject: Re: [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup To: Andrew Jeffery Cc: Daniel Lezcano , Joel Stanley , Linux ARM , Linux Kernel Mailing List , Linus Walleij Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 9, 2017 at 9:30 AM, Andrew Jeffery wrote: > Add the clock-names property in init_timer() to work-around Aspeed > devicetrees from times prior to merging the Moxart/Aspeed and Faraday > drivers. > > Signed-off-by: Andrew Jeffery > --- > Well, here's an implementation I knocked up. It's a fair chunk of code for > marginal benefit. Joel is against it. > > At least it's something to debate. > > Tested under QEMU for both AST2400 and AST2500 SoCs. Right, I think having the one-line fixup in the driver makes way more sense here, and that is what we usually do, but we could do this if Daniel has good reasons to keep the driver free of backwards-compatibility support. It also depends a bit on how common the old binding version already is, and if anyone is shipping systems with that. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 9 Jun 2017 11:19:13 +0200 Subject: [PATCH] arm: aspeed: Add Aspeed board file with clocksource devicetree fixup In-Reply-To: <20170609073037.21871-1-andrew@aj.id.au> References: <20170609073037.21871-1-andrew@aj.id.au> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jun 9, 2017 at 9:30 AM, Andrew Jeffery wrote: > Add the clock-names property in init_timer() to work-around Aspeed > devicetrees from times prior to merging the Moxart/Aspeed and Faraday > drivers. > > Signed-off-by: Andrew Jeffery > --- > Well, here's an implementation I knocked up. It's a fair chunk of code for > marginal benefit. Joel is against it. > > At least it's something to debate. > > Tested under QEMU for both AST2400 and AST2500 SoCs. Right, I think having the one-line fixup in the driver makes way more sense here, and that is what we usually do, but we could do this if Daniel has good reasons to keep the driver free of backwards-compatibility support. It also depends a bit on how common the old binding version already is, and if anyone is shipping systems with that. Arnd