From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932314AbdKFRMH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 12:12:07 -0500
Received: from mail-oi0-f66.google.com ([209.85.218.66]:50444 "EHLO
        mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753984AbdKFRMF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 12:12:05 -0500
X-Google-Smtp-Source: ABhQp+QJ//QGVoAa/jPV97FkvcJKmk6v/TLy05JcfLCAKTXLXPzLZ9ZMCLzimSSM2arAtJ38Ru8HHjcQ4DZNS/TEGAE=
MIME-Version: 1.0
In-Reply-To: <20171106165021.GV19485@e103592.cambridge.arm.com>
References: <20171106133700.558647-1-arnd@arndb.de> <20171106165021.GV19485@e103592.cambridge.arm.com>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 6 Nov 2017 18:12:03 +0100
X-Google-Sender-Auth: e9VRcO1c55D72zyTBjnUG12SP0I
Message-ID: <CAK8P3a25CP-FgezD1S-8kNMCZF3CGraKAvDdb6KaV6HJXATZJw@mail.gmail.com>
Subject: Re: [PATCH] sysctl: add register_sysctl() dummy helper
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 6, 2017 at 5:50 PM, Dave Martin <Dave.Martin@arm.com> wrote:
> On Mon, Nov 06, 2017 at 01:36:40PM +0000, Arnd Bergmann wrote:
>> The register_sysctl() function has been around for five years with commit
>> fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users")
>> but now that arm64 started using it, I ran into a compile error:
>>
>> arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
>> arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'
>
> Hmmm, looks like I missed this combination in testing.
>
> I wonder whether ARMV8_DEPRECATED without SYSCTL is really a good idea
> though: in that config, we build a lot of dead code and leak some
> memory today.  The default emulation is still potentially useful, but
> all the support for runtime twiddling of the emulation modes becomes
> useless.
>
> For parallel reasons, the SVE sysctl stuff is protected by #ifdef
> CONFIG_SYSCTL, which is why I didn't get a similar splat there.
>
>
> So, although this patch is superficially sensible, it may tend to hide
> bugs: code that calls register_sysctl() when CONFIG_SYSCTL=n is
> suspicious and probably needs review... no?

I think your analysis for this code is correct, we waste a lot of memory
if we do it like this. However in the general case where we register a
statically allocated 'struct ctl_table', it wouldn't be an issue, because
gcc could then eliminate all the dead code.

Adding a CONFIG_SYSCTL #ifdef or Kconfig dependency would
probably be reasonable for armv8_deprecated.c, for the rest of
the kernel, having that wrapper is probably better.

I don't really care how this gets fixed, as long as some solution gets
merged.

       Arnd