From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A549C433E1 for ; Mon, 29 Jun 2020 21:30:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 624A02073E for ; Mon, 29 Jun 2020 21:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728862AbgF2VaX (ORCPT ); Mon, 29 Jun 2020 17:30:23 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:41545 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727842AbgF2VaV (ORCPT ); Mon, 29 Jun 2020 17:30:21 -0400 Received: from mail-qv1-f49.google.com ([209.85.219.49]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MKbPg-1jX6cV011A-00KzBD for ; Mon, 29 Jun 2020 14:02:39 +0200 Received: by mail-qv1-f49.google.com with SMTP id m9so7486313qvx.5 for ; Mon, 29 Jun 2020 05:02:38 -0700 (PDT) X-Gm-Message-State: AOAM531OhSZ4Zoi9/bYdMoK6biOyoO+eqbwsGGTmbZ0keiM5SDlWoVK6 jvLxNsogocXhhjDiosJIyLVA7aNEJN3Iu2Ozak4= X-Google-Smtp-Source: ABdhPJznG3KXhGobnsMvegA1SAcvtwATKB5v7VQ9LDYftJtnSRjGxsomTyailCW05ySyhsOgMimFanF2ob2IwX+YusM= X-Received: by 2002:a0c:f385:: with SMTP id i5mr15202056qvk.4.1593432157860; Mon, 29 Jun 2020 05:02:37 -0700 (PDT) MIME-Version: 1.0 References: <1593425623-31810-1-git-send-email-Anson.Huang@nxp.com> <1593425623-31810-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Mon, 29 Jun 2020 14:02:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D To: Anson Huang Cc: Russell King - ARM Linux , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Catalin Marinas , Will Deacon , Philipp Zabel , Stefan Agner , "oleksandr.suvorov@toradex.com" , Bjorn Andersson , Leo Li , Vinod Koul , Geert Uytterhoeven , Olof Johansson , Linux ARM , "linux-kernel@vger.kernel.org" , dl-linux-imx Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:l3q3mI9pQkh4SjS+dXvkIKT5eYVF8JrWprPUbEW3p4wwCMyfXFe ZfHtRl84B7bpttx5J2tcvJtlOKAywx4+Ydkh6Za6y0lbVZM9vHJixqjStLPjM4MjPZzGK1L KnOahbsge/xvleZjhRWJtv4s9SWBg0fX02UB7fNom6/O2JrCXRQfccDmkO/763/3AWapiBn 0e2Qi+ElsCUefFaJIbQ/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:wmc4CPQsBmY=:RBuD1LHCvp2XO9aoQRAm0M jMdSK7uHIgbNX8kRlMUX6ieO7YzI8HZhUc25Xvkffr3Tpmq9NRsfElXDsEdWdMc2GQDEHokj6 PLfg+vCYjJJSgjaCIf5fXhauq125u7vqS6Wh7f5S+vIkyTLWYt+Q4CYp/NUTvRn+HNbgIvmlJ 4zslJiYwVh8wFnywq0G8AyEuj4C4IO2HFncqxM8hLnvJuqqXGzxjL6Oj/4Wy7LLBQN1h18j9Q tZLY2mbcuFgGuauy6Zuyk/WDANOjgkBbmtaJAAZuZ05I5g0UeLg5yQbTtx2oc4tPENUGfpcDs P7E1ZI6E76Ld4Oz/d/kIEqFdAG6J1qv4en0knpaAOAPrv4T50j+Dl4hb9EYtKURXdIZfGdPyI a2OEaxup0NiPJUG12g4hG1eNUxdWieinbQp7WNTWzsnyQXvjHLbpENQnF1Atf+cTn4d/IZ/Kt ttbMyAuVLlAZaVGC4XkXQ5s/Q84MP1WQpgW1u7KItZB1Gvsggiuu1PCJQzo46zTGKzbLgbRS8 K4oecPTPhSi5ekI0PojUo9uI5pYX2z56sCCxXq3xxbDJSmk2bJHKCOEHatoUB8IzBLnxppgwS x4AXC/wWoVKWxaSYEsDQSVVjWdpPW8F8Qir0wgCSMBP102hjWfsrvHfPd6TVeMjXgykQxj1Ii pnsf4+mhFBm0/dc1hkCIJ7lfPL0dU/07EPf1XDtQ3Rnk8vQvNOgdKaiER/pINKM1OWiidKoXs q8YdF7WiQn3j7j9x5QxQMP2mpp9PHb/rd3zpvI/qDDn/4jgwxioOT8k+Z4avEtof+BeDhUkBo 4TpkGA83tIlrS3RIhR4AJiqs5gyVfmWBSDVUy1KF9LEI76lyMc= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 1:54 PM Anson Huang wrote: > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D > > > > On Mon, Jun 29, 2020 at 1:36 PM Anson Huang > > wrote: > > > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D > > > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang > > wrote: > > I don't understand. Why can't this driver be a loadable module on i.MX7? > > Please clarify in the changelog what the bug is on i.MX7. > > > > > ARMv7 SoCs is NOT in the plan, that is why I add this patch to make it > > > same as previously when this reset driver is =y by default. Without > > > this patch, this reset driver will NOT be enabled by default for i.MX ARMv7 > > SoCs, function will be broken. > > > > But it's the same driver, make it work the same way on all chips! > > > > I think artificially limiting a new driver feature to one chip just because nobody > > asked for it on another chip is not helpful. > > > > Understood, what if I don't select it in SOC config which is NOT flexible, but put it in > imx_v6_v7_defconfig, then user can select either =y or =m according their requirement? I would recommend using a 'default m if SOC_IMX7' or 'default y if SOC_IMX7', so any distros and users that have their own defconfigs still get a reasonable default, but can choose between =m and =y based on their needs. > And in imx_v6_v7_defconfig make it =y by default. Having =y in imx_v6_v7_defconfig sounds reasonable if you go with 'default m'. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F9DBC433E0 for ; Mon, 29 Jun 2020 12:04:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35B0D23D20 for ; Mon, 29 Jun 2020 12:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o+zkg57s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35B0D23D20 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+gOdDzG7Z3fu9AJa/zMFkB9z5WLHHSkPK4JHEI/8NoU=; b=o+zkg57sgA3Dv883R6WKpHxBh 863e7dAhr6hZTRd9sIysGD7fn017558hxuXzyAqVxL9kNtCvHn8HXUJjKknmonhaN0VQMf5ZDf7IW ohXr5HJlCv939qZJE/pZHWjHJDXRX4Swax8ZwcHUiz8ADZJXJj9as9BEsiBnaQSI7ciqWfKvRkL+A KdyOZeZjlMtjW3XPA3440B4GtnDLhZIFRbC8og50ujlxrIyi6TZsOMwU6KEZKjIQ+SSzJ3s9uETdv U937p6yQZIP5QEIPCaFWYP4/y/j2gvsSF0GLVn2dZ2klaSPke5Xb1iyEkqFRmPDdo2id5NJoVsXeq EjEKNaPGQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsUr-0007ld-3e; Mon, 29 Jun 2020 12:02:49 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpsUm-0007gQ-Pa for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 12:02:47 +0000 Received: from mail-qv1-f50.google.com ([209.85.219.50]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MVubb-1jQH7k1KL7-00RtCC for ; Mon, 29 Jun 2020 14:02:41 +0200 Received: by mail-qv1-f50.google.com with SMTP id d12so7497936qvn.0 for ; Mon, 29 Jun 2020 05:02:38 -0700 (PDT) X-Gm-Message-State: AOAM533CNTrKFZXjE3J5wyErZw6ocq/SKMZ8kYDYy879GBrDkVyvmPw1 uHyQw8ZEm4Fk6P6v1yDXTRsJ0ccSCuWXhN10nYA= X-Google-Smtp-Source: ABdhPJznG3KXhGobnsMvegA1SAcvtwATKB5v7VQ9LDYftJtnSRjGxsomTyailCW05ySyhsOgMimFanF2ob2IwX+YusM= X-Received: by 2002:a0c:f385:: with SMTP id i5mr15202056qvk.4.1593432157860; Mon, 29 Jun 2020 05:02:37 -0700 (PDT) MIME-Version: 1.0 References: <1593425623-31810-1-git-send-email-Anson.Huang@nxp.com> <1593425623-31810-3-git-send-email-Anson.Huang@nxp.com> In-Reply-To: From: Arnd Bergmann Date: Mon, 29 Jun 2020 14:02:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D To: Anson Huang X-Provags-ID: V03:K1:dqGiRBrGaG3ULb54BKhGHsgYkVMbQYZAw6I49gcEwNCyw/x9NNT UVsRLIx1VuIhDY3KHGFh33hM+S+UR8bFcRh+W+ZX1GEBeEFzzaoHPmx6AsOmo/vn3H3ePcx EgSwoDQiSsb5w81YmIFt2jOSIckaJh3Zd+H0BQv8uCH3waMh7e9PQK83UdwJFsCCDPGQD/d uD+G5SrLtCdam5qTbsFpQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:TI31vdAXRfo=:aNMp3O4Pen65Jw27Dhm46N e504m/3sURuzefuEmBCFp3H2VDmpxZUmwEQkf39maOPnvk26fJ9dn52aZo0EVfC8Jy+mEMxMd IdWTOvPTEQzHK6X6OclpxHrmXtxLFm/SkfSkBVi9pmUxYl7H+bgXRY07lRB2h6zBK38B4loNB 3Avi9fyMrGYj4nOeLZmrZjmQNErof0Obt6pieQj/9WNpJrA+1KESTBY4lSx3eUc1+PIps9TI1 2hZtkqhl/z3XmmBLzNnsCiPncKFHpTc87ZxwzW7OvraAobz+F2NydjZFLDB+CFUIx4qWlUMeF cyMSeW9Ey3tjszxOD80MasuEjQ0DTtmnwHmkE97JBIs9tM8tGK4WFYcmmdoGpNJ9ha2qEJrEr 4TG3uQXRnUcnkgsHvoFy6669G/4cN3IbLct9fGnJ8zY5d0vsI4zVsHojKMS042iGUsikVzMQs wOiXifUGn0hMtZRvDAda/dINPg+IG23iMD/FQbCns1v+oIw2fx0Pyeajp+Btd3eCqsSbcxgWG w9GmZwbzqhyH+eCgvdlPuLnz5GUATMCwrTZRB6f7YlUSSmnhZboUgcaXsZAzNtvIlfL+6sW63 tVvWPirHl0+AWAQ2GCduAii8NCCPzeTp36ctEabD1RAARLV4lIap3a8bY+On8yvJ3+/yF/7kV msN6LZfrfT1Rvz7V+A4wZjEYXw+ntCuMTUfYAvGR9MPNJgQYQzU1xKIXwMwaVRuhSTVbcFXmj bdSM/0SX3FroeS8MiO6WLr7aRAKbJX1CbEb/xDFCV2RyjREuLslICr37WbpQpW8wc/Pcw3ImC zofFV7AgYWobGAtfdfKTs/w/LX2Z3UWddLVMiwJJPg5ikCz3Eh1VtZHH5TqzwMIWfXclsIWlB y8RToZI0diev+JKrOCs1hAIJ2k0y5jEGyHaJmMfdWP74ntFufamr46aPvBtMBGBu/eRyH7QZn A+XaXW0gEXIjFUVwyHY0yaOzgi2FrZNzdhXZOcTa36qQUiIvsNplP X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Philipp Zabel , Will Deacon , Stefan Agner , Shawn Guo , Sascha Hauer , Russell King - ARM Linux , Bjorn Andersson , "oleksandr.suvorov@toradex.com" , Vinod Koul , dl-linux-imx , Sascha Hauer , Catalin Marinas , Olof Johansson , Geert Uytterhoeven , Leo Li , Fabio Estevam , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 1:54 PM Anson Huang wrote: > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D > > > > On Mon, Jun 29, 2020 at 1:36 PM Anson Huang > > wrote: > > > > Subject: Re: [PATCH 3/3] ARM: imx: Select RESET_IMX7 for i.MX7D > > > > On Mon, Jun 29, 2020 at 12:25 PM Anson Huang > > wrote: > > I don't understand. Why can't this driver be a loadable module on i.MX7? > > Please clarify in the changelog what the bug is on i.MX7. > > > > > ARMv7 SoCs is NOT in the plan, that is why I add this patch to make it > > > same as previously when this reset driver is =y by default. Without > > > this patch, this reset driver will NOT be enabled by default for i.MX ARMv7 > > SoCs, function will be broken. > > > > But it's the same driver, make it work the same way on all chips! > > > > I think artificially limiting a new driver feature to one chip just because nobody > > asked for it on another chip is not helpful. > > > > Understood, what if I don't select it in SOC config which is NOT flexible, but put it in > imx_v6_v7_defconfig, then user can select either =y or =m according their requirement? I would recommend using a 'default m if SOC_IMX7' or 'default y if SOC_IMX7', so any distros and users that have their own defconfigs still get a reasonable default, but can choose between =m and =y based on their needs. > And in imx_v6_v7_defconfig make it =y by default. Having =y in imx_v6_v7_defconfig sounds reasonable if you go with 'default m'. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel