From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A8F3C433F5 for ; Thu, 7 Apr 2022 20:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MGwGGBKGNBp/+b02WaeHMBeKDHoTNDgyhIZefCWOcFs=; b=sd//rR+QtMtQ0k HJKCa9AS87QEJGKyiUFLiNy04Xvk+hAt4Yt61+m5exTZBRjgUS1hhTUXqfT90/bZM0bXiRQlZknpy T0jJe3H9V8LLhgMkN0yuXzXTfS1KvuXjJQq+4Zmkld1ABsmEilf+yXxxYzbqYVbhFg7gAtqX/zsdX K7ktXQY3GOwH0gQ1RptZGIQ43DQ3f8/D1ZMml0l20O0u+fgqYJp4V5KWnkBSV1Ndrf3TxxjY9qCoH FDgaTyFUitqn7pyFSUZYXaspCm/XDKl4wyl8GM32Vs2/1zcBjwhbTcHn1VOMONlfSEnjGPe1tSFXk wR5lnL0g/9gsXI+wRrsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncYuC-00DxVK-PT; Thu, 07 Apr 2022 20:39:01 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncYu5-00DxQf-TO for linux-arm-kernel@lists.infradead.org; Thu, 07 Apr 2022 20:38:55 +0000 Received: from mail-wr1-f41.google.com ([209.85.221.41]) by mrelayeu.kundenserver.de (mreue010 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MfpjF-1oDpSZ3nnF-00gL48 for ; Thu, 07 Apr 2022 22:38:46 +0200 Received: by mail-wr1-f41.google.com with SMTP id k23so9561397wrd.8 for ; Thu, 07 Apr 2022 13:38:46 -0700 (PDT) X-Gm-Message-State: AOAM533AvPcyBwmTF3/vxSy66o1KwpmPudUYmQ7jXgKE6A0t4ojALTxH hij9D1LDkk9UMxr2MZj3hgBWOGArlC31JGBTEOA= X-Google-Smtp-Source: ABdhPJy/SgVGQPTQl0Z9Jj7qvw3Sglc2LkZldTdO5JZKiCcu9L8Hp1QDfF0ep5w8MjBFmfVBXWNB7IIvt2RfSfgvQwI= X-Received: by 2002:a05:6000:154d:b0:207:9101:8f24 with SMTP id 13-20020a056000154d00b0020791018f24mr802419wry.317.1649363926543; Thu, 07 Apr 2022 13:38:46 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-10-brad@pensando.io> <3c8e94e1-fb8e-0d8f-4e79-b8313a1da5cb@intel.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 7 Apr 2022 22:38:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support To: Brad Larson Cc: Adrian Hunter , Arnd Bergmann , Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , Linux Kernel Mailing List X-Provags-ID: V03:K1:d4WjmH2GL43X0vx2ctHGQqQrozJLGbgeZ0/Vt9GSirTYB55vl4Y 4WWvIQmosZ8EYILpo4Xfn3ZPmahynvtPSTBBp7OvAaB896itL8EG1WpDML9E9TOjFRbFSP+ Z41J1zbcIrUP3gONYaPr8pLWVd2jAEBxTbtsWsxxDNlyEIn9z2kKL/YEcGAsM/1WF9fgk6C yG7bcJXvMQi5hxWdhAEog== X-UI-Out-Filterresults: notjunk:1;V03:K0:8lqxea8d7UQ=:z2mpz/lvYOG+1mz3MvBtkK H907nASxpmMZwEP9BPB59LLC1LeoxPuWcmG1a32nTA0zoKhmXVElGetG6tDNR/u7Ru73sOxpO o5SIFyAlXLc8XKzGw2yuY6RFiKNpNFR8NStxwIfUR2oAcEeRInP1JuQSKkBXX+jdYUgRN9ij3 JsNswy1pvEcOs5L5UmXIvL6IoqJXSo2JPC1WwlifRXSJweBkb2jhSDNstyIgFQpD5p1SX7/zP 672ZiPGF+8cFK/OaSk24mld9pvvHb+gTRFT+ehRasGmVsCCSVdZG3P24HyCJaqRhlB6T/PKJi POCJdEUnzNVTwsk+c7vyXIIKeKjTdkn6bJyCxpK5ZAmcTFV+v2V2o07EfxlhVVu5dTU0H8FGI KG4K4qquA3/zBgOcXovnZfjgQS7FBqZsPsy2Pu8TJah7QtmkylsS6AfNmenwxQuj7o1tOZLZp oUHPWzi5iu8vR2qemqpTxcNez0ccrBaiv5HQAWa3oaSI/Xn2POGZ46ioCX+8BMXJYcFDmmKiC sPbNCMdljU0QYPe1rQ31gUs3gkfpfsFTq26pAq/Z9nQfxlyhksQMDRIrkJMnt7zVxWIB3VWtw l7Mf/4rlu5qYhInnvFj6oCGZ+Dlsy5ZzwMIZ9cdVpDdG6afdDf3mnAUrfnVC8nuwgx2M4DSvj BVq4rKXDbz33xJVvUlwNEmneEOO8PzjMiVfU5OYSxtgw60l9ALPXoSRTsI7qUjw7dgSw= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220407_133854_301518_63051406 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 7, 2022 at 7:06 PM Brad Larson wrote: > On Thu, Apr 7, 2022 at 12:13 AM Adrian Hunter wrote: > > > > What is the relationship between cadence and pensando elba? > > Pensando licensed the cadence controller, its 100% cadence IP. The > integration issue we ran into was with the accessors where we have the > workaround. The initial patch added a separate Elba driver file but > the feedback was the Elba support didn't justify doing that and to add > to sdhci-cacence.c. I looked back at the earlier reviews now, I think the main problem with versions 1 and 2 was that it had the abstraction the wrong way around, so you added the complexity of having multiple files, without the benefits. I still think that the cleanest approach would be to have it the way I suggested in my reply to v1, with an elba specific platform driver that calls into the generic cadence code, but the generic code knowing nothing about the front-end. Then again, it sounds like there was already an agreement about the approach you took here, so let's stay with that and hope we don't get any other chips with the same IP block in the future. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E28C433F5 for ; Thu, 7 Apr 2022 20:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbiDGUvn (ORCPT ); Thu, 7 Apr 2022 16:51:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbiDGUvC (ORCPT ); Thu, 7 Apr 2022 16:51:02 -0400 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE7131F2BA; Thu, 7 Apr 2022 13:43:51 -0700 (PDT) Received: from mail-wr1-f53.google.com ([209.85.221.53]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MulyX-1ntOth3jXf-00rq0f; Thu, 07 Apr 2022 22:38:46 +0200 Received: by mail-wr1-f53.google.com with SMTP id a2so296936wrh.5; Thu, 07 Apr 2022 13:38:46 -0700 (PDT) X-Gm-Message-State: AOAM530ai52r9ufA7kTLGlcyas14gLwlkPzi/xiF1Bx/MVbPAy5/7mTX mN7HScK10aw8zhSJPM6kcOobrSCmcdPlCY4RV2c= X-Google-Smtp-Source: ABdhPJy/SgVGQPTQl0Z9Jj7qvw3Sglc2LkZldTdO5JZKiCcu9L8Hp1QDfF0ep5w8MjBFmfVBXWNB7IIvt2RfSfgvQwI= X-Received: by 2002:a05:6000:154d:b0:207:9101:8f24 with SMTP id 13-20020a056000154d00b0020791018f24mr802419wry.317.1649363926543; Thu, 07 Apr 2022 13:38:46 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-10-brad@pensando.io> <3c8e94e1-fb8e-0d8f-4e79-b8313a1da5cb@intel.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 7 Apr 2022 22:38:31 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support To: Brad Larson Cc: Adrian Hunter , Arnd Bergmann , Linux ARM , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , DTML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:o+5RPQIna+gLLkibDSf2fxD5OHxRZ7cFKWDQu2hSxDFX8cL2ozw dBRBfnC3YHm3Sj26oGBZ9vZ5OibxClaK/qHQ8TzNau7RL6AFZ2dVJtULWNrkpGTotxJgnCE rw2CREtNEwogmnSw8BqH5JVuZTkgoA+ehLW3TUolhlboqj2OOExX/ogwHiHgwQSk8Hq2Cbz BNn3FJC1YDc91BAIJQiuw== X-UI-Out-Filterresults: notjunk:1;V03:K0:JiwMnTpDL4E=:wO5ksrBM4sf9BGnIYfujL7 UZK24sW+KeZc/eg41jcx+Yx5Ky5nzwChDpKySgfivmkttaQMvv2uwSK0vSwBB13NofOU6dMGI niIMxCgeQeeTfgJ8uQYj1J26JmDlI3zgNzhchs3eZZ0MIZkgjSTdvWaqsOmT2lQPOE3gm5zmf BFzO5itUAb1VEubP8TnyOEyhhZmfXX1PS8/eQfPkxw9BBsKSpZzX0Ipxu0M/pXhbft5QXXVn5 QTRde2/fQEjYwypYdHrTHR6dElTW6YSsuZu1RNxTlC+/ZCNwcCSaldR/uvjO7vhCKcrq3eVhX XxKOQwpVQY5nwsrzs5out0PXZOdgY484FKqqRxmJL8VautBAyaBxKZbWFLCGa2QUHbBqics2y 8QNwLeTiXJthpJRObMunbojqPEB0HOmv0tVO4J0I+ewkyQXGbxNej87rQvNzT7QjFyuvS0PYP 4cpRCkFdyS2ZcTDFB0VhzX1Tqvhw/1SqL3BIpNJ5u8Tt32bAPw2DQ4urBS6XgBXpa3tgmPwcY Cwkezb13+YxjxziBHfGQWHK0xWKZYQ5WEOf+kFnw9eHQ2L6R1PKFWUxSOK90HHp3yx3lgMXVw mWBktMHAVWLTGC02pX6tPGexYqqCisBNevWjNC5ZseMCG8Lv10gu8CVMwTNpEh0vBJx8u7Awx PHWbmrH/X3ZYCAxafkapjZMa8d9hZY9CLbRLy0utvAtztmc4gkWzyzGF7wp0I3FVTVeo= Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Apr 7, 2022 at 7:06 PM Brad Larson wrote: > On Thu, Apr 7, 2022 at 12:13 AM Adrian Hunter wrote: > > > > What is the relationship between cadence and pensando elba? > > Pensando licensed the cadence controller, its 100% cadence IP. The > integration issue we ran into was with the accessors where we have the > workaround. The initial patch added a separate Elba driver file but > the feedback was the Elba support didn't justify doing that and to add > to sdhci-cacence.c. I looked back at the earlier reviews now, I think the main problem with versions 1 and 2 was that it had the abstraction the wrong way around, so you added the complexity of having multiple files, without the benefits. I still think that the cleanest approach would be to have it the way I suggested in my reply to v1, with an elba specific platform driver that calls into the generic cadence code, but the generic code knowing nothing about the front-end. Then again, it sounds like there was already an agreement about the approach you took here, so let's stay with that and hope we don't get any other chips with the same IP block in the future. Arnd