All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: "Geoffrey Le Gourriérec" <geoffrey.legourrierec@gmail.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/1] Use types.h and not time_types.h in sockios.h
Date: Sun, 24 Jan 2021 19:57:03 +0100	[thread overview]
Message-ID: <CAK8P3a2A6M_srCHzw6rOH3uPDYvQJuUdNujFf8NnumNO4WqnOA@mail.gmail.com> (raw)
In-Reply-To: <CADFgU5DoO79Py0bN9SWsVCF=kH1ntySwRtGgeYa8FcS=QMVRJg@mail.gmail.com>

On Sun, Jan 24, 2021 at 5:38 PM Geoffrey Le Gourriérec
<geoffrey.legourrierec@gmail.com> wrote:
> > On Sat, Jan 23, 2021 at 5:56 PM Geoffrey Le Gourriérec <geoffrey.legourrierec@gmail.com> wrote:

> ...It looks like we do not enter the __ASM_SH_POSIX_TYPES_32_H include guard.
> Searching for that in the uclibc source code, I fall upon this header:
> https://repo.or.cz/uclibc-ng.git/blob/ab1dd83bec59c9e65c31efd6e887182948f627be:/libc/sysdeps/linux/sh/bits/kernel_types.h
> ...with a preliminary comment that seems quite explicit (I am not
> familiar at all with the
> subject, sorry if I'm perhaps stating the obvious):
>
> /* Note that we use the exact same include guard #define names
> * as asm/posix_types.h. This will avoid gratuitous conflicts
> * with the posix_types.h kernel header, and will ensure that
> * our private content, and not the kernel header, will win.
> * -Erik
> */
> #if !defined __ASM_SH_POSIX_TYPES_H && !defined __ASM_SH_POSIX_TYPES_32_H
> #define __ASM_SH_POSIX_TYPES_H
> #define __ASM_SH_POSIX_TYPES_32_H

Ok, so I guess this means that it's just a bug in uclibc. Most likely this code
dates back a very long time, back when the asm/posix_types.h in the
kernel was in fact defining the same types as user space. Since it now
only contains the __kernel_* prefixed types, you can probably just
remove this hack. If that doesn't work, then uclibc needs to be changed to
define the same types as the kernel header.

        Arnd

      reply	other threads:[~2021-01-24 18:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-23 16:56 [PATCH 1/1] Use types.h and not time_types.h in sockios.h Geoffrey Le Gourriérec
2021-01-24 10:55 ` Arnd Bergmann
2021-01-24 16:38   ` Geoffrey Le Gourriérec
2021-01-24 18:57     ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a2A6M_srCHzw6rOH3uPDYvQJuUdNujFf8NnumNO4WqnOA@mail.gmail.com \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dalias@libc.org \
    --cc=geoffrey.legourrierec@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.