From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2904C43603 for ; Fri, 13 Dec 2019 10:26:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC0EE2465B for ; Fri, 13 Dec 2019 10:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbfLMKZ7 (ORCPT ); Fri, 13 Dec 2019 05:25:59 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:41381 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfLMKZ6 (ORCPT ); Fri, 13 Dec 2019 05:25:58 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue009 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MtwQm-1hsHv71CF2-00uIBN for ; Fri, 13 Dec 2019 11:25:57 +0100 Received: by mail-qt1-f176.google.com with SMTP id z15so1862393qts.5 for ; Fri, 13 Dec 2019 02:25:57 -0800 (PST) X-Gm-Message-State: APjAAAXVGHaXeMLQZkIEWC4lzb5PPXuRY3l6wf433Ei87Y+sKx7o0USD nDK7IeBS4TEIPDbrzRAY11l02xy4f2L+/Q6FSW4= X-Google-Smtp-Source: APXvYqzQbLZzun4UPMcyYud1qq2XcN6i6bQrSev+tzenclZnUxptcZ8EZKr8KndoQJUpiIybOxbQeNJCn8vGS4FD6jo= X-Received: by 2002:ac8:3a27:: with SMTP id w36mr11551312qte.204.1576232756266; Fri, 13 Dec 2019 02:25:56 -0800 (PST) MIME-Version: 1.0 References: <20191211212025.1981822-1-arnd@arndb.de> <20191211212025.1981822-7-arnd@arndb.de> <0e00090ef6fcf310159d6ce23f2c92f511dd01de.camel@codethink.co.uk> In-Reply-To: From: Arnd Bergmann Date: Fri, 13 Dec 2019 11:25:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Y2038] [PATCH v7 6/9] ALSA: Avoid using timespec for struct snd_timer_tread To: Ben Hutchings Cc: ALSA Development Mailing List , Takashi Iwai , Baolin Wang , y2038 Mailman List , "linux-kernel@vger.kernel.org" , Jaroslav Kysela , Mark Brown , Baolin Wang Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:eyS+wQjnZNz8XyPyl7OLhOOP/wDeX2qqcVdn3UETFCnnYRFW5kK XV6/PfAorm72G8EwylAtton1Wxnx+7ZC2nnjQiYrupVpwm18dezrnDzEzNbD09yMaZCRxZV sSPgFzRzKvq6KRjSJmfpUhOjv1uQndpgTxAT6rMHMfC67+MSqaCh8r6TgEBtx4fC6fOLxvN /4QjeNzAI+UHIt1LfNvrw== X-UI-Out-Filterresults: notjunk:1;V03:K0:+GA4uxNrECo=:K+0oQWF19VYn4z5VS3irGY 4RtSeil13++KGWsdIzE8sIJpj2/ygJsKXZnseQB/u7HsNk6RvGpRv3X0+pz0poU8EYrrVV8uK /2/JjNoyKQ5nWYtAb6vY8U8RoDMize7haRAZE9osifpVvOA9vR+NTpddlC0Hr4sv3m8vG25k+ 77faQb/iFDN5u79GeMzk8PLq1RH7w29CtPXIv3KkBRnG3tjk3cEswA2hE8v08GqeOyHlzXs40 1FhO+oX1RPKDDlhAzq0s6wNp4HoGBaa14th28HpVIA8mxBfYT2h4T/A/nHrHMNt6QVX4l1vrb oJFfYQKUFXcZd1lPRRZyO9+zCO8Xh1G1vKnTbCzdIZ3+nvoET67arsRHGnD7pj7dVG44vE5VV 0ZR1nDRojIkINWGCz4ynpPcJoc78Bd1KwnFETqMO3rsB1L5CB6bgsojVN8VN4IGratvpF0y3G tSmMoUkOlEgYLkMy3wbvuYu1owhSituwf94RWJ6bi86AH0s+0AKYBBe0M8FvWh5OVC+oYidFJ +bSH59MTCf4vBqqXzWeV6Ng2sUL4hQZUZE0wQaZDxFWHCUKAtk5rhq/PNSaxSz1hhOWB7tjrL iSEnZpMNPMlvG4diPdlZzmAdQgWdWK7C3ZAnPQOOxGryI01KPMMjXiYvsBnqtPVTgz/eTCyOi uOUpCM6h5LouVUQW+4Asj+wY5bltmtXyPGjh4PIR+IG3v/Q7eH126wgdUUz2JWn9sjLYn+/i3 CD13A1KYccf0/3aW4Uf7FqiElSCiDErd4MqE71XOdjVoU1piE/IAmMiO1xs0yr0eZ+L8VOV6j OOFjE1fDwIBVDoWqWtvbaNGcdSbm2z31WBYAG22lDOf/poiLpaKpohJ/2D4/Y1j36QRsa583U uzN6B9iOWLgGBpvpAUQQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 12, 2019 at 3:27 PM Ben Hutchings wrote: > On Thu, 2019-12-12 at 10:57 +0100, Arnd Bergmann wrote: > > On Thu, Dec 12, 2019 at 1:14 AM Ben Hutchings > > wrote: > > > On Wed, 2019-12-11 at 22:20 +0100, Arnd Bergmann wrote: > > > > @@ -2145,14 +2202,34 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer, > > > > + case TREAD_FORMAT_NONE: > > > > if (copy_to_user(buffer, &tu->queue[qhead], > > > > sizeof(struct snd_timer_read))) > > > > err = -EFAULT; > > > > + break; > > > > + default: > > > > + err = -ENOTSUPP; > > > [...] > > > > > > This is not a valid error code for returning to user-space, but this > > > case should be impossible so I don't think it matters. > > > > Agreed. Maybe it should also WARN_ON(1), as there getting here > > would indicate a bug in the kernel. > > Yes, WARN_ON() or WARN_ON_ONCE() would make sense. This is what I added now: --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -2161,6 +2161,7 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer, unit = sizeof(struct snd_timer_read); break; default: + WARN_ONCE(1, "Corrupt snd_timer_user\n"); return -ENOTSUPP; } Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF500C43603 for ; Fri, 13 Dec 2019 10:26:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB6424658 for ; Fri, 13 Dec 2019 10:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="rixlw4Nx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDB6424658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 744B11762; Fri, 13 Dec 2019 11:26:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 744B11762 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576232814; bh=5L7yauyh3aXxYODQ7La3EvGKQaJpITBZdfe5zdydnY4=; h=References:In-Reply-To:From:Date:To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rixlw4Nx41k0Tf/H3eMTl/Zrt0MAdyziI26VSVcRnCTul/EHBEMozr+mbSDWmK32V aCAPOjOQK3oGTnbMUKIxTpoRmDsScFm4dGnLY0vt06hgNeQlx5ySyp9Kk40fOfbbYy 7h/ijys4cYfHWSu67oNya4GidaEeIC3KYJ1ajvXk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A6EFFF800AB; Fri, 13 Dec 2019 11:26:03 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76111F801F4; Fri, 13 Dec 2019 11:26:01 +0100 (CET) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99FFEF800AB for ; Fri, 13 Dec 2019 11:25:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99FFEF800AB Received: from mail-qt1-f170.google.com ([209.85.160.170]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1M5PRT-1igWxM1ywH-001Sk1 for ; Fri, 13 Dec 2019 11:25:57 +0100 Received: by mail-qt1-f170.google.com with SMTP id 38so1814416qtb.13 for ; Fri, 13 Dec 2019 02:25:57 -0800 (PST) X-Gm-Message-State: APjAAAVQbZzc7IP6kMnmw2Otmn52mpEiToaBEKHNmcYkI1gBgVEDc52p oOPcChu2OMSctm8kzZOtJouHdOkF/thIbSesm+w= X-Google-Smtp-Source: APXvYqzQbLZzun4UPMcyYud1qq2XcN6i6bQrSev+tzenclZnUxptcZ8EZKr8KndoQJUpiIybOxbQeNJCn8vGS4FD6jo= X-Received: by 2002:ac8:3a27:: with SMTP id w36mr11551312qte.204.1576232756266; Fri, 13 Dec 2019 02:25:56 -0800 (PST) MIME-Version: 1.0 References: <20191211212025.1981822-1-arnd@arndb.de> <20191211212025.1981822-7-arnd@arndb.de> <0e00090ef6fcf310159d6ce23f2c92f511dd01de.camel@codethink.co.uk> In-Reply-To: From: Arnd Bergmann Date: Fri, 13 Dec 2019 11:25:40 +0100 X-Gmail-Original-Message-ID: Message-ID: To: Ben Hutchings X-Provags-ID: V03:K1:tSFlHh/bUHJGyCZOIXacgcz0Yb0i3PCtcY/Dgjzweltx7E4qAAU At8YLjURAs7MIx0oCwfRCSQ03AMiiFQv0/9bc5U4pgJT7ejQAOdEZL64Basx8lefWihAxyE cHDSQGBv0mK+ZFWTRcHZUOdYWssSrRppHzbYRXtgDr+3zQNkC0NCmwJZWR+3sDUo+fFKgHw RM7W43MZuMLw16rn9t8sA== X-UI-Out-Filterresults: notjunk:1;V03:K0:X6qdoxPEOZM=:F1o1ur3+ffcE8k8pbLMrSG ctKIIWz3+HAY8+ZfrkkXJK6y4eSWOacQ+/L84of+sRanGh6zXn9rNsendy1DoSLSeqpU5cNEm nSGZ/OspzHmNU/JZhFoMf1ISSFk00pxQO+YCOpHsuQNmQBV0V+V52W8fojnyglsDYu+BEZvWA fnFOnBS9PMv3I1AApLYiOSGfHnI1+PS/imMF7GClpQKV15D3Mn8HMGzJIy8G1NbeQT2VVzgXr STrsNJ4iL3gJ8ybLbfXjqtj2aYJWMAJ60HttOcFNJ88dq7vEEwRiUZlyGmZkRaqnk0YiWr+Sx 1s2QAPqsEEA4oW+3zr8zHd3DBf5jUNm45bcdrISEUzvsMzeQcYTwtr2uF6k0ffdPwn39vVyc1 bTJCVqH+4fScA5STWO/IIbP7nW8jJAQLQlRKZDjuMboOxLbWVLVnQrJ7OsoTQNNj6cbg/ttmN 0w6DvqDlEuFHx+/4AXQmO2hlfZluWD07fBSMup9xFmAgzHm1Ak6ofOz0wGDmlbX59ScSd9bEl Na2+2l79eC45cGn1hkHC3bng4tXyhtn8rikNvI8m8yB3TFwOQz5eNvlo7fEZ9ykUCuvUrCkWd l2nsW4W+JbJDvTNg7MyNIO0fQIpiAUDfg5zUZbJJ1VHf4Ysw3ItFQD1mXWMaRn7VkqSc8A7Vn Nx37RUsKri4Qqei7+rO4GVFquCRYka7MZE56lXcoKmD7lQCguxmFhrn5BUw6msLy7jwICvLDS 7EpgON1bQ7MsO5Hn2zn3iJ7kwjZEVxXnGVPBeSsvXBZjlDAVTel5xX1TbFVZ2e+nfPKTLL1g9 5uUuqTYQYG78qHpIoPlgV1IX6L02Z5qpcE2jevXbwEBp+tlvVjliB+6zzirpOwEdBsvAMmTQY o7iYfIho0VlwozIPoRBA== Cc: ALSA Development Mailing List , Baolin Wang , y2038 Mailman List , Takashi Iwai , "linux-kernel@vger.kernel.org" , Mark Brown , Baolin Wang Subject: Re: [alsa-devel] [Y2038] [PATCH v7 6/9] ALSA: Avoid using timespec for struct snd_timer_tread X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Dec 12, 2019 at 3:27 PM Ben Hutchings wrote: > On Thu, 2019-12-12 at 10:57 +0100, Arnd Bergmann wrote: > > On Thu, Dec 12, 2019 at 1:14 AM Ben Hutchings > > wrote: > > > On Wed, 2019-12-11 at 22:20 +0100, Arnd Bergmann wrote: > > > > @@ -2145,14 +2202,34 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer, > > > > + case TREAD_FORMAT_NONE: > > > > if (copy_to_user(buffer, &tu->queue[qhead], > > > > sizeof(struct snd_timer_read))) > > > > err = -EFAULT; > > > > + break; > > > > + default: > > > > + err = -ENOTSUPP; > > > [...] > > > > > > This is not a valid error code for returning to user-space, but this > > > case should be impossible so I don't think it matters. > > > > Agreed. Maybe it should also WARN_ON(1), as there getting here > > would indicate a bug in the kernel. > > Yes, WARN_ON() or WARN_ON_ONCE() would make sense. This is what I added now: --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -2161,6 +2161,7 @@ static ssize_t snd_timer_user_read(struct file *file, char __user *buffer, unit = sizeof(struct snd_timer_read); break; default: + WARN_ONCE(1, "Corrupt snd_timer_user\n"); return -ENOTSUPP; } Arnd _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel