From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7DCD221199252 for ; Wed, 5 Dec 2018 06:45:34 -0800 (PST) Received: by mail-qt1-f196.google.com with SMTP id y20so22455893qtm.13 for ; Wed, 05 Dec 2018 06:45:34 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 5 Dec 2018 15:45:10 +0100 Message-ID: Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: anton.ivanov@cambridgegreys.com Cc: Lawrence Brakmo , Brendan Higgins , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, Frank Rowand , Rob Herring , linux-nvdimm@lists.01.org, Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Shuah Khan , Jeff Dike , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , levinsasha928@gmail.com, kunit-dev@googlegroups.com, gregkh , Linux Kernel Mailing List , "Luis R. Rodriguez" , Daniel Vetter , Kees Cook , Joe Perches , Kevin Hilman List-ID: On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7B1C04EB9 for ; Wed, 5 Dec 2018 14:45:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8077020878 for ; Wed, 5 Dec 2018 14:45:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8077020878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727566AbeLEOpf (ORCPT ); Wed, 5 Dec 2018 09:45:35 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:46579 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727142AbeLEOpf (ORCPT ); Wed, 5 Dec 2018 09:45:35 -0500 Received: by mail-qt1-f194.google.com with SMTP id y20so22455891qtm.13; Wed, 05 Dec 2018 06:45:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uo3YjoIkwTYwSiqy/1VkqllPwcYFwGVyfV392Qe87oI=; b=PMO4hVRhyxrgh/DqO8l71X1DsW2HnluHPbjGVYNtMyoKxc37HRYy4vPYsytcCUK7nd /gD6sv69Te18Rm/OT8AjSP0l/iKbMFHnYzR6W1MKkVvFAl48kPXYKvaaOsMwPFrdZVhO frl6BspqFs5+FwVJoizZFmLsrUX927Es3jjahHtWqbWUE9E05HvoPD6s4U67U1N9qMhb Zgc6ZiFW6Kl51QtlisGv36Gaq+AV6JgK2kR5mbuerBcZ+82YAjWTeEE/ba+z550hI/tF geS1VlTlS9tS106t7ICM1xtN0ZLlMp3hOvfG/QEXf1hcUE+E4Irb0rh/zRQHaFpwbKKd fE0A== X-Gm-Message-State: AA+aEWZgNDdmxh2CBTBJXBe7T/eLAWMOpmcBL+5JS9E+U7xa8OMZ0OGF 6A9tFx+LIpCfQifwtehCW9ByxS6BOgYMbIpRJv8= X-Google-Smtp-Source: AFSGD/VDl6+Z0bR+uy5B3YqRBsCEzQMGbxG3q7Cr8DwbsQXesJVc9XNIK7p0z3qrmzELhMA/+b5gCkLHVXb6D6HyF/c= X-Received: by 2002:ac8:7451:: with SMTP id h17mr23215735qtr.319.1544021133415; Wed, 05 Dec 2018 06:45:33 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 5 Dec 2018 15:45:10 +0100 Message-ID: Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core To: anton.ivanov@cambridgegreys.com Cc: "Luis R. Rodriguez" , Brendan Higgins , Lawrence Brakmo , dri-devel , Sasha Levin , linux-kselftest@vger.kernel.org, Shuah Khan , Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , Jeff Dike , "Bird, Timothy" , Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , levinsasha928@gmail.com, Dan Williams , kunit-dev@googlegroups.com, gregkh , Linux Kernel Mailing List , Daniel Vetter , Michael Ellerman , Joe Perches , Kevin Hilman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd at arndb.de (Arnd Bergmann) Date: Wed, 5 Dec 2018 15:45:10 +0100 Subject: [RFC v3 01/19] kunit: test: add KUnit test runner core In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> Message-ID: On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 5 Dec 2018 15:45:10 +0100 Subject: [RFC v3 01/19] kunit: test: add KUnit test runner core In-Reply-To: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20181205144510.MXCrH7tSaF0Ot9zAYS_yxrFYpacrTsQsmFrV-u9DJYQ@z> On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018@11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core Date: Wed, 5 Dec 2018 15:45:10 +0100 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E1F46E428 for ; Wed, 5 Dec 2018 14:45:34 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id p17so22475625qtl.5 for ; Wed, 05 Dec 2018 06:45:34 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: anton.ivanov@cambridgegreys.com Cc: Lawrence Brakmo , Brendan Higgins , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, Frank Rowand , linux-nvdimm@lists.01.org, Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Shuah Khan , Jeff Dike , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , levinsasha928@gmail.com, Dan Williams , kunit-dev@googlegroups.com, gregkh , Linux Kernel Mailing List , "Luis R. Rodriguez" List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgNSwgMjAxOCBhdCAyOjQyIFBNIEFudG9uIEl2YW5vdgo8YW50b24uaXZhbm92 QGNhbWJyaWRnZWdyZXlzLmNvbT4gd3JvdGU6Cj4gT24gMzAvMTEvMjAxOCAwMzoxNCwgTHVpcyBD aGFtYmVybGFpbiB3cm90ZToKPiA+IE9uIFdlZCwgTm92IDI4LCAyMDE4IGF0IDExOjM2OjE4QU0g LTA4MDAsIEJyZW5kYW4gSGlnZ2lucyB3cm90ZToKPiA+IFRoZW4gZm9yIHRoZSBVTUwgc3R1ZmYs IEkgdGhpbmsgaWYgd2UgKnJlYWxseSogYWNjZXB0IHRoYXQgVU1MIHdpbGwKPiA+IGFsd2F5cyBi ZSBhIHZpYWJsZSBvcHRpb24gd2Ugc2hvdWxkIHByb2JhYmx5IGNvbnNpZGVyIG5vdyB0aHJvd2lu ZyB0aGVzZQo+ID4gdGhpbmdzIHVuZGVyIGRyaXZlcnMvcGxhdGZvcm0vdW1sLy4gVGhpcyBmb2xs b3dzIHRoZSBwYXR0ZXJuIG9mIGFyY2gKPiA+IHNwZWNpZmljIGRyaXZlcnMuIFdoZXRoZXIgb3Ig bm90IHdlIGVuZCB1cCB3aXRoIGEgY29tcGxldGUgdXNlcnNwYWNlCj4KPiBVTUwgcGxhdGZvcm0g ZHJpdmVycyBwcmVkYXRlIHRoYXQgYW5kIGFyZSB1bmRlciBhcmNoL3VtL2RyaXZlcnMvCj4KPiBX ZSBzaG91bGQgZWl0aGVyIGtlZXAgdG8gY3VycmVudCBjb252ZW50aW9uIG9yIGNvbnNpZGVyIHJl bG9jYXRpbmcgdGhlCj4gZXhpc3Rpbmcgb25lcyAtIGhhdmluZyB0aGluZ3Mgc3ByZWFkIGluIGRp ZmZlcmVudCBwbGFjZXMgYXJvdW5kIHRoZSB0cmVlCj4gaXMgbm90IGdvb2QgaW4gdGhlIGxvbmcg cnVuIChVTUwgYWxyZWFkeSBoYXMgYSBmZXcgb2YgdGhvc2UgdW5kZXIgdGhlCj4geDg2IHRyZWUs IGxldCdzIG5vdCBpbmNyZWFzZSB0aGUgbnVtYmVyKS4KCkkgZG9uJ3QgbWluZCB0aGUgY3VycmVu dCBsb2NhdGlvbiBtdWNoLCBidXQgaWYgd2UgbW92ZSBkcml2ZXJzLCB3ZSBzaG91bGQKbW92ZSB0 aGUgaW50byB0aGUgYXBwcm9wcmlhdGUgc3Vic3lzdGVtcyBiYXNlZCBvbiB3aGF0IHRoZXkgZG8s IHJhdGhlcgp0aGFuIGhhdmluZyBhIG5ldyBwbGFjZSB3aXRoIGEgbWl4IG9mIHRoaW5ncy4KCkUu Zy4gdGhlIHR0eSBkcml2ZXJzIHNob3VsZCBhbGwgYmUgaW4gZHJpdmVycy90dHkvIGFuZCB0aGUg bmV0d29yayBkcml2ZXJzIGluCmRyaXZlcnMvbmV0LiBUbyBwYXJhcGhyYXNlIHdoYXQgeW91IHNh aWQgYWJvdmU6IGhhdmluZyB0dHkgZHJpdmVycyBzcHJlYWQgaW4KZGlmZmVyZW50IHBsYWNlcyBh cm91bmQgdGhlIHRyZWUgaXMgbm90IGdvb2QgaW4gdGhlIGxvbmcgcnVuLiBXZSBoYXZlIGxvbmcK YWdvIG1vdmVkIGZyb20gb3JnYW5pemluZyBkcml2ZXJzIGJ5IGJ1cyBpbnRlcmZhY2UgdG8gb3Jn YW5pemluZyBkcml2ZXJzCmJ5IGNsYXNzLCB1bWwgYW5kIGRyaXZlcnMvcGxhdGZvcm0gYXJlIGp1 c3QgZXhjZXB0aW9ucyB0byB0aGlzIHJ1bGUuCgogICAgICAgICAgQXJuZApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com ([209.85.160.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUYQr-0000zj-8M for linux-um@lists.infradead.org; Wed, 05 Dec 2018 14:45:46 +0000 Received: by mail-qt1-f196.google.com with SMTP id v11so22493268qtc.2 for ; Wed, 05 Dec 2018 06:45:34 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-2-brendanhiggins@google.com> <20181130031438.GQ4922@garbanzo.do-not-panic.com> In-Reply-To: From: Arnd Bergmann Date: Wed, 5 Dec 2018 15:45:10 +0100 Message-ID: Subject: Re: [RFC v3 01/19] kunit: test: add KUnit test runner core List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: anton.ivanov@cambridgegreys.com Cc: Lawrence Brakmo , Brendan Higgins , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, Frank Rowand , Rob Herring , linux-nvdimm@lists.01.org, Richard Weinberger , knut.omang@oracle.com, Kieran Bingham , Joel Stanley , "Bird, Timothy" , Shuah Khan , Jeff Dike , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , levinsasha928@gmail.com, Dan Williams , kunit-dev@googlegroups.com, gregkh , Linux Kernel Mailing List , "Luis R. Rodriguez" , Daniel Vetter , Kees Cook , Joe Perches , Kevin Hilman On Wed, Dec 5, 2018 at 2:42 PM Anton Ivanov wrote: > On 30/11/2018 03:14, Luis Chamberlain wrote: > > On Wed, Nov 28, 2018 at 11:36:18AM -0800, Brendan Higgins wrote: > > Then for the UML stuff, I think if we *really* accept that UML will > > always be a viable option we should probably consider now throwing these > > things under drivers/platform/uml/. This follows the pattern of arch > > specific drivers. Whether or not we end up with a complete userspace > > UML platform drivers predate that and are under arch/um/drivers/ > > We should either keep to current convention or consider relocating the > existing ones - having things spread in different places around the tree > is not good in the long run (UML already has a few of those under the > x86 tree, let's not increase the number). I don't mind the current location much, but if we move drivers, we should move the into the appropriate subsystems based on what they do, rather than having a new place with a mix of things. E.g. the tty drivers should all be in drivers/tty/ and the network drivers in drivers/net. To paraphrase what you said above: having tty drivers spread in different places around the tree is not good in the long run. We have long ago moved from organizing drivers by bus interface to organizing drivers by class, uml and drivers/platform are just exceptions to this rule. Arnd _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um