From: Arnd Bergmann <arnd@kernel.org> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Will Deacon <will@kernel.org>, linux-toolchains@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, "Theodore Ts'o" <tytso@mit.edu>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andreas Dilger <adilger.kernel@dilger.ca>, Ext4 Developers List <linux-ext4@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Date: Thu, 7 Jan 2021 22:20:38 +0100 [thread overview] Message-ID: <CAK8P3a2J8fLjPhyV0XUeuRBdSo6rz1gU4wrQRyfzKQvwhf22ag@mail.gmail.com> (raw) In-Reply-To: <20210107133747.GP1551@shell.armlinux.org.uk> On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > On Thu, Jan 07, 2021 at 02:16:25PM +0100, Arnd Bergmann wrote: > > On Thu, Jan 7, 2021 at 1:47 PM Russell King - ARM Linux admin > > <linux@armlinux.org.uk> wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > them in my git history. Correction: I looked in the wrong branch, gcc-linaro does have it, as does the Android gcc, which was recently still at 4.9 before they dropped it in favor of clang. > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > or just for aarch64? I'd personally love to see gcc-5 as the global minimum version, as that would let us finally use --std=gnu11 features instead of gnu89. [There are a couple of useful features that are incompatible with gnu89, and gnu99/gnu11 support in gcc didn't like the kernel sources] If we make it arm64 specific, I'd propose only making it a build-time warning instead of an error, as there are no other benefits to increasing the minimum version if gcc-4.9 is still an option for other architectures, and most gcc-4.9 users (Android, Red Hat and everyone using gcc-linaro) have backported this bugfix already. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org> To: Russell King - ARM Linux admin <linux@armlinux.org.uk> Cc: Mark Rutland <mark.rutland@arm.com>, Theodore Ts'o <tytso@mit.edu>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andreas Dilger <adilger.kernel@dilger.ca>, linux-toolchains@vger.kernel.org, Ext4 Developers List <linux-ext4@vger.kernel.org>, Will Deacon <will@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Date: Thu, 7 Jan 2021 22:20:38 +0100 [thread overview] Message-ID: <CAK8P3a2J8fLjPhyV0XUeuRBdSo6rz1gU4wrQRyfzKQvwhf22ag@mail.gmail.com> (raw) In-Reply-To: <20210107133747.GP1551@shell.armlinux.org.uk> On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > On Thu, Jan 07, 2021 at 02:16:25PM +0100, Arnd Bergmann wrote: > > On Thu, Jan 7, 2021 at 1:47 PM Russell King - ARM Linux admin > > <linux@armlinux.org.uk> wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > them in my git history. Correction: I looked in the wrong branch, gcc-linaro does have it, as does the Android gcc, which was recently still at 4.9 before they dropped it in favor of clang. > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > or just for aarch64? I'd personally love to see gcc-5 as the global minimum version, as that would let us finally use --std=gnu11 features instead of gnu89. [There are a couple of useful features that are incompatible with gnu89, and gnu99/gnu11 support in gcc didn't like the kernel sources] If we make it arm64 specific, I'd propose only making it a build-time warning instead of an error, as there are no other benefits to increasing the minimum version if gcc-4.9 is still an option for other architectures, and most gcc-4.9 users (Android, Red Hat and everyone using gcc-linaro) have backported this bugfix already. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-07 21:21 UTC|newest] Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-05 15:47 Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Russell King - ARM Linux admin 2021-01-05 15:47 ` Russell King - ARM Linux admin 2021-01-05 18:27 ` Darrick J. Wong 2021-01-05 18:27 ` Darrick J. Wong 2021-01-05 19:50 ` Russell King - ARM Linux admin 2021-01-05 19:50 ` Russell King - ARM Linux admin 2021-01-06 11:53 ` Mark Rutland 2021-01-06 11:53 ` Mark Rutland 2021-01-06 12:13 ` Russell King - ARM Linux admin 2021-01-06 12:13 ` Russell King - ARM Linux admin 2021-01-06 13:52 ` Russell King - ARM Linux admin 2021-01-06 17:20 ` Will Deacon 2021-01-06 17:20 ` Will Deacon 2021-01-06 17:46 ` Russell King - ARM Linux admin 2021-01-06 17:46 ` Russell King - ARM Linux admin 2021-01-06 21:04 ` Arnd Bergmann 2021-01-06 21:04 ` Arnd Bergmann 2021-01-06 22:00 ` Arnd Bergmann 2021-01-06 22:00 ` Arnd Bergmann 2021-01-06 22:32 ` Russell King - ARM Linux admin 2021-01-06 22:32 ` Russell King - ARM Linux admin 2021-01-07 11:18 ` Russell King - ARM Linux admin 2021-01-07 11:18 ` Russell King - ARM Linux admin 2021-01-07 12:45 ` Russell King - ARM Linux admin 2021-01-07 12:45 ` Russell King - ARM Linux admin 2021-01-07 13:16 ` Arnd Bergmann 2021-01-07 13:16 ` Arnd Bergmann 2021-01-07 13:37 ` Russell King - ARM Linux admin 2021-01-07 13:37 ` Russell King - ARM Linux admin 2021-01-07 16:27 ` Theodore Ts'o 2021-01-07 16:27 ` Theodore Ts'o 2021-01-07 17:00 ` Florian Weimer 2021-01-07 17:00 ` Florian Weimer 2021-01-07 21:48 ` Arnd Bergmann 2021-01-07 21:48 ` Arnd Bergmann 2021-01-07 22:14 ` Russell King - ARM Linux admin 2021-01-07 22:14 ` Russell King - ARM Linux admin 2021-01-07 22:41 ` Eric Biggers 2021-01-07 22:41 ` Eric Biggers 2021-01-08 8:21 ` Ard Biesheuvel 2021-01-08 8:21 ` Ard Biesheuvel 2021-01-07 22:27 ` Eric Biggers 2021-01-07 22:27 ` Eric Biggers 2021-01-07 23:53 ` Darrick J. Wong 2021-01-07 23:53 ` Darrick J. Wong 2021-01-08 8:05 ` Arnd Bergmann 2021-01-08 8:05 ` Arnd Bergmann 2021-01-08 9:13 ` Peter Zijlstra 2021-01-08 9:13 ` Peter Zijlstra 2021-01-08 10:31 ` Pavel Machek 2021-01-08 10:31 ` Pavel Machek 2021-01-07 21:20 ` Arnd Bergmann [this message] 2021-01-07 21:20 ` Arnd Bergmann 2021-01-08 9:21 ` Peter Zijlstra 2021-01-08 9:21 ` Peter Zijlstra 2021-01-08 9:26 ` Will Deacon 2021-01-08 9:26 ` Will Deacon 2021-01-08 20:02 ` Linus Torvalds 2021-01-08 20:02 ` Linus Torvalds 2021-01-08 20:22 ` Arnd Bergmann 2021-01-08 20:22 ` Arnd Bergmann 2021-01-08 21:20 ` Nick Desaulniers 2021-01-08 21:20 ` Nick Desaulniers 2021-01-08 20:29 ` Russell King - ARM Linux admin 2021-01-08 20:29 ` Russell King - ARM Linux admin 2021-01-12 13:20 ` Lukas Wunner 2021-01-12 13:31 ` Florian Weimer 2021-01-12 13:31 ` Florian Weimer 2021-01-12 13:46 ` David Laight 2021-01-12 13:46 ` David Laight 2021-01-12 17:28 ` Linus Torvalds 2021-01-12 17:28 ` Linus Torvalds 2021-01-14 13:13 ` Lukas Wunner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a2J8fLjPhyV0XUeuRBdSo6rz1gU4wrQRyfzKQvwhf22ag@mail.gmail.com \ --to=arnd@kernel.org \ --cc=adilger.kernel@dilger.ca \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-toolchains@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=tytso@mit.edu \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.