From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A050C433E6 for ; Thu, 7 Jan 2021 21:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4271A23441 for ; Thu, 7 Jan 2021 21:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727365AbhAGVVg (ORCPT ); Thu, 7 Jan 2021 16:21:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:33630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbhAGVVg (ORCPT ); Thu, 7 Jan 2021 16:21:36 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E233235E4; Thu, 7 Jan 2021 21:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610054455; bh=JQnyou7N11nSe8TDE+2mKJurKi94dAj+iU3eUH7pczQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=O4EG1/PN8B9Wg7lpYA0oRBJPrPIzy5JYhq/uv8vAnK/qKAXzh2g2+xwzc52DYdWaT jW8bDDZtQpHc7BhcY8k0FNCZMdkctKEAry6+oh95f/0AS8/JFPrFGqEl2EbNbNsq6a IIIp4ugL2X2QUHgNNnzaAvIRVOZv0dDBw7gdh+n5y+G99h4ESxEr2KVTaTboDw+O5M 3Ca8tSqhrhpRbUbmy0mLuCEkONwQXqf8KunHz9uagepLWDnNxDeGN2XCF9/c9jktGH RS8lqR36hI85x9mFiN/vAbd8fxlbBEJb1Hk8nmYQ+OrGh3OVBX7S8VvvHwEoqc/+89 851m9rxIbZ+Xg== Received: by mail-oi1-f172.google.com with SMTP id q25so8962191oij.10; Thu, 07 Jan 2021 13:20:55 -0800 (PST) X-Gm-Message-State: AOAM530oBYz+WO4EK/funoWCJd5NqdItcrdUhWODCCB7wRg/CCKIW4bG 6JIHU7mwTd9gyISdsrUKJAh7cl/rcpzR/fBNVj4= X-Google-Smtp-Source: ABdhPJwlH1Ewtc7sSONuNWWPkcNOMjtoLMh6L28J0ziQAfl5nh6T+ZmmrR7FtjgXyEPFUnrDBSuyrAuRWDyklfja/ag= X-Received: by 2002:aca:e103:: with SMTP id y3mr349498oig.11.1610054455043; Thu, 07 Jan 2021 13:20:55 -0800 (PST) MIME-Version: 1.0 References: <20210105154726.GD1551@shell.armlinux.org.uk> <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> In-Reply-To: <20210107133747.GP1551@shell.armlinux.org.uk> From: Arnd Bergmann Date: Thu, 7 Jan 2021 22:20:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues To: Russell King - ARM Linux admin Cc: Will Deacon , linux-toolchains@vger.kernel.org, Mark Rutland , "Theodore Ts'o" , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 02:16:25PM +0100, Arnd Bergmann wrote: > > On Thu, Jan 7, 2021 at 1:47 PM Russell King - ARM Linux admin > > wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > them in my git history. Correction: I looked in the wrong branch, gcc-linaro does have it, as does the Android gcc, which was recently still at 4.9 before they dropped it in favor of clang. > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > or just for aarch64? I'd personally love to see gcc-5 as the global minimum version, as that would let us finally use --std=gnu11 features instead of gnu89. [There are a couple of useful features that are incompatible with gnu89, and gnu99/gnu11 support in gcc didn't like the kernel sources] If we make it arm64 specific, I'd propose only making it a build-time warning instead of an error, as there are no other benefits to increasing the minimum version if gcc-4.9 is still an option for other architectures, and most gcc-4.9 users (Android, Red Hat and everyone using gcc-linaro) have backported this bugfix already. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252F4C433DB for ; Thu, 7 Jan 2021 21:23:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4A6923441 for ; Thu, 7 Jan 2021 21:23:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4A6923441 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eaDTdf3VJuK94eZdN/MlLre/bod17RHF5bDl+mnNo+w=; b=dZuQ/DlwhPyBEfsZHcdyoxPP2 ZoPAZ7nCC8k+GAANeScec1eSwJhz19UXM6vtl9+BDpHdohvbB3lMssmBzlvxlCyDGJ2YOHLDCt2bc morWbLnnhBCNDNhfSeFDWz4vDwyjD0+OWFySBEz3//jEE+J0FXmzY5wWp5LqOoDDY7Duc2Y+sofw6 /axERRM+dWsD69J3DdVrrIdgzD90qYU/JD209h1gjHThewZUNWpwRB101InjRPdicfYqaLV6EwRkV a0i/SFk9NROqNeuwx2mdYbbowWObQQd9jo3E7EgBrD+wHzE+1D4PHl/nA7kFbIuCHdj3bJAq6jE/z Kj8elMLqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxciK-0002n9-1D; Thu, 07 Jan 2021 21:21:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxciG-0002mi-Tb for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 21:20:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9703D23441 for ; Thu, 7 Jan 2021 21:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610054455; bh=JQnyou7N11nSe8TDE+2mKJurKi94dAj+iU3eUH7pczQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=O4EG1/PN8B9Wg7lpYA0oRBJPrPIzy5JYhq/uv8vAnK/qKAXzh2g2+xwzc52DYdWaT jW8bDDZtQpHc7BhcY8k0FNCZMdkctKEAry6+oh95f/0AS8/JFPrFGqEl2EbNbNsq6a IIIp4ugL2X2QUHgNNnzaAvIRVOZv0dDBw7gdh+n5y+G99h4ESxEr2KVTaTboDw+O5M 3Ca8tSqhrhpRbUbmy0mLuCEkONwQXqf8KunHz9uagepLWDnNxDeGN2XCF9/c9jktGH RS8lqR36hI85x9mFiN/vAbd8fxlbBEJb1Hk8nmYQ+OrGh3OVBX7S8VvvHwEoqc/+89 851m9rxIbZ+Xg== Received: by mail-oi1-f182.google.com with SMTP id 9so8998189oiq.3 for ; Thu, 07 Jan 2021 13:20:55 -0800 (PST) X-Gm-Message-State: AOAM531tY8XYwygWBf7KweU3+oMu6tA7TCBCmsqtc2rGQ9tckikRUk+h IaSSID67/qMHl9UAQneEb/JvsAMcorF/6APOjeQ= X-Google-Smtp-Source: ABdhPJwlH1Ewtc7sSONuNWWPkcNOMjtoLMh6L28J0ziQAfl5nh6T+ZmmrR7FtjgXyEPFUnrDBSuyrAuRWDyklfja/ag= X-Received: by 2002:aca:e103:: with SMTP id y3mr349498oig.11.1610054455043; Thu, 07 Jan 2021 13:20:55 -0800 (PST) MIME-Version: 1.0 References: <20210105154726.GD1551@shell.armlinux.org.uk> <20210106115359.GB26994@C02TD0UTHF1T.local> <20210106135253.GJ1551@shell.armlinux.org.uk> <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> In-Reply-To: <20210107133747.GP1551@shell.armlinux.org.uk> From: Arnd Bergmann Date: Thu, 7 Jan 2021 22:20:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues To: Russell King - ARM Linux admin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_162057_049812_B510C666 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , linux-toolchains@vger.kernel.org, Ext4 Developers List , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 7, 2021 at 2:37 PM Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 02:16:25PM +0100, Arnd Bergmann wrote: > > On Thu, Jan 7, 2021 at 1:47 PM Russell King - ARM Linux admin > > wrote: > > > The gcc bugzilla mentions backports into gcc-linaro, but I do not see > > them in my git history. Correction: I looked in the wrong branch, gcc-linaro does have it, as does the Android gcc, which was recently still at 4.9 before they dropped it in favor of clang. > So, do we raise the minimum gcc version for the kernel as a whole to 5.1 > or just for aarch64? I'd personally love to see gcc-5 as the global minimum version, as that would let us finally use --std=gnu11 features instead of gnu89. [There are a couple of useful features that are incompatible with gnu89, and gnu99/gnu11 support in gcc didn't like the kernel sources] If we make it arm64 specific, I'd propose only making it a build-time warning instead of an error, as there are no other benefits to increasing the minimum version if gcc-4.9 is still an option for other architectures, and most gcc-4.9 users (Android, Red Hat and everyone using gcc-linaro) have backported this bugfix already. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel