From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FABC433E0 for ; Thu, 28 Jan 2021 21:25:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70CE264DD8 for ; Thu, 28 Jan 2021 21:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbhA1VZB (ORCPT ); Thu, 28 Jan 2021 16:25:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:32990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbhA1VYy (ORCPT ); Thu, 28 Jan 2021 16:24:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 53CEE64DED for ; Thu, 28 Jan 2021 21:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611869053; bh=Qsl4p6miI7eSEd2fPPqwxKkuNXr7EicxC031HxTIdm4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IU/7AcHAxrmz2NdnSCadDiHUu2Furi9m4Bd4WCzrto8haheh3TIFhnfzh/tv5inbX r+Ir/2RHqqvL6bZzJhIG1k24PCxMiIlPZ4zECjT6C8YZGbwdTds0MWmN37NGzgZnwZ tB0irp9OfCaKjlAVZZrJoFz16BZDInSJ3VTMIe5hJbDEsqA4KLEkddqLANidM6bbc1 sw4ArMHdBM9MoY+SmrTRJn7oXSJBcn5i/ikf36J2xTReKtX9rPlKbXKr84ItLB8Ds/ WYu+4tzH6vubg51eId7OILUn+lqTrqs/VEL2jtN1G4wZ/bQmg2yr1pOTBQqCtFg297 1D3MgbFdqGHww== Received: by mail-oi1-f176.google.com with SMTP id d18so7638007oic.3 for ; Thu, 28 Jan 2021 13:24:13 -0800 (PST) X-Gm-Message-State: AOAM533tIEKDLSXRjBGyDCrLluDAIap8DBXQV+2jMnAuHh98nDZfqD1p YO6/QWX3j1LA9odIuo2Vvzu4p5omqd6eKYnY4hU= X-Google-Smtp-Source: ABdhPJwOZ36pLEYdLYlkAVsv4oyAMtM4K8b9iTbU4fTV0A9CPlnRCJjIlHPKvSc+vvCtKSn3S3EsTyd4oNe0FfTdOQY= X-Received: by 2002:aca:e103:: with SMTP id y3mr785811oig.11.1611869052544; Thu, 28 Jan 2021 13:24:12 -0800 (PST) MIME-Version: 1.0 References: <20210128044356.38419-1-ndesaulniers@google.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 28 Jan 2021 22:23:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL To: Nick Desaulniers Cc: Russell King , Arnd Bergmann , Ard Biesheuvel , Nathan Chancellor , Linux ARM , "linux-kernel@vger.kernel.org" , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 28, 2021 at 7:59 PM 'Nick Desaulniers' via Clang Built Linux wrote: > On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann wrote: > > > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, > > as that uses tests in arch/arm/probes/kprobes/test-thumb.c. > > Technically, that's a distinctly separate issue; > arch/arm/probes/kprobes/test-arm.c is not built with > CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings; > that file has the same issue but it is separate from test-arm.c. > > Would you prefer to see a v2 with the swpvsb fix contain fixes for > test-thumb.c as well, or a separate patch for that? I think either way is fine. I'd probably go with a combined patch in this case, since you are addressing the same issue in two closely related files. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE4FC433DB for ; Thu, 28 Jan 2021 21:25:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F03B764DED for ; Thu, 28 Jan 2021 21:25:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F03B764DED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=34wTuZTX6gtveOu3s3aTG2MpnRVTW4DIlEJEXPB/UZw=; b=tLeLA9ME3nTGPCK0+0hcUziqF YcXSSoJaEU5pJhwpJnfAsrETSFOdHNJpwlyxwktcYTeFvS856T/uo/I2IHHS7eN4VoaEjLZS7ylU9 1ui4HW8pUweW24ZcTA7VTB4/qyZ6E92Y9RlNFiGimO4EIqVxTAXIhjx9Nzytoe9D2G0i0SVBJsuFV KDpx2wS/418PBp+60EFDdsEayfjSp3ubEwbmX8elZtYR7MdNpLlq/WbUS0wYEdveeiiUfaA86Qd7y 3XIIfH9noLUt64tC0oxC24Iui6qpJZHByvnXoePemutfl3d5/Qfs3m5/s1E9MC8VYBxNQTgCHlezT tjd+/6N/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Em1-0000qz-2L; Thu, 28 Jan 2021 21:24:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Ely-0000qR-Ve for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 21:24:15 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C7A164DF1 for ; Thu, 28 Jan 2021 21:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611869053; bh=Qsl4p6miI7eSEd2fPPqwxKkuNXr7EicxC031HxTIdm4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IU/7AcHAxrmz2NdnSCadDiHUu2Furi9m4Bd4WCzrto8haheh3TIFhnfzh/tv5inbX r+Ir/2RHqqvL6bZzJhIG1k24PCxMiIlPZ4zECjT6C8YZGbwdTds0MWmN37NGzgZnwZ tB0irp9OfCaKjlAVZZrJoFz16BZDInSJ3VTMIe5hJbDEsqA4KLEkddqLANidM6bbc1 sw4ArMHdBM9MoY+SmrTRJn7oXSJBcn5i/ikf36J2xTReKtX9rPlKbXKr84ItLB8Ds/ WYu+4tzH6vubg51eId7OILUn+lqTrqs/VEL2jtN1G4wZ/bQmg2yr1pOTBQqCtFg297 1D3MgbFdqGHww== Received: by mail-oi1-f180.google.com with SMTP id k25so7598058oik.13 for ; Thu, 28 Jan 2021 13:24:13 -0800 (PST) X-Gm-Message-State: AOAM532KOWFea4PySPmJmVpcMnPX+0ZZINVwevyvcWTggJrFE8gVOBb/ pMq6t7dEq4TAfxl0EyBUKCpDwxwDjP0tciJw2MA= X-Google-Smtp-Source: ABdhPJwOZ36pLEYdLYlkAVsv4oyAMtM4K8b9iTbU4fTV0A9CPlnRCJjIlHPKvSc+vvCtKSn3S3EsTyd4oNe0FfTdOQY= X-Received: by 2002:aca:e103:: with SMTP id y3mr785811oig.11.1611869052544; Thu, 28 Jan 2021 13:24:12 -0800 (PST) MIME-Version: 1.0 References: <20210128044356.38419-1-ndesaulniers@google.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 28 Jan 2021 22:23:56 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: kprobes: rewrite in UAL To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_162415_259689_6326B642 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , "linux-kernel@vger.kernel.org" , Russell King , clang-built-linux , Nathan Chancellor , Ard Biesheuvel , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 28, 2021 at 7:59 PM 'Nick Desaulniers' via Clang Built Linux wrote: > On Thu, Jan 28, 2021 at 8:15 AM Arnd Bergmann wrote: > > > Plus a lot of extra errors when building with CONFIG_THUMB2_KERNEL, > > as that uses tests in arch/arm/probes/kprobes/test-thumb.c. > > Technically, that's a distinctly separate issue; > arch/arm/probes/kprobes/test-arm.c is not built with > CONFIG_THUMB2_KERNEL=y. This patch doesn't introduce those warnings; > that file has the same issue but it is separate from test-arm.c. > > Would you prefer to see a v2 with the swpvsb fix contain fixes for > test-thumb.c as well, or a separate patch for that? I think either way is fine. I'd probably go with a combined patch in this case, since you are addressing the same issue in two closely related files. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel