From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1ED0C433E1 for ; Fri, 29 May 2020 07:39:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B6AF2151B for ; Fri, 29 May 2020 07:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725906AbgE2HjR (ORCPT ); Fri, 29 May 2020 03:39:17 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:53255 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgE2HjO (ORCPT ); Fri, 29 May 2020 03:39:14 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MRmsG-1jYYH41cmw-00TC0E for ; Fri, 29 May 2020 09:39:12 +0200 Received: by mail-qk1-f180.google.com with SMTP id q8so1347639qkm.12 for ; Fri, 29 May 2020 00:39:12 -0700 (PDT) X-Gm-Message-State: AOAM5306AF0Q7QyWYHwiRhKBsND1i0Rc0uA8S1bswV83Qrap2PMmzUKg bL+xjlrqgJQbK8JIqvQY0PDZQCvOOxsTwaOIETA= X-Google-Smtp-Source: ABdhPJxQKYd4FlNgNoz2isNi0ebCTB3nvWDUEuOZMHLr8f8WtGdScxnBe7hCE28C3sqQ+FdC/w/xyW9EOP1Ihhx9Ghk= X-Received: by 2002:a37:554:: with SMTP id 81mr6509274qkf.394.1590737951276; Fri, 29 May 2020 00:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20200527181307.2482167-1-robh@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 29 May 2020 09:38:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] clk: versatile: Fix kconfig dependency on COMMON_CLK_VERSATILE To: Rob Herring List-Id: Cc: SoC Team , Anders Roxell , Linus Walleij , Michael Turquette , Stephen Boyd , Linux ARM , linux-clk , Michal Simek Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:8HC9sS9M0wo7KFoCPxvtTIjjG4LG9CHguERYtiTjcCXqaVzV7wh T5h2u+cHxZJbjvFpWn1fHAeV9bG4ipivGmdsSYUSj6H8OjRHClQJ02Oc9gjHA21m2+tdKec KUObrTDgfO4NwNekTHcyBr867LH0TSKWmXDP0n+vO+++9O/KQxIGgTa38QLHvBeKCm5Dqjf nKdGvPnrp4/41qQy3f4PQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:466u57s88ls=:eR+hro1dB3x+bTqWEGbdAl 50TahiqmOYdGp6VnOUFzOKrCuri4CQBvXkkQSAJkqmh1HRc6ye0oK9Zus9ImFSSSEy0BHk/x0 5Qj+8gkg5pVnht7lZHZ4NMXs3vYbKMMHNV7hDgUGYGNZhOrNgikiEc46f1b63iOtmDOw3NHzp ALYjOUvkdBk49NcwZK6LdV8xPclS14PWKAj9zgGCnlIzRFXsI+RkhHnQnzljNRvYcc/NaCqYE fMfxz4wbvh5daOII5RzoPxDSkKI1bRR37lVvKtUbabj5PsTMiCW74raFgBZmf09+O4JUEESOp GQbnLy0Gw8lgqAF8bONDbNEHItsEmhExFiXvuP9BqNz+Ki7dJVJRXto7XCc2GJIeTlgFQ5Gil JBeZjTYdqZ79OtCfWkTTtS3+HkMSxyHU6rOxQWq3RCGQnsbZZDsA+Equr6VgTsw+LCtIRK9YR bS7LYv9pPf/OAzdUuIaBuawX9oKErn/mh/R/uqrGuk6veD3n9xwxL69y6Md6emVWkIUoBTviT OeJgXij3MUwobnA7Y7PgyVTRxMIzTBxPs+r13TC9ioY3G9s0G1oJphA+Zl6OG1H6TXx1pyIHO 0ipPgIZp1Hw3PMOYOIsybJdAGm6Hq7mtlrIfuEGa/3rsr5oSZSsSVmlR4QTEQearpCn1WeBQQ 5842kZYjflROVQ1YaJ5enQ410uZ9FGU6cZLrzD14JhoB9ZqiSi3QYD//R6tfyk80E/rF3d0c1 TrFuxXr/FJ+BxQWeocHaKVOjWRuxDjAlTz6bfuQiuW6u4/4eejtUZ2PbQB5ZYnUwQr1nOepRf 0YXjxsZ1LA/1AgzcJ2Q71BzqySKbLZ6+4zm8MrdQdEJ+yUMaa0= Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, May 28, 2020 at 11:29 PM Rob Herring wrote: > On Thu, May 28, 2020 at 5:57 AM Arnd Bergmann wrote: > > > > On Wed, May 27, 2020 at 8:13 PM Rob Herring wrote: > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > index a0ed412e8396..8c1b0e8e8d32 100644 > > > --- a/drivers/clk/versatile/Kconfig > > > +++ b/drivers/clk/versatile/Kconfig > > > @@ -1,11 +1,8 @@ > > > # SPDX-License-Identifier: GPL-2.0-only > > > > > > -menuconfig COMMON_CLK_VERSATILE > > > - bool "Clock driver for ARM Reference designs" if COMPILE_TEST > > > - default y if ARCH_INTEGRATOR || ARCH_REALVIEW || \ > > > - ARCH_VERSATILE || ARCH_VEXPRESS > > > - > > > -if COMMON_CLK_VERSATILE > > > +menu "Clock driver for ARM Reference designs" > > > + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || \ > > > + ARCH_VERSATILE || ARCH_VEXPRESS || COMPILE_TEST > > > > > > > I've applied this version now but added ARCH_ZYNQ as an additional > > dependency to work around one of the warnings we got earlier. > > That's just spreading a copy-n-paste error. Why don't you apply the > Zynq patch I referenced if Michal never did? Sorry I completely missed the reference from your previous email. I've applied that patch on top now, reverting the change I did in the process. I had noticed that the Zynq Kconfig seemed rather odd, by my interpretation was that it had been added intentionally in order to use an existing clk controller driver for configurable logic on Zynq that was not part of the main DT file. As Michal already confirmed that it was just a mistake, I agree it should be removed. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1106DC433DF for ; Fri, 29 May 2020 07:39:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D56A1207D4 for ; Fri, 29 May 2020 07:39:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h8LOp3YN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D56A1207D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7PVdzURGL5iX56AdWBK955cFW4ZhCxeea89iQsLvYYY=; b=h8LOp3YNXbu11o ON+zf3mpbZWquQjrIOSMobvZkraKfjXH4wK/DY4JUrQUd8qmB3liZfkxL4rzUFACjvadATcmiNJzD pN/llraokVLcoAehaQ/005gdImHPLz8FRuNrE236ym8lW9Xgjvre0rdsopANufMJP9IlWP3ESuOYF atd/DTD56PDnsky5YJfbvQ70Ka6OfSltCkdcubAjn/Nr0dQmum+KDDu/KGtL6797t+iwMCpv5rjxx U+R5WsKfS9tyEUHdeb4PGpFJaeVJPDjKqsXzuabgH30z0P6fPrGZ2G814gdXFNTB6CYhlKSJf8mfw q5yDDTyeHr0mgTDQQH/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeZbr-0003RT-QM; Fri, 29 May 2020 07:39:19 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeZbn-0003Nm-5x for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 07:39:17 +0000 Received: from mail-qk1-f176.google.com ([209.85.222.176]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MTRdK-1jZ5yO1gia-00To8t for ; Fri, 29 May 2020 09:39:12 +0200 Received: by mail-qk1-f176.google.com with SMTP id c12so1339109qkk.13 for ; Fri, 29 May 2020 00:39:12 -0700 (PDT) X-Gm-Message-State: AOAM531SishYNnFf8n+6GMffQgu1YIuABQS5zhANOn9f+gexZ22CFPJ5 OwTxyVPsv7HYyF6wggdNHRHPqT1tHHwqJqrNjq0= X-Google-Smtp-Source: ABdhPJxQKYd4FlNgNoz2isNi0ebCTB3nvWDUEuOZMHLr8f8WtGdScxnBe7hCE28C3sqQ+FdC/w/xyW9EOP1Ihhx9Ghk= X-Received: by 2002:a37:554:: with SMTP id 81mr6509274qkf.394.1590737951276; Fri, 29 May 2020 00:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20200527181307.2482167-1-robh@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Fri, 29 May 2020 09:38:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] clk: versatile: Fix kconfig dependency on COMMON_CLK_VERSATILE To: Rob Herring X-Provags-ID: V03:K1:tUqEEAndHEkWtijaFlYyLqzsyjIIZ9HQu0nhK0zHNvz9M7veo3Z 1VQ+r4ntl49VstDoZYZJyZTbjVciMJEqwFsh6KCgQ1qOMNkv752uOxw3zw/JjdASpAskz+B aekl4XFtpp+Pi7jyoGBOmCOCDub3uiDkkgH+rWsT+jlCqeVFrVJ5HiaIQM8sD0Zx87zkPBT MwIj5+XUiyYn4yKTu9Ghw== X-UI-Out-Filterresults: notjunk:1;V03:K0:/Viq+iY9rd0=:cvTdR6P+KDJqxmWcxvY0Bt c7Du2HebT7L5262Upl6nhO9VB+9TQIcP1Zlg6XCo60oJ517rn+Tv2iDgX1yml+iNRmFwiNxMi UpX0/+XKD5BqKy3/1gIoW2Qeo4aCYb1CCcSnhsKcSNAvvC1de6qdyhCxqPTrfIk1D4zsEWZOU Yq23GgN9hbn6ZE/xbtFXxwFaGP+MfOyVAb5cL1fbwnhSqz0AxpdkhvIo74vlBi2M3yLzwIs1m 7z4TwJFJzrHoOSNb/Ot2qJGncIqKr4Jg926R5QIkfJD2Ewyqi/eAP+uqy09wAc/r16FogdL78 N7TwCRczZuVQzbg6yFUP/YsYn4IaO90uqOWrUC8CWrY493YfPc2bE5qwkU1XvL2NKswX6C18g cu87YcEbOJgxDYcGvfoIURCnejKD35da/nv+i+WDv74UOTe6fejkh+WBiowSZja97XfWzkCNG xH5Y7AIz9zLNdsvXEmf1dvXphtxT8j+gynP5RTQ7F1pQM4Wa/F38on3r1rZd1oRj5hsfU0Sje T0JQz9dsmiXs5NKkLmOmH0wEXHBI3ZegdSbgGDQS+3ZociQm34MQ1hORqYGL/VFtvGFEg7+mf n3wWmCpQC6G8/Z4brpEXetoD9bUU5CWP70+YuaMbYNmJulMW8hdecs9sGB9vHNkQzk0rX4fsj 9bORIlb/A2dy891ne+RfoN/8znOvGpa2RluNAM1ln9vO2+zFwZwdTEIpH4jG4Bl9eGOjwnenM 6nGrNqVkeiKK635lFqEhUQR4SpoihM19m6/KBn0DC5aHN1chdXWcUujxlhSgW83SHuNDtcqA5 LfCc597SKdRbnmRtHckZUsIKfR/dFBIQ7KeiZSqo0sanc8AtSw= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_003915_529115_003EFF99 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: Anders Roxell , Stephen Boyd , Michael Turquette , Michal Simek , linux-clk , SoC Team , Linus Walleij , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 11:29 PM Rob Herring wrote: > On Thu, May 28, 2020 at 5:57 AM Arnd Bergmann wrote: > > > > On Wed, May 27, 2020 at 8:13 PM Rob Herring wrote: > > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > > > index a0ed412e8396..8c1b0e8e8d32 100644 > > > --- a/drivers/clk/versatile/Kconfig > > > +++ b/drivers/clk/versatile/Kconfig > > > @@ -1,11 +1,8 @@ > > > # SPDX-License-Identifier: GPL-2.0-only > > > > > > -menuconfig COMMON_CLK_VERSATILE > > > - bool "Clock driver for ARM Reference designs" if COMPILE_TEST > > > - default y if ARCH_INTEGRATOR || ARCH_REALVIEW || \ > > > - ARCH_VERSATILE || ARCH_VEXPRESS > > > - > > > -if COMMON_CLK_VERSATILE > > > +menu "Clock driver for ARM Reference designs" > > > + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || \ > > > + ARCH_VERSATILE || ARCH_VEXPRESS || COMPILE_TEST > > > > > > > I've applied this version now but added ARCH_ZYNQ as an additional > > dependency to work around one of the warnings we got earlier. > > That's just spreading a copy-n-paste error. Why don't you apply the > Zynq patch I referenced if Michal never did? Sorry I completely missed the reference from your previous email. I've applied that patch on top now, reverting the change I did in the process. I had noticed that the Zynq Kconfig seemed rather odd, by my interpretation was that it had been added intentionally in order to use an existing clk controller driver for configurable logic on Zynq that was not part of the main DT file. As Michal already confirmed that it was just a mistake, I agree it should be removed. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel